Pull request: server/util_md5.c:58 - replace magic number with constant arithmetic

2012-08-29 Thread SiPlus 

Hello, dev@.

I request a little change to HTTPD code.

On line 58 of server/util_md5.c, please replace

char  *r,  result[33];  /* (MD5_DIGESTSIZE * 2) + 1 */

with

char  *r,  result[2*APR_MD5_DIGESTSIZE+1];

There's only constant arithmetic here, so I don't see a reason to 
pre-calculate the size here, and other code files use 
2*APR_MD5_DIGESTSIZE+1 often.


Thanks,
SiPlus

Re: Pull request: server/util_md5.c:58 - replace magic number with constant arithmetic

2012-08-29 Thread pqf 
Some C compilers don't support this: result[2*APR_MD5_DIGESTSIZE+1] ?



Hello, dev@. 

I request a little change to HTTPD code. 

On line 58 of server/util_md5.c, please replace 

char  *r,  result[33];  /* (MD5_DIGESTSIZE * 2) + 1 */ 

with 

char  *r,  result[2*APR_MD5_DIGESTSIZE+1]; 

There's only constant arithmetic here, so I don't see a reason to  
pre-calculate the size here, and other code files use  
2*APR_MD5_DIGESTSIZE+1 often. 

Thanks, 
SiPlus

Re: [Vote] httpd 2.2.23 release

2012-08-29 Thread Michael Felt 
Not this time, but I have in the past. Need to automate the key-generation,
etc. for https:// - sounds like a ToDo!
Good reminder.

On Mon, Aug 27, 2012 at 3:58 PM, Guenter Knauf fua...@apache.org wrote:

 Hi Michael,
 Am 27.08.2012 15:42, schrieb Michael Felt:

 No package 'openssl' found

 that means that most likely your build doesnt support https protocol.


  However, the packaging proceeds fine. And I get an
 It Works message.

 yes, but have you checked https:// too??

 Gün.

Re: [Vote] httpd 2.2.23 release

2012-08-29 Thread Michael Felt 
Guenter,

working on it - after generating a test key, turning on two mod_'s and
adding extra/*ssl.conf I was able to do:

$ openssl s_client -connect localhost:443 -state -debug
GET / HTTP/1.0

snip - from end:
00d0 - 99 7a 90 ca 1c 28 b4 3e-a9 af 26 d4 cd 33 88 99   .z...(.3..
00e0 - bf de f5 60 da 89 5a ac-04 f4 23 dc 5b 3f 16 cb   ...`..Z...#.[?..
00f0 - a2 57 7d d1 88 8d cb c5-c1 7d 6b bc 0e cb 17 03   .W}..}k.
!DOCTYPE HTML PUBLIC -//IETF//DTD HTML 2.0//EN
htmlhead
title408 Request Timeout/title
/headbody
h1Request Timeout/h1
pServer timeout waiting for the HTTP request from the client./p
/body/html
read from 0x20050b38 [0x20056108] (5 bytes = 0 (0x0))
read:errno=0
write to 0x20050b38 [0x2005a918] (37 bytes = 37 (0x25))
 - 15 03 01 00 20 30 26 15-ec 9a 2e 90 65 49 db 2f    0.eI./
0010 - 80 40 bc df 8a 90 63 d3-32 d1 0b 90 07 d2 ed b8   .@c.2...
0020 - a8 0d d0 17 94.
SSL3 alert write:warning:close notify
michael@x054:[/etc/httpd/extra]

So, it seems I still do not understand the error message - openssl seems to
be integrated.

On Wed, Aug 29, 2012 at 1:23 PM, Michael Felt mamf...@gmail.com wrote:

 Not this time, but I have in the past. Need to automate the
 key-generation, etc. for https:// - sounds like a ToDo!
 Good reminder.


 On Mon, Aug 27, 2012 at 3:58 PM, Guenter Knauf fua...@apache.org wrote:

 Hi Michael,
 Am 27.08.2012 15:42, schrieb Michael Felt:

 No package 'openssl' found

 that means that most likely your build doesnt support https protocol.


  However, the packaging proceeds fine. And I get an
 It Works message.

 yes, but have you checked https:// too??

 Gün.