Re: mod_lbmethod_byrequests required to define a BalancerMember

2012-12-30 Thread Daniel Ruggeri 
On 12/28/2012 10:11 AM, Eric Covener wrote:
 When defining a balancer, mod_lbmethod_byrequests is always looked up
 explicitly and used as the initial LB method.

 I am curious how others feel about this:

 [ ] document that mod_lbmethod_byrequests needs to be loaded and
 improve the error
 [ ] make it work if ProxySet lbmethod=other occurs before BalancerMember
 [X] make it work if  ProxySet lbmethod=other occurs after BalancerMember
 [ ] refactor byrequests back into mod_proxy or mod_proxy_balancer so
 it's always available

This seems to be the best option to me also. Refactoring the code into
mod_proxy(_balancer) defeats the purpose of loadable balancer modules
and documenting the requirement sounds like working around the issue.

--
Daniel Ruggeri

Re: svn commit: r1426877 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/http_core.h include/httpd.h modules/http/http_filters.c server/core.c server/protocol.c server/util.c server/vhost.c

2012-12-30 Thread Stefan Fritsch 
Hi Roy,

On Sunday 30 December 2012, Roy T. Fielding wrote:
 Thanks for this work, but I don't consider HTTP conformance to be
 an option.  These are checks we should be making while parsing
 the received message, not as a separate pass, and in many cases
 they are required to result in a 400, 500, or 502 response.

Some of the new checks are bound to cause problems with existing sites 
and/or clients. I think we need to offer some soft migration path. 
Like

1) make the checks an option, defaulting to off
2) change the default to on
3) make the checks mandatory

I guess the time between the steps depends on the feedback we get from 
users. I expect one year may be reasonable. Of course, we may choose 
to make some checks mandatory earlier, if they are very unlikely to 
break things.

For some parts, the new checks are done during the normal parsing. But 
in order to allow them to be switched off, some separation was 
necessary.

 I am trying to get HTTPbis ready for last call this week.
 After that, I will be looking into making the changes in httpd,
 and I won't be using a configurable option.  I suggest we just
 remove that part and iterate on these checks as we go.

 The current HTTP/1.1 drafts are at
 
  
 http://svn.tools.ietf.org/svn/wg/httpbis/draft-ietf-httpbis/latest
 /
 
 and the message parsing requirements are in p1-messaging.html

Thanks, I hadn't looked at this previously, but it seems to be mostly 
in line to what I have implemented. HTTPbis mandates some more 
restrictions that should be checked, too.
 
 BTW, the protocol version is now restricted to uppercase and
 one digit per major and minor, so we can simplify that check
 to a very specific HTTP/[0-9].[0-9].
 
 And, yes, it is possible to have a valid empty Host because
 HTTP can be used with a proxy for any URI (including URNs).

OK, I will change the protocol parsing and remove the comment about 
empty Host headers.

 Roy
 
 On Dec 29, 2012, at 5:23 PM, s...@apache.org wrote:
  Author: sf
  Date: Sun Dec 30 01:23:24 2012
  New Revision: 1426877
  
  URL: http://svn.apache.org/viewvc?rev=1426877view=rev
  Log:
  Add an option to enforce stricter HTTP conformance
  
  This is a first stab, the checks will likely have to be revised.

Re: mod_macro contributors?

2012-12-30 Thread Eric Covener 
On Mon, Dec 24, 2012 at 1:42 AM,  fab...@apache.org wrote:

 Thanks Fabien. I am striking out on a valid e-mail for Dirk. Do you
 recall if he even sent in a patch, and if so the size/scope?


 It was not a patch. It was a bug report about the Warning  Error
 directives which were coredumping on Apache 2.2 because of changes between
 2.0  2.2. It triggered version 1.1.9 of mod_macro in November 2007.


The only unresolved contribution is:

 - Paul Mcilwaine paul dot mcilwaine at gmail dot com,
   Mike Papper michael at realgirlsmedia dot com
   (Mac OS X compiliation issue with boolean/false/true)

Fabien -- can you review/describe it here?

(I did send Mike a mail at his new work address and didn't CC dev@
but no response.)

Re: mod_macro contributors?

2012-12-30 Thread fabien 



The only unresolved contribution is:

- Paul Mcilwaine paul dot mcilwaine at gmail dot com,
  Mike Papper michael at realgirlsmedia dot com
  (Mac OS X compiliation issue with boolean/false/true)

Fabien -- can you review/describe it here?


It was a bug report about mod_macro compilation on MacOS X. It defines a 
boolean type with true and false constants, which were clashing with 
typedef boolean { false, true }; that I was using. I just changed it to 
typedef mm_boolean { mm_false, mm_true };, and now I have removed it 
anyway in my current dev version because apache does not use a boolean 
type and I do not want to add one in order to blend in with the code.


--
Fabien.