Re: Issue in using php5_module module.

2013-06-06 Thread Sindhi Sindhi
Thankyou Joe, I'll definitely check the the filter code.

On Tue, May 28, 2013 at 8:26 PM, Joe Lewis j...@joe-lewis.com wrote:

 On 05/28/2013 08:38 AM, Sindhi Sindhi wrote:

 [SNIP]


 With these changes, when I start httpd.exe and try to launch a simple php
 file shown above, from the browser, the first time I see that my filter
 module gets the correct php data from php file in the buckets. But when I
 try to open the same php file second time, I see that there are some extra
 strings appended to the original php file contents and sent to my filter
 module in the buckets. So in my filter when I read php data from the
 bucket
 I get the php data and some additional strings appended to the php data
 like below -

 !doctype htmlhtmlhead/headbody**Hello from PHP/body
 /html6.26%20(KHTML,%20like%**20Gecko)%20Version/6.0%**20Mobile/10A5355d
 %20Safari/8536.25 HTTP/1.1
 Host: localhost
 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101
 Firefox/22.0
 Accept: text/html,application/xhtml+**xml,application/xml;q=0.9,*/*;**
 q=0.8
 Accept-Language: en-US,en;q=0.5 

 Any help is highly appreciated.

 Thanks.


 Are you sure it's a problem with the php5_module and not your filter?  I
 only ask because the php5_module has been installed in numerous locations
 throughout the world, with custom modules (including an output filter of
 mine that wraps the page into a template), without issue.  I had run into a
 similar problem eons ago (I believe about 10 years or so).  In fact, I have
 one question that (if you answer honestly) will probably tell you where
 your problem is.

 Are you NULL-terminating all of your strings when you set them up at the
 beginning of the transaction?  If you say yes, please send copies of
 code.  If you say no, please fix and try again.  When I ran into that
 problem so long ago, I was mistakenly working under the assumption that the
 strings being passed around were NULL-terminated, which is not always the
 case.

 Joe
 --
 http://www.silverhawk.net/



Tear down of module on server stop

2013-06-06 Thread Sean Beck
Where does the tear down happen when httpd is stopped? I have some code for
sending messages to ActiveMQ in my module and I would like to only make a
connection on startup rather than every time someone connects, but then I
need to destroy the connection when the server stops.

Also, register_hooks is called when the server starts, correct? I am
thinking I would put the code for connecting to ActiveMQ in there.

Thanks!


Re: Tear down of module on server stop

2013-06-06 Thread Joe Lewis

On 06/06/2013 03:14 PM, Sean Beck wrote:

Where does the tear down happen when httpd is stopped? I have some code for
sending messages to ActiveMQ in my module and I would like to only make a
connection on startup rather than every time someone connects, but then I
need to destroy the connection when the server stops.

Also, register_hooks is called when the server starts, correct? I am
thinking I would put the code for connecting to ActiveMQ in there.

Thanks!



Register a pool clean up function with the pool for the server record.  
That should be called when the pool is removed.


Joe


Re: Tear down of module on server stop

2013-06-06 Thread Sean Beck
Would I register the pool clean up function in the module struct?


On Thu, Jun 6, 2013 at 3:16 PM, Joe Lewis j...@joe-lewis.com wrote:

 On 06/06/2013 03:14 PM, Sean Beck wrote:

 Where does the tear down happen when httpd is stopped? I have some code
 for
 sending messages to ActiveMQ in my module and I would like to only make a
 connection on startup rather than every time someone connects, but then I
 need to destroy the connection when the server stops.

 Also, register_hooks is called when the server starts, correct? I am
 thinking I would put the code for connecting to ActiveMQ in there.

 Thanks!


 Register a pool clean up function with the pool for the server record.
  That should be called when the pool is removed.

 Joe



Re: Tear down of module on server stop

2013-06-06 Thread Sean Beck
So in the post_config hook I set up the connections then register a clean
up function to terminate the connections?


On Thu, Jun 6, 2013 at 4:11 PM, Joe Lewis j...@joe-lewis.com wrote:

 On 06/06/2013 03:27 PM, Sean Beck wrote:

 Would I register the pool clean up function in the module struct?


 On Thu, Jun 6, 2013 at 3:16 PM, Joe Lewis j...@joe-lewis.com wrote:

  On 06/06/2013 03:14 PM, Sean Beck wrote:

  Where does the tear down happen when httpd is stopped? I have some code
 for
 sending messages to ActiveMQ in my module and I would like to only make
 a
 connection on startup rather than every time someone connects, but then
 I
 need to destroy the connection when the server stops.

 Also, register_hooks is called when the server starts, correct? I am
 thinking I would put the code for connecting to ActiveMQ in there.

 Thanks!


  Register a pool clean up function with the pool for the server record.
   That should be called when the pool is removed.

 Joe


 Try doing this in the post_config hook, which is probably where you set
 the connections up.

 Joe



Re: Bug with mod_xml2enc and docx files

2013-06-06 Thread Thomas Eckert
Would you please let me know once you have completed/commited this ? I much
rather copy your fix locally and apply it until the next upgrade where it
would be contained anyway, instead of live with another custom patch.

On Tue, Jun 4, 2013 at 1:13 AM, Nick Kew n...@webthing.com wrote:


 On 3 Jun 2013, at 14:31, Thomas Eckert wrote:

  mod_xml2enc_ctype.patch

 Thanks.

 Looks a lot like the patch I hacked up but have yet to test or commit :)

 --
 Nick Kew



Re: mod_lua oddities

2013-06-06 Thread Guenter Knauf

On 06.06.2013 02:34, Eric Covener wrote:

This is a bug in the example and/or the code. If you don't return a
HTTP status code, or apache2.OK, the request is declined and handled
by the core.

I am split between returning 500 or assuming no return value = apache2.OK.

thanks Eric!
After I added a 'return pache2.OK' to the script it started working on 
all platforms with absolute path;

now only the relative path messing remains ...

Gün.




Re: mod_lua oddities

2013-06-06 Thread Eric Covener
On Thu, Jun 6, 2013 at 5:03 AM, Guenter Knauf fua...@apache.org wrote:
 On 06.06.2013 02:34, Eric Covener wrote:

 This is a bug in the example and/or the code. If you don't return a
 HTTP status code, or apache2.OK, the request is declined and handled
 by the core.

 I am split between returning 500 or assuming no return value = apache2.OK.

 thanks Eric!
 After I added a 'return pache2.OK' to the script it started working on all
 platforms with absolute path;
 now only the relative path messing remains ...

What's the expectation on a relative path?  ServerRoot?


Re: mod_lua oddities

2013-06-06 Thread Guenter Knauf

On 06.06.2013 12:48, Eric Covener wrote:

What's the expectation on a relative path?  ServerRoot?

yep




Re: svn commit: r1490290 - /httpd/httpd/trunk/modules/lua/lua_passwd.c

2013-06-06 Thread Guenter Knauf

Hi Rüdiger,
On 06.06.2013 16:03, rpl...@apache.org wrote:

Author: rpluem
Date: Thu Jun  6 14:03:28 2013
New Revision: 1490290

URL: http://svn.apache.org/r1490290
Log:
* truncpw was allocated from a pool and not via malloc

Modified:
 httpd/httpd/trunk/modules/lua/lua_passwd.c

Modified: httpd/httpd/trunk/modules/lua/lua_passwd.c
URL: 
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/lua_passwd.c?rev=1490290r1=1490289r2=1490290view=diff
==
--- httpd/httpd/trunk/modules/lua/lua_passwd.c (original)
+++ httpd/httpd/trunk/modules/lua/lua_passwd.c Thu Jun  6 14:03:28 2013
@@ -138,7 +138,6 @@ int mk_password_hash(passwd_ctx *ctx)
 characters by CRYPT algorithm.);
  }
  memset(truncpw, '\0', strlen(pw));
-free(truncpw);
  }
  break;
  #endif /* CRYPT_ALGO_SUPPORTED */


doesnt the same then also apply to ./support/passwd_common.c line 241 ?

Gün.





Re: Time for 2.4.5 ??

2013-06-06 Thread Michael Felt
consider this a curiosity - but using the same configure command for 2.4.4
and 2.4.x - with 2.4.x the filter mod_deflate.c gets included in libexec in
version 2.4.4, but not in 2.4.x

Is this expected? the mod_deflate.so is no longer included (by default)?

using:
./configure \
--enable-layout=$LAYOUT \
--with-apr=$apr_config \
--with-apr-util=$apu_config \
--enable-mpms-shared=all \
--enable-mods-shared=all \
--disable-lua

is what I use to configure 2.4.X for AIX

note: there are also some additions, but I am mainly curious about what
does not get built, but the source still exists.

On Mon, Jun 3, 2013 at 7:47 PM, Shahid khan slappy...@gmail.com wrote:


 On Jun 3, 2013 11:11 PM, Michael Felt mamf...@gmail.com wrote:
 
  I have meanwhile all the compiler warnings reduced down to one:
  .\lua_request.c(574) : warning C4244: 'return' : conversion from
 'apr_off_t' to 'int', possible loss of data
 
  Nice work! :)
 
 



Re: Time for 2.4.5 ??

2013-06-06 Thread Eric Covener
On Thu, Jun 6, 2013 at 5:56 PM, Michael Felt mamf...@gmail.com wrote:
 consider this a curiosity - but using the same configure command for 2.4.4
 and 2.4.x - with 2.4.x the filter mod_deflate.c gets included in libexec in
 version 2.4.4, but not in 2.4.x

 Is this expected? the mod_deflate.so is no longer included (by default)?

Maybe your current env doesn't find zlib/zlib headers?  Check config.log.


Re: svn commit: r1490290 - /httpd/httpd/trunk/modules/lua/lua_passwd.c

2013-06-06 Thread Marion Christophe JAILLET

Correct.

This was introduced in r1465115.
Fixed in trunk in r1490507.


Le 06/06/2013 17:54, Guenter Knauf a écrit :

ua/lua_passwd.c T