Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

On Sat, Dec 17, 2016 at 12:51 AM, William A Rowe Jr 
wrote:

> Color me confused, is this w/w-o the hack for APR_HAVE_TIME_T?
>

Nevermind, that issues is entirely resolved. Thanks for confirmation!



> On Sat, Dec 17, 2016 at 12:09 AM, Jan Ehrhardt  wrote:
>
>> Jim Jagielski in gmane.comp.apache.devel (Fri, 16 Dec 2016 13:29:04
>> -0500):
>> >[x] +1: Good to go
>>
>> Running without problems on my dev server now.
>> Windows 2008 R2, VC9 x86 and VC11, x64
>> --
>> Jan
>>
>>
>

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

Color me confused, is this w/w-o the hack for APR_HAVE_TIME_T?

On Sat, Dec 17, 2016 at 12:09 AM, Jan Ehrhardt  wrote:

> Jim Jagielski in gmane.comp.apache.devel (Fri, 16 Dec 2016 13:29:04
> -0500):
> >[x] +1: Good to go
>
> Running without problems on my dev server now.
> Windows 2008 R2, VC9 x86 and VC11, x64
> --
> Jan
>
>

Re: svn commit: r1774650 - /httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak

[William A Rowe Jr]

I'm torn whether this is a showstopper or not.

In all fairness, feature/enhancement crap modified 2.4.x branch as of;

Modified *Tue Dec 13 13:57:02 2016 UTC* (3 days, 16 hours ago) by *jim*

So the question is, is it fair to other platform maintainers to deal with
enhancements requiring build structure refactoring less than 3 days
prior to T? (And if you presume me a win32 platform maintainer,
you would be mistaken. I resuscitated my win32 environments
as of 4pm today across all my VMs, after some brutal force-update-
reboot crap by M$ after I configured it never to do that again. and
again. and...)

I'll leave this question for the RM to decide. Right now I can offer no
vote for or against.

We have another thread on how to fix this long term. I haven't used
the packaged .mak/.dep files in a decade, since I forked the APR
core build from the httpd build, and that isn't reflected in our httpd
distro. At this point, I'm not looking back, the CMake solution on
trunk seems like the one and only one correct solution, and some
proposal to scuttle .dsp from that tree will be arriving once I have
a reasonable solution to CMake's 'f' you, it is a fixed root' nightmare.

If this were an enhancement release, I would shrug my shoulders
and say 'feh, small bug, patch this.' Since this release is overloaded
with 10 months of security fixes, I'd suggest an entirely correct
tarball is to everyone's' benefit. That's why I can't +1 this otherwise
satisfactory tag.

I won't vote against this release, the sources are as best as we
can accomplish, correct, build issues notwithstanding.




On Fri, Dec 16, 2016 at 12:48 PM,  wrote:

> Author: wrowe
> Date: Fri Dec 16 18:48:49 2016
> New Revision: 1774650
>
> URL: http://svn.apache.org/viewvc?rev=1774650=rev
> Log:
> Fix exported .mak output of mod_socache_memcache for '../generators'
> dependency
>
> Modified:
> httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak
>
> Modified: httpd/httpd/branches/2.4.x/modules/cache/mod_socache_
> memcache.mak
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/
> modules/cache/mod_socache_memcache.mak?rev=1774650=
> 1774649=1774650=diff
> 
> ==
> --- httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak
> (original)
> +++ httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak Fri
> Dec 16 18:48:49 2016
> @@ -62,7 +62,7 @@ CLEAN :
>  if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"
>
>  CPP=cl.exe
> -CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I "../../srclib/apr-util/include"
> /I "../../srclib/apr/include" /I "../../include" /D "NDEBUG" /D "WIN32" /D
> "_WINDOWS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_memcache_src" /FD /c
> +CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I "../../srclib/apr-util/include"
> /I "../../srclib/apr/include" /I "../../include" /I "../generators" /D
> "NDEBUG" /D "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\"
> /Fd"$(INTDIR)\mod_socache_memcache_src" /FD /c
>
>  .c{$(INTDIR)}.obj::
> $(CPP) @<<
> @@ -166,7 +166,7 @@ CLEAN :
>  if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"
>
>  CPP=cl.exe
> -CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I "../../srclib/apr-util/include" /I
> "../../srclib/apr/include" /I "../../include" /D "_DEBUG" /D "WIN32" /D
> "_WINDOWS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_memcache_src" /FD
> /EHsc /c
> +CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I "../../srclib/apr-util/include" /I
> "../../srclib/apr/include" /I "../../include" /I "../generators" /D
> "_DEBUG" /D "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\"
> /Fd"$(INTDIR)\mod_socache_memcache_src" /FD /EHsc /c
>
>  .c{$(INTDIR)}.obj::
> $(CPP) @<<
>
>
>

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jan Ehrhardt]

Jim Jagielski in gmane.comp.apache.devel (Fri, 16 Dec 2016 13:29:04
-0500):
>[x] +1: Good to go

Running without problems on my dev server now.
Windows 2008 R2, VC9 x86 and VC11, x64
-- 
Jan

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

On Fri, Dec 16, 2016 at 3:01 PM, Rainer Jung 
wrote:

> Am 16.12.2016 um 21:11 schrieb Jacob Champion:
>
>> On 12/16/2016 10:29 AM, Jim Jagielski wrote:
>>
>>> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
>>>
>>
>> mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I
>> *think* this is due to a bug in the tests as opposed to a regression,
>> related to the conversation in [1]. Does anyone else see this?
>>
>
> Tests 5-24 fail for me as well, status 200 instead of 413. But I thought
> it might be due to
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=60375
>
> not yet being fixed. The attached patch was not yet applied, not even for
> trunk. So probably the tests should be marked as TODO?
>

+1 on TODO for tests 5-24 under 2.4.x.

These tests already pass on trunk, which is odd if the proposed bugfix
isn't there yet :)

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Rainer Jung]

Am 16.12.2016 um 21:11 schrieb Jacob Champion:

On 12/16/2016 10:29 AM, Jim Jagielski wrote:

I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.


mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I
*think* this is due to a bug in the tests as opposed to a regression,
related to the conversation in [1]. Does anyone else see this?


Tests 5-24 fail for me as well, status 200 instead of 413. But I thought 
it might be due to


https://bz.apache.org/bugzilla/show_bug.cgi?id=60375

not yet being fixed. The attached patch was not yet applied, not even 
for trunk. So probably the tests should be marked as TODO?



[1]
https://lists.apache.org/thread.html/a11542ab3c06511e87bde4327dd1cfb72a027ac7bae895a18a772c5b@%3Ccvs.httpd.apache.org%3E


svn log says it is a test for BZ60375, but it seems that BZ is still open.

Regards,

Rainer

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jacob Champion]

On 12/16/2016 12:44 PM, William A Rowe Jr wrote:

I expect this is a bug in the 2.4.x branch. However, I found the same
exceptions in 2.4.23 tag, so this is not a regression, and Joe is still
researching what is happening here, so it doesn't seem to be something
we would want to hold up a release for.


Yeah, in my case I think it's just that the tests don't exit after 
skipping (i.e. 48 out of 24 tests are run...). Not a showstopper.


--Jacob

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[William A Rowe Jr]

On Fri, Dec 16, 2016 at 2:11 PM, Jacob Champion 
wrote:

> On 12/16/2016 10:29 AM, Jim Jagielski wrote:
>
>> I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.
>>
>
> mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I *think*
> this is due to a bug in the tests as opposed to a regression, related to
> the conversation in [1]. Does anyone else see this?
>
> --Jacob
>
> [1] https://lists.apache.org/thread.html/a11542ab3c06511e87bde43
> 27dd1cfb72a027ac7bae895a18a772c5b@%3Ccvs.httpd.apache.org%3E
>

I expect this is a bug in the 2.4.x branch. However, I found the same
exceptions in 2.4.23 tag, so this is not a regression, and Joe is still
researching what is happening here, so it doesn't seem to be something
we would want to hold up a release for.

Re: [VOTE] Release Apache httpd 2.4.25 as GA

[Jacob Champion]

On 12/16/2016 10:29 AM, Jim Jagielski wrote:

I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.


mod_ext_filter tests are failing for me on Ubuntu 16.04 x64, but I 
*think* this is due to a bug in the tests as opposed to a regression, 
related to the conversation in [1]. Does anyone else see this?


--Jacob

[1] 
https://lists.apache.org/thread.html/a11542ab3c06511e87bde4327dd1cfb72a027ac7bae895a18a772c5b@%3Ccvs.httpd.apache.org%3E

Re: svn commit: r1774650 - /httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak

[William A Rowe Jr]

On Fri, Dec 16, 2016 at 1:41 PM, William A Rowe Jr 
wrote:

> On Fri, Dec 16, 2016 at 1:36 PM, Rainer Jung 
> wrote:
>
>> Thanks, didn't notice the mak files, because trunk doesn't have them.
>>
>> I just noticed that the RSC_PROJ lines in the mak files also contain
>> include directories but not the one for "generators", in nove of the cache
>> module mak files. I have no idea what RSC_PROJ is used for but it looks
>> suspicious to only contain parts of the include path.
>>
>> Example line:
>>
>> RSC_PROJ=/l 0x409 /fo"$(INTDIR)\mod_socache_memcache.res" /i
>> "../../include" /i "../../srclib/apr/include" /d "NDEBUG" /d
>> BIN_NAME="mod_socache_memcache.so" /d LONG_NAME="socache_memcache_module
>> for Apache"
>>
>
> Yup, not needed. This is only used to emit the .res -> .exe/.dll stubs
> that describe the module, and only need to pick up the HTTPD version
> tag, so these have nothing to do with
>
> Looks like we have an issue with mod_socache_redis as well, I'll wire
> that appropriately in the next couple minutes.
>
> Arch-specific, no backport voting required.
>

Redis is not (yet) backported, nothing needed here for 2.4.x branch.

Re: svn commit: r1774650 - /httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak

[William A Rowe Jr]

On Fri, Dec 16, 2016 at 1:36 PM, Rainer Jung 
wrote:

> Thanks, didn't notice the mak files, because trunk doesn't have them.
>
> I just noticed that the RSC_PROJ lines in the mak files also contain
> include directories but not the one for "generators", in nove of the cache
> module mak files. I have no idea what RSC_PROJ is used for but it looks
> suspicious to only contain parts of the include path.
>
> Example line:
>
> RSC_PROJ=/l 0x409 /fo"$(INTDIR)\mod_socache_memcache.res" /i
> "../../include" /i "../../srclib/apr/include" /d "NDEBUG" /d
> BIN_NAME="mod_socache_memcache.so" /d LONG_NAME="socache_memcache_module
> for Apache"
>

Yup, not needed. This is only used to emit the .res -> .exe/.dll stubs
that describe the module, and only need to pick up the HTTPD version
tag, so these have nothing to do with

Looks like we have an issue with mod_socache_redis as well, I'll wire
that appropriately in the next couple minutes.

Arch-specific, no backport voting required.

Bill

Re: svn commit: r1774650 - /httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak

[Rainer Jung]

Thanks, didn't notice the mak files, because trunk doesn't have them.

I just noticed that the RSC_PROJ lines in the mak files also contain 
include directories but not the one for "generators", in nove of the 
cache module mak files. I have no idea what RSC_PROJ is used for but it 
looks suspicious to only contain parts of the include path.


Example line:

RSC_PROJ=/l 0x409 /fo"$(INTDIR)\mod_socache_memcache.res" /i 
"../../include" /i "../../srclib/apr/include" /d "NDEBUG" /d 
BIN_NAME="mod_socache_memcache.so" /d LONG_NAME="socache_memcache_module 
for Apache"


Regards,

Rainer

Am 16.12.2016 um 19:48 schrieb wr...@apache.org:

Author: wrowe
Date: Fri Dec 16 18:48:49 2016
New Revision: 1774650

URL: http://svn.apache.org/viewvc?rev=1774650=rev
Log:
Fix exported .mak output of mod_socache_memcache for '../generators' dependency

Modified:
httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak

Modified: httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak
URL: 
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak?rev=1774650=1774649=1774650=diff
==
--- httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak (original)
+++ httpd/httpd/branches/2.4.x/modules/cache/mod_socache_memcache.mak Fri Dec 
16 18:48:49 2016
@@ -62,7 +62,7 @@ CLEAN :
 if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"

 CPP=cl.exe
-CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I "../../srclib/apr-util/include" /I "../../srclib/apr/include" /I "../../include" /D 
"NDEBUG" /D "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_memcache_src" /FD /c
+CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I "../../srclib/apr-util/include" /I "../../srclib/apr/include" /I "../../include" /I 
"../generators" /D "NDEBUG" /D "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_memcache_src" 
/FD /c

 .c{$(INTDIR)}.obj::
$(CPP) @<<
@@ -166,7 +166,7 @@ CLEAN :
 if not exist "$(OUTDIR)/$(NULL)" mkdir "$(OUTDIR)"

 CPP=cl.exe
-CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I "../../srclib/apr-util/include" /I "../../srclib/apr/include" /I "../../include" /D 
"_DEBUG" /D "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_memcache_src" /FD /EHsc /c
+CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I "../../srclib/apr-util/include" /I "../../srclib/apr/include" /I "../../include" /I 
"../generators" /D "_DEBUG" /D "WIN32" /D "_WINDOWS" /Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_memcache_src" 
/FD /EHsc /c

 .c{$(INTDIR)}.obj::
$(CPP) @<<

Re: Fixing module-specific, public include/*.h file inclusion on trunk

[William A Rowe Jr]

On Fri, Dec 16, 2016 at 12:57 PM, William A Rowe Jr 
wrote:

> So today's primary bogus result is courtesy of is due to leaving
> public headers hiding in modules/class/*.h paths for our builds.
>
> I'd suggest one of two approaches, pick a favorite solution?
>
>  [  ] Have the top level build copy all modules/*/mod_*.h
>   definitions to the build tree include/ path (conditionally,
>   based on datestamp)?
>
>  [  ] Make individual modules/*/Makefile[*] responsible for
>   moving their headers into the build tree include/ path
>   (conditionally, based on datestamp)?
>

The challenge with option 2 is that we run the makefiles in
sequence by directory name. It introduces the need to reorder
the subdirectories by function, so that each makefile runs based
on its dependencies (and reciprocal dependencies require the
current /I "../foomodules/" hack.)

Fixing module-specific, public include/*.h file inclusion on trunk

[William A Rowe Jr]

So today's primary bogus result is courtesy of is due to leaving
public headers hiding in modules/class/*.h paths for our builds.

I'd suggest one of two approaches, pick a favorite solution?

 [  ] Have the top level build copy all modules/*/mod_*.h
  definitions to the build tree include/ path (conditionally,
  based on datestamp)?

 [  ] Make individual modules/*/Makefile[*] responsible for
  moving their headers into the build tree include/ path
  (conditionally, based on datestamp)?

Advantage to option 2 is that we could add magic to exclude
those headers for modules not built.

Advantage to both options is that we eliminate all of the
module-specific cross-module-class inclusions.

Overall logic change should be close to nill, since the
'make install' path no longer needs to be smart enough
to look throughout all of the modules/*/mod_*.h files for
the target installation. What doesn't end up in include/
wasn't needed for the target install tree anyways.

Re: svn commit: r1774609 - /httpd/httpd/trunk/modules/cache/mod_socache_memcache.dsp

[William A Rowe Jr]

Erm... did you miss the same edit to mod_socache_memcache.mak?
(Just catching up on the flurry of traffic, so this is speculation.)

Further speculation, are we solid for NetWare now? Any word, Norm?

[wrowe@hub cache]$ grep "/generators" *
mod_cache_socache.dsp:# ADD CPP /nologo /MD /W3 /O2 /Oy- /Zi /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "WIN32" /D "NDEBUG" /D "_WINDOWS"
/Fd"Release\mod_cache_socache_src" /FD /c
mod_cache_socache.dsp:# ADD CPP /nologo /MDd /W3 /EHsc /Zi /Od /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "WIN32" /D "_DEBUG" /D "_WINDOWS"
/Fd"Debug\mod_cache_socache_src" /FD /c
mod_cache_socache.mak:CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "WIN32" /D "NDEBUG" /D "_WINDOWS"
/Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_cache_socache_src" /FD /c
mod_cache_socache.mak:CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "WIN32" /D "_DEBUG" /D "_WINDOWS"
/Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_cache_socache_src" /FD /EHsc /c
mod_socache_dbm.dsp:# ADD CPP /nologo /MD /W3 /O2 /Oy- /Zi /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "NDEBUG" /D "WIN32" /D "_WINDOWS"
/Fd"Release\mod_socache_dbm_src" /FD /c
mod_socache_dbm.dsp:# ADD CPP /nologo /MDd /W3 /EHsc /Zi /Od /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "_DEBUG" /D "WIN32" /D "_WINDOWS"
/Fd"Debug\mod_socache_dbm_src" /FD /c
mod_socache_dbm.mak:CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "NDEBUG" /D "WIN32" /D "_WINDOWS"
/Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_dbm_src" /FD /c
mod_socache_dbm.mak:CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "_DEBUG" /D "WIN32" /D "_WINDOWS"
/Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_dbm_src" /FD /EHsc /c
mod_socache_memcache.dsp:# ADD CPP /nologo /MD /W3 /O2 /Oy- /Zi /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "NDEBUG" /D "WIN32" /D "_WINDOWS"
/Fd"Release\mod_socache_memcache_src" /FD /c
mod_socache_memcache.dsp:# ADD CPP /nologo /MDd /W3 /EHsc /Zi /Od /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "_DEBUG" /D "WIN32" /D "_WINDOWS"
/Fd"Debug\mod_socache_memcache_src" /FD /c
mod_socache_shmcb.dsp:# ADD CPP /nologo /MD /W3 /O2 /Oy- /Zi /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "NDEBUG" /D "WIN32" /D "_WINDOWS"
/Fd"Release\mod_socache_shmcb_src" /FD /c
mod_socache_shmcb.dsp:# ADD CPP /nologo /MDd /W3 /EHsc /Zi /Od /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "_DEBUG" /D "WIN32" /D "_WINDOWS"
/Fd"Debug\mod_socache_shmcb_src" /FD /c
mod_socache_shmcb.mak:CPP_PROJ=/nologo /MD /W3 /Zi /O2 /Oy- /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "NDEBUG" /D "WIN32" /D "_WINDOWS"
/Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_shmcb_src" /FD /c
mod_socache_shmcb.mak:CPP_PROJ=/nologo /MDd /W3 /Zi /Od /I
"../../srclib/apr-util/include" /I "../../srclib/apr/include" /I
"../../include" /I "../generators" /D "_DEBUG" /D "WIN32" /D "_WINDOWS"
/Fo"$(INTDIR)\\" /Fd"$(INTDIR)\mod_socache_shmcb_src" /FD /EHsc /c
NWGNUcach_socache: $(STDMOD)/generators \
NWGNUsocachdbm: $(STDMOD)/generators \
NWGNUsocachmem: $(STDMOD)/generators \
NWGNUsocachshmcb: $(STDMOD)/generators \


On Fri, Dec 16, 2016 at 9:00 AM,  wrote:

> Author: rjung
> Date: Fri Dec 16 15:00:06 2016
> New Revision: 1774609
>
> URL: http://svn.apache.org/viewvc?rev=1774609=rev
> Log:
> Add ../generators to include path for Windows
> build of mod_socache_memcache. It now needs
> mod_status.h.
>
> Untested but exactly analogous to what works for
> mod_socache_shmcb and others.
>
> Modified:
> httpd/httpd/trunk/modules/cache/mod_socache_memcache.dsp
>
> Modified: httpd/httpd/trunk/modules/cache/mod_socache_memcache.dsp
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache
> /mod_socache_memcache.dsp?rev=1774609=1774608=1774609=diff
> 
> ==
> --- httpd/httpd/trunk/modules/cache/mod_socache_memcache.dsp (original)
> +++ httpd/httpd/trunk/modules/cache/mod_socache_memcache.dsp Fri Dec 16
> 15:00:06 2016
> @@ -43,7 +43,7 @@ RSC=rc.exe
>  # PROP Ignore_Export_Lib 0
>  # PROP Target_Dir ""
>  # ADD BASE CPP /nologo /MD /W3 /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS"
> /D 

[VOTE] Release Apache httpd 2.4.25 as GA

[Jim Jagielski]

At long, long last, the pre-release test tarballs for Apache httpd
version 2.4.25 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.25 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

[REVOKED] Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Jim Jagielski]

This call is REVOKED!

> On Dec 16, 2016, at 7:06 AM, Jim Jagielski  wrote:
> 
> At long, long last, the pre-release test tarballs for Apache httpd
> version 2.4.24 can be found at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.24 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Steffen]

Building fine and running now with Exported revision 1774631 (with
r1706595).

Steffen
-Original Message- 
From: Rainer Jung

Sent: Friday, December 16, 2016 4:22 PM
To: dev@httpd.apache.org
Subject: Re: [VOTE] Release Apache httpd 2.4.24 as GA

I think the following missing simple backport from trunk is fixing it:

http://svn.apache.org/

Regards,

Rainer

Am 16.12.2016 um 15:59 schrieb Steffen:

Reverted that change, building and running now.

On Friday 16/12/2016 at 15:01, Jim Jagielski wrote:

Looks related to:


https://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/include/scoreboard.h?r1=1732275=1772330_format=h

Which is weird.


On Dec 16, 2016, at 8:45 AM, Steffen  wrote:

No go on Windows VC14:

...\include\scoreboard.h(30): fatal error C1083: Cannot open include
file: 'sys/time.h': No such file or directory

Steffen

On Friday 16/12/2016 at 13:07, Jim Jagielski wrote:

At long, long last, the pre-release test tarballs for Apache httpd
version 2.4.24 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.24 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx! 

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Rainer Jung]

I think the following missing simple backport from trunk is fixing it:

http://svn.apache.org/r1706595

Regards,

Rainer

Am 16.12.2016 um 15:59 schrieb Steffen:

Reverted that change, building and running now.

On Friday 16/12/2016 at 15:01, Jim Jagielski wrote:

Looks related to:


https://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/include/scoreboard.h?r1=1732275=1772330_format=h

Which is weird.


On Dec 16, 2016, at 8:45 AM, Steffen  wrote:

No go on Windows VC14:

...\include\scoreboard.h(30): fatal error C1083: Cannot open include
file: 'sys/time.h': No such file or directory

Steffen

On Friday 16/12/2016 at 13:07, Jim Jagielski wrote:

At long, long last, the pre-release test tarballs for Apache httpd
version 2.4.24 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.24 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Rainer Jung]

OK, but the shorter path is what is in the other Windows build files for 
modules which already use mod_status.h, so I'd prefer it for consistency.


Regards,

Rainer

Am 16.12.2016 um 16:12 schrieb Steffen:


I did already:


/I "../../modules/generators" instead of /I "../generators"

And that works.

Cheers,

Steffen


On Friday 16/12/2016 at 16:02, Rainer Jung  wrote:

Am 16.12.2016 um 15:13 schrieb Steffen:


An other one:

mod_socache_memcache.c(38): fatal error C1083: Cannot open include file:
'mod_status.h': No such file or directory

Build files are not changed to include mod_status.h


This specific problem is hopefully fixed by:

http://svn.apache.org/viewvc?view=revision=1774609

will propose to backport from trunk to 2.4.x but it would be nice if
you could confirm it is correct.

Thanks and Regards,

Rainer

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Steffen]

I did already:


/I "../../modules/generators" instead of /I "../generators"

And that works.

Cheers,

Steffen


On Friday 16/12/2016 at 16:02, Rainer Jung  wrote:

Am 16.12.2016 um 15:13 schrieb Steffen:


An other one:

mod_socache_memcache.c(38): fatal error C1083: Cannot open include 
file:

'mod_status.h': No such file or directory

Build files are not changed to include mod_status.h


This specific problem is hopefully fixed by:

http://svn.apache.org/viewvc?view=revision=1774609

will propose to backport from trunk to 2.4.x but it would be nice if 
you could confirm it is correct.


Thanks and Regards,

Rainer

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Jim Jagielski]

Hmmm Weird that using the "official" macro test results in the
error... Waiting to hear from other Win people.

> On Dec 16, 2016, at 9:59 AM, Steffen  wrote:
> 
> Reverted that change, building and running now. 
>  
> On Friday 16/12/2016 at 15:01, Jim Jagielski wrote: 
>> Looks related to:
>> 
>> 
>> https://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/include/scoreboard.h?r1=1732275=1772330_format=h
>> 
>> Which is weird.
>> 
>>> On Dec 16, 2016, at 8:45 AM, Steffen  wrote:
>>> 
>>> No go on Windows VC14:
>>> 
>>> ...\include\scoreboard.h(30): fatal error C1083: Cannot open include file: 
>>> 'sys/time.h': No such file or directory
>>> 
>>> Steffen
>>> 
>>> On Friday 16/12/2016 at 13:07, Jim Jagielski wrote: 
 At long, long last, the pre-release test tarballs for Apache httpd
 version 2.4.24 can be found at the usual place:
 
 http://httpd.apache.org/dev/dist/
 
 I'm calling a VOTE on releasing these as Apache httpd 2.4.24 GA.
 
 [ ] +1: Good to go
 [ ] +0: meh
 [ ] -1: Danger Will Robinson. And why.
 
 Vote will last the normal 72 hrs.
 
 NOTE: The *-deps are only there for convenience.
 
 Thx!
>>> 
>>> 
>> 
> 
> 

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Rainer Jung]

Am 16.12.2016 um 15:13 schrieb Steffen:

An other one:

mod_socache_memcache.c(38): fatal error C1083: Cannot open include file:
'mod_status.h': No such file or directory

Build files are not changed to include mod_status.h


This specific problem is hopefully fixed by:

http://svn.apache.org/viewvc?view=revision=1774609

will propose to backport from trunk to 2.4.x but it would be nice if you 
could confirm it is correct.


Thanks and Regards,

Rainer

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Steffen]

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Steffen]

An other one:

mod_socache_memcache.c(38): fatal error C1083: Cannot open include 
file: 'mod_status.h': No such file or directory


Build files are not changed to include mod_status.h



On Friday 16/12/2016 at 13:07, Jim Jagielski  wrote:

At long, long last, the pre-release test tarballs for Apache httpd
version 2.4.24 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.24 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Jim Jagielski]

Looks related to:

  
https://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/include/scoreboard.h?r1=1732275=1772330_format=h

Which is weird.

> On Dec 16, 2016, at 8:45 AM, Steffen  wrote:
> 
> No go on Windows VC14:
> 
> ...\include\scoreboard.h(30): fatal error C1083: Cannot open include file: 
> 'sys/time.h': No such file or directory
> 
> Steffen
>  
> On Friday 16/12/2016 at 13:07, Jim Jagielski wrote: 
>> At long, long last, the pre-release test tarballs for Apache httpd
>> version 2.4.24 can be found at the usual place:
>> 
>> http://httpd.apache.org/dev/dist/
>> 
>> I'm calling a VOTE on releasing these as Apache httpd 2.4.24 GA.
>> 
>> [ ] +1: Good to go
>> [ ] +0: meh
>> [ ] -1: Danger Will Robinson. And why.
>> 
>> Vote will last the normal 72 hrs.
>> 
>> NOTE: The *-deps are only there for convenience.
>> 
>> Thx!
> 
> 

Re: [VOTE] Release Apache httpd 2.4.24 as GA

[Steffen]

No go on Windows VC14:

...\include\scoreboard.h(30): fatal error C1083: Cannot open include 
file: 'sys/time.h': No such file or directory


Steffen


On Friday 16/12/2016 at 13:07, Jim Jagielski  wrote:

At long, long last, the pre-release test tarballs for Apache httpd
version 2.4.24 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.24 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

[VOTE] Release Apache httpd 2.4.24 as GA

[Jim Jagielski]

At long, long last, the pre-release test tarballs for Apache httpd
version 2.4.24 can be found at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.24 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!