Re: svn commit: r1826279 - /httpd/httpd/branches/2.4.x/STATUS
On Thu, Mar 8, 2018 at 11:00 PM, wrote: > >*) mod_access_compat, mod_authz_host: Prevent access control > misconfiguration > due to interpretation of #comments in Require host or Allow/Deny > directives. > trunk patch: http://svn.apache.org/r1667676 >http://svn.apache.org/r1826207 > 2.4.x patch: trunk works, svn merge -c 1667676,1826207 > ^/httpd/httpd/trunk . > - +1: jorton, jim, > + +1: jorton, jim, ylavic This one possibly/later could be addressed at ap_getword_conf[_nocomment)() level, many/most directives should stop on #comments no?
Re: svn commit: r1826284 - /httpd/httpd/branches/2.4.x/STATUS
Did you mean to add r1826289? On Thu, Mar 8, 2018 at 5:56 PM, wrote: > Author: ylavic > Date: Thu Mar 8 22:56:57 2018 > New Revision: 1826284 > > URL: http://svn.apache.org/viewvc?rev=1826284&view=rev > Log: > Update link (STALLED, but seems related to PR 62167, should we discuss it...). > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified: httpd/httpd/branches/2.4.x/STATUS > URL: > http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1826284&r1=1826283&r2=1826284&view=diff > == > --- httpd/httpd/branches/2.4.x/STATUS (original) > +++ httpd/httpd/branches/2.4.x/STATUS Thu Mar 8 22:56:57 2018 > @@ -302,7 +302,7 @@ PATCHES/ISSUES THAT ARE STALLED >http://svn.apache.org/r1641381 > ylavic: Merge patch provided (reusing new->real to avoid double > de_socketfy() call). > Also added missing r1609688 to the patchset. > - 2.4.x patch: > http://people.apache.org/~ylavic/httpd-2.4.x-ap_proxy_define_match_worker.patch > + 2.4.x patch: > http://home.apache.org/~ylavic/patches/httpd-2.4.x-ap_proxy_define_match_worker.patch > +1: ylavic > -0: covener tried to review this one in Austin with Jeff. Does the > added match function > really cover a very narrow set of parameters with the way it skips > over backreferences? > > -- Eric Covener cove...@gmail.com
Re: svn commit: r1826279 - /httpd/httpd/branches/2.4.x/STATUS
Doesn't our crazy old unquoted ErrorDocument directive have this issue too? On Mar 8, 2018 16:05, "Yann Ylavic" wrote: > On Thu, Mar 8, 2018 at 11:00 PM, wrote: > > > >*) mod_access_compat, mod_authz_host: Prevent access control > misconfiguration > > due to interpretation of #comments in Require host or Allow/Deny > directives. > > trunk patch: http://svn.apache.org/r1667676 > >http://svn.apache.org/r1826207 > > 2.4.x patch: trunk works, svn merge -c 1667676,1826207 > ^/httpd/httpd/trunk . > > - +1: jorton, jim, > > + +1: jorton, jim, ylavic > > This one possibly/later could be addressed at > ap_getword_conf[_nocomment)() level, many/most directives should stop > on #comments no? >
