trunk APR version requirement

2019-11-08 Thread Joe Orton
On trunk the configure script requires APR 1.4 but mod_proxy_balancer 
fails to build with APR < 1.5 since it uses apr_escape.h unconditionally 
[1].  Thinking of 2.5/2.6 it might make sense to bump up the APR version 
requirement to something newer, any opinions?  RHEL 8 and Bionic 
(18.04LTS) both have APR 1.6 so that might make a reasonable target for 
those wanting to build against distro APR versions.

grep for APR_VERSION_AT_LEAST --

./server/mpm/simple/simple_run.c:#if !APR_VERSION_AT_LEAST(1,4,0)
./server/mpm/event/event.c:#if !APR_VERSION_AT_LEAST(1,4,0)
./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,5,0)
./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,6,0)
./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,6,0)
./server/listen.c:#if APR_VERSION_AT_LEAST(1,7,0)
./server/listen.c:#if APR_VERSION_AT_LEAST(1,7,0)
./server/listen.c:#if !APR_VERSION_AT_LEAST(1,7,0)
./server/vhost.c:#if !APR_VERSION_AT_LEAST(1,7,0)
./server/vhost.c:#if APR_VERSION_AT_LEAST(1,7,0)
./modules/proxy/mod_serf.c:#if !APR_VERSION_AT_LEAST(1,4,0)
./modules/ssl/mod_ssl_ct.c:#if !APR_VERSION_AT_LEAST(1,5,0)
./modules/filters/mod_crypto.c:#if !APR_VERSION_AT_LEAST(2,0,0)
./modules/filters/mod_crypto.c:#if !APR_VERSION_AT_LEAST(2,0,0) && \
./modules/lua/lua_passwd.h:#if !APR_VERSION_AT_LEAST(2,0,0)
./modules/lua/lua_passwd.h:#if APR_VERSION_AT_LEAST(2,0,0) || \
./modules/metadata/mod_remoteip.c:#if !APR_VERSION_AT_LEAST(1,5,0)
./support/passwd_common.h:#if !APR_VERSION_AT_LEAST(2,0,0)
./support/passwd_common.h:#if APR_VERSION_AT_LEAST(2,0,0) || \

Regards, Joe

[1] https://travis-ci.org/notroj/httpd/jobs/609143667



Re: trunk APR version requirement

2019-11-08 Thread Stefan Eissing
+1

> Am 08.11.2019 um 10:40 schrieb Joe Orton :
> 
> On trunk the configure script requires APR 1.4 but mod_proxy_balancer 
> fails to build with APR < 1.5 since it uses apr_escape.h unconditionally 
> [1].  Thinking of 2.5/2.6 it might make sense to bump up the APR version 
> requirement to something newer, any opinions?  RHEL 8 and Bionic 
> (18.04LTS) both have APR 1.6 so that might make a reasonable target for 
> those wanting to build against distro APR versions.
> 
> grep for APR_VERSION_AT_LEAST --
> 
> ./server/mpm/simple/simple_run.c:#if !APR_VERSION_AT_LEAST(1,4,0)
> ./server/mpm/event/event.c:#if !APR_VERSION_AT_LEAST(1,4,0)
> ./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,5,0)
> ./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,6,0)
> ./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,6,0)
> ./server/listen.c:#if APR_VERSION_AT_LEAST(1,7,0)
> ./server/listen.c:#if APR_VERSION_AT_LEAST(1,7,0)
> ./server/listen.c:#if !APR_VERSION_AT_LEAST(1,7,0)
> ./server/vhost.c:#if !APR_VERSION_AT_LEAST(1,7,0)
> ./server/vhost.c:#if APR_VERSION_AT_LEAST(1,7,0)
> ./modules/proxy/mod_serf.c:#if !APR_VERSION_AT_LEAST(1,4,0)
> ./modules/ssl/mod_ssl_ct.c:#if !APR_VERSION_AT_LEAST(1,5,0)
> ./modules/filters/mod_crypto.c:#if !APR_VERSION_AT_LEAST(2,0,0)
> ./modules/filters/mod_crypto.c:#if !APR_VERSION_AT_LEAST(2,0,0) && \
> ./modules/lua/lua_passwd.h:#if !APR_VERSION_AT_LEAST(2,0,0)
> ./modules/lua/lua_passwd.h:#if APR_VERSION_AT_LEAST(2,0,0) || \
> ./modules/metadata/mod_remoteip.c:#if !APR_VERSION_AT_LEAST(1,5,0)
> ./support/passwd_common.h:#if !APR_VERSION_AT_LEAST(2,0,0)
> ./support/passwd_common.h:#if APR_VERSION_AT_LEAST(2,0,0) || \
> 
> Regards, Joe
> 
> [1] https://travis-ci.org/notroj/httpd/jobs/609143667
> 



Re: svn commit: r1869459 - in /httpd/httpd/trunk: .travis.yml test/travis_before_linux.sh test/travis_run_linux.sh

2019-11-08 Thread Ruediger Pluem



On 11/06/2019 12:45 PM, jor...@apache.org wrote:
> Author: jorton
> Date: Wed Nov  6 11:45:21 2019
> New Revision: 1869459
> 
> URL: http://svn.apache.org/viewvc?rev=1869459&view=rev
> Log:
> Move before/run scripts out of .travis.yml.
> 
> Reviewed by: elukey
> 
> Added:
> httpd/httpd/trunk/test/travis_before_linux.sh   (with props)
> httpd/httpd/trunk/test/travis_run_linux.sh   (with props)
> Modified:
> httpd/httpd/trunk/.travis.yml
> 

> Added: httpd/httpd/trunk/test/travis_before_linux.sh
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/trunk/test/travis_before_linux.sh?rev=1869459&view=auto
> ==
> --- httpd/httpd/trunk/test/travis_before_linux.sh (added)
> +++ httpd/httpd/trunk/test/travis_before_linux.sh Wed Nov  6 11:45:21 2019
> @@ -0,0 +1,5 @@
> +#!/bin/bash -ex
> +svn export -q https://svn.apache.org/repos/asf/apr/apr/trunk srclib/apr

Hmm. Why checking out apr trunk, when we supply --with-apr=/usr 
--with-apr-util=/usr to configure?
Just for buildconf to work?

Regards

Rüdiger



Re: svn commit: r1869459 - in /httpd/httpd/trunk: .travis.yml test/travis_before_linux.sh test/travis_run_linux.sh

2019-11-08 Thread Joe Orton
On Fri, Nov 08, 2019 at 11:04:32AM +0100, Ruediger Pluem wrote:
> On 11/06/2019 12:45 PM, jor...@apache.org wrote:
> > ==
> > --- httpd/httpd/trunk/test/travis_before_linux.sh (added)
> > +++ httpd/httpd/trunk/test/travis_before_linux.sh Wed Nov  6 11:45:21 2019
> > @@ -0,0 +1,5 @@
> > +#!/bin/bash -ex
> > +svn export -q https://svn.apache.org/repos/asf/apr/apr/trunk srclib/apr
> 
> Hmm. Why checking out apr trunk, when we supply --with-apr=/usr 
> --with-apr-util=/usr to configure?
> Just for buildconf to work?

Yup, I had it there for buildconf.  It was removed in r1869533 and 
actually we can switch to running buildconf against the APR version 
where available, thanks for the prompt.

Regards, Joe



Re: trunk APR version requirement

2019-11-08 Thread Ruediger Pluem
+1

Regards

Rüdiger

On 11/08/2019 10:45 AM, Stefan Eissing wrote:
> +1
> 
>> Am 08.11.2019 um 10:40 schrieb Joe Orton :
>>
>> On trunk the configure script requires APR 1.4 but mod_proxy_balancer 
>> fails to build with APR < 1.5 since it uses apr_escape.h unconditionally 
>> [1].  Thinking of 2.5/2.6 it might make sense to bump up the APR version 
>> requirement to something newer, any opinions?  RHEL 8 and Bionic 
>> (18.04LTS) both have APR 1.6 so that might make a reasonable target for 
>> those wanting to build against distro APR versions.
>>
>> grep for APR_VERSION_AT_LEAST --
>>
>> ./server/mpm/simple/simple_run.c:#if !APR_VERSION_AT_LEAST(1,4,0)
>> ./server/mpm/event/event.c:#if !APR_VERSION_AT_LEAST(1,4,0)
>> ./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,5,0)
>> ./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,6,0)
>> ./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,6,0)
>> ./server/listen.c:#if APR_VERSION_AT_LEAST(1,7,0)
>> ./server/listen.c:#if APR_VERSION_AT_LEAST(1,7,0)
>> ./server/listen.c:#if !APR_VERSION_AT_LEAST(1,7,0)
>> ./server/vhost.c:#if !APR_VERSION_AT_LEAST(1,7,0)
>> ./server/vhost.c:#if APR_VERSION_AT_LEAST(1,7,0)
>> ./modules/proxy/mod_serf.c:#if !APR_VERSION_AT_LEAST(1,4,0)
>> ./modules/ssl/mod_ssl_ct.c:#if !APR_VERSION_AT_LEAST(1,5,0)
>> ./modules/filters/mod_crypto.c:#if !APR_VERSION_AT_LEAST(2,0,0)
>> ./modules/filters/mod_crypto.c:#if !APR_VERSION_AT_LEAST(2,0,0) && \
>> ./modules/lua/lua_passwd.h:#if !APR_VERSION_AT_LEAST(2,0,0)
>> ./modules/lua/lua_passwd.h:#if APR_VERSION_AT_LEAST(2,0,0) || \
>> ./modules/metadata/mod_remoteip.c:#if !APR_VERSION_AT_LEAST(1,5,0)
>> ./support/passwd_common.h:#if !APR_VERSION_AT_LEAST(2,0,0)
>> ./support/passwd_common.h:#if APR_VERSION_AT_LEAST(2,0,0) || \
>>
>> Regards, Joe
>>
>> [1] https://travis-ci.org/notroj/httpd/jobs/609143667
>>
> 
> 


Re: svn commit: r1869551 - /httpd/httpd/branches/2.4.x/STATUS

2019-11-08 Thread ste...@eissing.org
I would like what Joe had for breakfast this week. Seems energizing. ;-)

> Am 08.11.2019 um 13:44 schrieb jor...@apache.org:
> 
> Author: jorton
> Date: Fri Nov  8 12:44:33 2019
> New Revision: 1869551
> 
> URL: http://svn.apache.org/viewvc?rev=1869551&view=rev
> Log:
> RTC exception for Travis.
> 
> Reviewed by: covener, ylavic, elukey
> 
> Modified:
>httpd/httpd/branches/2.4.x/STATUS
> 
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/STATUS?rev=1869551&r1=1869550&r2=1869551&view=diff
> ==
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Fri Nov  8 12:44:33 2019
> @@ -125,6 +125,7 @@ CURRENT RELEASE NOTES:
> . non-Unix, single-platform code
> . routine APLOGNO() backports
> . .gdbinit
> +. Travis integration: .travis.yml and test/travis*.sh
> 
> RELEASE SHOWSTOPPERS:
> 
> 
> 



Re: trunk APR version requirement

2019-11-08 Thread Mario Brandt
+1

Joe Orton  schrieb am Fr., 8. Nov. 2019, 10:40:

> On trunk the configure script requires APR 1.4 but mod_proxy_balancer
> fails to build with APR < 1.5 since it uses apr_escape.h unconditionally
> [1].  Thinking of 2.5/2.6 it might make sense to bump up the APR version
> requirement to something newer, any opinions?  RHEL 8 and Bionic
> (18.04LTS) both have APR 1.6 so that might make a reasonable target for
> those wanting to build against distro APR versions.
>
> grep for APR_VERSION_AT_LEAST --
>
> ./server/mpm/simple/simple_run.c:#if !APR_VERSION_AT_LEAST(1,4,0)
> ./server/mpm/event/event.c:#if !APR_VERSION_AT_LEAST(1,4,0)
> ./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,5,0)
> ./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,6,0)
> ./server/util_expr_eval.c:#if APR_VERSION_AT_LEAST(1,6,0)
> ./server/listen.c:#if APR_VERSION_AT_LEAST(1,7,0)
> ./server/listen.c:#if APR_VERSION_AT_LEAST(1,7,0)
> ./server/listen.c:#if !APR_VERSION_AT_LEAST(1,7,0)
> ./server/vhost.c:#if !APR_VERSION_AT_LEAST(1,7,0)
> ./server/vhost.c:#if APR_VERSION_AT_LEAST(1,7,0)
> ./modules/proxy/mod_serf.c:#if !APR_VERSION_AT_LEAST(1,4,0)
> ./modules/ssl/mod_ssl_ct.c:#if !APR_VERSION_AT_LEAST(1,5,0)
> ./modules/filters/mod_crypto.c:#if !APR_VERSION_AT_LEAST(2,0,0)
> ./modules/filters/mod_crypto.c:#if !APR_VERSION_AT_LEAST(2,0,0) && \
> ./modules/lua/lua_passwd.h:#if !APR_VERSION_AT_LEAST(2,0,0)
> ./modules/lua/lua_passwd.h:#if APR_VERSION_AT_LEAST(2,0,0) || \
> ./modules/metadata/mod_remoteip.c:#if !APR_VERSION_AT_LEAST(1,5,0)
> ./support/passwd_common.h:#if !APR_VERSION_AT_LEAST(2,0,0)
> ./support/passwd_common.h:#if APR_VERSION_AT_LEAST(2,0,0) || \
>
> Regards, Joe
>
> [1] https://travis-ci.org/notroj/httpd/jobs/609143667
>
>


Re: trunk APR version requirement

2019-11-08 Thread Graham Leggett
On 08 Nov 2019, at 11:40, Joe Orton  wrote:

> On trunk the configure script requires APR 1.4 but mod_proxy_balancer 
> fails to build with APR < 1.5 since it uses apr_escape.h unconditionally 
> [1].  Thinking of 2.5/2.6 it might make sense to bump up the APR version 
> requirement to something newer, any opinions?  RHEL 8 and Bionic 
> (18.04LTS) both have APR 1.6 so that might make a reasonable target for 
> those wanting to build against distro APR versions.

I’m keen for apr(-util) v1.7, because there is JSON and JOSE (AKA JWT) support 
that I want to take advantage of on the 2.5/2.6 series.

Given that 1.6 is in current long term support OSes as described above, I’m 
also happy for apr(-util) 1.6 with the option to use v1.7 where required.

Regards,
Graham
—



smime.p7s
Description: S/MIME cryptographic signature