Re: mod_proxy / mod_ssl interworking
> Am 02.06.2021 um 13:29 schrieb jean-frederic clere : > > On 01/06/2021 19:37, Stefan Eissing wrote: >>> Am 01.06.2021 um 18:21 schrieb jean-frederic clere : >>> >>> On 01/06/2021 16:40, Stefan Eissing wrote: > Am 01.06.2021 um 16:39 schrieb Stefan Eissing > : > > PR on trunk, for review and commenting: > https://github.com/apache/httpd/pull/190 > > This change makes it possible to have more than one SSL module handling > proxy connections. The intention is to do this in a backward compatible > way, like the previous ap_ssl_* changes. > > The addition of a `conn_rec->outgoing` flag, set for these connections, > makes it easy for any connection handling code to filter on the types of > connections it is interested in. > > Our test suite runs fine with these changes. He said while Travis is still running...optimistic as always... >>> >>> https://github.com/apache/httpd/pull/190/commits/867fa126f21575f104a1717ac49eaf1d8a558d77#diff-5506c76bad00bf136938033783d8d966bc463de54a679d3a8a390621b7a793c1R131 >>> >>> Should that be filled "automagically"? >> How would you advise in filling that out before I commit to trunk? > > I was thinking of telling this build something like ignore the PR it is for > review but that is too complex for nearly no benefits. Sorry for noises. No problem. It would be nice to have it clean, but allocating log numbers on suspicion seems not worth it. Upon further testing with 2 ssl modules today, I discovered the need for some changes which I will push most likely later today. Stefan
Re: mod_proxy / mod_ssl interworking
On 01/06/2021 19:37, Stefan Eissing wrote: Am 01.06.2021 um 18:21 schrieb jean-frederic clere : On 01/06/2021 16:40, Stefan Eissing wrote: Am 01.06.2021 um 16:39 schrieb Stefan Eissing : PR on trunk, for review and commenting: https://github.com/apache/httpd/pull/190 This change makes it possible to have more than one SSL module handling proxy connections. The intention is to do this in a backward compatible way, like the previous ap_ssl_* changes. The addition of a `conn_rec->outgoing` flag, set for these connections, makes it easy for any connection handling code to filter on the types of connections it is interested in. Our test suite runs fine with these changes. He said while Travis is still running...optimistic as always... https://github.com/apache/httpd/pull/190/commits/867fa126f21575f104a1717ac49eaf1d8a558d77#diff-5506c76bad00bf136938033783d8d966bc463de54a679d3a8a390621b7a793c1R131 Should that be filled "automagically"? How would you advise in filling that out before I commit to trunk? I was thinking of telling this build something like ignore the PR it is for review but that is too complex for nearly no benefits. Sorry for noises. -- Cheers Jean-Frederic
Re: [RESULT - PASS] Release httpd-2.4.48
> Am 02.06.2021 um 09:14 schrieb Ruediger Pluem : > > > > On 6/2/21 1:02 AM, Yann Ylavic wrote: >> On Tue, Jun 1, 2021 at 11:07 PM Christophe JAILLET >> wrote: >>> >>> 2.4.48 is live now. >>> >>> However, the mails sent on annouce@a.o and annouce@httpd.a.o seem to not >>> have reached their destination yet. >>> Maybe a moderation issue on the lists. >> >> I can see it on announce@a.o, not announce@httpd.a.o so far. >> >>> >>> [2]: https://httpd.apache.org/security/vulnerabilities_24.html >> >> This one also looks not up to date still. >> >> >> Thanks Christophe for RMing, nice work! > > Thank you very much also from my side and for your proposals and work to > improve the release process. +1
Re: [RESULT - PASS] Release httpd-2.4.48
On 6/2/21 1:02 AM, Yann Ylavic wrote: > On Tue, Jun 1, 2021 at 11:07 PM Christophe JAILLET > wrote: >> >> 2.4.48 is live now. >> >> However, the mails sent on annouce@a.o and annouce@httpd.a.o seem to not >> have reached their destination yet. >> Maybe a moderation issue on the lists. > > I can see it on announce@a.o, not announce@httpd.a.o so far. > >> >> [2]: https://httpd.apache.org/security/vulnerabilities_24.html > > This one also looks not up to date still. > > > Thanks Christophe for RMing, nice work! Thank you very much also from my side and for your proposals and work to improve the release process. Regards Rüdiger
