Re: svn commit: r1899390 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h
On 31/03/2022 12:59, Ruediger Pluem wrote: On 3/31/22 12:34 PM, Stefan Eissing wrote: Am 31.03.2022 um 11:55 schrieb Ruediger Pluem : On 3/31/22 11:11 AM, Ruediger Pluem wrote: On 3/30/22 4:42 PM, jfcl...@apache.org wrote: Author: jfclere Date: Wed Mar 30 14:42:14 2022 New Revision: 1899390 URL: http://svn.apache.org/viewvc?rev=1899390&view=rev Log: Add WorkerBalancerGrowth. To allow creation of workers to dynamically added balancers. Modified: httpd/httpd/trunk/CHANGES httpd/httpd/trunk/modules/proxy/mod_proxy.c httpd/httpd/trunk/modules/proxy/mod_proxy.h Modified: httpd/httpd/trunk/CHANGES URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1899390&r1=1899389&r2=1899390&view=diff == --- httpd/httpd/trunk/CHANGES [utf-8] (original) +++ httpd/httpd/trunk/CHANGES [utf-8] Wed Mar 30 14:42:14 2022 @@ -1,6 +1,10 @@ -*- coding: utf-8 -*- Changes with Apache 2.5.1 + *) mod_proxy: Add WorkerBalancerGrowth to allow adding workers to + balancer created dynamically or via "empty" + [Jean-Frederic Clere] I am not sure why this is needed. You can already do this via Or ProxySet growth=10 FYI: Travis trunk also fails almost completely. Does not seem to accept a proxy configuration. This is because the if +if (!ap_strchr_c(conf->p, ':')) +return apr_pstrcat(cmd->pool, thiscmd->name, + "> arguments are not supported for non url.", + NULL); should not return with an error, but just encapsulate the remainder of the block. And I think the further return apr_pstrcat are also wrong. But as said I am not sure about the purpose at all as you can already do, what the patch should provide if I understand the patch correctly. The purpose was to be able to add a balancer in the balancer-manager handle but that needs to pre-create the mutex and the slots for the workers. While looking to that I noted that: was doing nothing, the balancer is ignored, I should I revert the patch and add an error message if there is an empty entry like this one? Regards Rüdiger -- Cheers Jean-Frederic
Re: svn commit: r1899390 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h
On 3/31/22 12:34 PM, Stefan Eissing wrote: > > >> Am 31.03.2022 um 11:55 schrieb Ruediger Pluem : >> >> >> >> On 3/31/22 11:11 AM, Ruediger Pluem wrote: >>> >>> >>> On 3/30/22 4:42 PM, jfcl...@apache.org wrote: Author: jfclere Date: Wed Mar 30 14:42:14 2022 New Revision: 1899390 URL: http://svn.apache.org/viewvc?rev=1899390&view=rev Log: Add WorkerBalancerGrowth. To allow creation of workers to dynamically added balancers. Modified: httpd/httpd/trunk/CHANGES httpd/httpd/trunk/modules/proxy/mod_proxy.c httpd/httpd/trunk/modules/proxy/mod_proxy.h Modified: httpd/httpd/trunk/CHANGES URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1899390&r1=1899389&r2=1899390&view=diff == --- httpd/httpd/trunk/CHANGES [utf-8] (original) +++ httpd/httpd/trunk/CHANGES [utf-8] Wed Mar 30 14:42:14 2022 @@ -1,6 +1,10 @@ -*- coding: utf-8 -*- Changes with Apache 2.5.1 + *) mod_proxy: Add WorkerBalancerGrowth to allow adding workers to + balancer created dynamically or via "empty" + [Jean-Frederic Clere] >>> >>> I am not sure why this is needed. You can already do this via >>> >>> >>> >> >> Or >> >> >> ProxySet growth=10 >> > > FYI: Travis trunk also fails almost completely. Does not seem to accept a > proxy configuration. This is because the if +if (!ap_strchr_c(conf->p, ':')) +return apr_pstrcat(cmd->pool, thiscmd->name, + "> arguments are not supported for non url.", + NULL); should not return with an error, but just encapsulate the remainder of the block. And I think the further return apr_pstrcat are also wrong. But as said I am not sure about the purpose at all as you can already do, what the patch should provide if I understand the patch correctly. Regards Rüdiger
Re: svn commit: r1899390 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h
> Am 31.03.2022 um 11:55 schrieb Ruediger Pluem : > > > > On 3/31/22 11:11 AM, Ruediger Pluem wrote: >> >> >> On 3/30/22 4:42 PM, jfcl...@apache.org wrote: >>> Author: jfclere >>> Date: Wed Mar 30 14:42:14 2022 >>> New Revision: 1899390 >>> >>> URL: http://svn.apache.org/viewvc?rev=1899390&view=rev >>> Log: >>> Add WorkerBalancerGrowth. To allow creation of workers >>> to dynamically added balancers. >>> >>> Modified: >>> httpd/httpd/trunk/CHANGES >>> httpd/httpd/trunk/modules/proxy/mod_proxy.c >>> httpd/httpd/trunk/modules/proxy/mod_proxy.h >>> >>> Modified: httpd/httpd/trunk/CHANGES >>> URL: >>> http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1899390&r1=1899389&r2=1899390&view=diff >>> == >>> --- httpd/httpd/trunk/CHANGES [utf-8] (original) >>> +++ httpd/httpd/trunk/CHANGES [utf-8] Wed Mar 30 14:42:14 2022 >>> @@ -1,6 +1,10 @@ >>> -*- coding: utf-8 -*- >>> Changes with Apache 2.5.1 >>> >>> + *) mod_proxy: Add WorkerBalancerGrowth to allow adding workers to >>> + balancer created dynamically or via "empty" >>> + [Jean-Frederic Clere] >> >> I am not sure why this is needed. You can already do this via >> >> >> > > Or > > > ProxySet growth=10 > FYI: Travis trunk also fails almost completely. Does not seem to accept a proxy configuration. > > Regards > > Rüdiger
Re: svn commit: r1899390 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h
On 3/31/22 11:11 AM, Ruediger Pluem wrote: > > > On 3/30/22 4:42 PM, jfcl...@apache.org wrote: >> Author: jfclere >> Date: Wed Mar 30 14:42:14 2022 >> New Revision: 1899390 >> >> URL: http://svn.apache.org/viewvc?rev=1899390&view=rev >> Log: >> Add WorkerBalancerGrowth. To allow creation of workers >> to dynamically added balancers. >> >> Modified: >> httpd/httpd/trunk/CHANGES >> httpd/httpd/trunk/modules/proxy/mod_proxy.c >> httpd/httpd/trunk/modules/proxy/mod_proxy.h >> >> Modified: httpd/httpd/trunk/CHANGES >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1899390&r1=1899389&r2=1899390&view=diff >> == >> --- httpd/httpd/trunk/CHANGES [utf-8] (original) >> +++ httpd/httpd/trunk/CHANGES [utf-8] Wed Mar 30 14:42:14 2022 >> @@ -1,6 +1,10 @@ >> -*- coding: utf-8 >> -*- >> Changes with Apache 2.5.1 >> >> + *) mod_proxy: Add WorkerBalancerGrowth to allow adding workers to >> + balancer created dynamically or via "empty" >> + [Jean-Frederic Clere] > > I am not sure why this is needed. You can already do this via > > > Or ProxySet growth=10 Regards Rüdiger
Re: svn commit: r1899390 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy.c modules/proxy/mod_proxy.h
On 3/30/22 4:42 PM, jfcl...@apache.org wrote: > Author: jfclere > Date: Wed Mar 30 14:42:14 2022 > New Revision: 1899390 > > URL: http://svn.apache.org/viewvc?rev=1899390&view=rev > Log: > Add WorkerBalancerGrowth. To allow creation of workers > to dynamically added balancers. > > Modified: > httpd/httpd/trunk/CHANGES > httpd/httpd/trunk/modules/proxy/mod_proxy.c > httpd/httpd/trunk/modules/proxy/mod_proxy.h > > Modified: httpd/httpd/trunk/CHANGES > URL: > http://svn.apache.org/viewvc/httpd/httpd/trunk/CHANGES?rev=1899390&r1=1899389&r2=1899390&view=diff > == > --- httpd/httpd/trunk/CHANGES [utf-8] (original) > +++ httpd/httpd/trunk/CHANGES [utf-8] Wed Mar 30 14:42:14 2022 > @@ -1,6 +1,10 @@ > -*- coding: utf-8 > -*- > Changes with Apache 2.5.1 > > + *) mod_proxy: Add WorkerBalancerGrowth to allow adding workers to > + balancer created dynamically or via "empty" > + [Jean-Frederic Clere] I am not sure why this is needed. You can already do this via Furthermore WorkerBalancerGrowth is inconsistent as the growth parameter I mention above only allows 100 as maximum and WorkerBalancerGrowth allows 1000. Regards Rüdiger
Re: HTTP and HTTP/1.x separation
On 30/03/2022 11:11, Stefan Eissing wrote: Am 28.03.2022 um 15:52 schrieb jean-frederic clere : On 24/03/2022 13:21, Stefan Eissing wrote: You are invited to have a look at my PR for separating HTTP/1.x processing from generic HTTP protocol handling and verification: https://github.com/apache/httpd/pull/291 I made a description of the changes in the PR that helps reviewing it (I hope). "Changes appear larger than they really are" A lot is code split+move from mod_http to mod_http1. In mod_http2, changes are mainly removals of quirks necessary so far. Kind Regards, Stefan Something fishy: http/1.1: +++ < HTTP/1.1 200 OK < Date: Mon, 28 Mar 2022 13:48:23 GMT < Server: Apache/2.5.1-dev (Unix) OpenSSL/1.1.1n < Last-Modified: Fri, 25 Mar 2022 15:47:39 GMT < ETag: "bf-5db0ce1e1e93e" < Accept-Ranges: bytes < Content-Length: 191 < Content-Type: text/html +++ http/2: +++ < HTTP/2 200 < last-modified: Fri, 25 Mar 2022 15:47:39 GMT < etag: "bf-5db0ce1e1e93e" < accept-ranges: bytes < content-length: 191 < content-type: text/html +++ Did I miss something? Just added the fix to the PR: *) core, mod_http1, mod_http: moved the handling of the standard response headers `Date` and `Server` from mod_http1 into the generic HTTP protocol handling. Response buckets not always carry those headers (values preserved from proxied responses), irregardless of the HTTP protocol versions involved. mod_http1: the serialization of response header into HTTP/1.x format always writes `Date` and `Server` first if present. This assured backward compatibility with clients who are accustomed to this order. Thanks my tests are passing now. Kind Regards, Stefan -- Cheers Jean-Frederic -- Cheers Jean-Frederic
