Re: [PATCH] autoconf macros: quote macro names

2002-07-17 Thread Peter Poeml

On Tue, Jul 16, 2002 at 03:50:45PM -0700, Justin Erenkrantz wrote:
> On Mon, Jul 15, 2002 at 06:01:10PM +0200, Peter Poeml wrote:
> > Hi, 
> > 
> > in the autoconf macro definitions of acinclude.m4, the macro names are
> > not quoted as suggested in the autoconf documentation for AC_DEFUN:
> > 
> > 
> > [...]
> >Be sure to properly quote both the MACRO-BODY _and_ the MACRO-NAME
> > to avoid any problems if the macro happens to have been previously
> > defined.
> > [...]
> > 
> > 
> > The missing quotes actually lead to problems when running autoreconf
> > with recent autoconf versions.
> 
> What versions of autoconf have this problem?  -- justin

I'm not entirely sure -- at least with 2.52 and 2.53 it occurs here. They end
up in a recursion loop:

chroot ROOT@pepper /usr/src/packages/BUILD/httpd-2.0.39/ # aclocal
chroot ROOT@pepper /usr/src/packages/BUILD/httpd-2.0.39/ # autoconf
/usr/bin/m4: acinclude.m4: 289: ERROR: Recursion limit of 1024 exceeded, use -L to 
change it

This happens not only in our stable branch but also on SuSE Linux 8.0.

However, obviously the configure script packaged with the 2.0.39 tarball has
been created with autoconf 2.53. So it seems to work for you, somehow. 

Peter

-- 
VFS: Busy inodes after unmount. Self-destruct in 5 seconds.  Have a nice day...



Re: [PATCH] autoconf macros: quote macro names

2002-07-16 Thread Justin Erenkrantz

On Mon, Jul 15, 2002 at 06:01:10PM +0200, Peter Poeml wrote:
> Hi, 
> 
> in the autoconf macro definitions of acinclude.m4, the macro names are
> not quoted as suggested in the autoconf documentation for AC_DEFUN:
> 
> 
> [...]
>Be sure to properly quote both the MACRO-BODY _and_ the MACRO-NAME
> to avoid any problems if the macro happens to have been previously
> defined.
> [...]
> 
> 
> The missing quotes actually lead to problems when running autoreconf
> with recent autoconf versions.

What versions of autoconf have this problem?  -- justin



[PATCH] autoconf macros: quote macro names

2002-07-15 Thread Peter Poeml

Hi, 

in the autoconf macro definitions of acinclude.m4, the macro names are
not quoted as suggested in the autoconf documentation for AC_DEFUN:


[...]
   Be sure to properly quote both the MACRO-BODY _and_ the MACRO-NAME
to avoid any problems if the macro happens to have been previously
defined.
[...]


The missing quotes actually lead to problems when running autoreconf
with recent autoconf versions.

The attached patch adds brackets around those macro names. It applies
against 2.0.39 as well as the head branch.

Peter

-- 
VFS: Busy inodes after unmount. Self-destruct in 5 seconds.  Have a nice day...


--- httpd-2.0.36.orig/acinclude.m4  Thu Apr 18 19:29:59 2002
+++ httpd-2.0.36/acinclude.m4   Mon Jun  3 17:38:11 2002
@@ -4,25 +4,25 @@
 dnl AC_HELP_STRING, so let's try to call it if we can.
 dnl Note: this define must be on one line so that it can be properly returned
 dnl as the help string.
-AC_DEFUN(APACHE_HELP_STRING,[ifelse(regexp(AC_ACVERSION, 2\.1), -1, 
AC_HELP_STRING($1,$2),[  ]$1 substr([   ],len($1))$2)])dnl
+AC_DEFUN([APACHE_HELP_STRING],[ifelse(regexp(AC_ACVERSION, 2\.1), -1, 
+AC_HELP_STRING($1,$2),[  ]$1 substr([   ],len($1))$2)])dnl
 
 dnl APACHE_SUBST(VARIABLE)
 dnl Makes VARIABLE available in generated files
 dnl (do not use @variable@ in Makefiles, but $(variable))
-AC_DEFUN(APACHE_SUBST,[
+AC_DEFUN([APACHE_SUBST],[
   APACHE_VAR_SUBST="$APACHE_VAR_SUBST $1"
   AC_SUBST($1)
 ])
 
 dnl APACHE_FAST_OUTPUT(FILENAME)
 dnl Perform substitutions on FILENAME (Makefiles only)
-AC_DEFUN(APACHE_FAST_OUTPUT,[
+AC_DEFUN([APACHE_FAST_OUTPUT],[
   APACHE_FAST_OUTPUT_FILES="$APACHE_FAST_OUTPUT_FILES $1"
 ])
 
 dnl APACHE_GEN_CONFIG_VARS
 dnl Creates config_vars.mk
-AC_DEFUN(APACHE_GEN_CONFIG_VARS,[
+AC_DEFUN([APACHE_GEN_CONFIG_VARS],[
   APACHE_SUBST(abs_srcdir)
   APACHE_SUBST(bindir)
   APACHE_SUBST(sbindir)
@@ -98,14 +98,14 @@
 
 dnl APACHE_GEN_MAKEFILES
 dnl Creates Makefiles
-AC_DEFUN(APACHE_GEN_MAKEFILES,[
+AC_DEFUN([APACHE_GEN_MAKEFILES],[
   $SHELL $srcdir/build/fastgen.sh $srcdir $ac_cv_mkdir_p $BSD_MAKEFILE 
$APACHE_FAST_OUTPUT_FILES
 ])
 
 dnl ## APACHE_OUTPUT(file)
 dnl ## adds "file" to the list of files generated by AC_OUTPUT
 dnl ## This macro can be used several times.
-AC_DEFUN(APACHE_OUTPUT, [
+AC_DEFUN([APACHE_OUTPUT], [
   APACHE_OUTPUT_FILES="$APACHE_OUTPUT_FILES $1"
 ])
 
@@ -114,7 +114,7 @@
 dnl
 dnl If rlim_t is not defined, define it to int
 dnl
-AC_DEFUN(APACHE_TYPE_RLIM_T, [
+AC_DEFUN([APACHE_TYPE_RLIM_T], [
   AC_CACHE_CHECK([for rlim_t], ac_cv_type_rlim_t, [
 AC_TRY_COMPILE([
 #include 
@@ -132,7 +132,7 @@
 ])
 
 dnl APACHE_MODPATH_INIT(modpath)
-AC_DEFUN(APACHE_MODPATH_INIT,[
+AC_DEFUN([APACHE_MODPATH_INIT],[
   current_dir=$1
   modpath_current=modules/$1
   modpath_static=
@@ -141,7 +141,7 @@
   > $modpath_current/modules.mk
 ])dnl
 dnl
-AC_DEFUN(APACHE_MODPATH_FINISH,[
+AC_DEFUN([APACHE_MODPATH_FINISH],[
   echo "DISTCLEAN_TARGETS = modules.mk" >> $modpath_current/modules.mk
   echo "static = $modpath_static" >> $modpath_current/modules.mk
   echo "shared = $modpath_shared" >> $modpath_current/modules.mk
@@ -154,7 +154,7 @@
 ])dnl
 dnl
 dnl APACHE_MODPATH_ADD(name[, shared[, objects [, ldflags[, libs)
-AC_DEFUN(APACHE_MODPATH_ADD,[
+AC_DEFUN([APACHE_MODPATH_ADD],[
   if test -z "$3"; then
 objects="mod_$1.lo"
   else
@@ -197,7 +197,7 @@
 dnlsetting. otherwise, fall under the "all" setting.
 dnlexplicit yes/no always overrides.
 dnl
-AC_DEFUN(APACHE_MODULE,[
+AC_DEFUN([APACHE_MODULE],[
   AC_MSG_CHECKING(whether to enable mod_$1)
   define([optname],[--]ifelse($5,yes,disable,enable)[-]translit($1,_,-))dnl
   
AC_ARG_ENABLE(translit($1,_,-),APACHE_HELP_STRING(optname(),$2),,enable_$1=ifelse($5,,maybe-all,$5))
@@ -267,7 +267,7 @@
 dnl
 dnl APACHE_LAYOUT_DEFAULTS
 dnl
-AC_DEFUN(APACHE_LAYOUT_DEFAULTS,[
+AC_DEFUN([APACHE_LAYOUT_DEFAULTS],[
   dnl Apache defaults for autoconf variables.
   test "x${prefix}" = "xNONE" && prefix='/usr/local/apache2'
   test "x${exec_prefix}" = "xNONE" && exec_prefix='${prefix}'
@@ -286,7 +286,7 @@
 dnl
 dnl APACHE_LAYOUT(configlayout, layoutname)
 dnl
-AC_DEFUN(APACHE_LAYOUT,[
+AC_DEFUN([APACHE_LAYOUT],[
   if test ! -f $srcdir/config.layout; then
 echo "** Error: Layout file $srcdir/config.layout not found"
 echo "** Error: Cannot use undefined layout '$LAYOUT'"
@@ -338,7 +338,7 @@
 dnl
 dnl APACHE_ENABLE_LAYOUT
 dnl
-AC_DEFUN(APACHE_ENABLE_LAYOUT,[
+AC_DEFUN([APACHE_ENABLE_LAYOUT],[
 AC_ARG_ENABLE(layout,
 [  --enable-layout=LAYOUT],[
   LAYOUT=$enableval
@@ -356,7 +356,7 @@
 dnl
 dnl APACHE_ENABLE_MODULES
 dnl
-AC_DEFUN(APACHE_ENABLE_MODULES,[
+AC_DEFUN([APACHE_ENABLE_MODULES],[
   module_selection=default
   module_default=yes
 
@@ -385,7 +385,7 @@
   ])
 ])
 
-AC_DEFUN(APACHE_REQUIRE_CXX,[
+AC_DEFUN([APACHE_REQUIRE_CXX],[
   if test -z "$apache_cxx_done"; then
 AC_PROG_CXX
 AC_PROG_CXXCPP
@@ -402,7 +402,7 @@
 dnl and then AC_TRY_LINK to te