Re: [PATCH] ssl_engine_vars.c

[Doug MacEachern]

On Wed, 13 Mar 2002, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:

> 'just did a cvs update and found that SSL_SESSION_id2sz in ssl_engine_vars.c
> has fewer parameters than required.

whoops, my bad.  thanks, applied.

[PATCH] ssl_engine_vars.c

[MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)]

'just did a cvs update and found that SSL_SESSION_id2sz in ssl_engine_vars.c
has fewer parameters than required.

-Madhu

Index: ssl_engine_vars.c
===
RCS file: /home/cvspublic/httpd-2.0/modules/ssl/ssl_engine_vars.c,v
retrieving revision 1.14
diff -u -r1.14 ssl_engine_vars.c
--- ssl_engine_vars.c   12 Mar 2002 21:10:18 -  1.14
+++ ssl_engine_vars.c   13 Mar 2002 16:51:37 -
@@ -282,10 +282,13 @@
 result = (char *)SSL_get_version(ssl);
 }
 else if (ssl != NULL && strcEQ(var, "SESSION_ID")) {
+char buf[SSL_SESSION_ID_STRING_LEN];
+
 SSL_SESSION *pSession = SSL_get_session(ssl);
 result = apr_pstrdup(p, SSL_SESSION_id2sz(
 SSL_SESSION_get_session_id(pSession),
-
SSL_SESSION_get_session_id_length(pSession)));
+
SSL_SESSION_get_session_id_length(pSession),
+buf, sizeof(buf)));
 }
 else if (ssl != NULL && strlen(var) >= 6 && strcEQn(var, "CIPHER", 6))
{
 result = ssl_var_lookup_ssl_cipher(p, c, var+6);