Hi, I have revised the patch. Can some of the commiter kindly review the patch?
Regards, Basant. On Fri, Mar 02, 2007 at 10:53:29AM -0800, Basant Kukreja wrote: > On Fri, Mar 02, 2007 at 08:39:25AM +0100, Plüm, Rüdiger, VF EITO wrote: > > > > > > > -----Ursprüngliche Nachricht----- > > > Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > > > Gesendet: Freitag, 2. März 2007 02:15 > > > An: dev@httpd.apache.org > > > Betreff: Re: [PATCH 39299] - Patch review request > > > > > > > > > Thanks Nick for responding to my request. > > > > > > My comments are in between. > > > > > > On Wed, Feb 28, 2007 at 10:49:48PM +0000, Nick Kew wrote: > > > > On Wed, 28 Feb 2007 14:31:19 -0800 > > > > Basant Kukreja <[EMAIL PROTECTED]> wrote: > > > > > > > > > Hi, > > > > > I am Basant. I work in web tier group in Sun Microsystems Inc. > > > > > > > > > > I have submitted the patch for bug 39299. > > > > > Summary : Internal Server Error (500) on COPY > > > > > URI : http://issues.apache.org/bugzilla/show_bug.cgi?id=39299 > > > > > > > > > > > > > > > Can some of the committer kindly review my patch please > > > to see if it > > > > > is acceptable or not? > > > > > Patch is against 2.2.x branch. > > > > > > > > 409 implies a condition the client can fix. Your patch tests for > > > > a particular condition that is likely to be fixable in a server > > > > with DAV up&running. But AFAICS it could also give a bogus 409, > > > > for example in the case of a newly-installed and misconfigured > > > > server. > > > Can you kindly elaborate more? How newly misconfigured server can > > > send 409? Here is my test case : > > > > > > DavLockDB /disk/apache/apache2/var/DAVLockFs > > > <Directory "/disk/apache/apache2/htdocs/DAVtest"> > > > Options Indexes FollowSymLinks > > > AllowOverride None > > > order allow,deny > > > allow from all > > > AuthName "SMA Development server" > > > AuthType Basic > > > DAV On > > > </Directory> > > > > > > Now assuming, I misconfigured the server and I intended to > > > configure /DAVtest1 instead of > > > /DAVtest, if I send a request. > > > > > > ---------------------------------------------- > > > COPY /DAVtest1/litmus/copysrc HTTP/1.1 > > > Host: myhostname.mydomain:4004 > > > User-Agent: litmus/0.11 neon/0.25.5 > > > Connection: TE > > > TE: trailers > > > Depth: 0 > > > Destination: > > > http://myhostname.mydomain:4004/DAVtest/litmus/nonesuch/foo > > > Overwrite: F > > > X-Litmus: copymove: 5 (copy_nodestcoll > > > > I guess Nicks Idea was the other way round: > > > > COPY /DAVtest/litmus/copysrc > > > > Destination: http://myhostname.mydomain:4004/DAVtest1/litmus/nonesuch/foo > > > There is a crash issue in that case. I need to address the issue along > with the current fix. I have update the PR. > > Regards, > Basant. > > > IMHO this direction would also better match the problem described in > > PR39299. > > > > Regards > > > > Rüdiger > > > >
