Re: [VOTE] Release httpd-2.4.40

2019-08-08 Thread Eric Covener
> Can the backport I tested and suggested on May 13th 2019, about
> mod_session_crypto be considered for this release? Or if it's too late
> for me to ask again, for the next one?
>
I proposed it just now


Re: [VOTE] Release httpd-2.4.40

2019-08-08 Thread Vincent Deffontaines
Le Sat, 3 Aug 2019 08:51:07 -0500,
Daniel Ruggeri  a écrit :

> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.40:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> sha1: 31bc6f87ac209010b8b364abc1c80dfaee53cc64 *httpd-2.4.40.tar.gz
> sha256:
> 451e6cf6caa09119900b74652266427f70050de5c51948acd4aaaf60d0d3cad0
> *httpd-2.4.40.tar.gz
> 

Hi,

Can the backport I tested and suggested on May 13th 2019, about
mod_session_crypto be considered for this release? Or if it's too late
for me to ask again, for the next one?

email subject was :
Subject: Re: [2.4.39] [mod_auth_form]
[mod_session_crypto] Cookie management performance

Cheers,

Vincent Deffontaines
(alternate email address : gry...@apache.org)


-- 
Notre liberté repose sur ce que les autres ignorent de notre existence
Alexandre Soljenitsyne


Re: [RESULT] [VOTE] Release httpd-2.4.40

2019-08-06 Thread Dennis Clarke
On 8/5/19 8:00 PM, Daniel Ruggeri wrote:
> Hi, All;
> As discussed on this list, a minor regression has been detected with a
> fix in flight. I'll go ahead and terminate this release vote and will
> plan to T&R again in the near future with the fix in place.
> 
> Thanks to all who prepped for testing. Keep those testing rigs warm -
> we'll be back again soon!

In the meanwhile I'll leave this running as it seems to just work on
ye old old Solaris 10 sparc boxen : https://beta.tls13.net/

If I could only figure out why cgi based stuff isn't working and tossing
a 503 then all would be well. However that is off topic.

Sorry for the noises made earlier wherein I should have checked headers.

-- 
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional


Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Jan Ehrhardt
Daniel Ruggeri in gmane.comp.apache.devel (Mon, 05 Aug 2019 18:54:18
-0500):
>Thanks, Jan;
>   I'm afraid I have no way to verify or dig into Windows-specific
> issues. Can you share more information or errors that can help, or is
> this related to the things already discussed on the list?

There is a fix for the APLOGNO warnings in trunk. And there is a
solution for my problems with mod_md.so. See
https://lists.apache.org/thread.html/8246b0b077defd9a84d6cc3e32cf0d87a8a4753c2f7f566de336e4d5@
and follow-up messages.
-- 
Jan



[RESULT] [VOTE] Release httpd-2.4.40

2019-08-05 Thread Daniel Ruggeri
Hi, All;
   As discussed on this list, a minor regression has been detected with a fix 
in flight. I'll go ahead and terminate this release vote and will plan to T&R 
again in the near future with the fix in place.

Thanks to all who prepped for testing. Keep those testing rigs warm - we'll be 
back again soon!
-- 
Daniel Ruggeri

On August 3, 2019 8:51:07 AM CDT, Daniel Ruggeri  wrote:
>Hi, all;
>   Please find below the proposed release tarball and signatures:
>https://dist.apache.org/repos/dist/dev/httpd/
>
>I would like to call a VOTE over the next few days to release this
>candidate tarball as 2.4.40:
>[ ] +1: It's not just good, it's good enough!
>[ ] +0: Let's have a talk.
>[ ] -1: There's trouble in paradise. Here's what's wrong.
>
>The computed digests of the tarball up for vote are:
>sha1: 31bc6f87ac209010b8b364abc1c80dfaee53cc64 *httpd-2.4.40.tar.gz
>sha256:
>451e6cf6caa09119900b74652266427f70050de5c51948acd4aaaf60d0d3cad0
>*httpd-2.4.40.tar.gz
>
>-- 
>Daniel Ruggeri


Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Daniel Ruggeri
Thanks, Jan;
   I'm afraid I have no way to verify or dig into Windows-specific issues. Can 
you share more information or errors that can help, or is this related to the 
things already discussed on the list?
-- 
Daniel Ruggeri

On August 4, 2019 6:33:58 AM CDT, Jan Ehrhardt  wrote:
>Gregg Smith in gmane.comp.apache.devel (Sat, 3 Aug 2019 08:43:21
>-0700):
>>Opps, looks like the APLOGNO's didn't get filled in. I'm still ok with
>
>>releasing .40 w/o them.
>>
>>mod_md.c(386): warning C4003: not enough actual parameters for macro 
>>'APLOGNO'
>>mod_md.c(391): warning C4003: not enough actual parameters for macro 
>>'APLOGNO'
>>mod_md.c(601): warning C4003: not enough actual parameters for macro 
>>'APLOGNO'
>>mod_md.c(608): warning C4003: not enough actual parameters for macro 
>>'APLOGNO'
>>mod_md.c(659): warning C4003: not enough actual parameters for macro 
>>'APLOGNO'
>>mod_md.c(702): warning C4003: not enough actual parameters for macro 
>>'APLOGNO'
>>mod_md.c(912): warning C4003: not enough actual parameters for macro 
>>'APLOGNO'
>
>My conclusion after testing a lot of Visual Studio builds: mod_md.so is
>broken. At least on Windows, but probably on any other OS as well. Do
>not release this version.
>-- 
>Jan


Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Stefan Eissing
The fix is in trunk and I proposed it for backport. Needs 2 votes.

> Am 05.08.2019 um 15:44 schrieb Jan Ehrhardt :
> 
> Jim Jagielski in gmane.comp.apache.devel (Mon, 5 Aug 2019 09:15:22
> -0400):
>> I vote -1 due to the known issue w/ building and running mod_md.
>> 
>> Yes, it's not a regression, but the fix is easy and version numbers are
>> cheap. We should release the best possible version each time.
> 
> The fix for the APLOGNO warnings is probably easy. But a fix for 'my'
> issue with running it in combination with a SSLCertificateChainFile
> directive might not be that easy, if possible at all. But Stefan Eissing
> should be able to tell us.
> -- 
> Jan
> 



Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Jan Ehrhardt
Jim Jagielski in gmane.comp.apache.devel (Mon, 5 Aug 2019 09:15:22
-0400):
>I vote -1 due to the known issue w/ building and running mod_md.
>
>Yes, it's not a regression, but the fix is easy and version numbers are
>cheap. We should release the best possible version each time.

The fix for the APLOGNO warnings is probably easy. But a fix for 'my'
issue with running it in combination with a SSLCertificateChainFile
directive might not be that easy, if possible at all. But Stefan Eissing
should be able to tell us.
-- 
Jan



Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Dennis Clarke
On 8/5/19 4:04 AM, Joe Orton wrote:
> On Sun, Aug 04, 2019 at 04:51:45PM -0400, Dennis Clarke wrote:
>> Quick reply here to let you know that the build fails instantly
>> within server/config.c at func process_resource_config_cb() with
>> a strange error uttered by Oracle Studio 12.6 thus :
> ...
>> "config.c", line 1907: error: undefined symbol: ap_dir_match_t
> 
> Do you have httpd headers installed in /usr/local/include from an older 
> httpd?  My best guess would be it's picking up the wrong httpd.h.
> 
> Regards, Joe
> 

Yes of course .. sorry for the noises. Having done this fifty times you
would think I would recall to check for the previous versions headers.


-- 
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional


Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Jim Jagielski
I vote -1 due to the known issue w/ building and running mod_md.

Yes, it's not a regression, but the fix is easy and version numbers are cheap. 
We should release the best possible version each time.

Let's mark 2.4.40 DOA and release 2.4.41 w/ the patch.

> On Aug 3, 2019, at 9:51 AM, Daniel Ruggeri  wrote:
> 
> Hi, all;
>Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.40:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> sha1: 31bc6f87ac209010b8b364abc1c80dfaee53cc64 *httpd-2.4.40.tar.gz
> sha256: 451e6cf6caa09119900b74652266427f70050de5c51948acd4aaaf60d0d3cad0
> *httpd-2.4.40.tar.gz
> 
> -- 
> Daniel Ruggeri
> 



Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Steffen



Runs all fine, no issues seen sofar.

+1



On Saturday 03/08/2019 at 15:51, Daniel Ruggeri  wrote:

Hi, all;
  Please find below the proposed release tarball and signatures:
https://dist.apache.org/repos/dist/dev/httpd/

I would like to call a VOTE over the next few days to release this
candidate tarball as 2.4.40:
[ ] +1: It's not just good, it's good enough!
[ ] +0: Let's have a talk.
[ ] -1: There's trouble in paradise. Here's what's wrong.

The computed digests of the tarball up for vote are:
sha1: 31bc6f87ac209010b8b364abc1c80dfaee53cc64 *httpd-2.4.40.tar.gz
sha256: 
451e6cf6caa09119900b74652266427f70050de5c51948acd4aaaf60d0d3cad0

*httpd-2.4.40.tar.gz

--
Daniel Ruggeri





Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Jan Ehrhardt
Stefan Eissing in gmane.comp.apache.devel (Mon, 5 Aug 2019 11:01:32
+0200):
>I suspect it is the change in mod_ssl interface to the other modules. I
>have to write a test for it.
>
>It used to be that this chain file was ignored in mod_ssl 2.4.39 when it
>retrieved certificates from mod_md. Now mod_md adds its certificate via
>a hook and the chain file seems to remain in effect.
>
>I would say that 2.4.40 refuses a configuration that does not really
>make sense. And 2.4.39 silently ignored it. 

2.4.40 accepts the configuration when there is a valid MDomain
certificate. Then the intermediate certificate is loaded twice: by
mod_md's hook and by the SSLCertificateChainFile directive.

2.4.40 apparently only refuses a fallback certificate in combination
with the ChainFile.
-- 
Jan



Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Stefan Eissing
I suspect it is the change in mod_ssl interface to the other modules. I have to 
write a test for it.

It used to be that this chain file was ignored in mod_ssl 2.4.39 when it 
retrieved certificates from mod_md. Now mod_md adds its certificate via a hook 
and the chain file seems to remain in effect.

I would say that 2.4.40 refuses a configuration that does not really make 
sense. And 2.4.39 silently ignored it. 

> Am 05.08.2019 um 10:53 schrieb Jan Ehrhardt :
> 
> Stefan Eissing in gmane.comp.apache.devel (Mon, 5 Aug 2019 10:23:27
> +0200):
>> Trying to sum up what you are saying: mod_md 2.4.40 does not introduce a
>> new problem, but testing with it exposed an issue that affects both.
>> There is no regression in 2.4.40.
> 
> It was not an noticable issue in 2.4.39 and previous versions. The
> SSLCertificateChainFile statement may have been superfluous, but it did
> not prevent Apache from running and it also did not prevent mod_md to do
> what it is supposed to do: generate a new certificate when the time is
> there. It had been working flawlessly for the last 7 months.
> 
>> As to the problem: the SSLCertificateChainFile directive made mod_ssl
>> fail in conjunction with mod_md and an empty MDomain. Probably, the
>> fallback certificate was conflicting with the additional chain file.
>> This fallback is installed until mod_md gets the "real" certificate
>> from Lets Encrypt.
> 
> The fallback certificate does not conflict with the
> SSLCertificateChainFile directive in 2.4.39. Any idea why it fails in
> 2.4.40, but does not in 2.4.39?
> 
>> I try to add a test case for that and see how we can improve the 
>> interworking.
> 
> Thanks for your continuing work on the mod_md module!

Thanks! Nice to hear!

- Stefan

> -- 
> Jan
> 



Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Jan Ehrhardt
Stefan Eissing in gmane.comp.apache.devel (Mon, 5 Aug 2019 10:23:27
+0200):
>Trying to sum up what you are saying: mod_md 2.4.40 does not introduce a
>new problem, but testing with it exposed an issue that affects both.
>There is no regression in 2.4.40.

It was not an noticable issue in 2.4.39 and previous versions. The
SSLCertificateChainFile statement may have been superfluous, but it did
not prevent Apache from running and it also did not prevent mod_md to do
what it is supposed to do: generate a new certificate when the time is
there. It had been working flawlessly for the last 7 months.

>As to the problem: the SSLCertificateChainFile directive made mod_ssl
>fail in conjunction with mod_md and an empty MDomain. Probably, the
>fallback certificate was conflicting with the additional chain file.
>This fallback is installed until mod_md gets the "real" certificate
>from Lets Encrypt.

The fallback certificate does not conflict with the
SSLCertificateChainFile directive in 2.4.39. Any idea why it fails in
2.4.40, but does not in 2.4.39?

>I try to add a test case for that and see how we can improve the interworking.

Thanks for your continuing work on the mod_md module!
-- 
Jan



Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Stefan Eissing
Trying to sum up what you are saying: mod_md 2.4.40 does not introduce a new 
problem, but testing with it exposed an issue that affects both. There is no 
regression in 2.4.40.

As to the problem: the SSLCertificateChainFile directive made mod_ssl fail in 
conjunction with mod_md and an empty MDomain. Probably, the fallback 
certificate was conflicting with the additional chain file. This fallback is 
installed until mod_md gets the "real" certificate from Lets Encrypt.

I try to add a test case for that and see how we can improve the interworking.

- Stefan

> Am 05.08.2019 um 10:12 schrieb Jan Ehrhardt :
> 
> Jan Ehrhardt in gmane.comp.apache.devel (Sun, 04 Aug 2019 01:26:27
> +0200):
>> Maybe some config changes are needed, but then they should be clearly
>> documented in the change log. The trouble with this release is that the
>> problem with mod_md will only show up when the first certificate has to
>> be renewed.
> 
> Countless tests later I guess I have found out what was wrong. The
> server that I used for testing previously had a certificate by
> letsencrypt-win-simple. Back in the old days you had to load the
> intermediate certificate (Let's Encrypt Authority X3) with a
> SSLCertificateChainFile statement. The server was still doing that. The
> mod_md in 2.4.39 did not bother and just created a new certificate.
> 
> However, the mod_md in 2.4.40 stumbled over it, despite the fact that
> the intermediate certificate was exactly the same that mod_md would have
> loaded.
> 
> @icing: I tried it once again to see what is in the logs:
> 
> | AH02572: Failed to configure at least one certificate and key for 
> example.com:443
> | SSL Library Error: error:140A80B1:SSL routines:SSL_CTX_check_private_key:no 
> certificate assigned
> 
> This gave me no clue at all why it failed. And it was not Apache that
> stumbled. With a valid MDomain certificate mod_md and the
> SSLCertificateChainFile could happily co-exist. So without the test to
> remove the /md dir I would have run into troubles at the moment when the
> certificates had to be renewed (somewhere in September).
> -- 
> Jan
> 



Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Jan Ehrhardt
Jan Ehrhardt in gmane.comp.apache.devel (Sun, 04 Aug 2019 01:26:27
+0200):
>Maybe some config changes are needed, but then they should be clearly
>documented in the change log. The trouble with this release is that the
>problem with mod_md will only show up when the first certificate has to
>be renewed.

Countless tests later I guess I have found out what was wrong. The
server that I used for testing previously had a certificate by
letsencrypt-win-simple. Back in the old days you had to load the
intermediate certificate (Let's Encrypt Authority X3) with a
SSLCertificateChainFile statement. The server was still doing that. The
mod_md in 2.4.39 did not bother and just created a new certificate.

However, the mod_md in 2.4.40 stumbled over it, despite the fact that
the intermediate certificate was exactly the same that mod_md would have
loaded.

@icing: I tried it once again to see what is in the logs:

| AH02572: Failed to configure at least one certificate and key for 
example.com:443
| SSL Library Error: error:140A80B1:SSL routines:SSL_CTX_check_private_key:no 
certificate assigned

This gave me no clue at all why it failed. And it was not Apache that
stumbled. With a valid MDomain certificate mod_md and the
SSLCertificateChainFile could happily co-exist. So without the test to
remove the /md dir I would have run into troubles at the moment when the
certificates had to be renewed (somewhere in September).
-- 
Jan



Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Joe Orton
On Sun, Aug 04, 2019 at 04:51:45PM -0400, Dennis Clarke wrote:
> Quick reply here to let you know that the build fails instantly
> within server/config.c at func process_resource_config_cb() with
> a strange error uttered by Oracle Studio 12.6 thus :
...
> "config.c", line 1907: error: undefined symbol: ap_dir_match_t

Do you have httpd headers installed in /usr/local/include from an older 
httpd?  My best guess would be it's picking up the wrong httpd.h.

Regards, Joe


Re: [VOTE] Release httpd-2.4.40

2019-08-05 Thread Stefan Eissing
What fails and how? What is in the log?

> Am 03.08.2019 um 21:22 schrieb Jan Ehrhardt :
> 
> Gregg Smith in gmane.comp.apache.devel (Sat, 3 Aug 2019 08:43:21 -0700):
>> On 8/3/2019 6:51 AM, Daniel Ruggeri wrote:
>>> Hi, all;
>>>Please find below the proposed release tarball and signatures:
>>> https://dist.apache.org/repos/dist/dev/httpd/
>> 
>> [X] +1: It's good enough!
>> 
>> VC14 & 15 x86 & x64 w/ makefiles
> 
> Did you test mod_md? If I remove the apache/md directory httpd 2.4.39
> creates certificates, first in md/staging then in md/domains.
> httpd 2.4.40 fails.
> 
> No config changes. VC9 x86 OpenSSL 1.0.2, if that matters. Both 2.4.39
> and 2.4.40 were compiled today.
> 
> I will test later on with VC15 x64 OpenSSL 1.1.1.
> -- 
> Jan
> 



Re: [VOTE] Release httpd-2.4.40

2019-08-04 Thread Dennis Clarke
On 8/4/19 4:51 PM, Dennis Clarke wrote:
> On 8/3/19 9:51 AM, Daniel Ruggeri wrote:
>> Hi, all;
>>    Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
>>
>> I would like to call a VOTE over the next few days to release this
>> candidate tarball as 2.4.40:
>> [ ] +1: It's not just good, it's good enough!
>> [ ] +0: Let's have a talk.
>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>>
>> The computed digests of the tarball up for vote are:
>> sha1: 31bc6f87ac209010b8b364abc1c80dfaee53cc64 *httpd-2.4.40.tar.gz
>> sha256: 451e6cf6caa09119900b74652266427f70050de5c51948acd4aaaf60d0d3cad0
>> *httpd-2.4.40.tar.gz
>>
> 
> 
> Quick reply here to let you know that the build fails instantly
> within server/config.c at func process_resource_config_cb() with
> a strange error uttered by Oracle Studio 12.6 thus :
> 
> gmake[2]: Entering directory
> '/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/server'
> /usr/local/build-1/libtool --silent --mode=compile
> /opt/developerstudio12.6/bin/cc -D_STDC_C99=-Xa -g -errfmt=error
> -erroff=%none -xmemalign=8s -errshort=full -xstrconst -xildoff -m64
> -xnolibmil -xcode=pic32 -xregs=no%appl -xlibmieee -ftrap=%none
> -xarch=sparc -mc -xs -xbuiltin=%none -xdebugformat=dwarf -xunroll=1
> -D_TS_ERRNO -D_POSIX_PTHREAD_SEMANTICS -D_LARGEFILE64_SOURCE
> -DSOLARIS2=10 -D_REENTRANT  -I/usr/local/include
> -D_POSIX_PTHREAD_SEMANTICS -D_LARGEFILE64_SOURCE -D_TS_ERRNO   -I.
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/os/unix
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/include
> -I/usr/local/include/apr-1 -I/usr/local/include
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/aaa
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/cache
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/core
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/database
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/filters 
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/ldap
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/server
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/loggers 
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/lua
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/proxy
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/http2
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/session 
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/ssl
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/test
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/server
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/md
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/arch/unix
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/dav/main
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/generators
> -I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/mappers
> -prefer-non-pic -static -c config.c && touch config.lo
> "config.c", line 1893: error: syntax error before or at: *
> "config.c", line 1893: warning: undefined or missing type for: const
> "config.c", line 1895: error: undefined symbol: w
> "config.c", line 1895: error: left operand of "->" must be pointer to
> struct/union
> "config.c", line 1896: error: undefined symbol: fname
> "config.c", line 1896: error: non-unique member requires struct/union
> pointer: p
> "config.c", line 1896: error: left operand of "->" must be pointer to
> struct/union
> "config.c", line 1896: error: left operand of "->" must be pointer to
> struct/union
> "config.c", line 1896: warning: improper pointer/integer combination: arg #2
> "config.c", line 1907: error: undefined symbol: ap_dir_match_t
> "config.c", line 1907: error: syntax error before or at: w
> "config.c", line 1912: error: undefined symbol: w
> "config.c", line 1912: error: undefined struct/union member: prefix
> "config.c", line 1912: warning: left operand of "." must be struct/union
> object
> "config.c", line 1912: warning: improper pointer/integer combination: op "="
> "config.c", line 1913: error: non-unique member requires struct/union
> object: p
> "config.c", line 1913: warning: left operand of "." must be struct/union
> object
> "config.c", line 1913: error: cannot access member of non-struct/union
> object
> "config.c", line 1914: warning: left operand of "." must be struct/union
> object
> "config.c", line 1914: error: cannot access member of non-struct/union
> object
> "config.c", line 1915: error: non-unique member requires struct/union
> object: flags
> "config.c", line 1915: warning: left operand of "." must be struct/union
> object
> "config.c", line 1915: error: cannot access member of non-struct/union
> object
> "config.c", line 1915: error: 

Re: [VOTE] Release httpd-2.4.40

2019-08-04 Thread Dennis Clarke
On 8/3/19 9:51 AM, Daniel Ruggeri wrote:
> Hi, all;
>    Please find below the proposed release tarball and signatures:
> https://dist.apache.org/repos/dist/dev/httpd/
> 
> I would like to call a VOTE over the next few days to release this
> candidate tarball as 2.4.40:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
> 
> The computed digests of the tarball up for vote are:
> sha1: 31bc6f87ac209010b8b364abc1c80dfaee53cc64 *httpd-2.4.40.tar.gz
> sha256: 451e6cf6caa09119900b74652266427f70050de5c51948acd4aaaf60d0d3cad0
> *httpd-2.4.40.tar.gz
> 


Quick reply here to let you know that the build fails instantly
within server/config.c at func process_resource_config_cb() with
a strange error uttered by Oracle Studio 12.6 thus :

gmake[2]: Entering directory
'/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/server'
/usr/local/build-1/libtool --silent --mode=compile
/opt/developerstudio12.6/bin/cc -D_STDC_C99=-Xa -g -errfmt=error
-erroff=%none -xmemalign=8s -errshort=full -xstrconst -xildoff -m64
-xnolibmil -xcode=pic32 -xregs=no%appl -xlibmieee -ftrap=%none
-xarch=sparc -mc -xs -xbuiltin=%none -xdebugformat=dwarf -xunroll=1
-D_TS_ERRNO -D_POSIX_PTHREAD_SEMANTICS -D_LARGEFILE64_SOURCE
-DSOLARIS2=10 -D_REENTRANT  -I/usr/local/include
-D_POSIX_PTHREAD_SEMANTICS -D_LARGEFILE64_SOURCE -D_TS_ERRNO   -I.
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/os/unix
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/include
-I/usr/local/include/apr-1 -I/usr/local/include
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/aaa
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/cache
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/core
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/database
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/filters 
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/ldap
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/server
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/loggers 
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/lua
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/proxy
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/http2
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/session 
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/ssl
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/test
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/server
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/md
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/arch/unix
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/dav/main
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/generators
-I/usr/local/build/httpd-2.4.40_SunOS5.10_sparc64vii+.001/modules/mappers
-prefer-non-pic -static -c config.c && touch config.lo
"config.c", line 1893: error: syntax error before or at: *
"config.c", line 1893: warning: undefined or missing type for: const
"config.c", line 1895: error: undefined symbol: w
"config.c", line 1895: error: left operand of "->" must be pointer to
struct/union
"config.c", line 1896: error: undefined symbol: fname
"config.c", line 1896: error: non-unique member requires struct/union
pointer: p
"config.c", line 1896: error: left operand of "->" must be pointer to
struct/union
"config.c", line 1896: error: left operand of "->" must be pointer to
struct/union
"config.c", line 1896: warning: improper pointer/integer combination: arg #2
"config.c", line 1907: error: undefined symbol: ap_dir_match_t
"config.c", line 1907: error: syntax error before or at: w
"config.c", line 1912: error: undefined symbol: w
"config.c", line 1912: error: undefined struct/union member: prefix
"config.c", line 1912: warning: left operand of "." must be struct/union
object
"config.c", line 1912: warning: improper pointer/integer combination: op "="
"config.c", line 1913: error: non-unique member requires struct/union
object: p
"config.c", line 1913: warning: left operand of "." must be struct/union
object
"config.c", line 1913: error: cannot access member of non-struct/union
object
"config.c", line 1914: warning: left operand of "." must be struct/union
object
"config.c", line 1914: error: cannot access member of non-struct/union
object
"config.c", line 1915: error: non-unique member requires struct/union
object: flags
"config.c", line 1915: warning: left operand of "." must be struct/union
object
"config.c", line 1915: error: cannot access member of non-struct/union
object
"config.c", line 1915: error: undefined symbol: AP_DIR_FLAG_OPTIONAL
"config.c", line 1915: error: undefined symbol: AP_DIR_FLAG_NONE
"config.c", line 1915: error: undefined symbol: AP_DIR_FLAG_RECURSIVE
"config.c", line 1916: error: unde

Re: [VOTE] Release httpd-2.4.40

2019-08-04 Thread Jan Ehrhardt
Gregg Smith in gmane.comp.apache.devel (Sat, 3 Aug 2019 08:43:21 -0700):
>Opps, looks like the APLOGNO's didn't get filled in. I'm still ok with 
>releasing .40 w/o them.
>
>mod_md.c(386): warning C4003: not enough actual parameters for macro 
>'APLOGNO'
>mod_md.c(391): warning C4003: not enough actual parameters for macro 
>'APLOGNO'
>mod_md.c(601): warning C4003: not enough actual parameters for macro 
>'APLOGNO'
>mod_md.c(608): warning C4003: not enough actual parameters for macro 
>'APLOGNO'
>mod_md.c(659): warning C4003: not enough actual parameters for macro 
>'APLOGNO'
>mod_md.c(702): warning C4003: not enough actual parameters for macro 
>'APLOGNO'
>mod_md.c(912): warning C4003: not enough actual parameters for macro 
>'APLOGNO'

My conclusion after testing a lot of Visual Studio builds: mod_md.so is
broken. At least on Windows, but probably on any other OS as well. Do
not release this version.
-- 
Jan



Re: [VOTE] Release httpd-2.4.40

2019-08-03 Thread Jan Ehrhardt
Jan Ehrhardt in gmane.comp.apache.devel (Sat, 03 Aug 2019 21:22:58
+0200):
>Gregg Smith in gmane.comp.apache.devel (Sat, 3 Aug 2019 08:43:21 -0700):
>>On 8/3/2019 6:51 AM, Daniel Ruggeri wrote:
>>> Hi, all;
>>>     Please find below the proposed release tarball and signatures:
>>> https://dist.apache.org/repos/dist/dev/httpd/
>>
>>[X] +1: It's good enough!
>>
>>VC14 & 15 x86 & x64 w/ makefiles
>
>Did you test mod_md? If I remove the apache/md directory httpd 2.4.39
>creates certificates, first in md/staging then in md/domains.
>httpd 2.4.40 fails.
>
>No config changes. VC9 x86 OpenSSL 1.0.2, if that matters. Both 2.4.39
>and 2.4.40 were compiled today.
>
>I will test later on with VC15 x64 OpenSSL 1.1.1.

Same problem with VC15 x64 OpenSSL 1.1.1 and Apachelounge's VS16 x64
https://www.apachelounge.com/viewtopic.php?t=8329

Maybe some config chanes are needed, but then they should be clearly
documented in the change log. The trouble with this release is that the
problem with mod_md will only show up when the first certificate has to
be renewed. FWIW:

[x] -1: There's trouble in paradise. Here's what's wrong.
-- 
Jan



Re: [VOTE] Release httpd-2.4.40

2019-08-03 Thread Jan Ehrhardt
Gregg Smith in gmane.comp.apache.devel (Sat, 3 Aug 2019 08:43:21 -0700):
>On 8/3/2019 6:51 AM, Daniel Ruggeri wrote:
>> Hi, all;
>>     Please find below the proposed release tarball and signatures:
>> https://dist.apache.org/repos/dist/dev/httpd/
>
>[X] +1: It's good enough!
>
>VC14 & 15 x86 & x64 w/ makefiles

Did you test mod_md? If I remove the apache/md directory httpd 2.4.39
creates certificates, first in md/staging then in md/domains.
httpd 2.4.40 fails.

No config changes. VC9 x86 OpenSSL 1.0.2, if that matters. Both 2.4.39
and 2.4.40 were compiled today.

I will test later on with VC15 x64 OpenSSL 1.1.1.
-- 
Jan



Re: [VOTE] Release httpd-2.4.40

2019-08-03 Thread Gregg Smith

On 8/3/2019 6:51 AM, Daniel Ruggeri wrote:

Hi, all;
    Please find below the proposed release tarball and signatures:
https://dist.apache.org/repos/dist/dev/httpd/


[X] +1: It's good enough!

VC14 & 15 x86 & x64 w/ makefiles

Opps, looks like the APLOGNO's didn't get filled in. I'm still ok with 
releasing .40 w/o them.


mod_md.c(386): warning C4003: not enough actual parameters for macro 
'APLOGNO'
mod_md.c(391): warning C4003: not enough actual parameters for macro 
'APLOGNO'
mod_md.c(601): warning C4003: not enough actual parameters for macro 
'APLOGNO'
mod_md.c(608): warning C4003: not enough actual parameters for macro 
'APLOGNO'
mod_md.c(659): warning C4003: not enough actual parameters for macro 
'APLOGNO'
mod_md.c(702): warning C4003: not enough actual parameters for macro 
'APLOGNO'
mod_md.c(912): warning C4003: not enough actual parameters for macro 
'APLOGNO'





[VOTE] Release httpd-2.4.40

2019-08-03 Thread Daniel Ruggeri
Hi, all;
   Please find below the proposed release tarball and signatures:
https://dist.apache.org/repos/dist/dev/httpd/

I would like to call a VOTE over the next few days to release this
candidate tarball as 2.4.40:
[ ] +1: It's not just good, it's good enough!
[ ] +0: Let's have a talk.
[ ] -1: There's trouble in paradise. Here's what's wrong.

The computed digests of the tarball up for vote are:
sha1: 31bc6f87ac209010b8b364abc1c80dfaee53cc64 *httpd-2.4.40.tar.gz
sha256: 451e6cf6caa09119900b74652266427f70050de5c51948acd4aaaf60d0d3cad0
*httpd-2.4.40.tar.gz

-- 
Daniel Ruggeri