RE: Are there any specific info for the four vague change log entries?

2011-02-22 Thread Kuge, Tetsuo
Thank you to instruct a good / specific usage of svn.apache.org.
I was about to look into SVN project for some manual page of SVN.

Using annotation view to identify the revision number
is another good solution than listing up PR numbers.
// Using SVN via some scripts like ruby seems attractive for me.
--
Regards,
Tetsuo.

Full name   Tetsuo Kuge Hewlett-Packard Japan, Ltd.
E-mail  tetsuo.k...@hp.com



Re: Are there any specific info for the four vague change log entries?

2011-02-22 Thread Nick Kew

On 22 Feb 2011, at 07:47, Kuge, Tetsuo wrote:

> Without PR number, it seemed too hard to point out the changed code source 
> code.
> So I wished that there appear specific PR number from some root "Change Log" 
> data.
> 
>> Not as such.  Check the SVN record for the context of the changes that
>> introduced each of those.  Or tell us what problem you're trying to solve
>> and maybe we can tell you something specific.
> 
> All right.
> Since I am new to Apache development community, I would like to start from
> checking "SVN" and "SVN record" to ensure if we can identify the relationship
> with the four Change Log entries.

Use the "annotated" view:
http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/CHANGES?view=annotate

Find the lines you're looking at, and that'll tell you the revision they're in.
Now you can see the whole revision and figure out what it's about.
You can also look for nearby revisions of the files affected, etc.

To take your first example,

(1) line 1788, Version 2.1.9, module: mod_proxy
Description:
 *) mod_proxy: Run the request_status hook also if there are no free workers
or all workers are in error state.
[Ruediger Pluem, Brian Akins ]

The annotated view tells you this log entry was introduced in revision 306900.
So go to
http://svn.apache.org/viewvc?view=revision&revision=306900
and view the change to the mod_proxy.c code, which in this case
looks well-commented.  If necessary, check nearby revisions that
might be related.

Note that it's often better to do this looking up in /trunk/ than in 2.2!

If you still can't figure it out, that would be a good time to ask here!

-- 
Nick Kew

Available for work, contract or permanent
http://www.webthing.com/~nick/cv.html



RE: Are there any specific info for the four vague change log entries?

2011-02-21 Thread Kuge, Tetsuo
Without PR number, it seemed too hard to point out the changed code source code.
So I wished that there appear specific PR number from some root "Change Log" 
data.

> Not as such.  Check the SVN record for the context of the changes that
> introduced each of those.  Or tell us what problem you're trying to solve
> and maybe we can tell you something specific.

All right.
Since I am new to Apache development community, I would like to start from
checking "SVN" and "SVN record" to ensure if we can identify the relationship
with the four Change Log entries.



By the way, our original problem was the side effect of
SIGUSR1 handling change of Worker MPM for our custom module.
For mission critical module, unexpected SIGUSR1 caused service stop.
And we already resolved the problem.

Line 1534, Version 2.2.3, module, worker
Description:
*) Worker MPM: On graceless shutdown or restart, send signals to
 each worker thread to wake them up if they're polling on a
 Keep-Alive connection.  PR 38737.  [Chris Darroch]

We felt very sorry when we found no suggestion of that change
in the Apache 2.2 migration document.  This kind of change
for inter module I/F can cause unexpected behavior of custom module.
--
Regards,
Tetsuo.

Full name   Tetsuo Kuge Hewlett-Packard Japan, Ltd.
E-mail  tetsuo.k...@hp.com




Re: Are there any specific info for the four vague change log entries?

2011-02-21 Thread Nick Kew

On 22 Feb 2011, at 01:53, Kuge, Tetsuo wrote:

> Hello,
> are there any specific info for the following four vague change log entries?

Not as such.  Check the SVN record for the context of the changes that
introduced each of those.  Or tell us what problem you're trying to solve
and maybe we can tell you something specific.

-- 
Nick Kew

Available for work, contract or permanent
http://www.webthing.com/~nick/cv.html



Are there any specific info for the four vague change log entries?

2011-02-21 Thread Kuge, Tetsuo
Hello,
are there any specific info for the following four vague change log entries?

We wanted to confirm suspicious change from Apache 2.0 to Apache 2.2 and checked
the Complete ChangeLog for 2.2
  http://www.apache.org/dist/httpd/CHANGES_2.2
but failed to point out exact change for the following entries:

(1) line 1788, Version 2.1.9, module: mod_proxy
Description:
  *) mod_proxy: Run the request_status hook also if there are no free workers
 or all workers are in error state.
 [Ruediger Pluem, Brian Akins ]

(2) line 469, Version 2.2.11, module: core
Description:
*) core: When the ap_http_header_filter processes an error bucket, cleanup
 the passed brigade before returning AP_FILTER_ERROR down the filter
 chain. This unambiguously ensures the same error bucket isn't revisited
 [Ruediger Pluem]

(3) line 819, Version 2.2.8, module: core
Description:
*) core: Fix regression in 2.2.7 in chunk filtering with massively
 chunked requests.  [Ruediger Pluem, Nick Kew]

(4) line 547, Version 2.2.10, module: mod_proxy_http
*) mod_proxy_http: Don't trigger a retry by the client if a failure
   to read the response line was the result of a timeout.
  [Adam Woodworth ]


All lack PR number but each one has specific contact person name.
I believe asking to here should be done before asking them directly.
--
Regards,
Tetsuo.

Full name   Tetsuo Kuge Hewlett-Packard Japan, Ltd.
E-mail  tetsuo.k...@hp.com