Re: ProxyErrorOverride inside location
It seems there is a little problem in my code. When defining "ProxyErrorOverride On" at the vhost level, then "ProxyErrorOverride Off" at a directory level, the directive does not seem to work at the directory level. The merge works correctly, I traced it, and "error_override" is set to 1 at global level, then to 0 at the dir level. But in "ap_proxy_http_process_response()", dconf->error_override" is always set to 1. dconf is built as usual: proxy_dir_conf *dconf = ap_get_module_config(r->per_dir_config, &proxy_module); Any idea ? Thanks, Nick Nick Gearls wrote: A patch is submitted: https://issues.apache.org/bugzilla/show_bug.cgi?id=46656 Here are the modifs: - added |ACCESS_CONF to AP_INIT_FLAG - error_override & error_override_set are moved to proxy_dir_conf - set_proxy_error_override() is modified to use provided dconf* As I explained, this is very useful when using Web Services, as SOAP errors are reported inside status 500 pages. Will this be added ?
Re: ProxyErrorOverride inside location
> -Ursprüngliche Nachricht- > Von: Eric Covener > Gesendet: Dienstag, 3. Februar 2009 16:11 > An: dev@httpd.apache.org > Betreff: Re: ProxyErrorOverride inside location > > On Tue, Feb 3, 2009 at 9:33 AM, Nick Gearls > wrote: > > The development was actually done in 2.2. > > I do not see any difference between 2.2 & 2.3 regarding this. > > Since the per-server config appears in a public header, it's fair game > that other modules have a reference to it. They wouldn't expect that > to change in 2.2 maintenance. Yep. This change seems to require a major bump which would prevent a backport. Regards Rüdiger
Re: ProxyErrorOverride inside location
I understand now. What about 2.3 ? To be honest, I really cannot imagine another module using that value, even in 2.2. But we have to be strict, I agree. Does the code satisfies everybody, or should I rework it in any way ? Eric Covener wrote: On Tue, Feb 3, 2009 at 9:33 AM, Nick Gearls wrote: The development was actually done in 2.2. I do not see any difference between 2.2 & 2.3 regarding this. Since the per-server config appears in a public header, it's fair game that other modules have a reference to it. They wouldn't expect that to change in 2.2 maintenance.
Re: ProxyErrorOverride inside location
On Tue, Feb 3, 2009 at 9:33 AM, Nick Gearls wrote: > The development was actually done in 2.2. > I do not see any difference between 2.2 & 2.3 regarding this. Since the per-server config appears in a public header, it's fair game that other modules have a reference to it. They wouldn't expect that to change in 2.2 maintenance. -- Eric Covener cove...@gmail.com
Re: ProxyErrorOverride inside location
The development was actually done in 2.2. I do not see any difference between 2.2 & 2.3 regarding this. Eric Covener wrote: On Tue, Feb 3, 2009 at 5:39 AM, Nick Gearls wrote: A patch is submitted: https://issues.apache.org/bugzilla/show_bug.cgi?id=46656 Here are the modifs: - added |ACCESS_CONF to AP_INIT_FLAG - error_override & error_override_set are moved to proxy_dir_conf - set_proxy_error_override() is modified to use provided dconf* As I explained, this is very useful when using Web Services, as SOAP errors are reported inside status 500 pages. Will this be added ? While it's not my strong suit, it seems like the change to mod_proxy.h (per-server conf and pe-dir conf) presents some hurdles in backporting this to 2.2.x
Re: ProxyErrorOverride inside location
On Tue, Feb 3, 2009 at 5:39 AM, Nick Gearls wrote: > A patch is submitted: > https://issues.apache.org/bugzilla/show_bug.cgi?id=46656 > > Here are the modifs: > - added |ACCESS_CONF to AP_INIT_FLAG > - error_override & error_override_set are moved to proxy_dir_conf > - set_proxy_error_override() is modified to use provided dconf* > > As I explained, this is very useful when using Web Services, as SOAP errors > are reported inside status 500 pages. > > Will this be added ? While it's not my strong suit, it seems like the change to mod_proxy.h (per-server conf and pe-dir conf) presents some hurdles in backporting this to 2.2.x -- Eric Covener cove...@gmail.com
ProxyErrorOverride inside location
A patch is submitted: https://issues.apache.org/bugzilla/show_bug.cgi?id=46656 Here are the modifs: - added |ACCESS_CONF to AP_INIT_FLAG - error_override & error_override_set are moved to proxy_dir_conf - set_proxy_error_override() is modified to use provided dconf* As I explained, this is very useful when using Web Services, as SOAP errors are reported inside status 500 pages. Will this be added ?
