Question about NameVirtualHost

[Joost de Heer]

Hello,

Should a check be added to add_name_vhost_config() to see if it's a 
duplicate NameVirtualHost? At the moment, you can have multiple 
'NameVirtualHost *:80', which will result in an odd message 
'NameVirtualHost *:80 has no virtualhosts'.


Joost

Re: Question about NameVirtualHost

[Paul Querna]

Joost de Heer wrote:

Hello,

Should a check be added to add_name_vhost_config() to see if it's a 
duplicate NameVirtualHost? At the moment, you can have multiple 
'NameVirtualHost *:80', which will result in an odd message 
'NameVirtualHost *:80 has no virtualhosts'.


I think its reasonable to check.

What should it do, throw an error (seems reasonable) or silently drop 
the second occurrence :) ?


I vote for throwing an error.

-Paul

Re: Question about NameVirtualHost

[Joost de Heer]

Paul Querna wrote:

Joost de Heer wrote:

Hello,

Should a check be added to add_name_vhost_config() to see if it's a 
duplicate NameVirtualHost? At the moment, you can have multiple 
'NameVirtualHost *:80', which will result in an odd message 
'NameVirtualHost *:80 has no virtualhosts'.


I think its reasonable to check.

What should it do, throw an error (seems reasonable) or silently drop 
the second occurrence :) ?


I'd prefer an unsilent info-drop (something like 'Duplicate 
NameVirtualHost in [configfile]:[line] ignored' on INFO level?), since 
it's really just a silly configuration, not an error (things will work 
with duplicate NVH's, even if you don't drop it, or at least, that's how 
I can see it atm).


Joost