Re: APR version of support/logresolve.c

[Sander Temme]

On Oct 24, 2005, at 9:16 AM, Joost de Heer wrote:



Looks good; some nits:
- odd style in places, some "if("/"while(" without enough whitespace
and declarations with too much whitespace:
  apr_file_t * etc;




Is there an indent command line overview for 'ASF approved coding'?



We have:

http://httpd.apache.org/dev/styleguide.html

There are also .indent.pro files in most of the httpd tree, and even  
some emacs-style macros.


Of course these resources may not agree with each other... it's  
generally best to not put indentation changes and code changes in the  
same patch.


S.

--
[EMAIL PROTECTED]  http://www.temme.net/sander/
PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF




smime.p7s
Description: S/MIME cryptographic signature

Re: APR version of support/logresolve.c

[Colm MacCarthaigh]

On Mon, Oct 24, 2005 at 06:16:14PM +0200, Joost de Heer wrote:
> >Looks good; some nits:
> >
> >- odd style in places, some "if("/"while(" without enough whitespace
> >and declarations with too much whitespace:
> >  apr_file_t * etc;
> 
> Is there an indent command line overview for 'ASF approved coding'?

Yes, it's at;

http://httpd.apache.org/dev/styleguide.html

It doesn't cover quite everything though. There are two common
multi-mine comment formats, for example.

-- 
Colm MacCárthaighPublic Key: [EMAIL PROTECTED]

Re: APR version of support/logresolve.c

[Joost de Heer]

Looks good; some nits:

- odd style in places, some "if("/"while(" without enough whitespace
and declarations with too much whitespace:
  apr_file_t * etc;


Is there an indent command line overview for 'ASF approved coding'?

Joost

Re: APR version of support/logresolve.c

[Colm MacCarthaigh]

On Mon, Oct 24, 2005 at 12:58:21PM +0100, Joe Orton wrote:
> - odd style in places, some "if("/"while(" without enough whitespace

Ahh that old habit.

> and declarations with too much whitespace:
>   apr_file_t * etc;

This comes directly from the old logresolve.c.  Didn't want to change
absolutely everything ;-) But I'll make consistent and less wasteful.

> - apr_hash_* can use APR_HASH_KEY_STRING rather than strlen(key)
> - odd casts to/from (const void *) in hash handling which shouldn't
> be necessary?

No, they're not. I've forgotten why I even have them. Thanks for
spotting them.

-- 
Colm MacCárthaighPublic Key: [EMAIL PROTECTED]

Re: APR version of support/logresolve.c

[Joe Orton]

On Fri, Oct 21, 2005 at 10:10:51PM +0100, Colm MacCarthaigh wrote:
> support/logresolve doesn't support IPv6 addresses, which is a pain,
> because while logresolve is not a brilliant log resolver, it's useful
> for putting at the end of brief command lines, grepping things and so
> on.
> 
> Anyway;
> 
>   http://people.apache.org/~colm/logresolve.c
> 
> is an APR version, it's also a lot shorter than the current version.

Looks good; some nits:

- odd style in places, some "if("/"while(" without enough whitespace
and declarations with too much whitespace:
  apr_file_t * etc;

- apr_hash_* can use APR_HASH_KEY_STRING rather than strlen(key)
- odd casts to/from (const void *) in hash handling which shouldn't
be necessary?

joe

Re: APR version of support/logresolve.c

[Dirk-Willem van Gulik]

On Fri, 21 Oct 2005, Colm MacCarthaigh wrote:

>   http://people.apache.org/~colm/logresolve.c

I'd love to see this going in !

Dw.