Re: mod_rewrite: RewriteEngine off doesn't work in a directory context

2010-11-06 Thread Ruediger Pluem 


On 11/06/2010 01:39 AM, Graham Leggett wrote:

 
 Does this patch make sense?

Do we always have a valid dconf in hook_uri2file? And if yes, why do we need the
state field in the server conf any longer?

Regards

Rüdiger

Re: mod_rewrite: RewriteEngine off doesn't work in a directory context

2010-11-06 Thread Graham Leggett 

On 06 Nov 2010, at 5:21 PM, Ruediger Pluem wrote:


Does this patch make sense?


Do we always have a valid dconf in hook_uri2file? And if yes, why do  
we need the

state field in the server conf any longer?


It's because of the following function, called from a post config  
hook, at which point request_rec and per-directory configs don't yet  
exist:


static apr_status_t run_rewritemap_programs(server_rec *s, apr_pool_t  
*p)


If it wasn't for this function, we wouldn't need the server wide flag  
at all.


Regards,
Graham
--

Re: mod_rewrite: RewriteEngine off doesn't work in a directory context

2010-11-06 Thread Graham Leggett 

On 06 Nov 2010, at 5:21 PM, Ruediger Pluem wrote:


Does this patch make sense?


Do we always have a valid dconf in hook_uri2file?


To be safe, I have added a check for dconf being NULL.

Regards,
Graham
--


httpd-mod_rewrite-rewriteengine-fix.patch
Description: Binary data