Re: subversion-1.6.12, apache-2.3.6

2010-06-28 Thread Jeff Trawick
On Mon, Jun 28, 2010 at 3:13 PM, Greg Stein  wrote:
> [resending; the original has httpd.apache.COM ...]
>
> On Mon, Jun 28, 2010 at 15:12, Greg Stein  wrote:
>> On Mon, Jun 28, 2010 at 05:20, Philip Martin  
>> wrote:
>>> "Bert Huijben"  writes:
>>>
>>>>> -Original Message-
>>>>> From: szukw...@arcor.de [mailto:szukw...@arcor.de]
>>>>> Sent: maandag 28 juni 2010 9:51
>>>>> To: d...@subversion.apache.org
>>>>> Subject: Re: subversion-1.6.12, apache-2.3.6
>>>>>
>>>>> I know that httpd-2.3.x is alpha. Second trial for the patch.
>>>>
>>>> Thanks for your patch, it came through this time.
>>>> To apply the patch to trunk we need code that works on older and newer
>>>> versions of httpd (E.g. including proper checking for which version is 
>>>> being
>>>> used).
>>>>
>>>>  I assume you know more about how we should check for specific httpd
>>>> versions than we do as you are testing httpd alpha's.
>>>
>>> I think there is an apache bug here.  This is the revision that
>>> changed the dav_new_error API (in mod_dav.h):
>>>
>>> http://svn.apache.org/viewvc?view=revision&revision=882274
>>>
>>> It includes a change to ap_mmn.h, but that change only modifies the
>>> comments, it doesn't change MODULE_MAGIC_NUMBER_MAJOR. Thus callers
>>> cannot determine which version of the API to use.
>>
>> Yup... along with making other changes to keep up with further MMN
>> bumps since then. (eg. the AP_LOG_MARK change that OP mentioned)

see r882280


Re: subversion-1.6.12, apache-2.3.6

2010-06-28 Thread Greg Stein
[resending; the original has httpd.apache.COM ...]

On Mon, Jun 28, 2010 at 15:12, Greg Stein  wrote:
> On Mon, Jun 28, 2010 at 05:20, Philip Martin  
> wrote:
>> "Bert Huijben"  writes:
>>
>>>> -Original Message-
>>>> From: szukw...@arcor.de [mailto:szukw...@arcor.de]
>>>> Sent: maandag 28 juni 2010 9:51
>>>> To: d...@subversion.apache.org
>>>> Subject: Re: subversion-1.6.12, apache-2.3.6
>>>>
>>>> I know that httpd-2.3.x is alpha. Second trial for the patch.
>>>
>>> Thanks for your patch, it came through this time.
>>> To apply the patch to trunk we need code that works on older and newer
>>> versions of httpd (E.g. including proper checking for which version is being
>>> used).
>>>
>>>  I assume you know more about how we should check for specific httpd
>>> versions than we do as you are testing httpd alpha's.
>>
>> I think there is an apache bug here.  This is the revision that
>> changed the dav_new_error API (in mod_dav.h):
>>
>> http://svn.apache.org/viewvc?view=revision&revision=882274
>>
>> It includes a change to ap_mmn.h, but that change only modifies the
>> comments, it doesn't change MODULE_MAGIC_NUMBER_MAJOR. Thus callers
>> cannot determine which version of the API to use.
>
> Yup... along with making other changes to keep up with further MMN
> bumps since then. (eg. the AP_LOG_MARK change that OP mentioned)
>
> Cheers,
> -g
>