Re: cvs commit: httpd-2.0/server mpm_common.c

[Jeff Trawick]

André Malo <[EMAIL PROTECTED]> writes:

> * [EMAIL PROTECTED] wrote:
> 
> >   Add fatal exception hook for use by debug modules.  The hook is only
> >   available if the --enable-exception-hook configure parm is used.
> >   
> >   Sample users at http://httpd.apache.org/~trawick/exception_hook.html
> 
> >   +[
> >   +AC_DEFINE(AP_ENABLE_EXCEPTION_HOOK, 1,
> >   +  [Allow modules to run hook after a fatal exception])
> >   +])dnl
> >   +
> 
> there's a dnl too much.

I'll remove it; I don't know why there is dnl after some other
AC_ARG_ENABLE() invocations.  Do you know by any chance?

> Docs note: The "on test systems only" sentence should appear in a big
> warning box (with red letters :-). Perhaps this should be reflected in the
> configure help itself.

That doc, and especially that comment, refers only to those sample
modules.  Probably I would remove the "on test systems only" comment
if I get time to review mod_whatkilledus closely.  For quite a while
it had some assumptions of non-threaded MPM, and I don't recall how
much testing it had after I removed those assumptions, hence the
comment ;)  Meanwhile, forcing a segfault (via a special request
handled by a special module) while the worker MPM is under load yields
no surprises.

-- 
Jeff Trawick | [EMAIL PROTECTED]
Born in Roswell... married an alien...

Re: cvs commit: httpd-2.0/server mpm_common.c

[André Malo]

* [EMAIL PROTECTED] wrote:

>   Add fatal exception hook for use by debug modules.  The hook is only
>   available if the --enable-exception-hook configure parm is used.
>   
>   Sample users at http://httpd.apache.org/~trawick/exception_hook.html

>   +[
>   +AC_DEFINE(AP_ENABLE_EXCEPTION_HOOK, 1,
>   +  [Allow modules to run hook after a fatal exception])
>   +])dnl
>   +

there's a dnl too much.

Docs note: The "on test systems only" sentence should appear in a big
warning box (with red letters :-). Perhaps this should be reflected in the
configure help itself.

nd

Re: cvs commit: httpd-2.0/server mpm_common.c

[William A. Rowe, Jr.]

This is gross - can we please abstract into apr (preferrably in some
automated manner?)

- Original Message -
From: <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Friday, September 14, 2001 6:28 PM
Subject: cvs commit: httpd-2.0/server mpm_common.c


> bnicholes01/09/14 16:28:41
>
>   Modified:server   mpm_common.c
>   Log:
>   Added NetWare to the #ifdef list
>
>   Revision  ChangesPath
>   1.66  +1 -1  httpd-2.0/server/mpm_common.c
>
>   Index: mpm_common.c
>   ===
>   RCS file: /home/cvs/httpd-2.0/server/mpm_common.c,v
>   retrieving revision 1.65
>   retrieving revision 1.66
>   diff -u -r1.65 -r1.66
>   --- mpm_common.c 2001/08/16 13:59:14 1.65
>   +++ mpm_common.c 2001/09/14 23:28:41 1.66
>   @@ -326,7 +326,7 @@
>#ifndef HAVE_INITGROUPS
>int initgroups(const char *name, gid_t basegid)
>{
>   -#if defined(QNX) || defined(MPE) || defined(BEOS) || defined(_OSD_POSIX) || 
>defined(TPF) || defined(__TANDEM) || defined(OS2)
|| defined(WIN32)
>   +#if defined(QNX) || defined(MPE) || defined(BEOS) || defined(_OSD_POSIX) || 
>defined(TPF) || defined(__TANDEM) || defined(OS2)
|| defined(WIN32) || defined(NETWARE)
>/* QNX, MPE and BeOS do not appear to support supplementary groups. */
>return 0;
>#else /* ndef QNX */
>
>
>
>