Re: environment in mod_ext_filter
Craig Sebenik <[EMAIL PROTECTED]> writes: > I put it in as a bug: > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10925 code is committed to 2.0.40-dev with very minor tweaks to clean up warnings > The dev guidelines say that patches can be submitted either via an email > (to this list) or via the bug database. But, it doesn't say which is > preferred... I guess different people would have different preferences... > > Anyway, it's there... I could send it to the list also, if you > prefer. Either is a workable mechanism. If you're willing to follow dev@httpd for a while, posting there will get you a wider audience. If you're not willing to follow dev@httpd, posting to the bug db is still fine. Either way, it is your responsibility to remind us after a while if none of the unherded cats around here takes any interest in your patch :) > You'll notice that I put in a call to "ap_add_cgi_vars", which may be a > little excessive (or down right wrong). So, that is "up for discussion". Other than GATEWAY_INTERFACE, the other cgi vars seem reasonable to make available... I left that logic as-is. -- Jeff Trawick | [EMAIL PROTECTED] Born in Roswell... married an alien...
Re: environment in mod_ext_filter
Quoting Jeff Trawick ([EMAIL PROTECTED]): > Craig Sebenik <[EMAIL PROTECTED]> writes: > > Is there a reason why the environment is null? > probably because I'm a moron :) :) *Probably*??? You're not sure? :) > > Am I missing something? Is there a reason I shouldn't submit this patch? > > no, no I put it in as a bug: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10925 The dev guidelines say that patches can be submitted either via an email (to this list) or via the bug database. But, it doesn't say which is preferred... I guess different people would have different preferences... Anyway, it's there... I could send it to the list also, if you prefer. You'll notice that I put in a call to "ap_add_cgi_vars", which may be a little excessive (or down right wrong). So, that is "up for discussion". Craig
Re: environment in mod_ext_filter
Craig Sebenik <[EMAIL PROTECTED]> writes: > In modules/experimental/mod_ext_filter.c there's the following: > > rc = apr_proc_create(ctx->proc, > ctx->filter->command, > (const char * const *)ctx->filter->args, > NULL, /* environment */ > ctx->procattr, > ctx->p); > > Is there a reason why the environment is null? probably because I'm a moron :) > Am I missing something? Is there a reason I shouldn't submit this patch? no, no -- Jeff Trawick | [EMAIL PROTECTED] Born in Roswell... married an alien...
environment in mod_ext_filter
Hi, In modules/experimental/mod_ext_filter.c there's the following: rc = apr_proc_create(ctx->proc, ctx->filter->command, (const char * const *)ctx->filter->args, NULL, /* environment */ ctx->procattr, ctx->p); Is there a reason why the environment is null? I was able to hack in the env in a few simples lines. Am I missing something? Is there a reason I shouldn't submit this patch? Thanx, Craig
