Re: httpd-trunk/modules/http2 gets a proxy
On 12/02/2016 9:13 PM, Stefan Eissing wrote: Thanks. Added in r1729969. Am 11.02.2016 um 21:52 schrieb NormW : Thanks, Norm
Re: httpd-trunk/modules/http2 gets a proxy
G/M And the start of yje weekend. On 13/02/2016 4:06 AM, Rainer Jung wrote: Am 12.02.2016 um 11:13 schrieb Stefan Eissing: Thanks. Added in r1729969. Am 11.02.2016 um 21:52 schrieb NormW : The .txt extension is a bogus extension added by my mailer I assume. I got confused. Which file now builds mod_proxy_http2 on Netware? I can't find it. Shouldn't we also need a modules/http2/NWGNUmod_proxy_http2 file? Yes. I avoided digging further into that until the new NWGNUmakefile and NWGNUmod_http2 got added. Once they're playing correctly, then will come NWGNUproxy_htp2 (?) which will also get added to the list in the NWGNUmakefile. NetWare has a file name limitation that needs some regard; while the file system of later OS releases supports 'long file names' on the disk , every loadable module has an internal 8 char name IIRC, and no two nlm's with the same 8 char name can be loaded at the same time. IIRC the 8 chars is the first 8 chars of the modules disk file name. (Anyone who knows better please jump in here.) Regards, Rainer HTH, Norm
Re: httpd-trunk/modules/http2 gets a proxy
Am 12.02.2016 um 11:13 schrieb Stefan Eissing: Thanks. Added in r1729969. Am 11.02.2016 um 21:52 schrieb NormW : I got confused. Which file now builds mod_proxy_http2 on Netware? I can't find it. Shouldn't we also need a modules/http2/NWGNUmod_proxy_http2 file? Regards, Rainer
Re: httpd-trunk/modules/http2 gets a proxy
Thanks. Added in r1729969. > Am 11.02.2016 um 21:52 schrieb NormW : > >
Re: httpd-trunk/modules/http2 gets a proxy
G/M Stefan, I've specifically waited until sunup, which will hopefully mean I've got a clearer head. A check of the NWGNUmakefile I sent yesterday DID have a number of bugs in it, all largely my fault, and some the result of doing an SVN Update to my local copy at the wrong time. We'll call that the past. Attached are the two files now guarenteed (I've checked them twice this morning) and can even guarentee mod_http2 builds nghtttp2 v1.7.1, which contains a Security Fix, CVE-2016-1544. Process: 1. Delete /http2/NWGNUmakefile... it is not worth trying to do a diff against it, its innards have changed that much). 2. Add the two attached files herewith to /http2. 3. Job done. As for making things easier with a 'commit', I'd still make at least similar stuffups, whereas the ultimate 'easy' would be to wave goodbye to NetWare: 155+ build files and a few OS-specific files could go, your may be able to argue for something later than C89 as minimum standard, and so on... ...and I'm out of a job. But equally, once changes in trunk settle out, building is fairly stable for months (years?) at a stretch, and there'd be nothing for my 'commit' to do. Regard, and apologies for the transient trouble. Norm On 11/02/2016 8:31 PM, Stefan Eissing wrote: Uhm, is there an unresolved conflict in the first file? -Stefan PS. You know, it *would* actually be easier if you had commit access... ;-) Am 11.02.2016 um 03:09 schrieb NormW : G/A Stefan, My BBAADD. Until recently /http2 was home only to mod_http2, and to keep things automatic my NWGNUmakefile in there used a wildcard *.c to get the list of object files to build there. When the compile failed due to added .c files I made a few tweaks to the NWGNU and it all linked without issue again so I forwarded the small tweaks. Closer reading of the list and the added .c revealed there are (at least) two modules now in /http2. This necessitated a change of the NWGNU to use a specified list of .c for a start, and removal of a couple of the patch lines I'd recently sent. Because other modules will be sharing the same dir I've renamed the original NWNUmakefile to NWGNUmod_http2 and there is now a new NWGNUmakefile whose only job is to call the other NWGNU files that will eventually exist in the dir. (If all this sounds confusing it probably is, but by way of example see /proxy dir and note a NWGNUmakefile that contains a list of executables to build.) If we are still speaking after explaining all that, the new files are attached, thus: : NWGUmod_http2 which now has the list of /http2 files to build mod_http2; : NWGNUmakefile which, FTM, has a list of modules to build, but I won't try to explain why the list has a double entry if there is only one (so far) to build. Hopefully I will eventually work out a process to do away with this 'additional' NWGNUmakefile, which would allow removal of quite a few from the source tree. Apologies for the bother, Norm On 10/02/2016 10:34 PM, Stefan Eissing wrote: Applied in r1729583. Thanks! Am 08.02.2016 um 23:07 schrieb NormW : G/M, Recent additions to http-trunk/modules/http2 require the attached apatch to the http2 NetWare build file: Index: modules/http2/NWGNUmakefile === --- modules/http2/NWGNUmakefile (revision 1729251) +++ modules/http2/NWGNUmakefile (working copy) @@ -34,6 +34,8 @@ $(NGH2SRC)/lib/ \ $(NGH2SRC)/lib/includes \ $(SERVER)/mpm/NetWare \ + $(STDMOD)/proxy \ + $(STDMOD)/ssl \ $(NWOS) \ $(EOLIST) @@ -55,6 +57,7 @@ # XLFLAGS += \ -L$(OBJDIR) \ + -L../proxy \ $(EOLIST) # @@ -224,6 +227,7 @@ @libc.imp \ @aprlib.imp \ @httpd.imp \ + @mod_proxy.imp \ $(EOLIST) # The first 2 extra lines allow the compiler to find extra headers, the 3rd allows the linker to locate mod_proxy.imp. Please review and apply this if it seems reasonable. Norm # # Declare the sub-directories to be built here # SUBDIRS = \ $(EOLIST) # # Get the 'head' of the build environment. This includes default targets and # paths to tools # include $(AP_WORK)/build/NWGNUhead.inc # # build this level's files # # Make sure all needed macro's are defined # # # These directories will be at the beginning of the include list, followed by # INCDIRS # XINCDIRS+= \ $(EOLIST) # # These flags will come after CFLAGS # XCFLAGS += \ $(EOLIST) # # These defines will come after DEFINES # XDEFINES+= \ $(EOLIST) # # These flags will be added to the link.opt file # XLFLAGS += \ $(EOLIST) # # These values will be appended to the correc
Re: httpd-trunk/modules/http2 gets a proxy
Uhm, is there an unresolved conflict in the first file? -Stefan PS. You know, it *would* actually be easier if you had commit access... ;-) > Am 11.02.2016 um 03:09 schrieb NormW : > > G/A Stefan, > My BBAADD. Until recently /http2 was home only to mod_http2, and to keep > things automatic my NWGNUmakefile in there used a wildcard *.c to get the > list of object files to build there. When the compile failed due to added .c > files I made a few tweaks to the NWGNU and it all linked without issue again > so I forwarded the small tweaks. Closer reading of the list and the added .c > revealed there are (at least) two modules now in /http2. This necessitated a > change of the NWGNU to use a specified list of .c for a start, and removal of > a couple of the patch lines I'd recently sent. Because other modules will be > sharing the same dir I've renamed the original NWNUmakefile to NWGNUmod_http2 > and there is now a new NWGNUmakefile whose only job is to call the other > NWGNU files that will eventually exist in the dir. (If all this sounds > confusing it probably is, but by way of example see /proxy dir and note a > NWGNUmakefile that contains a list of executables to build.) > > If we are still speaking after explaining all that, the new files are > attached, thus: > : NWGUmod_http2 which now has the list of /http2 files to build mod_http2; > > : NWGNUmakefile which, FTM, has a list of modules to build, but I won't try > to explain why the list has a double entry if there is only one (so far) to > build. > > Hopefully I will eventually work out a process to do away with this > 'additional' NWGNUmakefile, which would allow removal of quite a few from the > source tree. > Apologies for the bother, > Norm > > On 10/02/2016 10:34 PM, Stefan Eissing wrote: >> Applied in r1729583. Thanks! >> >>> Am 08.02.2016 um 23:07 schrieb NormW : > > >>> G/M, >>> Recent additions to http-trunk/modules/http2 require the attached apatch to >>> the http2 NetWare build file: Index: modules/http2/NWGNUmakefile === --- modules/http2/NWGNUmakefile(revision 1729251) +++ modules/http2/NWGNUmakefile(working copy) @@ -34,6 +34,8 @@ $(NGH2SRC)/lib/ \ $(NGH2SRC)/lib/includes \ $(SERVER)/mpm/NetWare \ + $(STDMOD)/proxy \ + $(STDMOD)/ssl \ $(NWOS) \ $(EOLIST) @@ -55,6 +57,7 @@ # XLFLAGS+= \ -L$(OBJDIR) \ + -L../proxy \ $(EOLIST) # @@ -224,6 +227,7 @@ @libc.imp \ @aprlib.imp \ @httpd.imp \ + @mod_proxy.imp \ $(EOLIST) # >>> >>> The first 2 extra lines allow the compiler to find extra headers, the 3rd >>> allows the linker to locate mod_proxy.imp. >>> >>> Please review and apply this if it seems reasonable. >>> >>> Norm >>> >> > >
Re: httpd-trunk/modules/http2 gets a proxy
G/A Stefan, My BBAADD. Until recently /http2 was home only to mod_http2, and to keep things automatic my NWGNUmakefile in there used a wildcard *.c to get the list of object files to build there. When the compile failed due to added .c files I made a few tweaks to the NWGNU and it all linked without issue again so I forwarded the small tweaks. Closer reading of the list and the added .c revealed there are (at least) two modules now in /http2. This necessitated a change of the NWGNU to use a specified list of .c for a start, and removal of a couple of the patch lines I'd recently sent. Because other modules will be sharing the same dir I've renamed the original NWNUmakefile to NWGNUmod_http2 and there is now a new NWGNUmakefile whose only job is to call the other NWGNU files that will eventually exist in the dir. (If all this sounds confusing it probably is, but by way of example see /proxy dir and note a NWGNUmakefile that contains a list of executables to build.) If we are still speaking after explaining all that, the new files are attached, thus: : NWGUmod_http2 which now has the list of /http2 files to build mod_http2; : NWGNUmakefile which, FTM, has a list of modules to build, but I won't try to explain why the list has a double entry if there is only one (so far) to build. Hopefully I will eventually work out a process to do away with this 'additional' NWGNUmakefile, which would allow removal of quite a few from the source tree. Apologies for the bother, Norm On 10/02/2016 10:34 PM, Stefan Eissing wrote: Applied in r1729583. Thanks! Am 08.02.2016 um 23:07 schrieb NormW : G/M, Recent additions to http-trunk/modules/http2 require the attached apatch to the http2 NetWare build file: Index: modules/http2/NWGNUmakefile === --- modules/http2/NWGNUmakefile (revision 1729251) +++ modules/http2/NWGNUmakefile (working copy) @@ -34,6 +34,8 @@ $(NGH2SRC)/lib/ \ $(NGH2SRC)/lib/includes \ $(SERVER)/mpm/NetWare \ + $(STDMOD)/proxy \ + $(STDMOD)/ssl \ $(NWOS) \ $(EOLIST) @@ -55,6 +57,7 @@ # XLFLAGS += \ -L$(OBJDIR) \ + -L../proxy \ $(EOLIST) # @@ -224,6 +227,7 @@ @libc.imp \ @aprlib.imp \ @httpd.imp \ + @mod_proxy.imp \ $(EOLIST) # The first 2 extra lines allow the compiler to find extra headers, the 3rd allows the linker to locate mod_proxy.imp. Please review and apply this if it seems reasonable. Norm # # Declare the sub-directories to be built here # SUBDIRS = \ $(EOLIST) # # Get the 'head' of the build environment. This includes default targets and # paths to tools # include $(AP_WORK)/build/NWGNUhead.inc # # build this level's files # # Make sure all needed macro's are defined # # # These directories will be at the beginning of the include list, followed by # INCDIRS # XINCDIRS+= \ <<< .mine === $(APR)/include \ $(APRUTIL)/include \ $(SRC)/include \ $(NGH2SRC)/lib/ \ $(NGH2SRC)/lib/includes \ $(SERVER)/mpm/NetWare \ $(STDMOD)/proxy \ $(STDMOD)/ssl \ $(NWOS) \ >>> .r1729754 $(EOLIST) # # These flags will come after CFLAGS # XCFLAGS += \ $(EOLIST) # # These defines will come after DEFINES # XDEFINES+= \ $(EOLIST) # # These flags will be added to the link.opt file # XLFLAGS += \ -L../proxy \ $(EOLIST) # # These values will be appended to the correct variables based on the value of # RELEASE # ifeq "$(RELEASE)" "debug" XINCDIRS+= \ $(EOLIST) XCFLAGS += \ $(EOLIST) XDEFINES+= \ $(EOLIST) XLFLAGS += \ $(EOLIST) endif ifeq "$(RELEASE)" "noopt" XINCDIRS+= \ $(EOLIST) XCFLAGS += \ $(EOLIST) XDEFINES+= \ $(EOLIST) XLFLAGS += \ $(EOLIST) endif ifeq "$(RELEASE)" "release" XINCDIRS+= \ $(EOLIST) XCFLAGS += \ $(EOLIST) XDEFINES+= \ $(EOLIST) XLFLAGS += \ $(EOLIST) endif # # These are used by the link target if an NLM is being generated # This is used by the link 'name' directive to name the nlm. If left blank # TARGET_nlm (see below) will be used. # NLM_NAME
Re: httpd-trunk/modules/http2 gets a proxy
Applied in r1729583. Thanks! > Am 08.02.2016 um 23:07 schrieb NormW : > > G/M, > Recent additions to http-trunk/modules/http2 require the attached apatch to > the http2 NetWare build file: >> Index: modules/http2/NWGNUmakefile >> === >> --- modules/http2/NWGNUmakefile (revision 1729251) >> +++ modules/http2/NWGNUmakefile (working copy) >> @@ -34,6 +34,8 @@ >> $(NGH2SRC)/lib/ \ >> $(NGH2SRC)/lib/includes \ >> $(SERVER)/mpm/NetWare \ >> +$(STDMOD)/proxy \ >> +$(STDMOD)/ssl \ >> $(NWOS) \ >> $(EOLIST) >> >> @@ -55,6 +57,7 @@ >> # >> XLFLAGS += \ >> -L$(OBJDIR) \ >> +-L../proxy \ >> $(EOLIST) >> >> # >> @@ -224,6 +227,7 @@ >> @libc.imp \ >> @aprlib.imp \ >> @httpd.imp \ >> +@mod_proxy.imp \ >> $(EOLIST) >> >> # > > The first 2 extra lines allow the compiler to find extra headers, the 3rd > allows the linker to locate mod_proxy.imp. > > Please review and apply this if it seems reasonable. > > Norm >
httpd-trunk/modules/http2 gets a proxy
G/M, Recent additions to http-trunk/modules/http2 require the attached apatch to the http2 NetWare build file: Index: modules/http2/NWGNUmakefile === --- modules/http2/NWGNUmakefile (revision 1729251) +++ modules/http2/NWGNUmakefile (working copy) @@ -34,6 +34,8 @@ $(NGH2SRC)/lib/ \ $(NGH2SRC)/lib/includes \ $(SERVER)/mpm/NetWare \ + $(STDMOD)/proxy \ + $(STDMOD)/ssl \ $(NWOS) \ $(EOLIST) @@ -55,6 +57,7 @@ # XLFLAGS+= \ -L$(OBJDIR) \ + -L../proxy \ $(EOLIST) # @@ -224,6 +227,7 @@ @libc.imp \ @aprlib.imp \ @httpd.imp \ + @mod_proxy.imp \ $(EOLIST) # The first 2 extra lines allow the compiler to find extra headers, the 3rd allows the linker to locate mod_proxy.imp. Please review and apply this if it seems reasonable. Norm Index: modules/http2/NWGNUmakefile === --- modules/http2/NWGNUmakefile (revision 1729251) +++ modules/http2/NWGNUmakefile (working copy) @@ -34,6 +34,8 @@ $(NGH2SRC)/lib/ \ $(NGH2SRC)/lib/includes \ $(SERVER)/mpm/NetWare \ + $(STDMOD)/proxy \ + $(STDMOD)/ssl \ $(NWOS) \ $(EOLIST) @@ -55,6 +57,7 @@ # XLFLAGS += \ -L$(OBJDIR) \ + -L../proxy \ $(EOLIST) # @@ -224,6 +227,7 @@ @libc.imp \ @aprlib.imp \ @httpd.imp \ + @mod_proxy.imp \ $(EOLIST) #
