Re: httpd test suite breakage

[William A Rowe Jr]

On Tue, Nov 29, 2016 at 7:25 AM, Petr Gajdos  wrote:

> On Tue, Nov 29, 2016 at 01:09:25PM +, Joe Orton wrote:
> > On Mon, Nov 28, 2016 at 05:16:12PM -0600, William A Rowe Jr wrote:
> > > httpd: Syntax error on line 295 of
> > > /home/wrowe/dev/test/test24-apr16-ossl102/t/conf/httpd.conf: Cannot
> load
> > > /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_
> session/.libs/mod_test_session.so
> > > into server:
> > > /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_
> session/.libs/mod_test_session.so:
> > > undefined symbol: ap_hook_session_save
> > >
> > > Does anyone have an uncommitted test framework patch
> > > up their sleeve to remedy?
> >
> > Modules using the session API can't be loaded if mod_session isn't
> > loaded.
>

Of course. Note this threw me as mod_test_ssl doesn't suffer this same
issue,
since it correctly relied on optional hooks to avoid load order dependency
(and
emits errors in the log that it can't function if mod_ssl isn't loaded.)


> > To make this "work" in the test framework we'd need to surround the
> > generated LoadModule for mod_test_session with 
> > or something.  I don't know if that can be done without hacking around
> > inside Apache::Test.
>
> I was thinking about text file along each c-module which would express
> the required modules which would be translated to .
>

It seems like something inside Apache::Test that indicated module
dependencies
for compiled test modules would be worthwhile. Looked some this morning, and
noticed no special sauce other than

#define HTTPD_TEST_REQUIRE_APACHE 2

which isn't quite the same thing. But it does look like any special sauce
should be added to Apache-Test/lib/Apache/TestConfigC.pm unless we do
some  dependency logic. (Or simply fixed mod_session to not
be load order dependent and use the optional entry point APIs.)

Re: httpd test suite breakage

[Petr Gajdos]

On Tue, Nov 29, 2016 at 01:09:25PM +, Joe Orton wrote:
> On Mon, Nov 28, 2016 at 05:16:12PM -0600, William A Rowe Jr wrote:
> > httpd: Syntax error on line 295 of
> > /home/wrowe/dev/test/test24-apr16-ossl102/t/conf/httpd.conf: Cannot load
> > /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so
> > into server:
> > /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so:
> > undefined symbol: ap_hook_session_save
> > 
> > Does anyone have an uncommitted test framework patch
> > up their sleeve to remedy?
> 
> Modules using the session API can't be loaded if mod_session isn't 
> loaded.
> 
> To make this "work" in the test framework we'd need to surround the 
> generated LoadModule for mod_test_session with  
> or something.  I don't know if that can be done without hacking around 
> inside Apache::Test.

I was thinking about text file along each c-module which would express
the required modules which would be translated to .

Petr

Re: httpd test suite breakage

[Joe Orton]

On Mon, Nov 28, 2016 at 05:16:12PM -0600, William A Rowe Jr wrote:
> httpd: Syntax error on line 295 of
> /home/wrowe/dev/test/test24-apr16-ossl102/t/conf/httpd.conf: Cannot load
> /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so
> into server:
> /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so:
> undefined symbol: ap_hook_session_save
> 
> Does anyone have an uncommitted test framework patch
> up their sleeve to remedy?

Modules using the session API can't be loaded if mod_session isn't 
loaded.

To make this "work" in the test framework we'd need to surround the 
generated LoadModule for mod_test_session with  
or something.  I don't know if that can be done without hacking around 
inside Apache::Test.

Easier to just load mod_session to "fix" it!  Re your follow-up, for 
Fedora httpd this is in a separate package, so "dnf install 
mod_session".

Regards, Joe

Re: httpd test suite breakage

[William A Rowe Jr]

My bad.. this is not against HEAD, this is Fedora 25.

/sbin/httpd -v
Server version: Apache/2.4.23 (Fedora)
Server built:   Jul 18 2016 15:38:14

Not so urgent for me now, but worth addressing I'd guess.

On Mon, Nov 28, 2016 at 5:16 PM, William A Rowe Jr 
wrote:

> Against 2.4 HEAD...
>
> In file included from mod_test_session.c:61:0:
> mod_test_session.c: In function ‘test_session_register_hooks’:
> /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/apache_httpd_test.h:128:36:
> warning: the comparison will always evaluate as ‘true’ for the address of
> ‘test_session_handler’ will never be NULL [-Waddress]
>   if (APACHE_HTTPD_TEST_HANDLER != NULL) \
> ^
> mod_test_session.c:348:1: note: in expansion of macro
> ‘APACHE_HTTPD_TEST_MODULE’
>  APACHE_HTTPD_TEST_MODULE(test_session);
>  ^~~~
> /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/apache_httpd_test.h:136:39:
> warning: the comparison will always evaluate as ‘true’ for the address of
> ‘test_session_init’ will never be NULL [-Waddress]
>   if (APACHE_HTTPD_TEST_CHILD_INIT != NULL) \
>^
> mod_test_session.c:348:1: note: in expansion of macro
> ‘APACHE_HTTPD_TEST_MODULE’
>  APACHE_HTTPD_TEST_MODULE(test_session);
>  ^~~~
>
> httpd: Syntax error on line 295 of /home/wrowe/dev/test/test24-
> apr16-ossl102/t/conf/httpd.conf: Cannot load /home/wrowe/dev/test/test24-
> apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so into
> server: /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_
> session/.libs/mod_test_session.so: undefined symbol: ap_hook_session_save
>
> Does anyone have an uncommitted test framework patch
> up their sleeve to remedy?
>
> TIA,
>
> Bill
>

httpd test suite breakage

[William A Rowe Jr]

Against 2.4 HEAD...

In file included from mod_test_session.c:61:0:
mod_test_session.c: In function ‘test_session_register_hooks’:
/home/wrowe/dev/test/test24-apr16-ossl102/c-modules/apache_httpd_test.h:128:36:
warning: the comparison will always evaluate as ‘true’ for the address of
‘test_session_handler’ will never be NULL [-Waddress]
  if (APACHE_HTTPD_TEST_HANDLER != NULL) \
^
mod_test_session.c:348:1: note: in expansion of macro
‘APACHE_HTTPD_TEST_MODULE’
 APACHE_HTTPD_TEST_MODULE(test_session);
 ^~~~
/home/wrowe/dev/test/test24-apr16-ossl102/c-modules/apache_httpd_test.h:136:39:
warning: the comparison will always evaluate as ‘true’ for the address of
‘test_session_init’ will never be NULL [-Waddress]
  if (APACHE_HTTPD_TEST_CHILD_INIT != NULL) \
   ^
mod_test_session.c:348:1: note: in expansion of macro
‘APACHE_HTTPD_TEST_MODULE’
 APACHE_HTTPD_TEST_MODULE(test_session);
 ^~~~

httpd: Syntax error on line 295 of
/home/wrowe/dev/test/test24-apr16-ossl102/t/conf/httpd.conf: Cannot load
/home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so
into server:
/home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so:
undefined symbol: ap_hook_session_save

Does anyone have an uncommitted test framework patch
up their sleeve to remedy?

TIA,

Bill