Re: new compile errors on 2.0 cvs head

2002-03-20 Thread Bill Stoddard

I am on it.  Funny thing is, I developed the initial cut of the patch expecting to see
this warning. My compiler didn't issue the warning (gotta find out why), I sat on the
patch for a few days did a recompile before committing the patch, didn;t see any new
warnings so committed it. I must have a setting off in my VC++ 6.0 configuration...

Bill

- Original Message -
From: William A. Rowe, Jr. [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Wednesday, March 20, 2002 2:19 AM
Subject: new compile errors on 2.0 cvs head


 http_request.c
 C:\clean\httpd-2.0\modules\http\http_request.c(389) : warning C4090:
 'function' : different 'const' qualifiers
 C:\clean\httpd-2.0\modules\http\http_request.c(389) : warning C4024:
 'ap_rset_content_type' : different types for formal and actual parameter 1
 C:\clean\httpd-2.0\modules\http\http_request.c(431) : warning C4090:
 'function' : different 'const' qualifiers
 C:\clean\httpd-2.0\modules\http\http_request.c(431) : warning C4024:
 'ap_rset_content_type' : different types for formal and actual parameter 1
 mod_rewrite.c
 C:\clean\httpd-2.0\modules\mappers\mod_rewrite.c(1314) : warning C4090:
 'function' : different 'const' qualifiers
 C:\clean\httpd-2.0\modules\mappers\mod_rewrite.c(1314) : warning C4024:
 'ap_rset_content_type' : different types for formal and actual parameter 1
 proxy_ftp.c
 C:\clean\httpd-2.0\modules\proxy\proxy_ftp.c(1721) : warning C4090:
 'function' : different 'const' qualifiers
 C:\clean\httpd-2.0\modules\proxy\proxy_ftp.c(1721) : warning C4024:
 'ap_rset_content_type' : different types for formal and actual parameter 1






Re: new compile errors on 2.0 cvs head

2002-03-20 Thread Jeff Trawick

Bill Stoddard [EMAIL PROTECTED] writes:

 I am on it.  Funny thing is, I developed the initial cut of the patch expecting to 
see
 this warning. My compiler didn't issue the warning (gotta find out why), I sat on the
 patch for a few days did a recompile before committing the patch, didn;t see any new
 warnings so committed it. I must have a setting off in my VC++ 6.0 configuration...

try grabbing my very recent commit to http_protocol.c and
http_protocol.h...  I made the parm to ap_rset_content_type() const
char * instead of char *

-- 
Jeff Trawick | [EMAIL PROTECTED]
Born in Roswell... married an alien...



Re: new compile errors on 2.0 cvs head

2002-03-19 Thread Brian Pane

William A. Rowe, Jr. wrote:

http_request.c
C:\clean\httpd-2.0\modules\http\http_request.c(389) : warning C4090:
'function' : different 'const' qualifiers
C:\clean\httpd-2.0\modules\http\http_request.c(389) : warning C4024:
'ap_rset_content_type' : different types for formal and actual parameter 1
C:\clean\httpd-2.0\modules\http\http_request.c(431) : warning C4090:
'function' : different 'const' qualifiers
C:\clean\httpd-2.0\modules\http\http_request.c(431) : warning C4024:
'ap_rset_content_type' : different types for formal and actual parameter 1
mod_rewrite.c
C:\clean\httpd-2.0\modules\mappers\mod_rewrite.c(1314) : warning C4090:
'function' : different 'const' qualifiers
C:\clean\httpd-2.0\modules\mappers\mod_rewrite.c(1314) : warning C4024:
'ap_rset_content_type' : different types for formal and actual parameter 1
proxy_ftp.c
C:\clean\httpd-2.0\modules\proxy\proxy_ftp.c(1721) : warning C4090:
'function' : different 'const' qualifiers
C:\clean\httpd-2.0\modules\proxy\proxy_ftp.c(1721) : warning C4024:
'ap_rset_content_type' : different types for formal and actual parameter 1


I think ap_rset_content_type should take a const char* instead
of a char*.  The only thing that function does with the string
arg is assign it to request_rec-content_type, and that's const.

--Brian