Re: patch for flood to deal with gcc 4
Den Friday 18 April 2008 00.24.14 skrev Guy Ferraiolo: Folks Here's the patch to get this to compile correctly with gcc 4. It's actually only 3 lines. This has been tested with the following versions: gcc version 3.4.6 20060404 (Red Hat 3.4.6-8), (RHEL4 32-bit) gcc version 4.1.1 20070105 (Red Hat 4.1.1-52) (RHEL4 64-bit) Works, thanks. There is still some warnings though: http://pastebin.se/194251 -- Regards // Oden Eriksson
Re: patch for flood to deal with gcc 4
I believe the other warnings are from the code prior to my patch. I was somewhat shy about altering other people's code as a newbie. The fixes would be easy, anyone could do them. I felt responsible for my new code which others might not want to mess with. Guy On Fri, 2008-04-18 at 09:24 +0200, Oden Eriksson wrote: Den Friday 18 April 2008 00.24.14 skrev Guy Ferraiolo: Folks Here's the patch to get this to compile correctly with gcc 4. It's actually only 3 lines. This has been tested with the following versions: gcc version 3.4.6 20060404 (Red Hat 3.4.6-8), (RHEL4 32-bit) gcc version 4.1.1 20070105 (Red Hat 4.1.1-52) (RHEL4 64-bit) Works, thanks. There is still some warnings though: http://pastebin.se/194251 -- Guy Ferraiolo mailto:[EMAIL PROTECTED] Performance Measurement Analysis http://CNET.com CNETtel: 1.908.541.3739 1200 Route 22 East fax: 1.908.575.7474 Bridgewater, NJ 08807 cel: 1.732.618.0250
Re: patch for flood to deal with gcc 4
Den Friday 18 April 2008 17.49.29 skrev Guy Ferraiolo: I believe the other warnings are from the code prior to my patch. I was somewhat shy about altering other people's code as a newbie. The fixes would be easy, anyone could do them. I felt responsible for my new code which others might not want to mess with. Guy On Fri, 2008-04-18 at 09:24 +0200, Oden Eriksson wrote: Den Friday 18 April 2008 00.24.14 skrev Guy Ferraiolo: Folks Here's the patch to get this to compile correctly with gcc 4. It's actually only 3 lines. This has been tested with the following versions: gcc version 3.4.6 20060404 (Red Hat 3.4.6-8), (RHEL4 32-bit) gcc version 4.1.1 20070105 (Red Hat 4.1.1-52) (RHEL4 64-bit) Works, thanks. There is still some warnings though: http://pastebin.se/194251 I understood that, thanks man. I merely wanted to make the person maintaining the code aware. -- Regards // Oden Eriksson
patch for flood to deal with gcc 4
Folks
Here's the patch to get this to compile correctly with gcc 4. It's
actually only 3 lines. This has been tested with the following
versions:
gcc version 3.4.6 20060404 (Red Hat 3.4.6-8), (RHEL4 32-bit)
gcc version 4.1.1 20070105 (Red Hat 4.1.1-52) (RHEL4 64-bit)
Thanks,
Guy
--
Guy Ferraiolo mailto:[EMAIL PROTECTED]
Performance Measurement Analysis http://CNET.com
CNETtel: 1.908.541.3739
1200 Route 22 East fax: 1.908.575.7474
Bridgewater, NJ 08807 cel: 1.732.618.0250
diff -urN flood/flood_round_robin.c flood-asf-patchbuild/flood_round_robin.c
--- flood/flood_round_robin.c 2008-04-15 15:07:15.317181000 -0700
+++ flood-asf-patchbuild/flood_round_robin.c 2008-04-15 15:18:04.262536000 -0700
@@ -905,7 +905,7 @@
XML_SUBST_VAR, FLOOD_STRLEN_MAX) == 0) {
if (subst_entry_child-first_cdata.first
subst_entry_child-first_cdata.first-text) {
-(subst_rec_t*)subst_rec_p-subst_var =
+subst_rec_p-subst_var =
apr_pstrdup(pool,
subst_entry_child-first_cdata.first-text);
}
@@ -915,7 +915,7 @@
XML_SUBST_FILE, FLOOD_STRLEN_MAX) == 0) {
if (subst_entry_child-first_cdata.first
subst_entry_child-first_cdata.first-text) {
-(subst_rec_t*)subst_rec_p-subst_file_name =
+subst_rec_p-subst_file_name =
apr_pstrdup(pool,
subst_entry_child-first_cdata.first-text);
}
diff -urN flood/flood_subst_file.c flood-asf-patchbuild/flood_subst_file.c
--- flood/flood_subst_file.c 2008-04-15 15:07:15.330182000 -0700
+++ flood-asf-patchbuild/flood_subst_file.c 2008-04-15 15:18:04.308533000 -0700
@@ -1,4 +1,5 @@
#include assert.h
+#include stdlib.h
#include apr_general.h
#include apr_file_io.h
#include flood_subst_file.h
