Re: slotmem_plain & slotmem consumers
On Apr 2, 2011, at 7:28 PM, Gregg L. Smith wrote: > Nor would I expect you to. At minimum a hint in the consumers that > mod_slotmem_shm should be loaded. The current error message is not very clear > to a user IMO. mod_heartmonitor does this, explicitly says mod_watchdog is > needed should it not be loaded also. > Well, as they say in the Wizard of Oz: that's a horse of a different color. I better error message is different that simply adding in another provider, whether it works or not.
Re: Re: slotmem_plain & slotmem consumers
Nor would I expect you to. At minimum a hint in the consumers that mod_slotmem_shm should be loaded. The current error message is not very clear to a user IMO. mod_heartmonitor does this, explicitly says mod_watchdog is needed should it not be loaded also. There are other problems in at least mod_heartmonitor for us Windows folk should a slotmem provider not be available at all, mainly unix file permissions being set by the module and the module then errors when it receives the not implemented message. Originally I was on the probably erroneous thought process that mainly, we have this provider here but no, zero, zilch consumers. Seems odd no? Cheers, Gregg -Original Message- From: Jim Jagielski On Apr 1, 2011, at 8:28 PM, NormW wrote: If they *do* then I'm +1 on the patch, but adding the patch w/o verification is just silly...
Re: slotmem_plain & slotmem consumers
On Apr 1, 2011, at 8:28 PM, NormW wrote: > G/M... > On 2/04/2011 5:26 AM, Jim Jagielski wrote: >> The consumers in the patch depend on the shm version of the >> slotmem impl... no idea what the impact of moving to plain >> would be, but functionality will be lost... > without: >> + if (!storage) >> + storage = ap_lookup_provider(AP_SLOTMEM_PROVIDER_GROUP, "plain", "0"); > > "plain" won't even be found, which is really lost. My point is those consumers in the patch were designed to use shm; I doubt if they would work correctly if at all using the plain slotmem providers. If they *do* then I'm +1 on the patch, but adding the patch w/o verification is just silly...
Re: slotmem_plain & slotmem consumers
G/M... On 2/04/2011 5:26 AM, Jim Jagielski wrote: The consumers in the patch depend on the shm version of the slotmem impl... no idea what the impact of moving to plain would be, but functionality will be lost... without: + if (!storage) + storage = ap_lookup_provider(AP_SLOTMEM_PROVIDER_GROUP, "plain", "0"); "plain" won't even be found, which is really lost. Regards, Norm On Mar 30, 2011, at 7:36 PM, Gregg L. Smith wrote: Hello, It seems that slotmem_plain is not being found by the consumers which then causes a configuration error. Attached patch fixes this and makes the error message a little more friendlier for users by hinting to load slotmem which is currently not documented as a requirement of these modules. Regards, Gregg
Re: slotmem_plain & slotmem consumers
The consumers in the patch depend on the shm version of the slotmem impl... no idea what the impact of moving to plain would be, but functionality will be lost... On Mar 30, 2011, at 7:36 PM, Gregg L. Smith wrote: > Hello, > > It seems that slotmem_plain is not being found by the consumers which then > causes a configuration error. Attached patch fixes this and makes the error > message a little more friendlier for users by hinting to load slotmem which > is currently not documented as a requirement of these modules. > > Regards, > > Gregg > > >
Re: slotmem_plain & slotmem consumers
Thx for the patch! On Mar 30, 2011, at 7:36 PM, Gregg L. Smith wrote: > Hello, > > It seems that slotmem_plain is not being found by the consumers which then > causes a configuration error. Attached patch fixes this and makes the error > message a little more friendlier for users by hinting to load slotmem which > is currently not documented as a requirement of these modules. > > Regards, > > Gregg > > >
slotmem_plain & slotmem consumers
Hello, It seems that slotmem_plain is not being found by the consumers which then causes a configuration error. Attached patch fixes this and makes the error message a little more friendlier for users by hinting to load slotmem which is currently not documented as a requirement of these modules. Regards, Gregg slotmem_consumers_fix.diff Description: Binary data
