Re: svn commit: r1687642 - /httpd/httpd/trunk/server/protocol.c

2015-06-25 Thread Yann Ylavic 
IMHO, the core_input_filter() should not return APR_SUCCESS with an
empty brigade when the underlying socket is EOF, APR_EOF would be more
appropriate.

On Thu, Jun 25, 2015 at 10:44 PM,  cove...@apache.org wrote:
 Author: covener
 Date: Thu Jun 25 20:44:42 2015
 New Revision: 1687642

 URL: http://svn.apache.org/r1687642
 Log:
 elaborate on a misleading comment


 Modified:
 httpd/httpd/trunk/server/protocol.c

 Modified: httpd/httpd/trunk/server/protocol.c
 URL: 
 http://svn.apache.org/viewvc/httpd/httpd/trunk/server/protocol.c?rev=1687642r1=1687641r2=1687642view=diff
 ==
 --- httpd/httpd/trunk/server/protocol.c (original)
 +++ httpd/httpd/trunk/server/protocol.c Thu Jun 25 20:44:42 2015
 @@ -236,7 +236,9 @@ AP_DECLARE(apr_status_t) ap_rgetline_cor
  return rv;
  }

 -/* Something horribly wrong happened.  Someone didn't block! */
 +/* Something horribly wrong happened.  Someone didn't block!
 + * (this also happens at the end of each kept-alive connection)
 + */
  if (APR_BRIGADE_EMPTY(bb)) {
  return APR_EGENERAL;
  }

Re: svn commit: r1687642 - /httpd/httpd/trunk/server/protocol.c

2015-06-25 Thread Yann Ylavic 
To be more clear, that's only true for GETLINE or when NONBLOCK_READ
is used, not for READBYTES.

On Thu, Jun 25, 2015 at 11:02 PM, Yann Ylavic ylavic@gmail.com wrote:
 IMHO, the core_input_filter() should not return APR_SUCCESS with an
 empty brigade when the underlying socket is EOF, APR_EOF would be more
 appropriate.

 On Thu, Jun 25, 2015 at 10:44 PM,  cove...@apache.org wrote:
 Author: covener
 Date: Thu Jun 25 20:44:42 2015
 New Revision: 1687642

 URL: http://svn.apache.org/r1687642
 Log:
 elaborate on a misleading comment


 Modified:
 httpd/httpd/trunk/server/protocol.c

 Modified: httpd/httpd/trunk/server/protocol.c
 URL: 
 http://svn.apache.org/viewvc/httpd/httpd/trunk/server/protocol.c?rev=1687642r1=1687641r2=1687642view=diff
 ==
 --- httpd/httpd/trunk/server/protocol.c (original)
 +++ httpd/httpd/trunk/server/protocol.c Thu Jun 25 20:44:42 2015
 @@ -236,7 +236,9 @@ AP_DECLARE(apr_status_t) ap_rgetline_cor
  return rv;
  }

 -/* Something horribly wrong happened.  Someone didn't block! */
 +/* Something horribly wrong happened.  Someone didn't block!
 + * (this also happens at the end of each kept-alive connection)
 + */
  if (APR_BRIGADE_EMPTY(bb)) {
  return APR_EGENERAL;
  }