Re: svn commit: r1775186 - /httpd/test/framework/trunk/t/apache/http_strict.t

[Rainer Jung]

Hi Bill,

Am 20.12.2016 um 18:22 schrieb William A Rowe Jr:

On Mon, Dec 19, 2016 at 4:20 PM, > wrote:

Author: rjung
Date: Mon Dec 19 22:20:12 2016
New Revision: 1775186

URL: http://svn.apache.org/viewvc?rev=1775186=rev

Log:
Skip tests that need a cgi module if cgi
is not available.

Modified:
httpd/test/framework/trunk/t/apache/http_strict.t

Modified: httpd/test/framework/trunk/t/apache/http_strict.t
URL:

http://svn.apache.org/viewvc/httpd/test/framework/trunk/t/apache/http_strict.t?rev=1775186=1775185=1775186=diff



==
--- httpd/test/framework/trunk/t/apache/http_strict.t (original)
+++ httpd/test/framework/trunk/t/apache/http_strict.t Mon Dec 19
22:20:12 2016
@@ -122,6 +122,10 @@ foreach my $t (@test_cases) {
 my $decoded;

 if ($req =~ s/^R//) {
+if (!have_cgi) {
+skip "Skipping test without CGI module";
+next;
+}


Does this work in the presence of either cgi and/or cgid?


Yes, have_cgi is true if either one of the two is loaded.

Regards,

Rainer

Re: svn commit: r1775186 - /httpd/test/framework/trunk/t/apache/http_strict.t

[William A Rowe Jr]

On Mon, Dec 19, 2016 at 4:20 PM,  wrote:

> Author: rjung
> Date: Mon Dec 19 22:20:12 2016
> New Revision: 1775186
>
> URL: http://svn.apache.org/viewvc?rev=1775186=rev
> Log:
> Skip tests that need a cgi module if cgi
> is not available.
>
> Modified:
> httpd/test/framework/trunk/t/apache/http_strict.t
>
> Modified: httpd/test/framework/trunk/t/apache/http_strict.t
> URL: http://svn.apache.org/viewvc/httpd/test/framework/trunk/t/
> apache/http_strict.t?rev=1775186=1775185=1775186=diff
> 
> ==
> --- httpd/test/framework/trunk/t/apache/http_strict.t (original)
> +++ httpd/test/framework/trunk/t/apache/http_strict.t Mon Dec 19 22:20:12
> 2016
> @@ -122,6 +122,10 @@ foreach my $t (@test_cases) {
>  my $decoded;
>
>  if ($req =~ s/^R//) {
> +if (!have_cgi) {
> +skip "Skipping test without CGI module";
> +next;
> +}
>

Does this work in the presence of either cgi and/or cgid?