Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS

2017-06-30 Thread Jim Jagielski 

> On Jun 30, 2017, at 11:43 AM, Eric Covener  wrote:
> 
> On Fri, Jun 30, 2017 at 11:10 AM, William A Rowe Jr  
> wrote:
>> Thousands of bugs pass through STATUS, what makes yours special?
> 
> It fixes a regression in the last release, I think it's close enough
> in spirit as a showstopper.

+1. (imo)

Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS

2017-06-30 Thread Eric Covener 
On Fri, Jun 30, 2017 at 11:10 AM, William A Rowe Jr  wrote:
> Thousands of bugs pass through STATUS, what makes yours special?

It fixes a regression in the last release, I think it's close enough
in spirit as a showstopper.

Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS

2017-06-30 Thread Luca Toscano 
2017-06-30 17:34 GMT+02:00 Jacob Champion :

> On 06/30/2017 08:10 AM, William A Rowe Jr wrote:
>
>> -1 on showstopper. It's a bug, no security implications, cope with it.
>>
>> Thousands of bugs pass through STATUS, what makes yours special?
>>
>
> It's a reinstatement of my previous 2.4.26 showstopper, which got no
> objections, was unaddressed by the proposed patch for it, and is finally
> addressed with this patch.
>
> We've busted people three releases in a row, and we already have emails on
> the list asking if we're going to fix it next release, or if those affected
> need to hardwire workarounds into their stacks, which is exactly what we
> don't want. My showstopper stands unless more PMC members object, in which
> case I will retract it.


+1 to Jacob's point.

Luca

Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS

2017-06-30 Thread Jacob Champion 

On 06/30/2017 08:10 AM, William A Rowe Jr wrote:

-1 on showstopper. It's a bug, no security implications, cope with it.

Thousands of bugs pass through STATUS, what makes yours special?


It's a reinstatement of my previous 2.4.26 showstopper, which got no 
objections, was unaddressed by the proposed patch for it, and is finally 
addressed with this patch.


We've busted people three releases in a row, and we already have emails 
on the list asking if we're going to fix it next release, or if those 
affected need to hardwire workarounds into their stacks, which is 
exactly what we don't want. My showstopper stands unless more PMC 
members object, in which case I will retract it.


--Jacob

Re: svn commit: r1800307 - /httpd/httpd/branches/2.4.x/STATUS

2017-06-30 Thread William A Rowe Jr 
-1 on showstopper. It's a bug, no security implications, cope with it.

Thousands of bugs pass through STATUS, what makes yours special?

That said, unconditional +1 to any mod_proxy_fcgi.c patches you or Jim or
any committers determine for backport, I'd prefer we treat the module as
experimental until it behaves how we desire and in any way compatible with
PHP's tomfoolery.


On Jun 29, 2017 1:06 PM,  wrote:

> Author: jchampion
> Date: Thu Jun 29 18:06:49 2017
> New Revision: 1800307
>
> URL: http://svn.apache.org/viewvc?rev=1800307=rev
> Log:
> Propose showstopper.
>
> Modified:
> httpd/httpd/branches/2.4.x/STATUS
>
> Modified: httpd/httpd/branches/2.4.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/
> STATUS?rev=1800307=1800306=1800307=diff
> 
> ==
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Thu Jun 29 18:06:49 2017
> @@ -112,6 +112,12 @@ CURRENT RELEASE NOTES:
>
>  RELEASE SHOWSTOPPERS:
>
> +  *) PR61202: remove FPM-specific logic from mod_proxy_fcgi. Returns us to
> + 2.4.20 FCGI behavior by default.
> + trunk patch: https://svn.apache.org/r1800306
> + 2.4.x patch: trunk works, modulo APLOGNO and CHANGES
> + +1: jchampion
> +
>
>  PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
>[ start all new proposals below, under PATCHES PROPOSED. ]
>
>
>