Re: svn commit: r1913815 - in /httpd/httpd/trunk: changes-entries/pr68080.txt modules/ssl/mod_ssl.c modules/ssl/ssl_engine_config.c modules/ssl/ssl_private.h
On 11/15/23 23:09, yla...@apache.org wrote: Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_config.c URL:http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_engine_config.c?rev=1913815&r1=1913814&r2=1913815&view=diff == --- httpd/httpd/trunk/modules/ssl/ssl_engine_config.c (original) +++ httpd/httpd/trunk/modules/ssl/ssl_engine_config.c Wed Nov 15 22:09:05 2023 @@ -669,7 +669,6 @@ const char *ssl_cmd_SSLPassPhraseDialog( return NULL; } -#if defined(HAVE_OPENSSL_ENGINE_H) && defined(HAVE_ENGINE_INIT) const char *ssl_cmd_SSLCryptoDevice(cmd_parms *cmd, void *dcfg, const char *arg) @@ -714,7 +713,6 @@ const char *ssl_cmd_SSLCryptoDevice(cmd_ return NULL; } -#endif I think that is causing compilation problems with: mc->szCryptoDevice = NULL; in ssl_cmd_SSLCryptoDevice(). -- Cheers Jean-Frederic
Re: svn commit: r1913815 - in /httpd/httpd/trunk: changes-entries/pr68080.txt modules/ssl/mod_ssl.c modules/ssl/ssl_engine_config.c modules/ssl/ssl_private.h
On Mon, Feb 19, 2024 at 5:36 PM jean-frederic clere wrote: > > On 11/15/23 23:09, yla...@apache.org wrote: > > Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_config.c > > URL:http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_engine_config.c?rev=1913815&r1=1913814&r2=1913815&view=diff > > == > > --- httpd/httpd/trunk/modules/ssl/ssl_engine_config.c (original) > > +++ httpd/httpd/trunk/modules/ssl/ssl_engine_config.c Wed Nov 15 22:09:05 > > 2023 > > @@ -669,7 +669,6 @@ const char *ssl_cmd_SSLPassPhraseDialog( > > return NULL; > > } > > > > -#if defined(HAVE_OPENSSL_ENGINE_H) && defined(HAVE_ENGINE_INIT) > > const char *ssl_cmd_SSLCryptoDevice(cmd_parms *cmd, > > void *dcfg, > > const char *arg) > > @@ -714,7 +713,6 @@ const char *ssl_cmd_SSLCryptoDevice(cmd_ > > > > return NULL; > > } > > -#endif > > I think that is causing compilation problems with: > mc->szCryptoDevice = NULL; > in ssl_cmd_SSLCryptoDevice(). Thanks, I suppose this happens with the latest OpenSSL versions where they removed the ENGINE API completely? Fixed in r1915889 hopefully (should probably be backported to 2.4.x since r1913815 made it there already). Regards; Yann.
Re: svn commit: r1913815 - in /httpd/httpd/trunk: changes-entries/pr68080.txt modules/ssl/mod_ssl.c modules/ssl/ssl_engine_config.c modules/ssl/ssl_private.h
On 2/20/24 11:40, Yann Ylavic wrote: On Mon, Feb 19, 2024 at 5:36 PM jean-frederic clere wrote: On 11/15/23 23:09, yla...@apache.org wrote: Modified: httpd/httpd/trunk/modules/ssl/ssl_engine_config.c URL:http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ssl/ssl_engine_config.c?rev=1913815&r1=1913814&r2=1913815&view=diff == --- httpd/httpd/trunk/modules/ssl/ssl_engine_config.c (original) +++ httpd/httpd/trunk/modules/ssl/ssl_engine_config.c Wed Nov 15 22:09:05 2023 @@ -669,7 +669,6 @@ const char *ssl_cmd_SSLPassPhraseDialog( return NULL; } -#if defined(HAVE_OPENSSL_ENGINE_H) && defined(HAVE_ENGINE_INIT) const char *ssl_cmd_SSLCryptoDevice(cmd_parms *cmd, void *dcfg, const char *arg) @@ -714,7 +713,6 @@ const char *ssl_cmd_SSLCryptoDevice(cmd_ return NULL; } -#endif I think that is causing compilation problems with: mc->szCryptoDevice = NULL; in ssl_cmd_SSLCryptoDevice(). Thanks, I suppose this happens with the latest OpenSSL versions where they removed the ENGINE API completely? Yes. Fixed in r1915889 hopefully (should probably be backported to 2.4.x since r1913815 made it there already). Regards; Yann. -- Cheers Jean-Frederic