Re: svn commit: r219936 - in /httpd/httpd/trunk/modules/aaa: mod_authz_dbm.c mod_authz_groupfile.c mod_authz_user.c

2005-07-22 Thread Justin Erenkrantz 

--On July 21, 2005 6:30:36 PM +0200 Rich Bowen <[EMAIL PROTECTED]> wrote:


Sorry. This is actually my very first code patch in all the years I've
been working with Apache. Picking a nit. Will fix.


No worries - by all means, feel free to commit!  Just expect that we'll treat 
your commits with the same scrutiny as everyone else.  ;-)  -- justin

Re: svn commit: r219936 - in /httpd/httpd/trunk/modules/aaa: mod_authz_dbm.c mod_authz_groupfile.c mod_authz_user.c

2005-07-21 Thread Rich Bowen 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Justin Erenkrantz wrote:
> On Wed, Jul 20, 2005 at 04:23:38PM -, [EMAIL PROTECTED] wrote:
> 
>>-if (!strcmp(w, "file-group")) {
>>+if (!cmpstri(w, "file-group")) {
> 
> 
> Um, what's this?  Shouldn't that be strcasecmp?  -- justin

Sorry. This is actually my very first code patch in all the years I've
been working with Apache. Picking a nit. Will fix.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.4 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFC382sXP03+sx4yJMRApIBAJ9eBq94XXJ8x1Nw0HC11ZsTYaoRoQCfR+kg
K6HVHeomYwlJOjBkxSnIBq0=
=IHdT
-END PGP SIGNATURE-

Re: svn commit: r219936 - in /httpd/httpd/trunk/modules/aaa: mod_authz_dbm.c mod_authz_groupfile.c mod_authz_user.c

2005-07-21 Thread Justin Erenkrantz 
On Wed, Jul 20, 2005 at 04:23:38PM -, [EMAIL PROTECTED] wrote:
> -if (!strcmp(w, "file-group")) {
> +if (!cmpstri(w, "file-group")) {

Um, what's this?  Shouldn't that be strcasecmp?  -- justin