[jira] Commented: (IBATIS-414) Allow extending the Example classes or allow hand written criteria
[
https://issues.apache.org/jira/browse/IBATIS-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501489
]
James Burton commented on IBATIS-414:
-
Thanks for the reply. As long as I will be able to extend the Example classes
to add a method something like this...
public Criteria andCodeLikeCaseInsensitive(String value) {
addCriterion("upper(value) like", value, "upper(value)");
return this;
}
...then that will work for me (I think...!).
> Allow extending the Example classes or allow hand written criteria
> --
>
> Key: IBATIS-414
> URL: https://issues.apache.org/jira/browse/IBATIS-414
> Project: iBatis for Java
> Issue Type: Improvement
> Components: Tools
>Affects Versions: 2.3.0
> Environment: Java 1.5, Maven 2, ANT 1.6.5, Ibatis 2.3.0, abator 1.0.0
>Reporter: James Burton
>
> I currently have database searches implemented very nicely with abator
> generated code. I use the Example classes with the 'and..Like' criteria to do
> this. It works great.
> However, I now have a requirement to make these searches case-insensitive.
> After a bit of thinking I decided to try and extend the generated Example
> classes and override the 'and..Like' methods to add in the required upper()
> functions that Sybase requires to get true case insensitivity. I need to get
> a criteria added something like this...
> addCriterion("upper(code) like", value, "upper(code)");
> The problem is, I cannot extend the Example classes because there is no
> public constructor on the 'Criteria' inner class. Nor does the Example class
> allow a 'hand written' criteria to be added. This too, would be very useful.
> Do you think you could add a public constructor or make the existing one
> public? Either that or add methods to allow adding a hand-written criteria?
> ..or is there a better way to do this that I have completely missed?
> If not,
> Thanks,
> James
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (IBATIS-414) Allow extending the Example classes or allow hand written criteria
[
https://issues.apache.org/jira/browse/IBATIS-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501489
]
James Burton edited comment on IBATIS-414 at 6/5/07 1:50 PM:
-
Thanks for the reply. As long as I will be able to extend the Example classes
to add a method something like this...
public Criteria andCodeLikeCaseInsensitive(String value) {
addCriterion("upper(code) like", value, "upper(code)");
return this;
}
...then that will work for me (I think...!).
was:
Thanks for the reply. As long as I will be able to extend the Example classes
to add a method something like this...
public Criteria andCodeLikeCaseInsensitive(String value) {
addCriterion("upper(value) like", value, "upper(value)");
return this;
}
...then that will work for me (I think...!).
> Allow extending the Example classes or allow hand written criteria
> --
>
> Key: IBATIS-414
> URL: https://issues.apache.org/jira/browse/IBATIS-414
> Project: iBatis for Java
> Issue Type: Improvement
> Components: Tools
>Affects Versions: 2.3.0
> Environment: Java 1.5, Maven 2, ANT 1.6.5, Ibatis 2.3.0, abator 1.0.0
>Reporter: James Burton
>
> I currently have database searches implemented very nicely with abator
> generated code. I use the Example classes with the 'and..Like' criteria to do
> this. It works great.
> However, I now have a requirement to make these searches case-insensitive.
> After a bit of thinking I decided to try and extend the generated Example
> classes and override the 'and..Like' methods to add in the required upper()
> functions that Sybase requires to get true case insensitivity. I need to get
> a criteria added something like this...
> addCriterion("upper(code) like", value, "upper(code)");
> The problem is, I cannot extend the Example classes because there is no
> public constructor on the 'Criteria' inner class. Nor does the Example class
> allow a 'hand written' criteria to be added. This too, would be very useful.
> Do you think you could add a public constructor or make the existing one
> public? Either that or add methods to allow adding a hand-written criteria?
> ..or is there a better way to do this that I have completely missed?
> If not,
> Thanks,
> James
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IBATIS-414) Allow extending the Example classes or allow hand written criteria
[
https://issues.apache.org/jira/browse/IBATIS-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501694
]
Jeff Butler commented on IBATIS-414:
The more I think about it, the more I dislike the configuration option. How
about if I just make the relevent methods and fields protected instead of
private? You'll have to write a class like this:
ExtendedExample extends SomeTableExample {
public ExtendedCriteria createExtendedCriteria() {
ExtendedCriteria criteria = new ExtendedCriteria();
if (oredCriteria.size() == 0) {
oredCriteria.add(criteria);
}
return criteria;
}
public static class ExtendedCriteria extends SomeTableExample.Criteria {
public ExtendedCriteria andCodeLikeCaseInsensitive(String value) {
addCriterion("upper(code) like", value.toUpperCase(), "code");
return this;
}
}
}
This will be a quick change for me and will also make it possible to extend
these classes.
> Allow extending the Example classes or allow hand written criteria
> --
>
> Key: IBATIS-414
> URL: https://issues.apache.org/jira/browse/IBATIS-414
> Project: iBatis for Java
> Issue Type: Improvement
> Components: Tools
>Affects Versions: 2.3.0
> Environment: Java 1.5, Maven 2, ANT 1.6.5, Ibatis 2.3.0, abator 1.0.0
>Reporter: James Burton
>
> I currently have database searches implemented very nicely with abator
> generated code. I use the Example classes with the 'and..Like' criteria to do
> this. It works great.
> However, I now have a requirement to make these searches case-insensitive.
> After a bit of thinking I decided to try and extend the generated Example
> classes and override the 'and..Like' methods to add in the required upper()
> functions that Sybase requires to get true case insensitivity. I need to get
> a criteria added something like this...
> addCriterion("upper(code) like", value, "upper(code)");
> The problem is, I cannot extend the Example classes because there is no
> public constructor on the 'Criteria' inner class. Nor does the Example class
> allow a 'hand written' criteria to be added. This too, would be very useful.
> Do you think you could add a public constructor or make the existing one
> public? Either that or add methods to allow adding a hand-written criteria?
> ..or is there a better way to do this that I have completely missed?
> If not,
> Thanks,
> James
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (IBATIS-414) Allow extending the Example classes or allow hand written criteria
[
https://issues.apache.org/jira/browse/IBATIS-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Butler closed IBATIS-414.
--
Resolution: Fixed
Fixed in SVN (with protected methods and fields)
> Allow extending the Example classes or allow hand written criteria
> --
>
> Key: IBATIS-414
> URL: https://issues.apache.org/jira/browse/IBATIS-414
> Project: iBatis for Java
> Issue Type: Improvement
> Components: Tools
>Affects Versions: 2.3.0
> Environment: Java 1.5, Maven 2, ANT 1.6.5, Ibatis 2.3.0, abator 1.0.0
>Reporter: James Burton
>Assignee: Jeff Butler
>
> I currently have database searches implemented very nicely with abator
> generated code. I use the Example classes with the 'and..Like' criteria to do
> this. It works great.
> However, I now have a requirement to make these searches case-insensitive.
> After a bit of thinking I decided to try and extend the generated Example
> classes and override the 'and..Like' methods to add in the required upper()
> functions that Sybase requires to get true case insensitivity. I need to get
> a criteria added something like this...
> addCriterion("upper(code) like", value, "upper(code)");
> The problem is, I cannot extend the Example classes because there is no
> public constructor on the 'Criteria' inner class. Nor does the Example class
> allow a 'hand written' criteria to be added. This too, would be very useful.
> Do you think you could add a public constructor or make the existing one
> public? Either that or add methods to allow adding a hand-written criteria?
> ..or is there a better way to do this that I have completely missed?
> If not,
> Thanks,
> James
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[parabuild] BUILD for IBATIS (#53) on localhost TIMED OUT: Timed out after 120 minutes and was stopped.
BUILD result
BUILD for IBATIS (#53) on localhost TIMED OUT: Timed out after 120 minutes and
was stopped.
Build status:
http://parabuild.viewtier.com/parabuild/index.htm?view=detailed&buildid=150
Suspect changes
Change(s) by jgbutler :
- Fixes for IBATIS-414 (Abator) - allow generated example and ;
Time: 07:29 PM 06/05/2007; Change list: 544712
- Fixes for IBATIS-434 - incorrect default datatype mapping fo;
Time: 11:50 AM 06/04/2007; Change list: 544210
Change(s) Details:
http://parabuild.viewtier.com/parabuild/build/changes.htm?buildrunid=3956
BUILD logs
BUILD log:
http://parabuild.viewtier.com/parabuild/build/log.htm?logid=5243
Error lines:
http://parabuild.viewtier.com/parabuild/build/log.htm?logid=5244
JUnit Tests:
http://parabuild.viewtier.com/parabuild/build/log.htm?logid=5245
Log Lines Around Error
[javac] import com.ibatis.common.util.PaginatedList;
[javac] ^
[javac]
/opt/parabuild/etc/build/b150co/a/u/t/o/src/com/ibatis/sqlmap/engine/impl/SqlMapSessionImpl.java:19:
warning: [deprecation] com.ibatis.common.util.PaginatedList in
com.ibatis.common.util has been deprecated
[javac] import com.ibatis.common.util.PaginatedList;
[javac] ^
[javac]
/opt/parabuild/etc/build/b150co/a/u/t/o/src/com/ibatis/sqlmap/engine/impl/SqlMapClientImpl.java:18:
warning: [deprecation] com.ibatis.common.util.PaginatedList in
com.ibatis.common.util has been deprecated
[javac] import com.ibatis.common.util.PaginatedList;
[javac] ^
[javac]
/opt/parabuild/etc/build/b150co/a/u/t/o/src/com/ibatis/sqlmap/engine/mapping/statement/PaginatedDataList.java:19:
warning: [deprecation] com.ibatis.common.util.PaginatedList in
com.ibatis.common.util has been deprecated
[javac] import com.ibatis.common.util.PaginatedList;
[javac] ^
[javac]
/opt/parabuild/etc/build/b150co/a/u/t/o/src/com/ibatis/common/beans/ClassInfo.java:349:
warning: non-varargs call of varargs method with inexact argument type for
last parameter;
[javac] cast to java.lang.Object for a varargs call
[javac] cast to java.lang.Object[] for a non-varargs call and to suppress
this warning
[javac] return defaultConstructor.newInstance(null);
[javac] ^
[javac]
/opt/parabuild/etc/build/b150co/a/u/t/o/src/com/ibatis/sqlmap/engine/type/CallableStatementResultSet.java:322:
warning: [deprecation] getUnicodeStream(java.lang.String) in
java.sql.ResultSet has been deprecated
[javac] public InputStream getUnicodeStream(String columnName) throws
SQLException {
[javac] ^
[javac]
/opt/parabuild/etc/build/b150co/a/u/t/o/src/com/ibatis/sqlmap/engine/type/CallableStatementResultSet.java:106:
warning: [deprecation] getBigDecimal(java.lang.String,int) in
java.sql.ResultSet has been deprecated
[javac] public BigDecimal getBigDecimal(String columnName, int scale)
throws SQLException {
[javac] ^
[javac]
/opt/parabuild/etc/build/b150co/a/u/t/o/src/com/ibatis/sqlmap/engine/type/CallableStatementResultSet.java:318:
warning: [deprecation] getUnicodeStream(int) in java.sql.ResultSet has been
deprecated
[javac] public InputStream getUnicodeStream(int columnIndex) throws
SQLException {
[javac] ^
[javac]
/opt/parabuild/etc/build/b150co/a/u/t/o/src/com/ibatis/sqlmap/engine/type/CallableStatementResultSet.java:98:
warning: [deprecation] getBigDecimal(int,int) in java.sql.ResultSet has been
deprecated
[javac] public BigDecimal getBigDecimal(int columnIndex, int scale)
throws SQLException {
[javac] ^
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 11 warnings
[copy] Copying 4 files to
/opt/parabuild/etc/build/b150co/a/u/t/o/build/work/classes
[javac] Compiling 2 source files to
/opt/parabuild/etc/build/b150co/a/u/t/o/build/work/testclasses
[javac] Compiling 76 source files to
/opt/parabuild/etc/build/b150co/a/u/t/o/build/work/testclasses
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[copy] Copying 34 files to
/opt/parabuild/etc/build/b150co/a/u/t/o/build/work/testclasses
test.instrument:
[emma.instr] processing instrumentation pat
