[DiSCUSS] Incompatible changes
Reading this I thought it would be a good idea to articulate some of the possible challenges that we will face in the future. Say, how we add/release incompatible changes like API modifications, deprecations, etc. Say, introduction of incompatible changes shouldn't be done in minor release of a project: Scala transition 2.9 - 2.10 comes to mind as a biggest screw-up of the kind. Hence, to avoid being a laughing stock of the world's developers it would makes perfect sense to have some of these seemingly obvious principles either written or referred among other development resources. Thoughts? Cos On Tue, Aug 25, 2015 at 11:17PM, Alexey Goncharuk wrote: Ken, I added comments to the pull request on GitHub. I would prefer another committer to review this pull request as well since public API is being changed (Dmitriy, Yakov?) -- AG 2015-08-25 22:53 GMT-07:00 Ken Cheng kcheng@gmail.com: Hi Devs, Anybody can help me to do a code review for PR https://github.com/apache/ignite/pull/35 Thanks, kcheng
Re: Deprecate IgniteConfiguration.getGridName
We can add 'nodeName' on ClusterNode API, it is very easy to implement since node name is already stored in node attributes. On Wed, Aug 26, 2015 at 4:44 AM, Dmitriy Setrakyan dsetrak...@apache.org wrote: Although I share the sentiment that gridName is confusing, I think renaming gridName to nodeName will be equally confusing. The nodeName property sounds like something that should be on ClusterNode API, which is not the case. If we rename if in one of the future versions, I think instanceName would be a better option, no? D. On Wed, Aug 19, 2015 at 1:36 PM, Yakov Zhdanov yzhda...@apache.org wrote: I tend to agree with Semyon. This is not a grid name, but the name of the local Ignite instance as an entry point to the grid. And this name is used to conveniently get local Ignite instance: Ignite ignite = Ignition.ignite(name); It's usage in internal marshalling should stop. Any other opinions? --Yakov 2015-08-19 11:04 GMT+03:00 Alexey Kuznetsov akuznet...@gridgain.com: Semen, it is possible to distinguish nodes via attributes (put some marker to node attributes) ? On Wed, Aug 19, 2015 at 2:57 PM, Semyon Boikov sboi...@gridgain.com wrote: In my opinion this propery just should be renamed to 'nodeName'. Possibility to set node name is very useful in our tests. As I see 'setNodeId' is already deprecated in IgniteConfiguration, how we will distinguish nodes in our tests? On Tue, Aug 18, 2015 at 1:42 PM, Yakov Zhdanov yzhda...@apache.org wrote: Guys, I am thinking of deprecating this property. 1. nodes with different grid names can discover each other and build a single topology. I heard that some of the users expected that there would be separate topologies 2. Locally started nodes can be accessed via their IDs through Ignition interface. 3. Internally gridName is used in components serialization and deserializaiton, but this is very unreliable and can be broken if different names are configured within the same topology - https://issues.apache.org/jira/browse/IGNITE-10 Thoughts? --Yakov -- Alexey Kuznetsov GridGain Systems www.gridgain.com
Re: Deprecate IgniteConfiguration.getGridName
+1 for 'instanceName'. 'nodeName' looks confusing as well - I would think that it should be unique among all nodes. -Val On Wed, Aug 26, 2015 at 2:25 AM, Raul Kripalani r...@evosent.com wrote: Agree. The term grid to refer to a single node is very confusing. On 19 Aug 2015 08:58, Semyon Boikov sboi...@gridgain.com wrote: In my opinion this propery just should be renamed to 'nodeName'. Possibility to set node name is very useful in our tests. As I see 'setNodeId' is already deprecated in IgniteConfiguration, how we will distinguish nodes in our tests? On Tue, Aug 18, 2015 at 1:42 PM, Yakov Zhdanov yzhda...@apache.org wrote: Guys, I am thinking of deprecating this property. 1. nodes with different grid names can discover each other and build a single topology. I heard that some of the users expected that there would be separate topologies 2. Locally started nodes can be accessed via their IDs through Ignition interface. 3. Internally gridName is used in components serialization and deserializaiton, but this is very unreliable and can be broken if different names are configured within the same topology - https://issues.apache.org/jira/browse/IGNITE-10 Thoughts? --Yakov
Re: Documentation by contributors
On Wed, Aug 26, 2015 at 8:44 PM, Konstantin Boudnik c...@apache.org wrote: Just as a friendly reminder: readme.io hosting still opens us to the issue we've been discussing at length. Namely - the source of the documentation isn't hosted on the Apache premises. I remember there were some conversations with readme.io folks to add some extras for the imports or something like that. Were there any follow-ups on that front? Cos, good point. I was actually going to start a thread about this. Readme.io actually is replicated in GitHub with by-directional integration here: https://github.com/apacheignite/documentation The only thing we need is to move this repository to Apache, with Readme application having access to it. If there are no objections, I will start a discussion with INFRA on this. Let me know your thoughts. Sorry if I missed anything. Cos On Wed, Aug 26, 2015 at 04:43PM, Sergi Vladykin wrote: AFAIK currently Suggest Edit works well on readme.io. If someone wants to introduce a new topic, he can ask someone to do that on dev/user lists. Sergi 2015-08-26 14:09 GMT+03:00 Alexey Kuznetsov akuznet...@gridgain.com: I think contributor should provide at least some text file with a feature description. But collaboration on readme.io is a better approach. I don't know it is possible to introduce new topics on readme.io? I know that it is possible to suggest changes. We could have a special landing page for new items from contributors in this case. On Wed, Aug 26, 2015 at 3:39 PM, Raul Kripalani r...@evosent.com wrote: I believe that the current contribution process does not require contributors to enhance/modify the user guide accordingly. Do you think it would make sense to add this as a requirement to the process? Or are committers willing to take care of these docs in their entirety? Usually it's most efficient to have the contributor document their own feature/enhancement. We could use readme.io collaboration functionalities to Suggest Edits. Raúl. -- Alexey Kuznetsov GridGain Systems www.gridgain.com
[jira] [Created] (IGNITE-1303) Platforms: abstract-out platform context.
Vladimir Ozerov created IGNITE-1303: --- Summary: Platforms: abstract-out platform context. Key: IGNITE-1303 URL: https://issues.apache.org/jira/browse/IGNITE-1303 Project: Ignite Issue Type: Sub-task Components: interop Affects Versions: 1.1.4 Reporter: Vladimir Ozerov Assignee: Vladimir Ozerov Priority: Critical Fix For: ignite-1.4 Need to introduce context interface thus simplifying code move from GridGain. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Please give me some hints about IGNITE-881
Hi Devs, Can anyone give me some hints on the bug https://issues.apache.org/jira/browse/IGNITE-881 I am going to pick it up. Thanks, kcheng
Re: Ignite Web Control Center alpha version
I've implemented java preview for cluster and caches screens (metadata screen will be implemented shortly). Andrey Novikov, added mockup image for cache metadata ( https://issues.apache.org/jira/browse/IGNITE-1148) Feedback are very welcome! Just go to http://104.197.2.239 and play with Web Control Center. Thanks. -- Alexey Kuznetsov GridGain Systems www.gridgain.com
[GitHub] ignite pull request: IGNITE-1299: retry file meta unlock transacti...
GitHub user iveselovskiy opened a pull request: https://github.com/apache/ignite/pull/39 IGNITE-1299: retry file meta unlock transactions introduced. You can merge this pull request into a Git repository by running: $ git pull https://github.com/iveselovskiy/ignite ignite-1299 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit 542fae14e653f8c67146162038f884fbe902ed4b Author: iveselovskiy iveselovs...@gridgain.com Date: 2015-08-26T13:00:28Z IGNITE-1299: retry file meta unlock transactions introduced. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] ignite pull request: Ignite 264
GitHub user agoncharuk opened a pull request: https://github.com/apache/ignite/pull/42 Ignite 264 You can merge this pull request into a Git repository by running: $ git pull https://github.com/agoncharuk/ignite ignite-264 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 commit 141df5cf80a2d0757b60d277139a44cecc548509 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-19T01:27:42Z IGNITE-264 - Removed unused code. commit a22a8c21571cc5c095206e0e68250debc2958f13 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-19T01:37:25Z IGNITE-264 - Regenerated messages. commit 3a88c01933a8821920b845043d1a8f268a641e7a Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-21T02:53:36Z IGNITE-264 - WIP commit e929822bab4e00d54b8233385533673d59e51ffb Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-21T02:55:10Z IGNITE-264 - Regenerated messages. commit ba7cbc045aab7073ddfe11d9f684c76681dc1caf Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-23T19:15:01Z IGNITE-264 - WIP commit 0a6557a21017de79b73660c62250d9c338db4064 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-23T19:16:31Z IGNITE-264 - Regenerated message commit 65324d66a7df9310af41df7d8d2553aa7f51056c Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-23T20:50:44Z IGNITE-264 - WIP commit 99d8d593dd239cca870e4dcb555279001da73516 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-24T06:06:36Z IGNITE-264 - WIP commit 870cc58e08673e768319bffaf5c77a83d32e5a4c Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-24T22:40:36Z Merge branch sprint-2 into ignite-264 commit 2182da3a42b5b01831661e4e1de9706a36118c78 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-24T22:52:19Z IGNITE-264 - Fixed compilation commit 30fef4a0b38b183ed4da7d4d82d6c289abb9c272 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-25T00:51:20Z IGNITE-264 - Regenerated messages. commit e9fd4f7e36df7a1406af99040fd7b4a776bee2fa Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-25T01:32:33Z IGNITE-264 - Process check committed finish response properly. commit 6356e5e71ce247b417a3d09064122eefb950a42b Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-25T01:36:53Z IGNITE-264 - Rebuilt mesasge. commit f286bb42f0d200d4adccd83d15e0577fa37b893a Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-25T01:55:30Z IGNITE-264 - WIP commit 4bf51e7704d207bf91e994925ca509d2b6ba537d Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-25T02:09:27Z IGNITE-264 - WIP commit 9b0bd71b5844af5fd3a89655c1e3833e3e4cfcc4 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-26T19:20:34Z IGNITE-264 - WIP commit 541175b479d07d18e0a1069cfb9f6cb48eebe12c Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-26T19:33:42Z IGNITE-264 - WIP commit bae01f894dbacaf405e6f50ba35fd98d70c2ae4e Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-27T00:18:48Z Merge branch 'sprint-2' of https://git-wip-us.apache.org/repos/asf/incubator-ignite into ignite-264 commit 37805a56c63e07e5c474c52e7383cd9a106dbb9a Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-02-27T00:21:03Z IGNITE-264 - Rebuilt message. commit 905a139ea15f50afe33bada498200ced6b5d6f6e Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-03-25T20:11:16Z Merge branch sprint-3 into ignite-264 commit a7b37493808cf76e6ee9e4ff94bc2f3dd92af172 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-03-25T21:08:55Z Fixing tests. commit 03923c9b7ac57511ec73d49610807bf427d379f3 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-03-27T02:13:05Z Sprint-2 - Restored original client projection behavior. commit c31ad7e35a16e5b1a2a21d96740829729404eb17 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-08-08T01:30:58Z Merge branch master into ignite-264 commit 373237707b68e442026533791b71552634974f2c Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-08-10T18:26:53Z IGNITE-264 - Fixed compilation. commit 4bc5d50916d2a4a9293653d62b0b35a43cd6449e Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-08-10T19:09:17Z IGNITE-264 - Regenerated messages. commit e7fa1b324dd569fa37d5bfc31a76c321fb5e80d3 Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-08-11T00:19:49Z IGNITE-264 - Fixing tests WIP. commit ac54b3056e371ee9558489f7bfd10fb29cec446a Author: Alexey Goncharuk agoncha...@gridgain.com Date: 2015-08-11T01:34:13Z IGNITE-264 - Fixing tests WIP. commit