Re: PR : Please help do the code review for IGNITE-1069

[Denis Magda]

Hi Ken,

I think that Alex Kuznetsov as a maintainer of visorcmd will be able to review 
your contribution.

Regards,
Denis

> On 30 янв. 2016 г., at 11:59, Ken Cheng  wrote:
> 
> @Ilya Suntsov
> ,
> 
> You logged this issue, please help to reivew it. Thanks.
> 
> Thanks,
> kcheng
> 
> On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng  wrote:
> 
>> 
>> Dear Ignite Developers,
>> 
>> 
>> I have raised a PR https://github.com/apache/ignite/pull/440 for bug
>> https://issues.apache.org/jira/browse/IGNITE-1069
>> 
>> 
>> please help do a code review.
>> 
>> 
>> 
>> Thanks,
>> kcheng
>> 

PR : Please help do the code review for IGNITE-1069

[Ken Cheng]

Dear Ignite Developers,


I have raised a PR https://github.com/apache/ignite/pull/440 for bug
https://issues.apache.org/jira/browse/IGNITE-1069


please help do a code review.



Thanks,
kcheng

Re: PR : Please help do the code review for IGNITE-1069

[Ken Cheng]

@Ilya Suntsov
,

You logged this issue, please help to reivew it. Thanks.

Thanks,
kcheng

On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng  wrote:

>
> Dear Ignite Developers,
>
>
> I have raised a PR https://github.com/apache/ignite/pull/440 for bug
> https://issues.apache.org/jira/browse/IGNITE-1069
>
>
> please help do a code review.
>
>
>
> Thanks,
> kcheng
>

[GitHub] ignite pull request: Ignite 1187

[DoudTechData]

GitHub user DoudTechData opened a pull request:

https://github.com/apache/ignite/pull/441

Ignite 1187

fix some issues with sources when using eclipse

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DoudTechData/ignite ignite-1187

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #441


commit b1d380b84d8a53ce14b71d83738d947f8567b38c
Author: DoudTechData 
Date:   2016-01-27T15:00:54Z

Merge pull request #1 from apache/master

update

commit e5a057c71dcbeffa0008dfa865c79e9ab0725ce2
Author: Valentin Kulichenko 
Date:   2016-01-28T02:51:12Z

IGNITE-2332 - Support package-private implementations for services

commit f4ccd5d2505ea275c8afe56393f8c1f6fb53b350
Author: Valentin Kulichenko 
Date:   2016-01-28T02:52:00Z

JDBC driver authentication fixed

commit 8ea0d000c80c6299199d0a6b913d9787268a3e00
Author: Valentin Kulichenko 
Date:   2016-01-28T03:04:48Z

Do not show 'you should implement Externalizable' warning

commit b7481a70318b265b8e47c11b94dbe0dd5d59040a
Author: Valentin Kulichenko 
Date:   2016-01-28T03:49:37Z

Fixed 'misses' cache metric

commit ca36175a111f22e6aaa19b05f2403a780f2e2454
Author: Pavel Tupitsyn 
Date:   2016-01-28T08:25:20Z

IGNITE-2324: .NET: Added static code analysis rules and suppressed warnings 
accordingly.

commit 1d269a53cc507d6783a92a0775b37a6fc93b05bf
Author: ashutak 
Date:   2016-01-28T09:20:21Z

IGNITE-1355 - Fixed potential NPE in CacheAffinityProxy - Fixes #263.

Signed-off-by: Alexey Goncharuk 

commit 9de66292d1a582d1e30374d3f45bff4e9eadc4a1
Author: vershov 
Date:   2016-01-28T09:29:31Z

IGNITE-2453 Fixed single primary and single backup failure cause NPE at 
future for backup - Fixes #427.

Signed-off-by: Alexey Goncharuk 

commit 6cb0a210e5f3f518f913fb9fcc35a6baf708a998
Author: vozerov-gridgain 
Date:   2016-01-28T10:24:22Z

WIP on local benchmarks.

commit d7859af9919022a9a2aaf40f4fcf0f2cfe6c8582
Author: vozerov-gridgain 
Date:   2016-01-28T12:28:40Z

Removed benchmark packaging step as it causes build error on TC for no 
apparent reason.

commit 71b7d6ae1ca30e148f239fd53fc88ca366a98367
Author: Valentin Kulichenko 
Date:   2016-01-29T00:09:20Z

Fixed GridServicePackagePrivateSelfTest - nodes were not properly stopped

commit 0009c2c09d5354c032d29b541cfede06d5a0fbe6
Author: vozerov-gridgain 
Date:   2016-01-28T13:37:20Z

WIP on local benchmarks.

commit cf4c0e5ad9f450c7b0ae327ff000187843d0e35a
Author: vozerov-gridgain 
Date:   2016-01-28T13:46:09Z

WIP on local benchmarks.

commit 919957ace01caef404e29d2621bc8904a3821a48
Author: Tikhonov Nikolay 
Date:   2016-01-29T07:36:03Z

Added docker file for version 1.5.0.final.

commit 065cea19ce5c68ec8d2c3e291ec7877697ea8a36
Author: vozerov-gridgain 
Date:   2016-01-29T09:33:35Z

WIP on local benchmarks: added profiler option.

commit 3b2f0e9d88b4d2ecf2afe42dcc3e22c1d8b40b5a
Author: Anton Vinogradov 
Date:   2016-01-29T11:35:09Z

Rebalancing future hotfix. Correct finishing (with false) in case of 
unmarshalling problems.

commit 19b968e44054c85d4c768e72dae448c8c612f9dd
Author: Denis Magda 
Date:   2016-01-29T12:51:44Z

Proper initialization of utility and marshalling pools.

commit 5c93b678e7258e563e65052edf14a77ba76a7920
Author: Anton Vinogradov 
Date:   2016-01-29T15:43:10Z

gc

commit ffea779880572b6d3c38fb37258247150c4f82f0
Author: DoudTechData 
Date:   2016-01-30T16:47:23Z

Merge pull request #2 from apache/master

update from original

commit debaaa3e0fad8e33cd5d0cd8bab730e0939d4313
Author: Edouard Chevalier 
Date:   2016-01-30T17:29:09Z

update .gitignore to ignore files generated by eclipse

commit 1a37722903f197941fe8ed2b18d95b347afac5e9
Author: Edouard Chevalier 
Date:   2016-01-30T17:31:07Z

add m2e profile to pom.xml fixing eclipse issues:
eclipse do not support duplicated package-info.java in main and test
sources.
Eclipse do not like plugins it is not told to ignore.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not 

Re: PR : Please help do the code review for IGNITE-1069

[Ken Cheng]

Hi Alexey Kuznetsov,

*All the related test cases are passed, please check the detail in jira. I
have paste the build link.*

Thanks,
kcheng

On Sat, Jan 30, 2016 at 7:03 PM, Alexey Kuznetsov 
wrote:

> Hi Ken!
> I will review you PR shortly.
>
>
> On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda  wrote:
>
> > Hi Ken,
> >
> > I think that Alex Kuznetsov as a maintainer of visorcmd will be able to
> > review your contribution.
> >
> > Regards,
> > Denis
> >
> > > On 30 янв. 2016 г., at 11:59, Ken Cheng  wrote:
> > >
> > > @Ilya Suntsov
> > > ,
> > >
> > > You logged this issue, please help to reivew it. Thanks.
> > >
> > > Thanks,
> > > kcheng
> > >
> > > On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng 
> wrote:
> > >
> > >>
> > >> Dear Ignite Developers,
> > >>
> > >>
> > >> I have raised a PR https://github.com/apache/ignite/pull/440 for bug
> > >> https://issues.apache.org/jira/browse/IGNITE-1069
> > >>
> > >>
> > >> please help do a code review.
> > >>
> > >>
> > >>
> > >> Thanks,
> > >> kcheng
> > >>
> >
> >
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
>

Re: PR : Please help do the code review for IGNITE-1069

[Alexey Kuznetsov]

Hi Ken!
I will review you PR shortly.


On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda  wrote:

> Hi Ken,
>
> I think that Alex Kuznetsov as a maintainer of visorcmd will be able to
> review your contribution.
>
> Regards,
> Denis
>
> > On 30 янв. 2016 г., at 11:59, Ken Cheng  wrote:
> >
> > @Ilya Suntsov
> > ,
> >
> > You logged this issue, please help to reivew it. Thanks.
> >
> > Thanks,
> > kcheng
> >
> > On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng  wrote:
> >
> >>
> >> Dear Ignite Developers,
> >>
> >>
> >> I have raised a PR https://github.com/apache/ignite/pull/440 for bug
> >> https://issues.apache.org/jira/browse/IGNITE-1069
> >>
> >>
> >> please help do a code review.
> >>
> >>
> >>
> >> Thanks,
> >> kcheng
> >>
>
>


-- 
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

Re: Adding tracing component to Ignite

[Sergi Vladykin]

+1

I think it is a great idea, still it must be carefully designed to avoid
additional performance penalty.

BTW, for performance measurements there is already a good component:
https://github.com/HdrHistogram/HdrHistogram

Sergi

2016-01-30 3:01 GMT+03:00 Dmitriy Setrakyan :

> How do you disable it? I mean, how do you make sure that it does not affect
> performance when it is turned off?
>
> D.
>
> On Fri, Jan 29, 2016 at 12:31 PM, Vladimir Ozerov 
> wrote:
>
> > Folks,
> >
> > Quite often we face some concurrency or performance issues. And what is
> > worse, sometimes they spread across several nodes making them hard to
> > debug.
> >
> > We do various things to debug such problems. We add System.outs, measure
> > latencies between algorithm steps, etc.. And once the problem is
> resolved,
> > we throw away all debugging code.
> >
> > What if add a kind of tracing component to Ignite, so that convenient
> > debugging infrastructure wiil always be ready for use?
> >
> > E.g., assume that we have performance issue in cache operation. Tracing
> > framework could be used as follows:
> >
> > /** Register tracer. */
> > Cache.onStart() {
> > ...
> > ctx.trace().createProfile("cache_problem");
> > }
> >
> > /** Put trace inside problematic code. */
> > Cache.get(...) {
> > TraceEvent traceEvt = ctx.trace().start("cache_problem");
> > ...
> > traceEvt.checkpoint("LOCKED", [optional args and identifiers]);
> > ...
> > traceEvt.checkpoint("COMMITTED", ...);
> > }
> >
> > /** In the end we dump problematic events. */
> > Cache.onStop() {
> > ...
> > ctx.profile("cache_problem").dump(System.out, [FILTER PREDICATE]);
> > }
> >
> > Result:
> > 23:20:01.234 [LOCKED=20ms, COMMITTED=152ms, FINISHED=153ms]
> > 23:20:03.211 [LOCKED= 1ms, COMMITTED=  1ms, FINISHED=  2ms]
> >
> > I believe lots of you already did something like this during debug. The
> > idea is to have some reusable component, so that we do not need to
> reinvent
> > the wheel over and over again.
> >
> > Thoughts?
> >
> > Vladimir.
> >
>