[GitHub] ignite pull request #1520: Ignite 4641 - Refresh client attributes during re...

[dkarachentsev]

GitHub user dkarachentsev opened a pull request:

https://github.com/apache/ignite/pull/1520

Ignite 4641 - Refresh client attributes during reconnect



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-4641

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/1520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1520


commit 02f48d72364fb0c52e95aef8ed383a14ee531bf6
Author: ptupitsyn 
Date:   2016-10-04T08:17:54Z

IGNITE-3820: .NET: Added log4net integration. This closes #1138.

commit bfdb5c3b374fd3512481cf16779d227d7f96e569
Author: Saikat Maitra 
Date:   2016-10-04T09:40:35Z

IGNITE-3841 Web console added check for eviction policy max mem and max 
size consistency. Fixes #1136.

commit a92f20b5cc75e6b80b2731da0192723526b0c1dc
Author: vozerov-gridgain 
Date:   2016-10-04T11:10:26Z

IGNITE-3597: Removed static work directory.

commit d45383b69cc68c0ec967ebd673b197e437720214
Author: Pavel Tupitsyn 
Date:   2016-10-04T15:48:25Z

.NET: Fix code analysis warnings

commit 23461b8d33922772ef8e7217e9e87b3f3b0b37b1
Author: vozerov-gridgain 
Date:   2016-10-06T07:14:59Z

IGNITE-4001: Timeouts for threads in Ignite pools. This closes #1130.

commit b94b0aeae4c42b1d35128c6b1de97e3fa318d497
Author: tledkov-gridgain 
Date:   2016-10-06T07:22:50Z

IGNITE-3163 IGFS: Added working directory support to 
IgniteHadoopIgfsSecondaryFileSystem. This closes #1030. This closes #1058. This 
closes #1132.

commit e6317e01fa8a0de03e15dcdd84a575c6b06ce701
Author: vozerov-gridgain 
Date:   2016-10-06T09:03:48Z

IGNITE-3593 .NET: IgniteConfiguration.WorkDirectory has no effect. This 
closes #903. This closes #1145.

commit 952be8b995050b34379006dd6e739da3fe3b49e3
Author: Dmitriy Govorukhin 
Date:   2016-10-07T12:00:09Z

Squashed commit of the following:

commit 566881b695b8bc00e618fe9a9b4c86a8fd563cc1
Author: sboikov 
Date:   Fri Oct 7 13:08:38 2016 +0300

minor

commit 7fe88a1cb21f794ee55a176ab36d895cbf916528
Author: Dmitriy Govorukhin 
Date:   Thu Oct 6 11:11:24 2016 +0300

ignite-update-notifier fix after review

(cherry picked from commit a10d2ff)

commit f2de749f958a3b18dc479f8a5517d7bf9362b933
Author: Dmitriy Govorukhin 
Date:   Tue Oct 4 12:12:08 2016 +0300

ignite-2079-2 optimize import and change url path

(cherry picked from commit 830a3cf)

commit 0d1be85ad55b0aa91224690d6c112ae92e8bc0a9
Author: Dmitriy Govorukhin 
Date:   Thu Sep 29 19:54:54 2016 +0300

update-notifier remove parse xml, now parse like properties

(cherry picked from commit 9ecaa29)

commit e43bca6fb4528a7fc0dcb804a74fca1c59d7468b
Author: Dmitriy Govorukhin 
Date:   Tue Sep 27 17:07:21 2016 +0300

remove dom parser

(cherry picked from commit d1653b2)

commit b9c776a8423471706ecb1dc6176b38f23e799077
Author: Anton Vinogradov 
Date:   2016-10-10T08:52:57Z

IGNITE-3235 Failed to initialize primitive boolean cache property of 
superclass

commit f9a0676fad7fd6c23e3c91c10d7e0412ccb27c06
Author: vozerov-gridgain 
Date:   2016-10-11T07:23:01Z

IGNITE-4041: Created separate processor for thread pools and refactored IO 
manager. This closes #1150.

commit 9a6cfce659df40b0a4624f19fd91c217b74bafea
Author: nikolay_tikhonov 
Date:   2016-10-11T10:59:57Z

IGNITE-4014 Fixed "Transaction hangs if entry processor failed during 
serialization". This closes #1148.

commit 1938a17b01fac1e08c30011180bbcc3ed7374d83
Author: Andrey V. Mashenkov 
Date:   2016-10-11T11:50:18Z

IGNITE-3948: Fixed a bug causing TTL manager to continue tracking of 
evicted entries. This closes #1101.

commit 60d27547dfc6bd27c6d39cbcc523d0d1e872a821
Author: vozerov-gridgain 
Date:   2016-10-11T11:51:00Z

Merge remote-tracking branch 'upstream/ignite-1.6.10' into ignite-1.6.10

commit 359a392f1c53217c691c4c40762c51fd330666e2
Author: Valentin Kulichenko 
Date:   2016-01-15T06:58:41Z

Update notifier fixes

(cherry picked from commit a5c85ca)

commit 01ca6db70933fb7f50f161a80cde9647e68a3710
Author: dkarachentsev 
Date:   2016-10-11T13:18:40Z

Merge remote-tracking branch 'origin/ignite-1.6.10' into ignite-1.6.10

commit 0659bebe04dc9c0b0a163bc95061519c553e678c
Author: Andrey V. Mashenkov 
Date:   2016-10-12T11:49:36Z

IGNITE-3972: Fixed a bug causing continuous queries to be lost for ATOMIC 
cache when key's primary node leaves topology. This closes #1133.

commit f597aff1bdf65d3d430cf85c9932391a72c2d7dc
Author: Andrey V. Mashenkov 
Date:   2016-10-12T12:44:08Z

IGNITE-3875: Added separate thread pool for data streamer. This closes 
#1067.

commit 2ab094e08373dc6667af44d48a38b4f044953a79
Au

Re: IGNITE-4158 - ready for review

[Denis Magda]

Hi Vyacheslav,

Val, Vovan, please assist with the review

—
Denis

> On Feb 10, 2017, at 3:53 AM, Vyacheslav Daradur  wrote:
> 
> Hello. I did it.
> 
> Please, review.
> 
> https://issues.apache.org/jira/browse/IGNITE-4158 - Implement Time type for
> binary protocol.
> 
> latest ci.tests 

Re: IGNITE-13

[Valentin Kulichenko]

Vladimir,

Can you please take a look and provide your thoughts? Can this be applied
to binary marshaller? From what I recall, it serializes string a bit
differently from optimized marshaller, so I'm not sure.

-Val

On Fri, Feb 10, 2017 at 5:16 PM, Dmitriy Setrakyan 
wrote:

> On Thu, Feb 9, 2017 at 11:26 PM, Valentin Kulichenko <
> valentin.kuliche...@gmail.com> wrote:
>
> > Hi Vadim,
> >
> > I don't think it makes much sense to invest into OptimizedMarshaller.
> > However, I would check if this optimization is applicable to
> > BinaryMarshaller, and if yes, implement it.
> >
>
> Val, in this case can you please update the ticket?
>
>
> >
> > -Val
> >
> > On Thu, Feb 9, 2017 at 11:05 PM, Вадим Опольский 
> > wrote:
> >
> > > Dear sirs!
> > >
> > > I want to resolve issue IGNITE-13 -
> > > https://issues.apache.org/jira/browse/IGNITE-13
> > >
> > > Is it actual?
> > >
> > > Vadim Opolski
> > >
> >
>

Re: IGNITE-13

[Vladimir Ozerov]

Hi,

It is hard to say whether it makes sense or not. No doubt, it could speed
up marshalling process at the cost of 2x memory required for strings. From
my previous experience with marshalling micro-optimizations, we will hardly
ever notice speedup in distributed environment.

But, there is another sied - it could speedup our queries, because we will
not have to unmarshal string on every field access. So I would try to make
this optimization optional and then measure query performance with classes
having lots of strings. It could give us interesting results.

On Mon, Feb 13, 2017 at 5:37 AM, Valentin Kulichenko <
valentin.kuliche...@gmail.com> wrote:

> Vladimir,
>
> Can you please take a look and provide your thoughts? Can this be applied
> to binary marshaller? From what I recall, it serializes string a bit
> differently from optimized marshaller, so I'm not sure.
>
> -Val
>
> On Fri, Feb 10, 2017 at 5:16 PM, Dmitriy Setrakyan 
> wrote:
>
>> On Thu, Feb 9, 2017 at 11:26 PM, Valentin Kulichenko <
>> valentin.kuliche...@gmail.com> wrote:
>>
>> > Hi Vadim,
>> >
>> > I don't think it makes much sense to invest into OptimizedMarshaller.
>> > However, I would check if this optimization is applicable to
>> > BinaryMarshaller, and if yes, implement it.
>> >
>>
>> Val, in this case can you please update the ticket?
>>
>>
>> >
>> > -Val
>> >
>> > On Thu, Feb 9, 2017 at 11:05 PM, Вадим Опольский 
>> > wrote:
>> >
>> > > Dear sirs!
>> > >
>> > > I want to resolve issue IGNITE-13 -
>> > > https://issues.apache.org/jira/browse/IGNITE-13
>> > >
>> > > Is it actual?
>> > >
>> > > Vadim Opolski
>> > >
>> >
>>
>
>

Re: IGNITE-817: [Test] Disabled tests of GridCacheOffHeapTest

[Semyon Boikov]

Hi,

GridCacheOffHeapTest is some very old class and I think it can be removed.
Currently all actual benchmarks are in 'benchmarks' and 'yardstick' modules.

Thanks

On Sat, Feb 11, 2017 at 3:18 AM, Denis Magda  wrote:

> Yakov, Sam?
>
> Please join and share your thoughts.
>
> —
> Denis
>
> > On Feb 10, 2017, at 7:08 AM, Александр Меньшиков 
> wrote:
> >
> > Denis, thank you for information. I see JMH in pom file in benchmarks
> > module. So this must be removed or it's okay for micro-benchmarks?
> >
> > 2017-02-10 0:04 GMT+03:00 Denis Magda :
> >
> >> Alexander,
> >>
> >> We use Yardstick benchmarks for performance measurements of Ignite:
> >> https://github.com/apacheignite/yardstick-ignite  >> apacheignite/yardstick-ignite>
> >>
> >> In 1.9 it will be much easier to execute the benchmarks directly from
> >> Apache Ignite bundle:
> >> http://apache-ignite-developers.2346864.n4.nabble.
> com/IGNITE-4212-Ignite-
> >> Benchmarking-Simplification-and-Automation-td13079.html <
> >> http://apache-ignite-developers.2346864.n4.nabble.
> com/IGNITE-4212-Ignite-
> >> Benchmarking-Simplification-and-Automation-td13079.html>
> >>
> >> As for GridCacheOffHeapTest it looks like a candidate for removal.
> *Yakov,
> >> Sam*, do we still need this test?
> >>
> >>> On Feb 9, 2017, at 6:25 AM, Александр Меньшиков 
> >> wrote:
> >>>
> >>> Hello, everyone.
> >>>
> >>> GridCacheOffHeapTest  is about the Off-heap benchmarks.
> >>>
> >>> As I understand it right now we haven't clear vision how better make
> >>> benchmarks in Ignite.
> >>>
> >>> If it's not true, please make me know.
> >>>
> >>> I think it's a good idea to make benchmarks with JMH framework. It can
> be
> >>> load with maven, right now it's part of OpenJDK project. But it will be
> >>> included in Java 9 like standart framework for benchmarks.
> >>>
> >>> So what do you think, Igniters?
> >>
> >>
>
>

Re: general question

[Vladimir Ozerov]

Alex,

FieldAccessor stores field positions for the given schema to allow for fast
field value lookup.

On Fri, Feb 10, 2017 at 7:06 PM, ALEKSEY KUZNETSOV  wrote:

> Guys, i have a question.Why do we store fields position information in
> FieldAccessor before hashcode evaluation? Test example is in
> : org.apache.ignite.internal.binary.BinaryFieldIdentityResolverSel
> fTest#testHashCode
> --
>
> *Best Regards,*
>
> *Kuznetsov Aleksey*
>