Re: Please Subscribe me

2018-06-29 Thread kcheng.mvp
Thank you very much! I can see my post now.

by the way, can you take a look about my question?
http://apache-ignite-developers.2346864.n4.nabble.com/is-these-correct-td32111.html




--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/


is these correct?

2018-06-29 Thread kcheng.mvp
here is the environment : 1 server node + 1 client node

executed below code
===
IgniteCache igniteCache =
igniteSpringBean.getOrCreateCache("HappyFlow");
igniteCache.put("hello", "hello1");
Assert.assertEquals("hello1",igniteCache.get("hello"));

for (int i = 0;i < 100; i ++) {
igniteCache.get("hello");
}
===

I got below screenshot in ignitevisorcmd.sh


 




--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/


[jira] [Created] (IGNITE-8901) Duplicate messages in TcpCommunicationSpi result in "Cache is restarting" messages

2018-06-29 Thread Andrew Medvedev (JIRA)
Andrew Medvedev created IGNITE-8901:
---

 Summary: Duplicate messages in TcpCommunicationSpi result in 
"Cache is restarting" messages
 Key: IGNITE-8901
 URL: https://issues.apache.org/jira/browse/IGNITE-8901
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.5
Reporter: Andrew Medvedev


We have several cases with duplicate "Accepted incoming communication 
connection" messages in TcpCommunicationSpi for a job from client.  Messages 
are identical including timestamp and tcp comm worker thread

Server node sends duplicate outgoing messages to other cluster nodes (duplicate 
incoming communication connection messages can be seen in their logs).

Then on some of those nodes we got [o.a.i.i.processors.job.GridJobWorker] 
Failed to execute job, Caused by: 
org.apache.ignite.IgniteCacheRestartingException: Cache is restarting 

Cache is started and indexed, no messages that that the cache has been stopped 
are logged.

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-8900) SqlFieldsQuery provides incorrect result when item size exceeds page size

2018-06-29 Thread Anton Kurbanov (JIRA)
Anton Kurbanov created IGNITE-8900:
--

 Summary: SqlFieldsQuery provides incorrect result when item size 
exceeds page size
 Key: IGNITE-8900
 URL: https://issues.apache.org/jira/browse/IGNITE-8900
 Project: Ignite
  Issue Type: Bug
  Components: sql
Affects Versions: 2.4
Reporter: Anton Kurbanov


Start several server nodes, then start client.

As an example:

expected 5 results but got back 3 results (query range 61002664327616 to 
610026643276160004), cache.getAll returned 5 entries.

expected 8 results but got back 7 results (query range 61002664327616 to 
610026643276160007), cache.getAll returned 8 entries.
Query results: [61002664327616, 610026643276160003, 610026643276160004, 
610026643276160005, 610026643276160005, 610026643276160006, 610026643276160007]

Please find reproducer attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] ignite pull request #4285: Ignite 8747 fresh

2018-06-29 Thread glukos
GitHub user glukos opened a pull request:

https://github.com/apache/ignite/pull/4285

Ignite 8747 fresh



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-8747-fresh

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4285


commit ba4ca8b4d42d112003e5763dd94a022d788148d4
Author: Andrey V. Mashenkov 
Date:   2018-06-01T15:51:37Z

WIP. Introduce expiry throttling.
Thread will avoid try to clean expired entries if recent try has finished 
with "nothing to clean".

commit 0af00789c5d6d99a141c6170b98af0e2fac0e1f0
Author: Andrey V. Mashenkov 
Date:   2018-06-01T17:14:06Z

WIP. Avoid useless unwindEvict try for caches with eagerTtl disabled.

commit 53c81d51c796790d3d675a428dbc36a89f56127a
Author: Andrey V. Mashenkov 
Date:   2018-06-01T20:25:54Z

WIP. Minor

commit 4107681d21821cd2f52d7eb337be12d0def837f0
Author: Andrey V. Mashenkov 
Date:   2018-06-05T09:32:02Z

WIP.
Added per-cacheGroup unwind throttling.
Styles.

commit a330736d96697c75f671296c1d672796b7b7b897
Author: Andrey V. Mashenkov 
Date:   2018-06-06T09:09:42Z

Wip. Minors

commit fde8bc2fc0908f6fbbaeeedc38d787bb896e2c91
Author: Andrey V. Mashenkov 
Date:   2018-06-06T09:54:22Z

Wip.
Disable throttling for in memory store.

commit af9c2775d7926236f9cfe79759901f4ef9a27b17
Author: Andrey V. Mashenkov 
Date:   2018-06-06T10:49:01Z

Revert "Wip. Disable throttling for in memory store."

This reverts commit f9048aa

commit f2c078817541babbe832d6e6d29a2aeab8538d39
Author: Andrey V. Mashenkov 
Date:   2018-06-06T12:28:18Z

IGNITE-8503: Fix entry startVersion.

commit 5c1ec4728f802857cbe2b072b099f09e85023cb4
Author: Andrey V. Mashenkov 
Date:   2018-06-08T10:08:14Z

WIP. Increase throttling to 500ms.

commit 2b445a3169186099dbe3fa1cb1254275f98baf9a
Author: Andrey V. Mashenkov 
Date:   2018-06-09T10:03:59Z

WIP. Minor.

commit a2b8ade77a24186a8403092bbdc863462a7a6a42
Author: Andrey V. Mashenkov 
Date:   2018-06-14T15:53:36Z

IGNITE-8747: Fix test. Minor code cleanup.

commit 2c1bc86925777f30ebf368d0c8cdd02ffd9361ec
Author: Andrey V. Mashenkov 
Date:   2018-06-21T13:50:11Z

IGNITE-8747: Fixed expiration on entry update.

commit 1fa749ea9f888e48b2f87bc25c81a4334ee09334
Author: Andrey V. Mashenkov 
Date:   2018-06-21T15:04:03Z

Styles.

commit 28a4713aaed6b5b4c344782262142f41e9bcf11d
Author: Andrey V. Mashenkov 
Date:   2018-06-25T14:48:29Z

Removed non-relevant test.

commit f9a1cd4ff87300eac5af488aa25cf3007b0ea9cd
Author: Andrey V. Mashenkov 
Date:   2018-06-27T08:59:16Z

ignite-8747: Fix flacky test.

commit d1d1e3ca395bf379c072d7630e41aa53409915f1
Author: Ivan Rakov 
Date:   2018-06-29T17:46:54Z

Merge branch 'master' into ignite-8681-8503




---


[GitHub] ignite pull request #4284: IGNITE-8899 remove creating JavaLogger in static ...

2018-06-29 Thread ezhuravl
GitHub user ezhuravl opened a pull request:

https://github.com/apache/ignite/pull/4284

IGNITE-8899 remove creating JavaLogger in static context in IgniteJdb…

…cDriver

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-8899

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4284


commit a2f5910d33ee15d5f8777666f7f68a64bf043d1a
Author: ezhuravl 
Date:   2018-06-29T15:59:16Z

IGNITE-8899 remove creating JavaLogger in static context in IgniteJdbcDriver




---


[GitHub] ignite pull request #4247: IGNITE-8858 - Client none may not stop.

2018-06-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4247


---


[jira] [Created] (IGNITE-8899) IgniteJdbcDriver directly create JavaLogger in static context

2018-06-29 Thread Evgenii Zhuravlev (JIRA)
Evgenii Zhuravlev created IGNITE-8899:
-

 Summary: IgniteJdbcDriver directly create JavaLogger in static 
context
 Key: IGNITE-8899
 URL: https://issues.apache.org/jira/browse/IGNITE-8899
 Project: Ignite
  Issue Type: Bug
Reporter: Evgenii Zhuravlev


It means, that it always prints error in logs, if Jul logging file doesn't 
exist. I suggest to use the same approach as in thin driver:
replace 
new JavaLogger()
with
Logger.getLogger(IgniteJdbcDriver.class.getName())



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-8898) rename command argument '--force' to '--yes' for control.sh

2018-06-29 Thread Max Shonichev (JIRA)
Max Shonichev created IGNITE-8898:
-

 Summary: rename command argument '--force' to '--yes' for 
control.sh
 Key: IGNITE-8898
 URL: https://issues.apache.org/jira/browse/IGNITE-8898
 Project: Ignite
  Issue Type: Improvement
Affects Versions: 2.5
Reporter: Max Shonichev


control.sh requires admin to provide `--force` to auto-confirm actions 
requiring manual confirmation as deactivation of the grid or setting new 
baseline. Semantically, this is not 'forcing', but 'auto-confirmation', so 

please, rename `--force` argument of control.sh to `--yes`.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review IGNITE-8859

2018-06-29 Thread Petr Ivanov
Very nice!


I’ll try to review changes at weekend.


> On 29 Jun 2018, at 17:40, Dmitry Karachentsev  
> wrote:
> 
> Hi Petr,
> 
> Yes, as I said I tested on following JDKs: 1.7, 1.8, 9 and 10.
> In waring showed JAVA_HOME directory. If it would be useful, I can add 
> detected version.
> 
> Thanks!
> 
> 29.06.2018 17:34, Petr Ivanov пишет:
>> Looks good.
>> 
>> Did you intentionally not mentioned JDK10 in warning/error texts?
>> Also have you tested running built Apache Ignite under JDK10?
>> 
>> 
>>> On 29 Jun 2018, at 17:06, Dmitry Karachentsev  
>>> wrote:
>>> 
>>> Forgot a link to the ticket 
>>> https://issues.apache.org/jira/browse/IGNITE-8859
>>> 
>>> 29.06.2018 17:06, Dmitry Karachentsev пишет:
 Hi guys,
 
 I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please 
 review.
 
 I'm not sure if there exist tests, but I tested on Windows/Linux for 1.7, 
 1.8, 9 and 10 JDKs manually.
 
 Thanks!
 
> 



[GitHub] ignite pull request #4283: GG-13963

2018-06-29 Thread vldpyatkov
GitHub user vldpyatkov opened a pull request:

https://github.com/apache/ignite/pull/4283

GG-13963

rename command argument '--force' to '--yes' for control.sh

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-13963

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4283


commit 0bcc46d7f82037689da319fb6997d25dc072
Author: vd-pyatkov 
Date:   2018-06-29T14:50:02Z

GG-13963
rename command argument '--force' to '--yes' for control.sh




---


[GitHub] ignite pull request #4282: IGNITE-7149: Gradient Boosting on Trees

2018-06-29 Thread avplatonov
GitHub user avplatonov opened a pull request:

https://github.com/apache/ignite/pull/4282

IGNITE-7149: Gradient Boosting on Trees

Implementation GDB on DecisionTrees

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-7149

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4282


commit 7d76d34e52c351307a3674ce05e133097ceec49f
Author: Alexey Platonov 
Date:   2018-06-27T18:47:53Z

first iteration

commit 60670228737c1446ab721a79b8182acd27dec961
Author: Alexey Platonov 
Date:   2018-06-27T21:41:24Z

refactoring - add binary classifier and regression

commit d373af816a9f7ff3482f29af95e381fac372f72c
Author: Alexey Platonov 
Date:   2018-06-28T14:14:10Z

compactify code

commit ed1f8e461ab960068b59c8b33581ca796706d0ed
Author: Alexey Platonov 
Date:   2018-06-28T15:23:46Z

Merge branch 'master' of https://github.com/apache/ignite into ignite-7149

commit ecc284a35a0a36df40c5b60f30bbb7f005d963b0
Author: Alexey Platonov 
Date:   2018-06-29T09:41:08Z

add examples, some refactoring

commit 0dd880e11d4559de0b0342a747f393dff540fd8e
Author: Alexey Platonov 
Date:   2018-06-29T12:47:23Z

javadocs, refactorings

commit b2bef377076b40c3c548db2ba4f8591da2335a8e
Author: Alexey Platonov 
Date:   2018-06-29T12:53:30Z

remove ExecutorService

commit 6c702a8063c54d111606696d5360d7b09f8b1070
Author: Alexey Platonov 
Date:   2018-06-29T13:32:23Z

remove useless code

commit eb255d1d40ee01ff8a3d422663f5a6c97143aaa9
Author: Alexey Platonov 
Date:   2018-06-29T13:47:13Z

pre-review refactorings




---


Re: Review IGNITE-8859

2018-06-29 Thread Dmitry Karachentsev

Hi Petr,

Yes, as I said I tested on following JDKs: 1.7, 1.8, 9 and 10.
In waring showed JAVA_HOME directory. If it would be useful, I can add 
detected version.


Thanks!

29.06.2018 17:34, Petr Ivanov пишет:

Looks good.

Did you intentionally not mentioned JDK10 in warning/error texts?
Also have you tested running built Apache Ignite under JDK10?



On 29 Jun 2018, at 17:06, Dmitry Karachentsev  
wrote:

Forgot a link to the ticket https://issues.apache.org/jira/browse/IGNITE-8859

29.06.2018 17:06, Dmitry Karachentsev пишет:

Hi guys,

I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please review.

I'm not sure if there exist tests, but I tested on Windows/Linux for 1.7, 1.8, 
9 and 10 JDKs manually.

Thanks!





[GitHub] ignite pull request #4249: IGNITE-8426 LongJVMPauseDetector add logger from ...

2018-06-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4249


---


Re: Review IGNITE-8859

2018-06-29 Thread Petr Ivanov
Looks good.

Did you intentionally not mentioned JDK10 in warning/error texts?
Also have you tested running built Apache Ignite under JDK10?


> On 29 Jun 2018, at 17:06, Dmitry Karachentsev  
> wrote:
> 
> Forgot a link to the ticket https://issues.apache.org/jira/browse/IGNITE-8859
> 
> 29.06.2018 17:06, Dmitry Karachentsev пишет:
>> Hi guys,
>> 
>> I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please 
>> review.
>> 
>> I'm not sure if there exist tests, but I tested on Windows/Linux for 1.7, 
>> 1.8, 9 and 10 JDKs manually.
>> 
>> Thanks!
>> 
> 



Re: Review IGNITE-8859

2018-06-29 Thread Dmitry Karachentsev
Forgot a link to the ticket 
https://issues.apache.org/jira/browse/IGNITE-8859


29.06.2018 17:06, Dmitry Karachentsev пишет:

Hi guys,

I've enhanced our scripts a bit to allow run Ignite on Java 10+. 
Please review.


I'm not sure if there exist tests, but I tested on Windows/Linux for 
1.7, 1.8, 9 and 10 JDKs manually.


Thanks!





Review IGNITE-8859

2018-06-29 Thread Dmitry Karachentsev

Hi guys,

I've enhanced our scripts a bit to allow run Ignite on Java 10+. Please 
review.


I'm not sure if there exist tests, but I tested on Windows/Linux for 
1.7, 1.8, 9 and 10 JDKs manually.


Thanks!



Re: Thin Client lib: Python

2018-06-29 Thread Dmitry Melnichuk

Dmitry,

I have mentioned Jira task in my reply earlier today. Sorry, but the 
task description was a bit messy and less than informative. I just 
updated it. Please have a look.


https://issues.apache.org/jira/browse/IGNITE-7782

Please let me know if this information is supposed to be somewhere in 
Wiki. I'll post it right away.


On 06/29/2018 07:53 AM, Dmitriy Setrakyan wrote:

Is there an IEP for it where the community can read about the feature set
that will be supported by the Python client?

D. 


[GitHub] ignite pull request #4281: IGNITE-8859 - Open upper Java verison bounds

2018-06-29 Thread dkarachentsev
GitHub user dkarachentsev opened a pull request:

https://github.com/apache/ignite/pull/4281

IGNITE-8859 - Open upper Java verison bounds



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-8859

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4281


commit c474e3e68cae80bd7bf4e2eda69a594bfc4f6e0f
Author: dkarachentsev 
Date:   2018-06-29T13:16:02Z

IGNITE-8859 - Open upper Java verison bounds




---


Re: Please Subscribe me

2018-06-29 Thread Dmitriy Setrakyan
Ken, seems like you have subscribed. Generally, all you have to do is send
an email to dev-subsci...@ignite.apache.org and then simply reply to the
confirmation email.

D.

On Fri, Jun 29, 2018 at 5:01 AM, Ken Cheng  wrote:

> Thanks,
> Ken Cheng
>


Re: Access to change jira status

2018-06-29 Thread uday kale
Thanks Valentin

On Fri, Jun 29, 2018 at 4:15 PM Valentin Kulichenko <
valentin.kuliche...@gmail.com> wrote:

> Hi Uday,
>
> I added you to contributors list, you should be able to assign the ticket
> to yourself now. Welcome to the community!
>
> -Val
>
> On Fri, Jun 29, 2018 at 3:40 AM uday kale  wrote:
>
> > Hi,
> >
> > I am unable to change the jira status of IGNITE-1260 or assign it to
> > myself. Can someone grant me the necessary permissions. My jira user name
> > is: uday.
> >
> > Regards,
> > Uday
> >
>


Please Subscribe me

2018-06-29 Thread Ken Cheng
Thanks,
Ken Cheng


[GitHub] ignite pull request #4280: exception when try to enable atomic operation in ...

2018-06-29 Thread SomeFire
GitHub user SomeFire opened a pull request:

https://github.com/apache/ignite/pull/4280

exception when try to enable atomic operation in tx

IGNITE-2313 Need to add a mode to fail atomic operations within a 
transaction

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SomeFire/ignite ignite-2313-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4280


commit 27f4f3c3a415c4226df1776bc95173b6c2f2b815
Author: Dmitrii Ryabov 
Date:   2018-06-29T11:42:13Z

exception when try to enable atomic operation in tx




---


[GitHub] ignite pull request #4279: check ssh fix for TC flucky tests

2018-06-29 Thread 1vanan
GitHub user 1vanan opened a pull request:

https://github.com/apache/ignite/pull/4279

check ssh fix for TC flucky tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1vanan/ignite SshTests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4279


commit 1bebd917fa1609d2375c57b11aa3f075556f3d96
Author: Fedotov 
Date:   2018-06-29T11:21:30Z

change EXECUTE_WAIT_TIME for waiting execution shell command

commit f62917114a08ef360d82156a414dc6be2c20bd6d
Author: Fedotov 
Date:   2018-06-29T11:30:57Z

run testStopNodes for 300 times




---


[GitHub] ignite pull request #4268: IGNITE-5980 Failing testClientAtomicLongCreateClo...

2018-06-29 Thread 1vanan
Github user 1vanan closed the pull request at:

https://github.com/apache/ignite/pull/4268


---


Re: Thin Client lib: Python

2018-06-29 Thread Dmitry Melnichuk

Hi, Dmitry!

I guess there will be no IEP specifically for the client, because it has 
nothing to do with Ignite enhancing, as what IEP stands for.


From Ignite side, the purpose and potential capabilities of the thin 
client, aka binary API client, is best described by this document:


https://apacheignite.readme.io/docs/binary-client-protocol

From our side, there is some basic info about our project in the 
corresponding Jira task:


https://issues.apache.org/jira/browse/IGNITE-7782

This info is yet to be extended and adjusted.

For more in-depth look at our current work in progress please consult 
our Sphinx documentation. It is contained in our repo in already 
prebuilt form, and will be updated frequently:


https://github.com/nobitlost/ignite/tree/ignite-7782/modules/platforms/python/docs/generated

Regarding the feature set, we strive for the most complete 
implementation of the protocol. However, some of its features (type IDs, 
filter objects, binary type registering, and may be more) are specific 
for Java typing system and thus not relevant for Python language, and 
will unlikely be implemented.


Regards,

On 06/29/2018 07:53 AM, Dmitriy Setrakyan wrote:

Is there an IEP for it where the community can read about the feature set
that will be supported by the Python client?

D.


Re: Access to change jira status

2018-06-29 Thread Valentin Kulichenko
Hi Uday,

I added you to contributors list, you should be able to assign the ticket
to yourself now. Welcome to the community!

-Val

On Fri, Jun 29, 2018 at 3:40 AM uday kale  wrote:

> Hi,
>
> I am unable to change the jira status of IGNITE-1260 or assign it to
> myself. Can someone grant me the necessary permissions. My jira user name
> is: uday.
>
> Regards,
> Uday
>


Access to change jira status

2018-06-29 Thread uday kale
Hi,

I am unable to change the jira status of IGNITE-1260 or assign it to
myself. Can someone grant me the necessary permissions. My jira user name
is: uday.

Regards,
Uday


Potential OOM while iterating over query cursor. Review needed.

2018-06-29 Thread Andrey Mashenkov
Hi Igniters,

There is an issue IGNITE-8892 [1] related to OOM during distributed query
execution.
This issue is not limited with ScanQuery usage and looks like affected all
query types.

The use case is quite simple. 1 server and 1 client.
Client starts scan query with default flags and iterate over cursor.
If whole query result is not fit to memory - JVM will crashed with OOM,
but it is not expected as client takes entries one by one and throw out
them immediately.
Reproducer is attached to the ticket.

Same query works fine if query starts on server. Seems, we have no
DistributedQueryFuture in that case and all works fine.

I've found GridCacheDistributedQueryFuture collects all entries and try to
return the collection via onDone().
This behaviour turn on with a flag 'keepAll' which is true by default.
Iterating over cache via cache.iterator() has no OOM issues as we set
keepAll flag to false.

Why we have keepAll=true by default as seems noone expects future.get()
will return any data and all queries works through queue in paging mode?
Will it be ok to get rid of 'allCol' and keepAll flag at all?

I've made a PR and TC looks fine.
Could someone review it, please?

[1] https://issues.apache.org/jira/browse/IGNITE-8892


-- 
Best regards,
Andrey V. Mashenkov


[jira] [Created] (IGNITE-8897) Node with longer BaselineHistory joining the cluster causes cluster stopping

2018-06-29 Thread Sergey Chugunov (JIRA)
Sergey Chugunov created IGNITE-8897:
---

 Summary: Node with longer BaselineHistory joining the cluster 
causes cluster stopping
 Key: IGNITE-8897
 URL: https://issues.apache.org/jira/browse/IGNITE-8897
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.5
Reporter: Sergey Chugunov
Assignee: Sergey Chugunov
 Fix For: 2.7


There is no array index boundary check in code verifying BaselineHistory on new 
node join so it may end up with ArrayIndexOutOfBoundsException.

We need to check bltHistory size and if node joins with incorrect bltHistory we 
should refuse the join.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-8896) Wrong javadoc for TcpCommunicationSpi.setSlowClientQueueLimit()

2018-06-29 Thread Dmitry Karachentsev (JIRA)
Dmitry Karachentsev created IGNITE-8896:
---

 Summary: Wrong javadoc for 
TcpCommunicationSpi.setSlowClientQueueLimit()
 Key: IGNITE-8896
 URL: https://issues.apache.org/jira/browse/IGNITE-8896
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.5
Reporter: Dmitry Karachentsev
 Fix For: 2.7


Javadoc for TcpCommunicationSpi.setSlowClientQueueLimit() says that is should 
be set to value equal to TcpCommunicationSpi.getMessageQueueLimit().

But this is wrong, because first checks back pressure limit and sender thread 
will be blocked before slow client check. Also, warning checks the value 
correctly, but message should be "...greater or equal...":
{code:java}
if (slowClientQueueLimit > 0 && msgQueueLimit > 0 && slowClientQueueLimit >= 
msgQueueLimit) {
U.quietAndWarn(log, "Slow client queue limit is set to a value 
greater than message queue limit " +
"(slow client queue limit will have no effect) [msgQueueLimit=" 
+ msgQueueLimit +
", slowClientQueueLimit=" + slowClientQueueLimit + ']');
}
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)