[jira] [Created] (IGNITE-9799) Web console: remove unused code

2018-10-04 Thread Ilya Borisov (JIRA)
Ilya Borisov created IGNITE-9799:


 Summary: Web console: remove unused code
 Key: IGNITE-9799
 URL: https://issues.apache.org/jira/browse/IGNITE-9799
 Project: Ignite
  Issue Type: Improvement
  Components: wizards
Reporter: Ilya Borisov
Assignee: Alexander Kalinin


There's a bunch of legacy/unused code and dependencies, let's remove those. 
Here's an incomplete list, feel free to add more items:
1. angular-cookies dependency



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-9798) Add TensorFlow Integration Page to Ignite website

2018-10-04 Thread Denis Magda (JIRA)
Denis Magda created IGNITE-9798:
---

 Summary: Add TensorFlow Integration Page to Ignite website
 Key: IGNITE-9798
 URL: https://issues.apache.org/jira/browse/IGNITE-9798
 Project: Ignite
  Issue Type: Task
  Components: site
Reporter: Denis Magda
Assignee: Prachi Garg
 Fix For: 2.7


We need to create a dedicated page for Ignite and TensorFlow integration. 
Please put it under Machine Learning item of the Features menu.

[~abchaudhri], will provide a reference to the readme.io page with in-depth 
integration description.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-9797) Refer to PHP, Python and Node.JS getting started guides from the website

2018-10-04 Thread Denis Magda (JIRA)
Denis Magda created IGNITE-9797:
---

 Summary: Refer to PHP, Python and Node.JS getting started guides 
from the website
 Key: IGNITE-9797
 URL: https://issues.apache.org/jira/browse/IGNITE-9797
 Project: Ignite
  Issue Type: Task
  Components: site
Affects Versions: 2.7
Reporter: Denis Magda
Assignee: Prachi Garg


This page includes a section with the list of references to getting started 
guides:
https://ignite.apache.org/features/multilanguage.html

Add references to Python, PHP and Node.JS docs on readme.io (Instantiation and 
Configuration pages on readme).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-9796) NPE if you call array on empty GridLongList

2018-10-04 Thread Eduard Shangareev (JIRA)
Eduard Shangareev created IGNITE-9796:
-

 Summary: NPE if you call array on empty GridLongList
 Key: IGNITE-9796
 URL: https://issues.apache.org/jira/browse/IGNITE-9796
 Project: Ignite
  Issue Type: Bug
Reporter: Eduard Shangareev
Assignee: Eduard Shangareev


{code}
/**
 *
 */
public void testArray() {
GridLongList list = new GridLongList();

long[] array = list.array();

assertNotNull(array);

assertEquals(0, array.length);
}
{code}

That is it, current version of GridLongList would cause NPE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Danger (?) change of DiscoveryCustomEvent in GridDhtPartitionsExchangeFuture#onDone

2018-10-04 Thread Vyacheslav Daradur
Alexey, thank you for the advice!


On Thu, Oct 4, 2018 at 1:25 PM Alexey Goncharuk
 wrote:
>
> Vyacheslav,
>
> I think it would be more correct to capture all required state that will be
> further used in a custom object and use it later in service processor.
> Nullifying the field is an explicit action that was taken to reduce memory
> consumption on server nodes, so we cannot simply drop it. Another solution
> is reference counting and nullifying the field only after all parties
> finished processing the message, but it looks like an overengineering to me.
>
> ср, 3 окт. 2018 г. в 15:00, Vyacheslav Daradur :
>
> > Alexey, thank you for the answer. I'd ask your advice about the
> > following question:
> >
> > New Service Grid implementation listens to messages:
> > * ChangeGlobalStateMessage - to perform activation/deactivation actions;
> > * DynamicCacheChangeBatch - to handle caches stopping to undeploy
> > related affinity services;
> > * CacheAffinityChangeMessage - to recalculate assignments for affinity
> > services in case of late affinity.
> >
> > It's important to handle these messages in order from disco-spi that
> > means SG is storing them in own exchange queue to process.
> > In some cases, PME may nullify this message earlier than they will be
> > processed by SG.
> >
> > Could I exclude these messages from PME nullifying?
> >
> > On Wed, Oct 3, 2018 at 11:26 AM Alexey Goncharuk
> >  wrote:
> > >
> > > Vyacheslav,
> > >
> > > Thanks for investigating this. User code should never listen to system
> > > custom events because this is an internal API and it's a subject to
> > change.
> > > If there is anything a user interested in, the corresponding public event
> > > should be added.
> > >
> > > Nullifying the event in this case looks ok for me.
> > >
> > > вс, 30 сент. 2018 г. в 11:45, Vyacheslav Daradur :
> > >
> > > > I think that I understand a reason for doing this:
> > > > The most custom events which handle in
> > > > 'GridDhtPartitionsExchangeFuture' are using only in PME flow and
> > > > reason is release them for GC as soon as possible.
> > > >
> > > > But there are some other systems which can listen to the same events,
> > > > for example, to perform activation/deactivation actions them should
> > > > handle [ChangeGlobalStateMessage, ChangeGlobalStateFinishMessage]
> > > > which can be reset to 'null' by PME earlier then they will be handled
> > > > by other systems.
> > > >
> > > > I'd suggest do not reset to 'null' custom messages in
> > > > 'DiscoveryCustomEvent ' (at least without properly logic from the
> > > > discovery-spi side).
> > > >
> > > > Thoughts?
> > > >
> > > >
> > > >
> > > > On Sat, Sep 29, 2018 at 11:43 PM Vyacheslav Daradur <
> > daradu...@gmail.com>
> > > > wrote:
> > > > >
> > > > > Hi Igniters!
> > > > >
> > > > > I think I found an illegal behavior in
> > > > > GridDhtPartitionsExchangeFuture#onDone, the following code is called
> > > > > here:
> > > > > ((DiscoveryCustomEvent)firstDiscoEvt).customMessage(null);
> > > > >
> > > > > That means a global instance of 'DiscoveryCustomEvent' is being
> > > > > mutated outside discovery-spi infrastructure. It also means that
> > > > > discovery listeners receive 'DiscoveryCustomEvent' with 'null' field
> > > > > instead of 'CustomMessage' which they may rely on.
> > > > >
> > > > > Could someone confirm if it is wrong behavior and should be fixed?
> > > > >
> > > > > --
> > > > > Best Regards, Vyacheslav D.
> > > >
> > > >
> > > >
> > > > --
> > > > Best Regards, Vyacheslav D.
> > > >
> >
> >
> >
> > --
> > Best Regards, Vyacheslav D.
> >



-- 
Best Regards, Vyacheslav D.


[jira] [Created] (IGNITE-9795) Web Agent: Improve information message in case REST command failed on cluster

2018-10-04 Thread Alexey Kuznetsov (JIRA)
Alexey Kuznetsov created IGNITE-9795:


 Summary: Web Agent: Improve information message in case REST 
command failed on cluster
 Key: IGNITE-9795
 URL: https://issues.apache.org/jira/browse/IGNITE-9795
 Project: Ignite
  Issue Type: Bug
  Components: wizards
Reporter: Alexey Kuznetsov
Assignee: Alexey Kuznetsov
 Fix For: 2.8


In current implementation we print `res.message()`, but I found that 
Responce.toString() method contains much more information:

{code}

"Response\{protocol=" + this.protocol + ", code=" + this.code + ", message=" + 
this.message + ", url=" + this.request.url() + '}';
}

{code}

 

lets print it instead of just message, it will help in case of finding the 
reasons of failures.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-9794) Registration of a binary type with POJO field under topology lock leads to UnregisteredBinaryTypeException

2018-10-04 Thread Denis Mekhanikov (JIRA)
Denis Mekhanikov created IGNITE-9794:


 Summary: Registration of a binary type with POJO field under 
topology lock leads to UnregisteredBinaryTypeException
 Key: IGNITE-9794
 URL: https://issues.apache.org/jira/browse/IGNITE-9794
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.6
Reporter: Denis Mekhanikov
Assignee: Denis Mekhanikov
 Fix For: 2.8
 Attachments: BinaryMetadataRegistrationInsideEntryProcessorTest.java

Please find attached test class with a reproducer.

The exception was introduced in IGNITE-8926. Metadata registration should be 
retried when this exception is thrown, but it doesn't happen.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] ignite pull request #4916: IGNITE-9794 Handle UnregisteredBinaryTypeExceptio...

2018-10-04 Thread dmekhanikov
GitHub user dmekhanikov opened a pull request:

https://github.com/apache/ignite/pull/4916

IGNITE-9794 Handle UnregisteredBinaryTypeException on metadata registration 
under topology lock.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite IGNITE-9794

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4916


commit b49ddc9600c6483e4d00d75018eb5839e076e0bf
Author: Denis Mekhanikov 
Date:   2018-10-04T14:59:02Z

IGNITE-9794 Handle UnregisteredBinaryTypeException on metadata registration 
under topology lock.




---


[GitHub] ignite pull request #4915: IGNITE-9792 Fixed assert in case if IGNITE_MBEANS...

2018-10-04 Thread akuznetsov-gridgain
GitHub user akuznetsov-gridgain opened a pull request:

https://github.com/apache/ignite/pull/4915

IGNITE-9792 Fixed assert in case if IGNITE_MBEANS_DISABLED is true. F…

…ixed tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/ignite ignite-9792

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4915.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4915


commit e66c9850ce1ba5e8c2c028f837aff646577beebe
Author: Alexey Kuznetsov 
Date:   2018-10-04T11:19:02Z

IGNITE-9792 Fixed assert in case if IGNITE_MBEANS_DISABLED is true. Fixed 
tests.




---


[GitHub] ignite pull request #4912: IGNITE-9788: Import IgniteDataset explicitly in T...

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4912


---


[GitHub] asfgit closed pull request #28: improve exception handling

2018-10-04 Thread GitBox
asfgit closed pull request #28: improve exception handling
URL: https://github.com/apache/ignite-teamcity-bot/pull/28
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITcHelper.java 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITcHelper.java
index 5c25432..5d68ce9 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITcHelper.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITcHelper.java
@@ -18,13 +18,11 @@
 package org.apache.ignite.ci;
 
 import java.util.List;
-import org.apache.ignite.ci.observer.BuildObserver;
 import org.apache.ignite.ci.issue.IssueDetector;
 import org.apache.ignite.ci.issue.IssuesStorage;
 import org.apache.ignite.ci.user.ICredentialsProv;
 import org.apache.ignite.ci.user.UserAndSessionsStorage;
 
-import javax.annotation.Nullable;
 import java.util.Collection;
 
 /**
@@ -43,7 +41,6 @@
 
 IssueDetector issueDetector();
 
-
 ITcAnalytics tcAnalytics(String serverId);
 
 UserAndSessionsStorage users();
@@ -62,5 +59,5 @@
  * @param ticket JIRA ticket full name.
  * @return {@code True} if JIRA was notified.
  */
-boolean notifyJira(String srvId, ICredentialsProv prov, String 
buildTypeId, String branchForTc, String ticket);
+String notifyJira(String srvId, ICredentialsProv prov, String buildTypeId, 
String branchForTc, String ticket);
 }
diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITeamcity.java 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITeamcity.java
index 4989b31..e404b70 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITeamcity.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITeamcity.java
@@ -18,6 +18,7 @@
 package org.apache.ignite.ci;
 
 import java.io.File;
+import java.io.IOException;
 import java.util.Date;
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
@@ -37,7 +38,6 @@
 import org.apache.ignite.ci.tcmodel.hist.BuildRef;
 import org.apache.ignite.ci.tcmodel.result.Build;
 import org.apache.ignite.ci.tcmodel.result.issues.IssuesUsagesList;
-import org.apache.ignite.ci.tcmodel.result.problems.ProblemOccurrence;
 import org.apache.ignite.ci.tcmodel.result.problems.ProblemOccurrences;
 import org.apache.ignite.ci.tcmodel.result.stat.Statistics;
 import org.apache.ignite.ci.tcmodel.result.tests.TestOccurrence;
@@ -314,8 +314,11 @@ default SingleBuildRunCtx loadTestsAndProblems(@Nonnull 
Build build, @Deprecated
  * @param ticket JIRA ticket full name.
  * @param comment Comment to be placed in the ticket conversation.
  * @return {@code True} if ticket was succesfully commented. Otherwise - 
{@code false}.
+ *
+ * @throws IOException If failed to comment JIRA ticket.
+ * @throws IllegalStateException If can't find URL to the JIRA.
  */
-boolean sendJiraComment(String ticket, String comment);
+String sendJiraComment(String ticket, String comment) throws IOException;
 
 /**
  * @param url URL for git integration.
diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
index 82bea6d..35e5d63 100644
--- 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
+++ 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgnitePersistentTeamcity.java
@@ -21,6 +21,7 @@
 import com.google.common.base.Throwables;
 import java.io.File;
 import java.io.FileNotFoundException;
+import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
@@ -1162,7 +1163,7 @@ private void 
migrateTestOneOcurrToAddToLatest(TestOccurrence next) {
 }
 
 /** {@inheritDoc} */
-@Override public boolean sendJiraComment(String ticket, String comment) {
+@Override public String sendJiraComment(String ticket, String comment) 
throws IOException {
 return teamcity.sendJiraComment(ticket, comment);
 }
 
diff --git 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
index 2b2d365..aa0e76c 100644
--- 
a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
+++ 
b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
@@ -194,25 +194,13 @@ public void init(@Nullable String tcName) {
 
 /** {@inheritDoc} */
 @AutoProfiling
-@Override public boolean sendJiraComment(String ticket, String comment) {
-if (isNullOrEmpty(jiraApiUrl)) {
-

[GitHub] SomeFire opened a new pull request #28: improve exception handling

2018-10-04 Thread GitBox
SomeFire opened a new pull request #28: improve exception handling
URL: https://github.com/apache/ignite-teamcity-bot/pull/28
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Apache Ignite 2.7 release

2018-10-04 Thread Nikolay Izhikov
Helo, Dmitriy.

I looked at patch.
Seems it local for a ML module.

Is it's true I'm +1 to include it to 2.7.


В Чт, 04/10/2018 в 08:33 -0500, dmitrievanthony пишет:
> Hi, Yury, Nikolay.
> 
> This issue reproduces in "TensorFlow on Apache Ignite" use cases. When user
> prepares training script (like official MNIST model
> https://github.com/tensorflow/models/tree/master/official/mnist), runs it in
> distributed standalone client mode (see this documentation
> https://github.com/tensorflow/tensorflow/tree/master/tensorflow/contrib/distribute#standalone-client-mode)
> using IgniteDataset he can see that workers throw exceptions says that
> IgniteDataset operation is not loaded.
> 
> For more information about distributed training please see
> https://docs.google.com/document/d/1PtYmyaT4dPBNp1mWkCczOdCZHt2xaqB183honfMup3g/edit
> documentation.
> 
> 
> 
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/


signature.asc
Description: This is a digitally signed message part


Re: Apache Ignite 2.7 release

2018-10-04 Thread dmitrievanthony
Hi, Yury, Nikolay.

This issue reproduces in "TensorFlow on Apache Ignite" use cases. When user
prepares training script (like official MNIST model
https://github.com/tensorflow/models/tree/master/official/mnist), runs it in
distributed standalone client mode (see this documentation
https://github.com/tensorflow/tensorflow/tree/master/tensorflow/contrib/distribute#standalone-client-mode)
using IgniteDataset he can see that workers throw exceptions says that
IgniteDataset operation is not loaded.

For more information about distributed training please see
https://docs.google.com/document/d/1PtYmyaT4dPBNp1mWkCczOdCZHt2xaqB183honfMup3g/edit
documentation.



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/


[jira] [Created] (IGNITE-9793) Deactivation, segmentation of one node, activation may lead to hang activation forever

2018-10-04 Thread Pavel Voronkin (JIRA)
Pavel Voronkin created IGNITE-9793:
--

 Summary: Deactivation, segmentation of one node, activation may 
lead to hang activation forever
 Key: IGNITE-9793
 URL: https://issues.apache.org/jira/browse/IGNITE-9793
 Project: Ignite
  Issue Type: Bug
Affects Versions: 2.5
Reporter: Pavel Voronkin


There is coordinator and ring of nodes

coordinator -> 1 -> 2 - > 3 -> 4

coordinator deactivated:

2018-09-24 15:09:01.609 [INFO 
][exchange-worker-#153%DPL_GRID%DplGridNodeName%][o.a.i.i.p.c.d.d.p.GridDhtPartitionsExchangeFuture]
 Successfully deactivated data structures, services and caches 
[nodeId=e002e011-8d1c-4353-a0f3-b71264c5b0f4, client=false, 
topVer=AffinityTopologyVersion [topVer=183, minorTopVer=1]]
2018-09-24 15:09:01.620 
[DEBUG][exchange-worker-#153%DPL_GRID%DplGridNodeName%][o.a.i.i.p.c.d.d.p.l.ExchangeLatchManager]
 Server latch is created [latch=CompletableLatchUid\{id='exchange', 
topVer=AffinityTopologyVersion [topVer=183, minorTopVer=1]}, 
participantsSize=160]
2018-09-24 15:09:01.621 [INFO ][exchange-worker-#153%DPL_GRID%DplGridNodeName%]

nodes 1, 2, 3, 4 were deactivated:

2018-09-24 15:09:01.609 [INFO 
][exchange-worker-#153%DPL_GRID%DplGridNodeName%][o.a.i.i.p.c.d.d.p.GridDhtPartitionsExchangeFuture]
 Successfully deactivated data structures, services and caches 
[nodeId=e002e011-8d1c-4353-a0f3-b71264c5b0f4, client=false, 
topVer=AffinityTopologyVersion [topVer=183, minorTopVer=1]]

2018-09-24 15:09:03.328 [INFO 
][exchange-worker-#153%DPL_GRID%DplGridNodeName%][o.a.i.i.p.c.d.d.p.GridDhtPartitionsExchangeFuture]
 Successfully deactivated data structures, services and caches 
[nodeId=22a58223-47b5-43c2-897b-e70e8e50edf7, client=false, 
topVer=AffinityTopologyVersion [topVer=183, minorTopVer=1]]

2018-09-24 15:09:03.334 [INFO 
][exchange-worker-#153%DPL_GRID%DplGridNodeName%][o.a.i.i.p.c.d.d.p.GridDhtPartitionsExchangeFuture]
 Successfully deactivated data structures, services and caches 
[nodeId=973eb8ce-3b8c-463d-a6ab-00ac66d93f13, client=false, 
topVer=AffinityTopologyVersion [topVer=183, minorTopVer=1]]

2018-09-24 15:09:03.332 [INFO 
][exchange-worker-#153%DPL_GRID%DplGridNodeName%][o.a.i.i.p.c.d.d.p.GridDhtPartitionsExchangeFuture]
 Successfully deactivated data structures, services and caches 
[nodeId=a904bac4-aaed-4f69-90f3-c13bc4d331d1, client=false, 
topVer=AffinityTopologyVersion [topVer=183, minorTopVer=1]]

Node 2 SEGMENTED

2018-09-24 15:17:50.068 [WARN 
][tcp-disco-msg-worker-#2%DPL_GRID%DplGridNodeName%][o.a.i.s.d.tcp.TcpDiscoverySpi]
 Node is out of topology (probably, due to short-time network problems).
2018-09-24 15:17:50.069 [WARN 
][disco-event-worker-#152%DPL_GRID%DplGridNodeName%][o.a.i.i.m.d.GridDiscoveryManager]
 Local node SEGMENTED: TcpDiscoveryNode 
[id=a904bac4-aaed-4f69-90f3-c13bc4d331d1, addrs=ArrayList [10.116.206.98], 
sockAddrs=HashSet [grid724.domain/10.116.206.98:47500], discPort=47500, 
order=110, intOrder=110, lastExchangeTime=1537791470063, loc=true, 
ver=2.5.1#20180906-sha1:ebde6c79, isClient=false]

Coordinator started activation on topology without node2

2018-09-24 15:19:48.686 [INFO 
][exchange-worker-#153%DPL_GRID%DplGridNodeName%][o.a.i.i.p.c.d.d.p.GridDhtPartitionsExchangeFuture]
 Start activation process [nodeId=e002e011-8d1c-4353-a0f3-b71264c5b0f4, 
client=false, topVer=AffinityTopologyVersion [topVer=188, minorTopVer=1]]

But node 3 which is next to node 2 haven't received activation message.

Coordinator sent activation to all except

2018-09-24 15:24:25.911 [INFO 
][sys-#28144%DPL_GRID%DplGridNodeName%][o.a.i.i.p.c.d.d.p.GridDhtPartitionsExchangeFuture]
 Coordinator received single message [ver=AffinityTopologyVersion [topVer=188, 
minorTopVer=1], node=073f1598-6b70-49df-8f45-126735611775, allReceived=false]

GridDhtPartitionsExchangeFuture hangs forever.

 

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] ignite pull request #4914: Ignite 9737

2018-10-04 Thread andrey-kuznetsov
GitHub user andrey-kuznetsov opened a pull request:

https://github.com/apache/ignite/pull/4914

Ignite 9737



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrey-kuznetsov/ignite ignite-9737

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4914.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4914


commit 23591291a3ce6401e0a98db961bf0ac90649017b
Author: Andrey Kuznetsov 
Date:   2018-10-03T16:08:54Z

IGNITE-9737 Added separate timeout for blocked workers detection.

commit e07e40cade56a33ea57ee98907eb40d5a2b3
Author: Andrey Kuznetsov 
Date:   2018-10-04T11:56:20Z

IGNITE-9737 Added separate timeout for checkpoint read lock.

commit e043f9aece6941d30233341249de14f3f40d457b
Author: Andrey Kuznetsov 
Date:   2018-10-04T12:18:28Z

IGNITE-9737 Refined throwing rules on cp-read-lock timeout.




---


[GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button

2018-10-04 Thread GitBox
SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222642202
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/TriggerBuild.java
 ##
 @@ -167,7 +167,8 @@ private String observeJira(
 
 BuildObserver observer = 
CtxListener.getInjector(context).getInstance(BuildObserver.class);
 
-observer.observe(build, srvId, prov, "ignite-" + ticketId);
+for (Build build : builds)
 
 Review comment:
   We shouldn't observe builds for the same PR separately, because in such case 
we Bot will comment same ticket for every build. We should wait while all of 
the builds will be finished and comment only once.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button

2018-10-04 Thread GitBox
SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222642946
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -171,9 +170,29 @@ function showChainCurrentStatusData(server, settings) {
 
 if (settings.isJiraAvailable()) {
 res += "Comment JIRA";
++ server.branchName + "\")'>Comment JIRA";
 }
 
+var blockersList = "";
+
+for (var i = 0; i < server.suites.length; i++) {
+var suite = server.suites[i];
+
+suite = suiteWithCriticalFailuresOnly(suite);
+
+if (suite != null) {
+if (blockersList.length !== 0)
+blockersList += ",";
+
+blockersList += suite.suiteId;
+}
+}
+
+res += " Re-run 
possible blockers";
 
 Review comment:
   Too long line. Also, add `` tag.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button

2018-10-04 Thread GitBox
SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222643151
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -171,9 +170,29 @@ function showChainCurrentStatusData(server, settings) {
 
 if (settings.isJiraAvailable()) {
 res += "Comment JIRA";
++ server.branchName + "\")'>Comment JIRA";
 }
 
+var blockersList = "";
+
+for (var i = 0; i < server.suites.length; i++) {
+var suite = server.suites[i];
+
+suite = suiteWithCriticalFailuresOnly(suite);
+
+if (suite != null) {
+if (blockersList.length !== 0)
+blockersList += ",";
+
+blockersList += suite.suiteId;
+}
+}
+
+res += " Re-run 
possible blockers";
+
+res += " Re-run 
possible blockers & Comment JIRA";
 
 Review comment:
   Too long line. Also, add `` tag and move this under 
`settings.isJiraAvailable()` check. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button

2018-10-04 Thread GitBox
SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222643602
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -125,11 +124,11 @@ function showChainCurrentStatusData(server, settings) {
 if (suitesFailedList.length !== 0 && isDefinedAndFilled(server.serverId) 
&& isDefinedAndFilled(server.branchName)) {
 mInfo += "Trigger failed " + cntFailed + " builds";
 mInfo += " 

[GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button

2018-10-04 Thread GitBox
SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222642529
 
 

 ##
 File path: 
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/rest/TriggerBuild.java
 ##
 @@ -195,31 +196,42 @@ private String observeJira(
 @GET
 @Path("triggerBuilds")
 public SimpleResult triggerBuilds(
-@Nullable @QueryParam("serverId") String serverId,
+@Nullable @QueryParam("serverId") String srvId,
 @Nullable @QueryParam("branchName") String branchName,
 @NotNull @QueryParam("suiteIdList") String suiteIdList,
-@Nullable @QueryParam("top") Boolean top) {
+@Nullable @QueryParam("top") Boolean top,
+@Nullable @QueryParam("observe") Boolean observe,
+@Nullable @QueryParam("ticketId") String ticketId) {
+
+String jiraRes = "";
 
 final ICredentialsProv prov = ICredentialsProv.get(req);
 
-if (!prov.hasAccess(serverId))
-throw ServiceUnauthorizedException.noCreds(serverId);
+if (!prov.hasAccess(srvId))
+throw ServiceUnauthorizedException.noCreds(srvId);
 
 List strings = Arrays.asList(suiteIdList.split(","));
 if (strings.isEmpty())
 return new SimpleResult("Error: nothing to run");
 
-final ITeamcity helper = 
CtxListener.getTcHelper(context).server(serverId, prov);
+ITcHelper helper = CtxListener.getTcHelper(context);
+
+final ITeamcity teamcity = helper.server(srvId, prov);
 
 boolean queueToTop = top != null && top;
 
+List buildList = new ArrayList<>();
+
 for (String suiteId : strings) {
 System.out.println("Triggering [ " + suiteId + "," + branchName + 
"," + "top=" + queueToTop + "]");
 
-helper.triggerBuild(suiteId, branchName, false, queueToTop);
+buildList.add(teamcity.triggerBuild(suiteId, branchName, false, 
queueToTop));
 }
 
-return new SimpleResult("OK");
+if (observe != null && observe)
+jiraRes = observeJira(srvId, branchName, ticketId, helper, 
teamcity, prov, buildList.toArray(new Build[0]));
 
 Review comment:
   Redundant argument `new Build[0]`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button

2018-10-04 Thread GitBox
SomeFire commented on a change in pull request #27: IGNITE-9770 Add 'Re-run 
possible blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27#discussion_r222643571
 
 

 ##
 File path: ignite-tc-helper-web/src/main/webapp/js/testfails-2.1.js
 ##
 @@ -125,11 +124,11 @@ function showChainCurrentStatusData(server, settings) {
 if (suitesFailedList.length !== 0 && isDefinedAndFilled(server.serverId) 
&& isDefinedAndFilled(server.branchName)) {
 mInfo += "Trigger failed " + cntFailed + " builds";
 mInfo += " 

Re: Apache Ignite 2.7 release

2018-10-04 Thread Nikolay Izhikov
Hello, Yuriy

What is consequences of this issue?
How user can reproduce it?


В Чт, 04/10/2018 в 15:02 +0300, Yuriy Babak пишет:
> Igniters,
> 
> We have new ticket related with TensorFlow integration:
> https://issues.apache.org/jira/browse/IGNITE-9788
> 
> From my point of view this fix is important for release and I want to
> include it to 2.7.
> 
> Any objections?
> 
> пн, 20 авг. 2018 г. в 21:22, Nikolay Izhikov :
> 
> > Hello, Igniters.
> > 
> > I'm release manager of Apache Ignite 2.7.
> > 
> > It's time to start discussion of release. [1]
> > 
> > Current code freeze date is September, 30.
> > If you have any objections - please, responsd to this thread.
> > 
> > [1] https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7


signature.asc
Description: This is a digitally signed message part


Re: Apache Ignite 2.7 release

2018-10-04 Thread Yuriy Babak
Igniters,

We have new ticket related with TensorFlow integration:
https://issues.apache.org/jira/browse/IGNITE-9788

>From my point of view this fix is important for release and I want to
include it to 2.7.

Any objections?

пн, 20 авг. 2018 г. в 21:22, Nikolay Izhikov :

> Hello, Igniters.
>
> I'm release manager of Apache Ignite 2.7.
>
> It's time to start discussion of release. [1]
>
> Current code freeze date is September, 30.
> If you have any objections - please, responsd to this thread.
>
> [1] https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.7


[GitHub] asfgit closed pull request #26: add git and JIRA URL samples

2018-10-04 Thread GitBox
asfgit closed pull request #26: add git and JIRA URL samples
URL: https://github.com/apache/ignite-teamcity-bot/pull/26
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/conf/apache.auth.properties b/conf/apache.auth.properties
index 653d082..c0ff1cf 100644
--- a/conf/apache.auth.properties
+++ b/conf/apache.auth.properties
@@ -1,3 +1,6 @@
 host=https://ci.ignite.apache.org/
  
-logs=apache_logs
\ No newline at end of file
+logs=apache_logs
+
+git.api_url=https://api.github.com/repos/apache/ignite/
+jira.api_url=https://issues.apache.org/jira/rest/api/2/
diff --git a/ignite-tc-helper-web/src/main/webapp/js/common-1.6.js 
b/ignite-tc-helper-web/src/main/webapp/js/common-1.6.js
index 8f15680..3a4688d 100644
--- a/ignite-tc-helper-web/src/main/webapp/js/common-1.6.js
+++ b/ignite-tc-helper-web/src/main/webapp/js/common-1.6.js
@@ -326,8 +326,10 @@ function _fillGitUrls(result) {
  * @private
  */
 function _sendRequestsToFillAutocompleteLists() {
-for (var entry of gitUrls.entries())
-scriptRequest(entry[1] + "pulls?sort=updated=desc", 
_fillBranchAutocompleteList);
+for (var entry of gitUrls.entries()) {
+if (entry[1])
+scriptRequest(entry[1] + "pulls?sort=updated=desc", 
_fillBranchAutocompleteList);
+}
 }
 
 /**


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Apache Ignite 2.7 release

2018-10-04 Thread Dmitriy Pavlov
Hi Alexey,

Security is always mandatory for all Apache projects. So I agree we should
include.

Sincerely,
Dmitriy Pavlov

чт, 4 окт. 2018 г. в 12:37, Alexey Kuznetsov :

> Hi, All!
>
> I found a bug with *IGNITE_MBEANS_DISABLED* system property.
> I created issue:  IGNITE-9792 Setting system property
> *IGNITE_MBEANS_DISABLED* to true lead to NPE.
>
> I think this one can be included into 2.7, because java docs
> for IGNITE_MBEANS_DISABLED
>  claims that "*This may be helpful if MBeans are not allowed e.g. for
> security reasons.*"
>
> The fix is trivial (one liner + simple text).
>
> I can contribute the fix for this bug.
>
> 1. https://issues.apache.org/jira/browse/IGNITE-9792
>
> --
> Alexey Kuznetsov
>


Re: [ML] New features and improvement of ML module for 2.7 release

2018-10-04 Thread Dmitriy Pavlov
Alexey, what do you think about sending announce of your talks also to user
list?

Some of the dev-list subscribers are Ignite contributors, so maybe it will
be reasonable to inform users about talks.

чт, 4 окт. 2018 г. в 11:41, Alexey Zinoviev :

> Great, will wait video from summit.
>
> чт, 4 окт. 2018 г. в 0:22, Denis Magda :
>
> > >
> > > It will be great if you can share your presentation/video after this
> > summit
> > > in dev-list.
> >
> >
> > The video should be posted on this page in a couple of weeks:
> >
> >
> https://www.imcsummit.org/2018/us/session/scalable-machine-and-deep-learning-apache-ignite
> >
> > Did you use a TensorFlow integration stand in your presentation?
> >
> >
> > Yes, could present and announce it. Yuri and Andrey helped me with the
> demo
> > but, unfortunately, could show it because the organizers failed to set up
> > my laptop and projector.
> >
> > --
> > Denis
> >
> > On Wed, Oct 3, 2018 at 2:35 AM Alexey Zinoviev 
> > wrote:
> >
> > > It will be great if you can share your presentation/video after this
> > summit
> > > in dev-list.
> > > Did you use a TensorFlow integration stand in your presentation?
> > >
> > > Good news about potential users, it will be great to contact with
> > somebody
> > > who are going to use ML in production to discuss possible cases
> > >
> > > ср, 3 окт. 2018 г. в 6:29, Denis Magda :
> > >
> > > > Alexey,
> > > >
> > > > Thanks for spreading the word about the ML capabilities! *Prachi*,
> > please
> > > > help us to add the talks Alexey is going to give to Ignite events
> page:
> > > > https://ignite.apache.org/events.html
> > > >
> > > > Btw, I gave a presentation about Ignite ML + TensorFlow integration
> > today
> > > > at IMC Summit in the US. It was perceived really well, was bombarded
> > with
> > > > many questions after the talk and think we've got some potential
> users
> > ;)
> > > >
> > > > --
> > > > Denis
> > > >
> > > > On Tue, Oct 2, 2018 at 8:54 AM Alexey Zinoviev <
> zaleslaw@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > Currently, in release 2.7, the ignite ML has a parity with a Spark
> ML
> > > by
> > > > ML
> > > > > algorithms, feature preprocessing and other capabilities.
> > > > >
> > > > > I'm going to talk about that in October on two conferences
> > > > >
> > > > > 1) [Ru] Yaroslavl, Open Source Distributed Machine Learning Library
> > for
> > > > > Apache Ignite https://yappidays.ru/talks.html#zinovev
> > > > >
> > > > > 2) [En] Minsk, Nuances of Machine Learning with Ignite ML,
> > > > > https://jfuture.by/#talkbyAlexeyZinoviev
> > > > >
> > > > > After my previous event, JUG MSK, the new contributor @Ravil
> Galeyev
> > > > joined
> > > > > to our community, hope for new members from Yaroslavl and Minsk
> soon
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > > > >
> > > >
> > >
> >
>


Re: Danger (?) change of DiscoveryCustomEvent in GridDhtPartitionsExchangeFuture#onDone

2018-10-04 Thread Alexey Goncharuk
Vyacheslav,

I think it would be more correct to capture all required state that will be
further used in a custom object and use it later in service processor.
Nullifying the field is an explicit action that was taken to reduce memory
consumption on server nodes, so we cannot simply drop it. Another solution
is reference counting and nullifying the field only after all parties
finished processing the message, but it looks like an overengineering to me.

ср, 3 окт. 2018 г. в 15:00, Vyacheslav Daradur :

> Alexey, thank you for the answer. I'd ask your advice about the
> following question:
>
> New Service Grid implementation listens to messages:
> * ChangeGlobalStateMessage - to perform activation/deactivation actions;
> * DynamicCacheChangeBatch - to handle caches stopping to undeploy
> related affinity services;
> * CacheAffinityChangeMessage - to recalculate assignments for affinity
> services in case of late affinity.
>
> It's important to handle these messages in order from disco-spi that
> means SG is storing them in own exchange queue to process.
> In some cases, PME may nullify this message earlier than they will be
> processed by SG.
>
> Could I exclude these messages from PME nullifying?
>
> On Wed, Oct 3, 2018 at 11:26 AM Alexey Goncharuk
>  wrote:
> >
> > Vyacheslav,
> >
> > Thanks for investigating this. User code should never listen to system
> > custom events because this is an internal API and it's a subject to
> change.
> > If there is anything a user interested in, the corresponding public event
> > should be added.
> >
> > Nullifying the event in this case looks ok for me.
> >
> > вс, 30 сент. 2018 г. в 11:45, Vyacheslav Daradur :
> >
> > > I think that I understand a reason for doing this:
> > > The most custom events which handle in
> > > 'GridDhtPartitionsExchangeFuture' are using only in PME flow and
> > > reason is release them for GC as soon as possible.
> > >
> > > But there are some other systems which can listen to the same events,
> > > for example, to perform activation/deactivation actions them should
> > > handle [ChangeGlobalStateMessage, ChangeGlobalStateFinishMessage]
> > > which can be reset to 'null' by PME earlier then they will be handled
> > > by other systems.
> > >
> > > I'd suggest do not reset to 'null' custom messages in
> > > 'DiscoveryCustomEvent ' (at least without properly logic from the
> > > discovery-spi side).
> > >
> > > Thoughts?
> > >
> > >
> > >
> > > On Sat, Sep 29, 2018 at 11:43 PM Vyacheslav Daradur <
> daradu...@gmail.com>
> > > wrote:
> > > >
> > > > Hi Igniters!
> > > >
> > > > I think I found an illegal behavior in
> > > > GridDhtPartitionsExchangeFuture#onDone, the following code is called
> > > > here:
> > > > ((DiscoveryCustomEvent)firstDiscoEvt).customMessage(null);
> > > >
> > > > That means a global instance of 'DiscoveryCustomEvent' is being
> > > > mutated outside discovery-spi infrastructure. It also means that
> > > > discovery listeners receive 'DiscoveryCustomEvent' with 'null' field
> > > > instead of 'CustomMessage' which they may rely on.
> > > >
> > > > Could someone confirm if it is wrong behavior and should be fixed?
> > > >
> > > > --
> > > > Best Regards, Vyacheslav D.
> > >
> > >
> > >
> > > --
> > > Best Regards, Vyacheslav D.
> > >
>
>
>
> --
> Best Regards, Vyacheslav D.
>


Re: [MTCGA]: new failures in builds [1871897] needs to be handled

2018-10-04 Thread Dmitriy Pavlov
Great, thanks for the update.

чт, 4 окт. 2018 г. в 13:21, Alexey Goncharuk :

> Dmitriy, to my knowledge, the test will be fixed by the ticket
> https://issues.apache.org/jira/browse/IGNITE-9550, we expect it to be
> merged by the end of this week.
>
> ср, 3 окт. 2018 г. в 18:00, Dmitriy Pavlov :
>
>> Hi Alexey,
>>
>> Could you please assist with fixing test?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> сб, 29 сент. 2018 г. в 12:23, Dmitriy Pavlov :
>>
>>> Folks,
>>>
>>> both tests are failed in ignite-2.7 IgniteStandByClusterTest.testSimple
>>> 
>>>  &
>>> IgniteChangeGlobalStateFailOverTest.testActivateDeActivateOnFixTopologyWithPutValues
>>> 
>>>
>>>
>>> Can I hope these failures will be fixed in master and 2.7 before release?
>>>
>>> https://issues.apache.org/jira/browse/IGNITE-7618
>>> 
>>>
>>>
>>>
>>> пт, 21 сент. 2018 г. в 11:33, Dmitrii Ryabov :
>>>
 Hi, Dmitriy,
 I checked 7618 and previous commits: test fails locally starting from
 7618.
 It fails because `cache.get()` remembers deactivated state and doesn't
 check current state.

 2018-09-20 18:41 GMT+03:00 Dmitriy Pavlov :

 > Hi,
 >
 > IgniteStandByClusterTest seems to fail, Dmitriy G., Ivan, would it be
 > reasonable to revert commit?
 >
 > Dmitriy Ryabov, is it related to recent fix or is it a standalone
 problem?
 >
 > Sincerely,
 > Dmitriy Pavlov
 >
 > пн, 17 сент. 2018 г. в 18:45, Dmitrii Ryabov :
 >
 > > Looks like problem I had described in the ticket.
 > >
 > >
 > > https://issues.apache.org/jira/browse/IGNITE-7618?
 > focusedCommentId=16506923=com.atlassian.jira.
 > plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16506923
 > >
 > > 2018-09-15 12:01 GMT+03:00 Dmitriy Pavlov :
 > >
 > > > Dmitriy G, Ivan B,
 > > >
 > > > could you please double-check if failure is not coming from
 > > > https://issues.apache.org/jira/browse/IGNITE-7618
 > > >
 > > > Sincerely,
 > > > Dmitriy Pavlov
 > > >
 > > > сб, 15 сент. 2018 г. в 5:42, :
 > > >
 > > > > Hi Ignite Developer,
 > > > >
 > > > > I am MTCGA.Bot, and I've detected some issue on TeamCity to be
 > > addressed.
 > > > > I hope you can help.
 > > > >
 > > > >  *New test failure in master
 IgniteStandByClusterTest.testSimple
 > > > > https://ci.ignite.apache.org/project.html?projectId=
 > > > IgniteTests24Java8=1332314705000986815=%
 > > > 3Cdefault%3E=testDetails
 > > > >  Changes may led to failure were done by
 > > > >  - bessonov.ip
 > > > > http://ci.ignite.apache.org/viewModification.html?modId=
 > > > 831651=false
 > > > >
 > > > > - If your changes can led to this failure(s), please
 create
 > > issue
 > > > > with label MakeTeamCityGreenAgain and assign it to you.
 > > > > -- If you have fix, please set ticket to PA state and
 write
 > to
 > > > dev
 > > > > list fix is ready
 > > > > -- For case fix will require some time please mute test
 and
 > set
 > > > > label Muted_Test to issue
 > > > > - If you know which change caused failure please contact
 > change
 > > > > author directly
 > > > > - If you don't know which change caused failure please
 send
 > > > > message to dev list to find out
 > > > > Should you have any questions please contact
 dev@ignite.apache.org
 > > > > Best Regards,
 > > > > MTCGA.Bot
 > > > > Notification generated at Sat Sep 15 05:42:21 MSK 2018
 > > > >
 > > >
 > >
 >

>>>


Re: [MTCGA]: new failures in builds [1871897] needs to be handled

2018-10-04 Thread Alexey Goncharuk
Dmitriy, to my knowledge, the test will be fixed by the ticket
https://issues.apache.org/jira/browse/IGNITE-9550, we expect it to be
merged by the end of this week.

ср, 3 окт. 2018 г. в 18:00, Dmitriy Pavlov :

> Hi Alexey,
>
> Could you please assist with fixing test?
>
> Sincerely,
> Dmitriy Pavlov
>
> сб, 29 сент. 2018 г. в 12:23, Dmitriy Pavlov :
>
>> Folks,
>>
>> both tests are failed in ignite-2.7 IgniteStandByClusterTest.testSimple
>> 
>>  &
>> IgniteChangeGlobalStateFailOverTest.testActivateDeActivateOnFixTopologyWithPutValues
>> 
>>
>>
>> Can I hope these failures will be fixed in master and 2.7 before release?
>>
>> https://issues.apache.org/jira/browse/IGNITE-7618
>> 
>>
>>
>>
>> пт, 21 сент. 2018 г. в 11:33, Dmitrii Ryabov :
>>
>>> Hi, Dmitriy,
>>> I checked 7618 and previous commits: test fails locally starting from
>>> 7618.
>>> It fails because `cache.get()` remembers deactivated state and doesn't
>>> check current state.
>>>
>>> 2018-09-20 18:41 GMT+03:00 Dmitriy Pavlov :
>>>
>>> > Hi,
>>> >
>>> > IgniteStandByClusterTest seems to fail, Dmitriy G., Ivan, would it be
>>> > reasonable to revert commit?
>>> >
>>> > Dmitriy Ryabov, is it related to recent fix or is it a standalone
>>> problem?
>>> >
>>> > Sincerely,
>>> > Dmitriy Pavlov
>>> >
>>> > пн, 17 сент. 2018 г. в 18:45, Dmitrii Ryabov :
>>> >
>>> > > Looks like problem I had described in the ticket.
>>> > >
>>> > >
>>> > > https://issues.apache.org/jira/browse/IGNITE-7618?
>>> > focusedCommentId=16506923=com.atlassian.jira.
>>> > plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16506923
>>> > >
>>> > > 2018-09-15 12:01 GMT+03:00 Dmitriy Pavlov :
>>> > >
>>> > > > Dmitriy G, Ivan B,
>>> > > >
>>> > > > could you please double-check if failure is not coming from
>>> > > > https://issues.apache.org/jira/browse/IGNITE-7618
>>> > > >
>>> > > > Sincerely,
>>> > > > Dmitriy Pavlov
>>> > > >
>>> > > > сб, 15 сент. 2018 г. в 5:42, :
>>> > > >
>>> > > > > Hi Ignite Developer,
>>> > > > >
>>> > > > > I am MTCGA.Bot, and I've detected some issue on TeamCity to be
>>> > > addressed.
>>> > > > > I hope you can help.
>>> > > > >
>>> > > > >  *New test failure in master
>>> IgniteStandByClusterTest.testSimple
>>> > > > > https://ci.ignite.apache.org/project.html?projectId=
>>> > > > IgniteTests24Java8=1332314705000986815=%
>>> > > > 3Cdefault%3E=testDetails
>>> > > > >  Changes may led to failure were done by
>>> > > > >  - bessonov.ip
>>> > > > > http://ci.ignite.apache.org/viewModification.html?modId=
>>> > > > 831651=false
>>> > > > >
>>> > > > > - If your changes can led to this failure(s), please
>>> create
>>> > > issue
>>> > > > > with label MakeTeamCityGreenAgain and assign it to you.
>>> > > > > -- If you have fix, please set ticket to PA state and
>>> write
>>> > to
>>> > > > dev
>>> > > > > list fix is ready
>>> > > > > -- For case fix will require some time please mute test
>>> and
>>> > set
>>> > > > > label Muted_Test to issue
>>> > > > > - If you know which change caused failure please contact
>>> > change
>>> > > > > author directly
>>> > > > > - If you don't know which change caused failure please
>>> send
>>> > > > > message to dev list to find out
>>> > > > > Should you have any questions please contact
>>> dev@ignite.apache.org
>>> > > > > Best Regards,
>>> > > > > MTCGA.Bot
>>> > > > > Notification generated at Sat Sep 15 05:42:21 MSK 2018
>>> > > > >
>>> > > >
>>> > >
>>> >
>>>
>>


[GitHub] ignite pull request #4850: IGNITE-9661 Optimize partitions validation

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4850


---


[GitHub] zzzadruga opened a new pull request #27: IGNITE-9770 Add 'Re-run possible blockers' button

2018-10-04 Thread GitBox
zzzadruga opened a new pull request #27: IGNITE-9770 Add 'Re-run possible 
blockers' button
URL: https://github.com/apache/ignite-teamcity-bot/pull/27
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Apache Ignite 2.7 release

2018-10-04 Thread Alexey Kuznetsov
Hi, All!

I found a bug with *IGNITE_MBEANS_DISABLED* system property.
I created issue:  IGNITE-9792 Setting system property
*IGNITE_MBEANS_DISABLED* to true lead to NPE.

I think this one can be included into 2.7, because java docs
for IGNITE_MBEANS_DISABLED
 claims that "*This may be helpful if MBeans are not allowed e.g. for
security reasons.*"

The fix is trivial (one liner + simple text).

I can contribute the fix for this bug.

1. https://issues.apache.org/jira/browse/IGNITE-9792

-- 
Alexey Kuznetsov


[jira] [Created] (IGNITE-9792) Setting system property IGNITE_MBEANS_DISABLED to true lead to NPE.

2018-10-04 Thread Alexey Kuznetsov (JIRA)
Alexey Kuznetsov created IGNITE-9792:


 Summary: Setting system property IGNITE_MBEANS_DISABLED to true 
lead to NPE.
 Key: IGNITE-9792
 URL: https://issues.apache.org/jira/browse/IGNITE-9792
 Project: Ignite
  Issue Type: Bug
Reporter: Alexey Kuznetsov


Javadocs for IGNITE_MBEANS_DISABLED: "This may be helpful if MBeans are not 
allowed e.g. for security reasons."

So I set in code:

{code}

System.setProperty(IgniteSystemProperties.IGNITE_MBEANS_DISABLED, "true")

{code}

 

And on node start node failed with NPE:

{code}

Caused by: class org.apache.ignite.IgniteCheckedException: Unexpected exception 
when starting grid.
 at 
org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start0(IgnitionEx.java:2079)
 at 
org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start(IgnitionEx.java:1728)
 at org.apache.ignite.internal.IgnitionEx.start0(IgnitionEx.java:1156)
 at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:676)
 at org.apache.ignite.internal.IgnitionEx.start(IgnitionEx.java:601)
 at org.apache.ignite.Ignition.start(Ignition.java:323)
 ... 3 more
Caused by: java.lang.NullPointerException: Ouch! Argument cannot be null: 
cfg.getMBeanServer()
 at 
org.apache.ignite.internal.util.GridArgumentCheck.notNull(GridArgumentCheck.java:48)
 at 
org.apache.ignite.internal.IgniteKernal.validateCommon(IgniteKernal.java:1355)
 at org.apache.ignite.internal.IgniteKernal.start(IgniteKernal.java:833)
 at 
org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance.start0(IgnitionEx.java:2033)
 ... 8 more

{code}

 

The fix is trivial: in org.apache.ignite.internal.IgniteKernal#validateCommon

{code}

if (!U.IGNITE_MBEANS_DISABLED) // <<< The fix
    A.notNull(cfg.getMBeanServer(), "cfg.getMBeanServer()");

{code}

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-9790) Assertion error on full messages merge after coordinator failover

2018-10-04 Thread Alexey Goncharuk (JIRA)
Alexey Goncharuk created IGNITE-9790:


 Summary: Assertion error on full messages merge after coordinator 
failover
 Key: IGNITE-9790
 URL: https://issues.apache.org/jira/browse/IGNITE-9790
 Project: Ignite
  Issue Type: Bug
Reporter: Alexey Goncharuk






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-9789) "Starting Demo" message on top of Web console is rendered with delay,

2018-10-04 Thread Alexander Kalinin (JIRA)
Alexander Kalinin created IGNITE-9789:
-

 Summary: "Starting Demo" message on top of Web console is rendered 
with delay,
 Key: IGNITE-9789
 URL: https://issues.apache.org/jira/browse/IGNITE-9789
 Project: Ignite
  Issue Type: Bug
  Components: wizards
Reporter: Alexander Kalinin
Assignee: Alexander Kalinin






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (IGNITE-9791) Document: SQL query lazy mode is used by default

2018-10-04 Thread Taras Ledkov (JIRA)
Taras Ledkov created IGNITE-9791:


 Summary: Document: SQL query lazy mode is used by default
 Key: IGNITE-9791
 URL: https://issues.apache.org/jira/browse/IGNITE-9791
 Project: Ignite
  Issue Type: Task
  Components: documentation, sql
Affects Versions: 2.6
Reporter: Taras Ledkov
Assignee: Artem Budnikov
 Fix For: 2.7


We need to document changes in 'lazy' mode SQL query execution:
- since Ignite 2.7 the lazy mode is ON by default and user should use explicit 
{{lazy=false}} to disable it.
- but for JDBC, ODBC drivers and thin clients with version less than 2.7 lazy 
mode is false by default because the the default value is kept on the client  
side too.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] ignite pull request #4913: IGNITE-5935: WIP server origin transactions recov...

2018-10-04 Thread pavlukhin
GitHub user pavlukhin opened a pull request:

https://github.com/apache/ignite/pull/4913

IGNITE-5935: WIP server origin transactions recovery



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-5935-wip2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4913.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4913


commit 77dc283027793bee8831fe75c8947a825f81a539
Author: ipavlukhin 
Date:   2018-09-28T14:50:59Z

accumulate backups participating in transaction in 
GridDistributedTxMapping, retrieve them from received enlist response

commit 781dab6e0a2068acaaf859f4848f35c52327cc4f
Author: ipavlukhin 
Date:   2018-09-28T15:14:11Z

GridDistributedTxMapping normalize null backups to empty list

commit 090d17e40e56f45258a5a3f27c4da6e065343ed9
Author: ipavlukhin 
Date:   2018-09-28T15:32:01Z

pass backups to transaction mappings upon receiving response in 
GridNearTxEnlistFuture

commit 0d2446b27da80944d203cfd3c8a218a6904daa1c
Author: ipavlukhin 
Date:   2018-09-28T15:36:28Z

putIfAbsent -> put

commit 8d3eb13b40ba1bcd3fa70fa6af4c7af5ed521454
Author: ipavlukhin 
Date:   2018-09-28T15:48:16Z

remove outdated todo

commit 36a22a8b0ffc487dd47ab430057d185afdb81da9
Author: ipavlukhin 
Date:   2018-09-28T16:05:52Z

make backups in GridDistributedTxMapping thread-safe

commit 3ff50a1d2553d249f30858b478fc89986f344f8e
Author: ipavlukhin 
Date:   2018-09-28T16:07:41Z

add draft of a test

commit 9087ab222ad5b5ef41cb3ed5183d88ba5a141a77
Author: ipavlukhin 
Date:   2018-10-01T13:26:10Z

fix NPE occurring when enlist operation is finished by exception and 
response is null

commit caafe2fbad8c09fd07e5e8d1a5ed39c55aac0d7d
Author: ipavlukhin 
Date:   2018-10-02T05:30:54Z

Merge branch 'master' into ignite-5935

commit 8329bf39dcf83e65f44c69766b75a8d018da4191
Author: ipavlukhin 
Date:   2018-10-02T08:10:45Z

factor CacheMvccTxNodeMappingTest and add it to suite

commit 5866adc686ff6521bbed443e48d54a8e18fddd19
Author: ipavlukhin 
Date:   2018-10-02T08:21:13Z

test scenarios when near tx node is server

commit 2cc98761ee3bf0c241351c1da1154e3e0b537852
Author: ipavlukhin 
Date:   2018-10-02T13:47:17Z

get rid of extra method used in tests only

commit 9d77ac3d115d66f0b14dfc3997c1f5f8cc9626a5
Author: ipavlukhin 
Date:   2018-10-03T15:20:14Z

Merge branch 'master' into recover-tx-mvcc-exchange

commit dfa2c00472a4bced02e8e9e081ad9ece44e586f8
Author: ipavlukhin 
Date:   2018-10-03T15:25:52Z

allow tx recovery to start

commit 16cdef5c62fb84b62e0584036853f1941c14927f
Author: ipavlukhin 
Date:   2018-10-03T15:27:14Z

Long -> long

commit ddd6268c72789ec8b6a08029fc26e4b18733a8d6
Author: ipavlukhin 
Date:   2018-10-04T08:49:11Z

improve log message

commit fbffa348604ac750565b0b860ca9a45031336937
Author: ipavlukhin 
Date:   2018-10-04T08:50:46Z

cleanup orphaned server transactions on mvcc coordinator on exchange




---


Re: [ML] New features and improvement of ML module for 2.7 release

2018-10-04 Thread Alexey Zinoviev
Great, will wait video from summit.

чт, 4 окт. 2018 г. в 0:22, Denis Magda :

> >
> > It will be great if you can share your presentation/video after this
> summit
> > in dev-list.
>
>
> The video should be posted on this page in a couple of weeks:
>
> https://www.imcsummit.org/2018/us/session/scalable-machine-and-deep-learning-apache-ignite
>
> Did you use a TensorFlow integration stand in your presentation?
>
>
> Yes, could present and announce it. Yuri and Andrey helped me with the demo
> but, unfortunately, could show it because the organizers failed to set up
> my laptop and projector.
>
> --
> Denis
>
> On Wed, Oct 3, 2018 at 2:35 AM Alexey Zinoviev 
> wrote:
>
> > It will be great if you can share your presentation/video after this
> summit
> > in dev-list.
> > Did you use a TensorFlow integration stand in your presentation?
> >
> > Good news about potential users, it will be great to contact with
> somebody
> > who are going to use ML in production to discuss possible cases
> >
> > ср, 3 окт. 2018 г. в 6:29, Denis Magda :
> >
> > > Alexey,
> > >
> > > Thanks for spreading the word about the ML capabilities! *Prachi*,
> please
> > > help us to add the talks Alexey is going to give to Ignite events page:
> > > https://ignite.apache.org/events.html
> > >
> > > Btw, I gave a presentation about Ignite ML + TensorFlow integration
> today
> > > at IMC Summit in the US. It was perceived really well, was bombarded
> with
> > > many questions after the talk and think we've got some potential users
> ;)
> > >
> > > --
> > > Denis
> > >
> > > On Tue, Oct 2, 2018 at 8:54 AM Alexey Zinoviev  >
> > > wrote:
> > >
> > > > Currently, in release 2.7, the ignite ML has a parity with a Spark ML
> > by
> > > ML
> > > > algorithms, feature preprocessing and other capabilities.
> > > >
> > > > I'm going to talk about that in October on two conferences
> > > >
> > > > 1) [Ru] Yaroslavl, Open Source Distributed Machine Learning Library
> for
> > > > Apache Ignite https://yappidays.ru/talks.html#zinovev
> > > >
> > > > 2) [En] Minsk, Nuances of Machine Learning with Ignite ML,
> > > > https://jfuture.by/#talkbyAlexeyZinoviev
> > > >
> > > > After my previous event, JUG MSK, the new contributor @Ravil Galeyev
> > > joined
> > > > to our community, hope for new members from Yaroslavl and Minsk soon
> > > >
> > > >
> > > >
> > > > --
> > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
> > > >
> > >
> >
>


[GitHub] ignite pull request #4841: IGNITE-9705 GridCacheDatabaseSharedManager#create...

2018-10-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4841


---


[GitHub] SomeFire opened a new pull request #26: add git and JIRA URL samples

2018-10-04 Thread GitBox
SomeFire opened a new pull request #26: add git and JIRA URL samples
URL: https://github.com/apache/ignite-teamcity-bot/pull/26
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (IGNITE-9788) ML: IgniteDataset op is not loaded in TensorFlow worker

2018-10-04 Thread Anton Dmitriev (JIRA)
Anton Dmitriev created IGNITE-9788:
--

 Summary: ML: IgniteDataset op is not loaded in TensorFlow worker
 Key: IGNITE-9788
 URL: https://issues.apache.org/jira/browse/IGNITE-9788
 Project: Ignite
  Issue Type: Bug
  Components: ml
Affects Versions: 2.7
Reporter: Anton Dmitriev
Assignee: Anton Dmitriev
 Fix For: 2.7


Due to late changes in TensorFlow master (third-party library used by 
"TensorFlow on Apache Ignite") worker code now requires explicit import of 
operations declared in contrib package.

 

We have to explicitly import IgniteDataset op.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] ignite pull request #4912: IGNITE-9788: Import IgniteDataset explicitly in T...

2018-10-04 Thread dmitrievanthony
GitHub user dmitrievanthony opened a pull request:

https://github.com/apache/ignite/pull/4912

IGNITE-9788: Import IgniteDataset explicitly in TensorFlow worker code



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gridgain/apache-ignite ignite-9788

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4912.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4912


commit 3340ac5cb6be7bec02ff16db7c554ef01e31cf1b
Author: Anton Dmitriev 
Date:   2018-10-04T06:33:57Z

IGNITE-9788: Import IgniteDataset explicitly in TensorFlow worker code.




---