[GitHub] ignite pull request #5218: IGNITE-10077 Disable P2P class loading for CQ wit...
GitHub user dmekhanikov opened a pull request: https://github.com/apache/ignite/pull/5218 IGNITE-10077 Disable P2P class loading for CQ with autoUnsubscribe=false You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10077 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5218.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5218 commit f226a6f03587f3d6e98b934c1487d6502d90b045 Author: Denis Mekhanikov Date: 2018-10-31T06:36:29Z IGNITE-10077 Disable P2P class loading for CQ with autoUnsubscribe=false ---
[jira] [Created] (IGNITE-10077) P2P class loading shouldn't be applied to continuous queries with autoUnsubscribe=false
Denis Mekhanikov created IGNITE-10077:
-
Summary: P2P class loading shouldn't be applied to continuous
queries with autoUnsubscribe=false
Key: IGNITE-10077
URL: https://issues.apache.org/jira/browse/IGNITE-10077
Project: Ignite
Issue Type: Improvement
Reporter: Denis Mekhanikov
Assignee: Denis Mekhanikov
{{ContinuousQuery#autoUnsubscribe}} flag makes it possible to deploy a
continuous query, which won't be undeployed, when the subscriber node leaves.
P2P class loading is not applicable in these settings, because when the
subscriber leaves topology, it becomes impossible to load any classes from it
to new nodes.
So, P2P class loading should be disabled for continuous queries with
{{autoUnsubscribe=false}}
Dev list discussion:
[http://apache-ignite-developers.2346864.n4.nabble.com/Continuous-query-deployment-td36732.html]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Problem with reading incomplete payload - IGNITE-7153
Hi Yakov,
Thanks for your reply. :)
Please allow me to explain the whole situation and how to reproduce
the problem:
In the PR of IGNITE-7153, I added a test case under
RedisProtocolConnectSelfTest, sending some binary data via Jedis client,
large enough (> 8192 bytes) to reproduce the original problem of
IGNITE-7153 from my understanding.
Later on, I found another problem which I explain in the previous email
that payload is sometimes not fully read via
GridNioServer.processRead(). This,
however, does not seem to be a Redis protocol parsing problem.
Unfortunately, the only way that I found to reproduce this NioServer
packet-reading problem is to add a for-loop in the new test case. I would
say 95% of time, it will occur, i.e.
for(int i = 0; i < 100; i ++) {
String randomString1 = RandomStringUtils.random(8 << 10, true,
true); //8192
try (Jedis jedis = pool.getResource()) {
jedis.set("b1".getBytes(), randomString1.getBytes());
Assert.assertEquals(randomString1, jedis.get("b1"));
Thread.sleep(100);
}
}
For troubleshooting, I simply print out the content of ByteBuffer along the
data flow, and that is how I got packet in the previous email. I could try
to emulate the erroneous packet then add the added in another test case via
pure socket connection per your request. Thanks!
Regards,
Michael
On Tue, Oct 30, 2018 at 6:00 PM Yakov Zhdanov wrote:
> Michael, can you please share a reproducer? Is it possible to snapshot a
> packet that causes the error and just emulate packet send with manually
> opened socket bypassing Redis client lib?
>
> --Yakov
>
[jira] [Created] (IGNITE-10076) Web Console: Investigate big number parsing in JSON
Alexey Kuznetsov created IGNITE-10076: - Summary: Web Console: Investigate big number parsing in JSON Key: IGNITE-10076 URL: https://issues.apache.org/jira/browse/IGNITE-10076 Project: Ignite Issue Type: Improvement Components: wizards Reporter: Alexey Kuznetsov Assignee: Alexey Kuznetsov To fix issue with big numbers (see IGNITE-6570) we are using "json-bigint" library. And I found that it is not very effective (3x time slower that native JSON.parse()). Need to investigate. See also: [http://derpturkey.com/untitled/] [https://github.com/josdejong/lossless-json] https://github.com/sidorares/json-bigint -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: How to begin to contribute
Absolutely, I am glad to see this problem solved regardless whom the assignee is. After all, we are suffering this Redis problem in our Ignite PoC, and we are in urgency to solve this problem. I would be glad to provide my solution for you guys to apply if you think it is a good (enough) solution. :-) Regards, Michael On Tue, Oct 30, 2018 at 7:53 PM Dmitriy Pavlov wrote: > Hi Michael, > > I can see that https://issues.apache.org/jira/browse/IGNITE-7153 is > already > assigned to Roman Shtykh and is In Progress status. > > I hope Roman can step in and comment if he is interested in continuing of > developing this issue/or he could apply you PR as well. > > Sincerely, > Dmitriy Pavlov > > пн, 22 окт. 2018 г. в 11:33, Michael Fong : > > > Ah, never mind. I found out that I chose the wrong test suite to begin > with > > on Team City. :-) > > > > On Sun, Oct 21, 2018 at 10:20 PM Michael Fong > > wrote: > > > > > Hi, all, > > > > > > I happened to have a fix for IGNITE-7153 and created pull request for > > it. ( > > > https://github.com/apache/ignite/pull/5044) > > > > > > I tried to follow the How to Contribute Workflow > > > < > > > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Workflow > > > > but > > > kind of got stuck on TeamCity CI, where all the test suite build failed > > at > > > unrelated library (ignite-tool). Is there any other easier or more > > > intuitive CI or documentation to guide through the testing process? > > > > > > Furthermore, I wonder what would the code review process be, still via > > > github comment review? > > > > > > Regards, > > > > > > Michael > > > > > >
[jira] [Created] (IGNITE-10075) Avoid binary configurations of Ignite Java service params and result when calling it from Ignite.NET
Alexey Kukushkin created IGNITE-10075: - Summary: Avoid binary configurations of Ignite Java service params and result when calling it from Ignite.NET Key: IGNITE-10075 URL: https://issues.apache.org/jira/browse/IGNITE-10075 Project: Ignite Issue Type: Improvement Components: platforms Affects Versions: 2.6 Reporter: Alexey Kukushkin Assignee: Alexey Kukushkin Presently if there is an Ignite Java service taking parameters of complex (composite) types and returning a result of complex type then all the complex types must be explicitly specified in the binary configuration. We need to enhance Ignite not to require binary configuration assuming that we use the same type, package/namespace and field/property names on both the .NET and Java sides (or provide a custom name mapper for relaxed naming conventions). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10074) Structured Exception information is lost when Ignite .NET client calls Ignite Java service
Alexey Kukushkin created IGNITE-10074: - Summary: Structured Exception information is lost when Ignite .NET client calls Ignite Java service Key: IGNITE-10074 URL: https://issues.apache.org/jira/browse/IGNITE-10074 Project: Ignite Issue Type: Improvement Components: platforms Affects Versions: 2.6 Reporter: Alexey Kukushkin Suppose an Ignite service in Java throws *new ModelVerificationException(“ERROR!”)* to signal about a failure. An Ignite.NET client of such a Java service would receive this exception: Apache.Ignite.Core.Services.ServiceInvocationException * *Message*: Proxy method invocation failed with an exception. Examine InnerException for details. * *InnerException*: Apache.Ignite.Core.Common.IgniteException o *Message*: ERROR! o *InnerException*: Apache.Ignite.Core.Common.JavaException * *JavaClassName*: class org.apache.ignite.IgniteCheckedException * *JavaMessage*: ERROR! * *InnerException*: null * *Message*: class org.apache.ignite.IgniteCheckedException: ERROR! at org.apache.ignite.internal.util.IgniteUtils.cast(IgniteUtils.java:7332) at org.apache.ignite.internal.processors.platform.services.PlatformServices$ServiceProxyHolder.invoke(PlatformServices.java:589) at org.apache.ignite.internal.processors.platform.services.PlatformServices.processInObjectStreamOutObjectStream(PlatformServices.java:289) at org.apache.ignite.internal.processors.platform.PlatformTargetProxyImpl.inObjectStreamOutObjectStream(PlatformTargetProxyImpl.java:172) Caused by: ModelVerificationException: ERROR! at ... Ignite service wraps the custom ModelVerificationException in a IgniteCheckedException, which we get information for on the client side. There is no structured information about the custom exception in the client. We need to have information about the custom exception on the client. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10073) Ignite NuGet package without embedded Ignite JARs
Alexey Kukushkin created IGNITE-10073: - Summary: Ignite NuGet package without embedded Ignite JARs Key: IGNITE-10073 URL: https://issues.apache.org/jira/browse/IGNITE-10073 Project: Ignite Issue Type: Improvement Components: platforms Affects Versions: 2.6 Reporter: Alexey Kukushkin The existing Apache.Ignite NuGet package includes Ignite JARs deployed into the "libs" directory in the .NET project output directory upon the package installation. We prefer using external Ignite JARs from $IGNITE_HOME/libs instead of the JARs in the local libs directory. Right now we have to manually remove local "libs" directory after every Apache.Ignite package installation or upgrade. It would help us having another Ignite NuGet package without the embedded Ignite JARs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10072) Apache.Ignite NuGet package removes existing post-build actions
Alexey Kukushkin created IGNITE-10072: - Summary: Apache.Ignite NuGet package removes existing post-build actions Key: IGNITE-10072 URL: https://issues.apache.org/jira/browse/IGNITE-10072 Project: Ignite Issue Type: Bug Components: platforms Affects Versions: 2.6 Reporter: Alexey Kukushkin Assignee: Alexey Kukushkin Setup: # A *.csproj file with any one ore more post-build actions specified opened in Visual Studio Steps to reproduce: # In Visual Studio -> Package Manager Console run "Install-Package Apache.Ignite" # Open the csproj file in a test editor and check the post-build actions Expected: # Package Apache.Ignite installed OK # The initial post-build actions are still in the csproj file Actual: # As expected # The initial post-build actions are gone -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5217: ClusterNodeAttributeAffinityBackupFilter: make co...
GitHub user rynffoll opened a pull request: https://github.com/apache/ignite/pull/5217 ClusterNodeAttributeAffinityBackupFilter: make constructor public You can merge this pull request into a Git repository by running: $ git pull https://github.com/rynffoll/ignite feature/public-constructor-ClusterNodeAttributeAffinityBackupFilter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5217.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5217 commit fdb78a8b6d0331975e61df16af2f109b1bfed9a9 Author: Ruslan Kamashev Date: 2018-10-30T18:25:13Z Make constructor public ---
[GitHub] asfgit closed pull request #55: IGNITE-10071
asfgit closed pull request #55: IGNITE-10071 URL: https://github.com/apache/ignite-teamcity-bot/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dspavlov opened a new pull request #55: IGNITE-10071
dspavlov opened a new pull request #55: IGNITE-10071 URL: https://github.com/apache/ignite-teamcity-bot/pull/55 Background upload of a build and simultaneous bot restart may result in a queued build persisted but actually build is finished This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (IGNITE-10071) [TC Bot] Background upload of a build and simultaneous bot restart may result in a queued build persisted but actually build is finished
Dmitriy Pavlov created IGNITE-10071: --- Summary: [TC Bot] Background upload of a build and simultaneous bot restart may result in a queued build persisted but actually build is finished Key: IGNITE-10071 URL: https://issues.apache.org/jira/browse/IGNITE-10071 Project: Ignite Issue Type: Task Reporter: Dmitriy Pavlov Assignee: Dmitriy Pavlov TC bot new persistence based on continuous uploading builds from the TC server may become outdated during bot server restart. E.g. Run all which became completed in TC Bot's base may include queued/running builds, which may lead to missed test failures (As running build may not have these failures). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10070) SQL: If table not found, error message should contain full table name including schema.
Pavel Kuznetsov created IGNITE-10070: Summary: SQL: If table not found, error message should contain full table name including schema. Key: IGNITE-10070 URL: https://issues.apache.org/jira/browse/IGNITE-10070 Project: Ignite Issue Type: Improvement Components: sql Reporter: Pavel Kuznetsov If we do a query and we make a typo in the schema name or table name or if we make incorrect assumtions about default schema name, we won't see schema name in the error message. It's good for usability to print full table name SCHEMA.TABLE in the error message. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #4403: IGNITE-9009 Don't process backup updates for loca...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4403 ---
[jira] [Created] (IGNITE-10069) SQL implicit schema is incorrectly resolved in native api.
Pavel Kuznetsov created IGNITE-10069:
Summary: SQL implicit schema is incorrectly resolved in native api.
Key: IGNITE-10069
URL: https://issues.apache.org/jira/browse/IGNITE-10069
Project: Ignite
Issue Type: Bug
Components: sql
Reporter: Pavel Kuznetsov
Without explicit schema declaration (either sql syntax SCHEMA.TABLE or
SqlFieldsQuery#setSchema), do:
1) Create table using cache.query()
2) Perform select to this table
reproducer:
{noformat}
public void testSchema(){
IgniteCache c = ignite.getOrCreateCache("testCache");
c.query(new SqlFieldsQuery("CREATE TABLE TEST1 (ID LONG PRIMARY KEY,
VAL LONG) WITH \"template=replicated\";")).getAll();
c.query(new SqlFieldsQuery("SELECT * FROM TEST1")).getAll();
}
{noformat}
Got exception:
{noformat}
javax.cache.CacheException: Failed to parse query. Таблица "TEST1" не найдена
Table "TEST1" not found; SQL statement:
SELECT * FROM "testCache".TEST1 [42102-197]
at
org.apache.ignite.internal.processors.cache.IgniteCacheProxyImpl.query(IgniteCacheProxyImpl.java:697)
at
org.apache.ignite.internal.processors.cache.IgniteCacheProxyImpl.query(IgniteCacheProxyImpl.java:636)
at
org.apache.ignite.internal.processors.cache.GatewayProtectedCacheProxy.query(GatewayProtectedCacheProxy.java:388)
at
org.apache.ignite.internal.processors.query.h2.sql.ExplainSelfTest.testSchema(ExplainSelfTest.java:119)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at junit.framework.TestCase.runTest(TestCase.java:176)
at
org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2209)
at
org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:144)
at
org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:2124)
at java.lang.Thread.run(Thread.java:745)
Caused by: class
org.apache.ignite.internal.processors.query.IgniteSQLException: Failed to parse
query. Таблица "TEST1" не найдена
Table "TEST1" not found; SQL statement:
SELECT * FROM "testCache".TEST1 [42102-197]
at
org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.prepareStatementAndCaches(IgniteH2Indexing.java:2628)
at
org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.parseAndSplit(IgniteH2Indexing.java:2327)
at
org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing.querySqlFields(IgniteH2Indexing.java:2171)
at
org.apache.ignite.internal.processors.query.GridQueryProcessor$4.applyx(GridQueryProcessor.java:2141)
at
org.apache.ignite.internal.processors.query.GridQueryProcessor$4.applyx(GridQueryProcessor.java:2136)
at
org.apache.ignite.internal.util.lang.IgniteOutClosureX.apply(IgniteOutClosureX.java:36)
at
org.apache.ignite.internal.processors.query.GridQueryProcessor.executeQuery(GridQueryProcessor.java:2713)
at
org.apache.ignite.internal.processors.query.GridQueryProcessor.querySqlFields(GridQueryProcessor.java:2150)
at
org.apache.ignite.internal.processors.cache.IgniteCacheProxyImpl.query(IgniteCacheProxyImpl.java:685)
... 12 more
Caused by: org.h2.jdbc.JdbcSQLException: Таблица "TEST1" не найдена
Table "TEST1" not found; SQL statement:
SELECT * FROM "testCache".TEST1 [42102-197]
at org.h2.message.DbException.getJdbcSQLException(DbException.java:357)
at org.h2.message.DbException.get(DbException.java:179)
at org.h2.message.DbException.get(DbException.java:155)
at org.h2.schema.Schema.getTableOrView(Schema.java:506)
at org.h2.command.Parser.readTableOrView(Parser.java:5903)
at org.h2.command.Parser.readTableFilter(Parser.java:1430)
at org.h2.command.Parser.parseSelectSimpleFromPart(Parser.java:2138)
at org.h2.command.Parser.parseSelectSimple(Parser.java:2287)
at org.h2.command.Parser.parseSelectSub(Parser.java:2133)
at org.h2.command.Parser.parseSelectUnion(Parser.java:1946)
at org.h2.command.Parser.parseSelect(Parser.java:1919)
at org.h2.command.Parser.parsePrepared(Parser.java:463)
at org.h2.command.Parser.parse(Parser.java:335)
at org.h2.command.Parser.parse(Parser.java:307)
at org.h2.command.Parser.prepareCommand(Parser.java:278)
at org.h2.engine.Session.prepareLocal(Session.java:611)
at org.h2.engine.Session.prepareCommand(Session.java:549)
at org.h2.jdbc.JdbcConnection.prepareCommand(JdbcConnection.java:1247)
at
org.h2.jdbc.JdbcPreparedStatement.(JdbcPreparedStat
[GitHub] ignite pull request #5216: Ignite-1.9.15
GitHub user dmekhanikov opened a pull request: https://github.com/apache/ignite/pull/5216 Ignite-1.9.15 **Do not merge!** Created for testing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-1.9.15 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5216 commit 97d3f42c1c95a6aafce1d0c300ccfe6708398c17 Author: shtykh_roman Date: 2016-09-07T05:35:31Z IGNITE-3809: Fix for ArrayIndexOutOfBoundsException in GridUnsafeLru. (cherry picked from commit 31b9bb8) commit c2062d52a227dda5afee560d80c3bb4dd2ce09eb Author: dkarachentsev Date: 2017-07-19T05:41:46Z Remove empty test_utils.cpp commit 45cbba4853bab1ba4ffe2ea0d3add99a9d454aab Author: dkarachentsev Date: 2017-07-19T07:44:04Z IGNITE-5768 - Retry resolving class name from marshaller cache and .classname file. commit f24969f7e908645444df622642967a5f7fd3db23 Author: Evgenii Zhuravlev Date: 2017-07-19T16:30:07Z IGNITE 5775 JobsProcessor fix bug with delay in compute commit e5aab82f5629c2705e9bc82a7676f63c7c77062a Author: dkarachentsev Date: 2017-07-20T07:37:08Z Merge branch 'ignite-1.7.13' into ignite-1.8.9 # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/jdbc2/JdbcPreparedStatement.java # modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java commit 1544d3b63974ef8a96694cfc0681548fb4625a59 Author: Evgenii Zhuravlev Date: 2017-07-24T07:18:59Z Merge branch 'ignite-1.7.4-p2' into ignite-1.7.14 commit 7e5b479a9c48a6e272f8883f16d0ffa454e44046 Author: Andrey V. Mashenkov Date: 2017-07-24T10:27:52Z Merge remote-tracking branch 'origin/ignite-1.7.12-p1' into ignite-1.7.14 commit cc89a6a224ade08c92f44211dc144dc806c2b400 Author: dkarachentsev Date: 2017-07-26T08:19:19Z Merge branch 'ignite-1.8.9' into ignite-1.9.5 # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/MarshallerContextImpl.java # modules/core/src/test/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerImplSelfTest.java # modules/indexing/src/test/java/org/apache/ignite/testsuites/IgniteCacheQuerySelfTestSuite2.java # modules/platforms/cpp/core-test/src/test_utils.cpp commit f3adb9559b42698771b0b9b5116dd535446d2bef Author: vsisko Date: 2017-07-26T08:40:19Z IGNITE-5781 Visor throws ClassCastException if cache store implementation is other than CacheJdbcPojoStore. commit a58688f6cc6c5b114dcdd1b2fde43b7e1e5e0732 Author: vsisko Date: 2017-07-26T08:40:19Z IGNITE-5781 Visor throws ClassCastException if cache store implementation is other than CacheJdbcPojoStore. (cherry picked from commit f3adb95) commit 5b8963e38254fcac3bdd255a95adf9f733ce08f2 Author: vsisko Date: 2017-07-26T08:40:19Z IGNITE-5781 Visor throws ClassCastException if cache store implementation is other than CacheJdbcPojoStore. (cherry picked from commit f3adb95) commit 6c6264e93c378ff3f083528b46e673fefc76f471 Author: vsisko Date: 2017-07-26T08:48:27Z Merge remote-tracking branch 'community/ignite-1.9.5' into ignite-1.9.5 commit b7d1fb25ceba20b82631bb2e926a0ad52bf19e9d Author: sboikov Date: 2017-07-20T14:43:17Z Do not process partition exchange messages in striped pool. (cherry picked from commit 3a33706) commit c338bb9f5ac8f34dccbac1f7058765c5ce4549a4 Author: sboikov Date: 2017-07-20T14:49:55Z Removed unnecessary discoCache.updateAlives. (cherry picked from commit 07a0698) commit e7fbe8fba6bcd427bebf6ab6fa8746bc47b0d42f Author: Andrey V. Mashenkov Date: 2017-07-31T14:20:29Z IGNITE-4800: Lucene query may fails with NPE. commit 8c992fb8ba33a0c0ac5c0fb741ee8ffd515c0f31 Author: Evgenii Zhuravlev Date: 2017-08-01T14:46:27Z IGNITE-5775 Fix removing jobs from activeJobs for jobAlwaysActivate commit 114f10a243e41ef1dec0f35bef92cbf6a9a4f161 Author: Evgenii Zhuravlev Date: 2017-08-01T14:47:25Z Merge branch 'ignite-1.7.14' of https://github.com/gridgain/apache-ignite into ignite-1.7.14 commit eb3471075035d4d6ed3f54b3c26e929a6a097262 Author: Igor Sapego Date: 2017-08-01T15:30:54Z Fix for C++ tests commit 9f12a2d4bf333840df50d2a56478349f530b65c8 Author: Andrey V. Mashenkov Date: 2017-08-02T11:23:26Z IGNITE-4800: Test fixed. commit f0f1c82c8f9877d952f639ffe56803043e53415b Author: nikolay_tikhonov Date: 2017-08-04T11:58:52Z IGNITE-5290 Partial back port commit from master (42293fa sboikov on 29.05.2017 at 16:41) Signed-off-by: nikolay_tikhonov commit 3d64cf1a023ce71cf522b6ce843669fcf44a3145 Author: Ivan Rakov Date: 2017-03-30T11:56:40Z IGNITE-3477 - Fixed concurrent read-through
[jira] [Created] (IGNITE-10068) Update documentation for username and password handling in control.sh
Alexey Goncharuk created IGNITE-10068: - Summary: Update documentation for username and password handling in control.sh Key: IGNITE-10068 URL: https://issues.apache.org/jira/browse/IGNITE-10068 Project: Ignite Issue Type: Task Components: documentation Reporter: Alexey Goncharuk Need to update documentation on ./control.sh utility handling username and password according to the linked change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5079: IGNITE-9990 Control.sh utility should request a p...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5079 ---
[GitHub] ignite pull request #5191: IGNITE-10023
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5191 ---
Re: Starting with Apache Ignite
Hi Ruslan, Welcome to the Apache Software Foundation and to the Apache Ignite Community. I've added your account to the list of contributors. Now you should be able to assign an issue to yourself. Should you have any questions please do not hesitate to ask here. Looking forward to your contributions. Sincerely, Dmitriy Pavlov P.S. Additional references that should boost your onboarding. Please subscribe to both dev and user lists: https://ignite.apache.org/community/resources.html#mail-lists Get familiar with Apache Ignite development process described here: https://cwiki.apache.org/confluence/display/IGNITE/Development+Process Instructions on how to contribute can be found here: https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute Project setup in Intellij IDEA: https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup вт, 30 окт. 2018 г. в 17:47, Ruslan Gilemzyanov : > Hello, Ignite Community! > > My name is Ruslan. I want to contribute to Apache Ignite and want to > start with this issue https://issues.apache.org/jira/browse/IGNITE-8903 > JIRA username is ruslangm >
[GitHub] ignite pull request #5032: IGNITE-9935 Test fix.
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5032 ---
[GitHub] ignite pull request #4894: IGNITE-9673
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4894 ---
[GitHub] ignite pull request #5215: [DO NOT MERGE] IGNITE-9996: Investigration of per...
GitHub user nizhikov opened a pull request: https://github.com/apache/ignite/pull/5215 [DO NOT MERGE] IGNITE-9996: Investigration of performance drop. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nizhikov/ignite IGNITE-9996 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5215.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5215 commit cb68e975dd0e753ce360c48b4c2ed90cdad737bb Author: Nikolay Izhikov Date: 2018-10-30T14:56:23Z IGNITE-9996: Investigration of performance drop. ---
[GitHub] ignite pull request #4566: IGNITE-3653 Fix P2P class loading for remote filt...
GitHub user dmekhanikov reopened a pull request: https://github.com/apache/ignite/pull/4566 IGNITE-3653 Fix P2P class loading for remote filter and filter factory in CQs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3653 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4566.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4566 commit f33c53d8895d5b9764fc3daddc213aa0f530e06d Author: Denis Mekhanikov Date: 2018-08-17T12:18:01Z IGNITE-3653 Add tests. commit c598082d504f6b9f8bde4e020be3e4960da9b7ff Author: Denis Mekhanikov Date: 2018-08-17T14:32:04Z IGNITE-3653 Call p2pUnmarshal() before registering CQ handler on data exchange. commit 5a0423aaab7f9c36552da5464ce143750bb385fd Author: Denis Mekhanikov Date: 2018-09-05T12:21:45Z IGNITE-3653 Use GridToStringBuilder for CacheContinuousQueryDeployableObject. commit d7ffa09674ddc3780ae3a9c6cade63cc4e0c7bc7 Author: Denis Mekhanikov Date: 2018-09-06T08:13:23Z IGNITE-3653 Check that P2P class loading is enabled. commit 6531f2a28504586cc3294aa71ca6f4a871e5cf42 Author: Denis Mekhanikov Date: 2018-10-19T12:36:26Z IGNITE-3653 Exclude bytes from CacheContinuousQueryDeployableObject.toString ---
[jira] [Created] (IGNITE-10067) Tracking progress of index building
Stanislav Lukyanov created IGNITE-10067: --- Summary: Tracking progress of index building Key: IGNITE-10067 URL: https://issues.apache.org/jira/browse/IGNITE-10067 Project: Ignite Issue Type: Bug Reporter: Stanislav Lukyanov When a new index is being created or indexes are being rebuilt in case a node is restarted without index.bin, the performance of queries is low until the index is ready. It would be good to track the process of indexing to have an approximate completion time. Currently we only have "started" and "finished" messages in the logs for each index. It would be good to also know - All indexes to be built - Number (+ percentage?) of processed entries (or pages, if it's hard to update progress for each entry) - Number (+ percentage?) of entries left It seems reasonable to start collecting this data and just print it in the logs for now. `metricsLogFrequency` could be reused as the frequency of logging. After community has some experience with using this, this metrics could be exposed via Java API/JMX/etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #4566: IGNITE-3653 Fix P2P class loading for remote filt...
Github user dmekhanikov closed the pull request at: https://github.com/apache/ignite/pull/4566 ---
Starting with Apache Ignite
Hello, Ignite Community! My name is Ruslan. I want to contribute to Apache Ignite and want to start with this issue https://issues.apache.org/jira/browse/IGNITE-8903 JIRA username is ruslangm
[GitHub] ignite pull request #5214: IGNITE-9975 Set partition counters to 0 when rese...
GitHub user akalash opened a pull request: https://github.com/apache/ignite/pull/5214 IGNITE-9975 Set partition counters to 0 when reset lost partitions You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9975 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5214 commit 5a009467ceb96763c58f297838f4cfb44c974bf8 Author: Anton Kalashnikov Date: 2018-10-30T14:41:59Z IGNITE-9975 Set partition counters to 0 when reset lost partitions ---
[jira] [Created] (IGNITE-10066) Missing key and value validation for MVCC tables
PetrovMikhail created IGNITE-10066:
--
Summary: Missing key and value validation for MVCC tables
Key: IGNITE-10066
URL: https://issues.apache.org/jira/browse/IGNITE-10066
Project: Ignite
Issue Type: Bug
Reporter: PetrovMikhail
It seems that key and value constraints for MVCC tables are ignoring now when
code approach is using to operate with table. The same SQL requests work fine.
It seems that QueryTypeDescriptorImpl.validateKeyAndValue method call which
provides corresponding constraints is missed now.
Reproducer for not null constraint:
{code:java}
public class IgniteCacheTransactionalSnapshotNullConstraintTest extends
GridCommonAbstractTest {
private static final String REPLICATED_CACHE_NAME = "replicatedCacheName";
private static final String PARTITIONED_CACHE_NAME = "partitionedCacheName";
@Override protected void beforeTestsStarted() throws Exception {
startGrid(0);
execSQL("CREATE TABLE table(id INT PRIMARY KEY, str VARCHAR NOT NULL)
WITH \"atomicity=transactional_snapshot\"");
jcache(grid(0), cacheConfiguration(REPLICATED, TRANSACTIONAL_SNAPSHOT),
REPLICATED_CACHE_NAME);
jcache(grid(0), cacheConfiguration(PARTITIONED,
TRANSACTIONAL_SNAPSHOT), PARTITIONED_CACHE_NAME);
}
protected CacheConfiguration cacheConfiguration(CacheMode cacheMode,
CacheAtomicityMode atomicityMode) {
CacheConfiguration cfg = new CacheConfiguration();
cfg.setCacheMode(cacheMode);
cfg.setAtomicityMode(atomicityMode);
cfg.setWriteSynchronizationMode(FULL_SYNC);
cfg.setQueryEntities(Collections.singletonList(new
QueryEntity(Integer.class, Person.class)));
return cfg;
}
public void testPutNullValueReplicatedModeFail() throws Exception {
IgniteCache cache = jcache(0, REPLICATED_CACHE_NAME);
assertThrowsWithCause(() -> {
cache.put(0, new Person(null, 25));
}, IgniteException.class);
}
public void testPutNullValuePartitionedModeFail() throws Exception {
IgniteCache cache = jcache(0, PARTITIONED_CACHE_NAME);
assertThrowsWithCause(() -> {
cache.put(1, new Person(null, 18));
}, IgniteException.class);
}
public void testPutNullValueSQLFail() throws Exception {
checkSQLThrows("INSERT INTO table VALUES(?, ?)", NULL_VALUE, 0, null);
}
public static class Person implements Serializable {
@QuerySqlField(notNull = true)
private String name;
@QuerySqlField
private int age;
public Person(String name, int age) {
this.name = name;
this.age = age;
}
}
private void checkSQLThrows(String sql, String sqlStateCode, Object...
args) {
IgniteSQLException err =
(IgniteSQLException)GridTestUtils.assertThrowsWithCause(() -> {
execSQL(sql, args);
return 0;
}, IgniteSQLException.class);
assertEquals((err).sqlState(), sqlStateCode);
}
private List execSQL(String sql, Object... args) {
SqlFieldsQuery qry = new SqlFieldsQuery(sql)
.setArgs(args);
return grid(0).context().query().querySqlFields(qry, true).getAll();
}
}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-10065) possibility to get EVT_CACHE_STARTED before cache proxy initialization
ARomantsov created IGNITE-10065: --- Summary: possibility to get EVT_CACHE_STARTED before cache proxy initialization Key: IGNITE-10065 URL: https://issues.apache.org/jira/browse/IGNITE-10065 Project: Ignite Issue Type: Bug Components: cache Affects Versions: 2.7 Reporter: ARomantsov Fix For: 2.8 It looks , I can take EVT_CACHE_STARTED before take message - Finish proxy initialization, cacheName=cache -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #4898: 9769 tests
Github user SomeFire closed the pull request at: https://github.com/apache/ignite/pull/4898 ---
[GitHub] ignite pull request #4897: IGNITE-9769 IgniteCacheAtomicProtocolTest.testPut...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4897 ---
[GitHub] ignite pull request #5213: Sock timeout
GitHub user SpiderRus opened a pull request: https://github.com/apache/ignite/pull/5213 Sock timeout You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9840 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5213 commit 215827ea50d7a54fe6f3bfee1477df1d3720ebcf Author: Alexey Stelmak Date: 2018-10-30T14:01:36Z Debug ---
[jira] [Created] (IGNITE-10064) Build examples project failed
Sergey Kozlov created IGNITE-10064:
--
Summary: Build examples project failed
Key: IGNITE-10064
URL: https://issues.apache.org/jira/browse/IGNITE-10064
Project: Ignite
Issue Type: Bug
Components: examples
Affects Versions: 2.7
Reporter: Sergey Kozlov
Fix For: 2.7
1. Import {{examples/pom.xml}} in IDEA and compile
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on
project ignite-examples: Compilation failure: Compilation failure:
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringAppCfg.java:[25,49]
package org.apache.ignite.springdata20.repository does not exist
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringAppCfg.java:[26,56]
package org.apache.ignite.springdata20.repository.config does not exist
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringAppCfg.java:[27,57]
package org.apache.ignite.springdata20.repository.support does not exist
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringAppCfg.java:[43,2]
cannot find symbol
[ERROR] symbol: class EnableIgniteRepositories
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/PersonRepository.java:[23,49]
package org.apache.ignite.springdata20.repository does not exist
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/PersonRepository.java:[24,56]
package org.apache.ignite.springdata20.repository.config does not exist
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/PersonRepository.java:[25,56]
package org.apache.ignite.springdata20.repository.config does not exist
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/PersonRepository.java:[34,43]
cannot find symbol
[ERROR] symbol: class IgniteRepository
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/PersonRepository.java:[33,2]
cannot find symbol
[ERROR] symbol: class RepositoryConfig
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/PersonRepository.java:[56,6]
cannot find symbol
[ERROR] symbol: class Query
[ERROR] location: interface
org.apache.ignite.examples.springdata.PersonRepository
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringDataExample.java:[62,13]
cannot find symbol
[ERROR] symbol: method deleteAll()
[ERROR] location: variable repo of type
org.apache.ignite.examples.springdata.PersonRepository
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringDataExample.java:[64,60]
cannot find symbol
[ERROR] symbol: method count()
[ERROR] location: variable repo of type
org.apache.ignite.examples.springdata.PersonRepository
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringDataExample.java:[101,13]
cannot find symbol
[ERROR] symbol: method
save(java.util.TreeMap)
[ERROR] location: variable repo of type
org.apache.ignite.examples.springdata.PersonRepository
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringDataExample.java:[103,49]
cannot find symbol
[ERROR] symbol: method count()
[ERROR] location: variable repo of type
org.apache.ignite.examples.springdata.PersonRepository
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringDataExample.java:[111,29]
cannot find symbol
[ERROR] symbol: method findById(long)
[ERROR] location: variable repo of type
org.apache.ignite.examples.springdata.PersonRepository
[ERROR]
/C:/Work/2.7/examples/src/main/java/org/apache/ignite/examples/springdata/SpringDataExample.java:[122,40]
cannot find symbol
[ERROR] symbol: method findAllById(java.util.ArrayList)
[ERROR] location: variable repo of type
org.apache.ignite.examples.springdata.PersonRepository
[ERROR] -> [Help 1]
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] ignite pull request #5212: IGNITE-9420 Logical recovery before PME
GitHub user Jokser opened a pull request: https://github.com/apache/ignite/pull/5212 IGNITE-9420 Logical recovery before PME You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9420-squash Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5212 commit 79202a948d6605129e6fbc85cbbe679c78d83aeb Author: Pavel Kovalenko Date: 2018-10-30T13:42:53Z IGNITE-9420 Logical recovery before PME ---
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229273660 ## File path: ignite-tc-helper-web/src/main/webapp/visas.html ## @@ -0,0 +1,151 @@ + + + + +Ignite Teamcity - Visas history + +https://code.jquery.com/jquery-1.12.4.js";> +https://code.jquery.com/ui/1.12.1/jquery-ui.js";> +https://cdn.jsdelivr.net/momentjs/latest/moment.min.js";> +https://cdn.jsdelivr.net/npm/daterangepicker/daterangepicker.min.js";> +https://cdn.jsdelivr.net/npm/daterangepicker/daterangepicker.css"; /> + +https://code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css";> + +https://d3js.org/d3.v4.min.js";> +https://cdn.datatables.net/1.10.16/js/jquery.dataTables.js";> +https://cdn.datatables.net/1.10.16/js/dataTables.jqueryui.js";> +https://code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css";> +https://cdn.datatables.net/1.10.16/css/jquery.dataTables.min.css";> + + + + + + + + +. +. +. +. +. +. + + + + + +
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229284966
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/TcHelper.java
##
@@ -193,61 +216,87 @@ private String generateJiraComment(
Map> fails =
findFailures(server);
-for (List suites : fails.values()) {
-for (SuiteCurrentStatus suite : suites) {
-
res.append("{color:#d04437}").append(suite.name).append("{color}");
-res.append(" [[tests ").append(suite.failedTests);
+fails.entrySet().forEach(e -> res.addAll(e.getValue()));
+}
+}
+
+return res;
+}
+
+/** */
+private String generateJiraComment(List suites, String
webUrl) {
+StringBuilder res = new StringBuilder();
-if (suite.result != null && !suite.result.isEmpty())
-res.append(' ').append(suite.result);
+for (SuiteCurrentStatus suite : suites) {
+res.append("{color:#d04437}").append(suite.name).append("{color}");
+res.append(" [[tests ").append(suite.failedTests);
-
res.append('|').append(suite.webToBuild).append("]]\\n");
+if (suite.result != null && !suite.result.isEmpty())
+res.append(' ').append(suite.result);
-for (TestFailure failure : suite.testFailures) {
-res.append("* ");
+res.append('|').append(suite.webToBuild).append("]]\\n");
-if (failure.suiteName != null && failure.testName
!= null)
-res.append(failure.suiteName).append(":
").append(failure.testName);
-else
-res.append(failure.name);
+for (TestFailure failure : suite.testFailures) {
+res.append("* ");
-FailureSummary recent =
failure.histBaseBranch.recent;
+if (failure.suiteName != null && failure.testName != null)
+res.append(failure.suiteName).append(":
").append(failure.testName);
+else
Review comment:
Remove empty line before closing brace.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229307325
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/TcBotTriggerAndSignOffService.java
##
@@ -69,11 +75,60 @@
/** Helper. */
@Inject ITcHelper tcHelper;
+/** */
+SimpleDateFormat formatter = new SimpleDateFormat("-MM-dd HH:mm:ss");
+
/** */
public void startObserver() {
buildObserverProvider.get();
}
+/** */
+public List getVisasStatus(String srvId, ICredentialsProv
prov) {
+List visaStatuses = new ArrayList<>();
+
+IAnalyticsEnabledTeamcity teamcity = tcHelper.server(srvId, prov);
+
+for (VisaRequest visaRequest :
tcHelper.getVisasHistoryStorage().getVisas()) {
+VisaStatus visaStatus = new VisaStatus();
+
+BuildsInfo info = visaRequest.getInfo();
+
+Visa visa = visaRequest.getResult();
+
+visaStatus.date = formatter.format(info.date);
+visaStatus.branchName = info.branchName;
+visaStatus.userName = info.userName;
+visaStatus.ticket = info.ticket;
+
+if (info.isFinished(teamcity)) {
+if (visa != null && visa.isSuccess()) {
+visaStatus.commentUrl =
"https://issues.apache.org/jira/browse/"; + visaStatus.ticket +
+"?focusedCommentId=" +
visa.getJiraCommentResponse().getId() +
+
"&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-"
+
+visa.getJiraCommentResponse().getId();
+
+visaStatus.blockers =
visa.getSuitesStatuses().stream().mapToInt(suite ->
+suite.testFailures.size()).sum();
+
+visaStatus.state = BuildsInfo.FINISHED_STATE;
+}
+else if (visa != null && !visa.isSuccess())
+visaStatus.state = BuildsInfo.FINISHED_WITH_FAILURES_STATE;
+
Review comment:
Remove empty line.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229271532
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/ITcHelper.java
##
@@ -69,5 +74,5 @@
* @param ticket JIRA ticket full name.
* @return {@code True} if JIRA was notified.
*/
-String notifyJira(String srvId, ICredentialsProv prov, String buildTypeId,
String branchForTc, String ticket);
+Visa notifyJira(String srvId, ICredentialsProv prov, String buildTypeId,
String branchForTc, String ticket);
Review comment:
Change javadoc too.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229276186
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
##
@@ -58,10 +63,16 @@ public void stop() {
/**
* @param srvId Server id.
* @param prov Credentials.
+ * @param ticket Ticket.
+ * @param branch Branch.
* @param ticket JIRA ticket name.
*/
-public void observe(String srvId, ICredentialsProv prov, String ticket,
Build... builds) {
-observerTask.addBuild(new BuildsInfo(srvId, prov, ticket, builds));
+public void observe(String srvId, ICredentialsProv prov, String ticket,
String branch, Build... builds) {
Review comment:
Rename `branch` to `branchForTc`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229284314
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/TcHelper.java
##
@@ -144,44 +160,51 @@ private BranchesTracked getTrackedBranches() {
List builds =
teamcity.getFinishedBuildsIncludeSnDepFailed(buildTypeId, branchForTc);
if (builds.isEmpty())
-return "JIRA wasn't commented - no finished builds to analyze.";
+return new Visa().setStatus("JIRA wasn't commented - no finished
builds to analyze.");
BuildRef build = builds.get(builds.size() - 1);
-String comment;
+
+List suitesStatuses;
+
+JiraCommentResponse response;
try {
-comment = generateJiraComment(buildTypeId, build.branchName,
srvId, prov, build.webUrl);
+suitesStatuses = getSuitesStatuses(buildTypeId, build.branchName,
srvId, prov);
+
+String comment = generateJiraComment(suitesStatuses, build.webUrl);
+
+response = objectMapper.readValue(teamcity.sendJiraComment(ticket,
comment),
+JiraCommentResponse.class);
Review comment:
Remove empty line before closing brace.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229272122
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/VisasHistoryStorage.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.ci.web.model.hist;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.Date;
+import java.util.List;
+import java.util.Objects;
+import javax.cache.Cache;
+import javax.inject.Inject;
+import javax.inject.Provider;
+import org.apache.ignite.Ignite;
+import org.apache.ignite.ci.db.TcHelperDb;
+import org.apache.ignite.ci.observer.BuildsInfo;
+import org.apache.ignite.ci.web.model.Visa;
+import org.apache.ignite.ci.web.model.VisaRequest;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ *
+ */
+public class VisasHistoryStorage {
+/** */
+private static final String VISAS_CACHE_NAME = "visasCache";
+
+/** */
+@Inject
+private Ignite ignite;
+
+/** */
+public void clear() {
+visas().clear();
+}
+
+/** */
+private Cache visas() {
+return
ignite.getOrCreateCache(TcHelperDb.getCacheV2TxConfig(VISAS_CACHE_NAME));
+}
+
+/** */
+public void put(VisaRequest visaRequest) {
+visas().put(visaRequest.getInfo().date, visaRequest);
+}
+
+/** */
+@Nullable public VisaRequest get(Date date) {
+return visas().get(date);
+}
+
+/** */
+public boolean updateVisaRequestResult(Date date, Visa visa) {
+VisaRequest visaRequest = visas().get(date);
Review comment:
Rename `visaRequest` to `visaReq` or simple `req`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229308341
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/tcbot/visa/VisaStatus.java
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.ci.tcbot.visa;
+
+import org.jetbrains.annotations.Nullable;
+
+/**
+ *
+ */
+public class VisaStatus {
+/** */
+@Nullable public String userName;
+
+/** Branch name. */
+@Nullable public String branchName;
+
+/** JIRA ticket full name. */
+@Nullable public String ticket;
+
+/** */
+@Nullable public String state;
+
+/** */
+@Nullable public String commentUrl;
+
+/** */
+@Nullable public String date;
+
+/** */
+@Nullable public int blockers;
Review comment:
Can't be null.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229283280
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/TcHelper.java
##
@@ -193,61 +216,87 @@ private String generateJiraComment(
Map> fails =
findFailures(server);
-for (List suites : fails.values()) {
-for (SuiteCurrentStatus suite : suites) {
-
res.append("{color:#d04437}").append(suite.name).append("{color}");
-res.append(" [[tests ").append(suite.failedTests);
+fails.entrySet().forEach(e -> res.addAll(e.getValue()));
Review comment:
Redundant call `.entrySet()`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229273513
##
File path: ignite-tc-helper-web/src/main/webapp/visas.html
##
@@ -0,0 +1,151 @@
+
+
+
+
+Ignite Teamcity - Visas history
+
+https://code.jquery.com/jquery-1.12.4.js";>
+https://code.jquery.com/ui/1.12.1/jquery-ui.js";>
+https://cdn.jsdelivr.net/momentjs/latest/moment.min.js";>
+https://cdn.jsdelivr.net/npm/daterangepicker/daterangepicker.min.js";>
+https://cdn.jsdelivr.net/npm/daterangepicker/daterangepicker.css"; />
+
+https://code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css";>
+
+https://d3js.org/d3.v4.min.js";>
+https://cdn.datatables.net/1.10.16/js/jquery.dataTables.js";>
+https://cdn.datatables.net/1.10.16/js/dataTables.jqueryui.js";>
+https://code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css";>
+https://cdn.datatables.net/1.10.16/css/jquery.dataTables.min.css";>
+
+
+
+
+
+
+
+
+.
+.
+.
+.
+.
+.
+
+
+
+
+
+
+function showErrInLoadStatus(jqXHR, exception) {
+if (jqXHR.status === 0) {
+$("#loadStatus").html('Not connect.\n Verify Network.');
+} else if (jqXHR.status === 404) {
+$("#loadStatus").html('Requested page not found. [404]');
+} else if (jqXHR.status === 401) {
+$("#loadStatus").html('Unauthorized [401]');
+
+setTimeout(function() {
+window.location.href = "/login.html" + "?backref=" +
encodeURIComponent(window.location.href);
+}, 1000);
+} else if (jqXHR.status === 403) {
+$("#loadStatus").html('Forbidden [403]');
+} else if( jqXHR.status === 418) {
+$("#loadStatus").html('Services are starting [418], I\'m a teapot');
+} else if (jqXHR.status === 424) {
+$("#loadStatus").html('Dependency problem: [424]: ' +
jqXHR.responseText);
+} else if (jqXHR.status === 500) {
+$("#loadStatus").html('Internal Server Error [500].');
+} else if (exception === 'parsererror') {
+$("#loadStatus").html('Requested JSON parse failed.');
+} else if (exception === 'timeout') {
+$("#loadStatus").html('Time out error.');
+} else if (exception === 'abort') {
+$("#loadStatus").html('Ajax request aborted.');
+} else {
+$("#loadStatus").html('Uncaught Error.\n' + jqXHR.responseText);
+}
+}
+
+$(document).ready(function() {
+loadData();
+
+$.ajax({ url: "rest/branches/version", success: showVersionInfo, error:
showErrInLoadStatus });
+});
+
+function showVisasTable(result) {
+let visasTable = $('#visasTable');
+
+visasTable.dataTable().fnDestroy();
+
+var table = visasTable.DataTable({
+"order": [[ 1, 'desc' ]],
+data: result,
+"iDisplayLength": 30, //rows to be shown by default
+stateSave: true,
+columnDefs: [
+{
+targets: '_all',
+className: 'dt-body-center'
+},
+],
+columns: [
+{
+"data": "state",
+title: "Status",
+"render": function (data, type, row, meta) {
+if (type === 'display') {
+if (data ==='finished' && row.commentUrl)
+data = "" + data
+ "";
+}
+
+return data;
+}
+},
+{
+"data": "date",
+title: "Date"
+},
+{
+"data": "userName",
+title: "User"
+},
+{
+"data": "branchName",
+title: "Branch"
+},
+{
+"data": "ticket",
+title: "Ticket"
+},
+{
+"data": "blockers",
+title: "Blockers",
+"render": function (data, type, row, meta) {
+if (type === 'display') {
+if (row.state != 'finished')
+data = "";
+}
+
+return data;
+}
+}
+
+]
+});
+}
+
+function loadData() {
+$.ajax(
+{
+url: "rest/visa/history?serverId=apache",
+success: function (result) {
+showVisasTable(result);
+},
+error: showErrInLoadStatus
+}
+);
+}
+
+
+
Review comment:
Missed last empty line.
This
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229282683
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Visa.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.ci.web.model;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Objects;
+import org.apache.ignite.ci.TcHelper;
+import org.apache.ignite.ci.jira.IJiraIntegration;
+import org.apache.ignite.ci.web.model.current.SuiteCurrentStatus;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ *
+ */
+public class Visa {
+/** */
+@Nullable private String status;
Review comment:
Make fields final and replace setters by 2 constructors: with status only
and with all fields.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229282722 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/Visa.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.ci.web.model; + +import java.util.ArrayList; Review comment: Unused import. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229273410 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/hist/VisasHistoryStorage.java ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.ci.web.model.hist; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.Date; +import java.util.List; +import java.util.Objects; +import javax.cache.Cache; +import javax.inject.Inject; +import javax.inject.Provider; Review comment: Unused import. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver
UNKNOWN build state handling added
URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229275815
##
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildsInfo.java
##
@@ -40,37 +54,68 @@
/** JIRA ticket full name. */
public final String ticket;
+/** */
+public final Date date;
+
/** Finished builds. */
-private final Map finishedBuilds = new HashMap<>();
+private final Map finishedBuilds = new HashMap<>();
/**
* @param srvId Server id.
* @param prov Prov.
* @param ticket Ticket.
* @param builds Builds.
*/
-public BuildsInfo(String srvId, ICredentialsProv prov, String ticket,
Build[] builds) {
+public BuildsInfo(String srvId, ICredentialsProv prov, String ticket,
String branchName, Build... builds) {
Review comment:
Rename `branchName` to `branchForTc`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added
SomeFire commented on a change in pull request #40: IGNITE-9939 BuildObserver UNKNOWN build state handling added URL: https://github.com/apache/ignite-teamcity-bot/pull/40#discussion_r229304648 ## File path: ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/ObserverTask.java ## @@ -31,7 +32,9 @@ import org.apache.ignite.ci.di.MonitoredTask; import org.apache.ignite.ci.jira.IJiraIntegration; import org.apache.ignite.ci.user.ICredentialsProv; +import org.apache.ignite.ci.web.model.VisaRequest; Review comment: Unused import. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: hello
Hi Scott, I've added your account to the list of contributors, so you can now assign an issue to yourself. I've also assigned https://issues.apache.org/jira/browse/IGNITE-9893 to you, I hope you don't mind. Sincerely, Dmitriy Pavlov чт, 25 окт. 2018 г. в 21:36, Denis Magda : > Hi Scott, > > Thanks, the contributions looks valuable to me. As I see a community member > is already working with you. Hope the code will be merged soon! > > -- > Denis > > On Thu, Oct 25, 2018 at 10:59 AM Scott Feldstein > wrote: > > > Hi Denis, > > Thanks! > > > > This is what I'm trying to contribute > > jira: https://issues.apache.org/jira/browse/IGNITE-9893 > > pullRequest: https://github.com/apache/ignite/pull/5008 > > > > WRT the blog, we actually discussed this at the in-memory conference. At > > the beginning of the year we'll start to make our usage more public > > internally and externally if all goes well :) > > > > Scott > > > > On Wed, Oct 24, 2018 at 7:44 PM Denis Magda wrote: > > > > > Hey Scott, > > > > > > Great to know, welcome to the community! > > > > > > What exactly do you like to contribute back? Please start a separate > > > discussion with the most meaningful topic. > > > > > > Also, if you can post a blog post about your architecture at VMWare > will > > be > > > glad to mention it on the "Ignite in Production" page: > > > https://ignite.apache.org/provenusecases.html > > > > > > -- > > > Denis > > > > > > On Wed, Oct 24, 2018 at 7:39 PM Scott Feldstein > > > wrote: > > > > > > > Hi Everyone, > > > > I'm following the instructions from > > > > https://ignite.apache.org/community/contribute.html. I'd like to > > > > contribute > > > > some of the code I've been working on in order to continue evolving > > > Ignite. > > > > > > > > I've been evangelizing Ignite at VMware and am in the process of > > locking > > > > down our next-gen service architecture. The plan is to use Ignite > as a > > > > multi-faceted caching server on steriods! > > > > > > > > Please feel free to reach out to me and say hi as well :) > > > > > > > > Scott > > > > > > > > > >
Re: Abbreviation code-style requirement.
Guys, I am sorry I missed this discussion. Apparently, abbreviations use is far from being the biggest problem in the project. I think everyone agrees here. I vote for leaving abbreviations mandatory, and would be strongly against making them optional since we will endup in situation when different lines of the same method or class will contain abbreviated and non-abbreviated variables, fields and parameters names. This will look ugly. I think nobody thought about source files that are several thousands lines long. Undo abbreviations throughout the entire project is hard work, pretty stupid to do on such huge code base and I am sure will introduce problems and failures on TeamCity. Instead I want to suggest the following: 1. Abbreviations stay mandatory. Making them optional does not make any sense. 2. List of abbreviations should be shortened to up to 20 items and we should leave only those which are common sense. 3. Contributor may also choose to use full words in complex variable names if there is a mix of abbreviated and non-abbreviated words if this helps with readability. I will suggest shorter abbreviations list today or tomorrow and let you know in this thread. Thanks! --Yakov
[jira] [Created] (IGNITE-10063) MVCC SQL: Tx SQL commands are not supported in multistatements
Ivan Pavlukhin created IGNITE-10063:
---
Summary: MVCC SQL: Tx SQL commands are not supported in
multistatements
Key: IGNITE-10063
URL: https://issues.apache.org/jira/browse/IGNITE-10063
Project: Ignite
Issue Type: Bug
Reporter: Ivan Pavlukhin
Is is possible to execute multiple statements in single JDBC call like:
{code:sql}UPDATE t1 SET b = '2'; COMMIT{code}
Currently tx commands fail to execute if passed in such multistatement. Tx
commands are e.g. {{BEGIN}}, {{COMMIT}}, {{ROLLBACK}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: Apache Ignite 2.7. Last Mile
Hello Nikolay, Igniters, It seems that we lost the following commit that should be included in 'ignite-2.7' branch (It looks like the change was not accidentally cherry-picked from 'master' to 'ignite-2.7') - https://github.com/apache/ignite/commit/6e0ff06f8e309657a16c94da605348d9c3b804ad The most important part is the change introduced into GridDhtAtomicCache, the fix prevents NullPointerException during cache updates under some circumstances. So, I propose including the fix into ignite-2.7, at least the change of GridDhtAtomicCache. Thanks, Slava. пн, 29 окт. 2018 г. в 11:20, Nikolay Izhikov : > Hello, guys. > > For today we have 11 tickets mapped to 2.7 > > IGNITE-10010 Alexey Goncharuk Node halted if second node was stopped, then > cache destroyed, then second node returned > IGNITE-10015 Alexey Goncharuk Sporadic JVM crash due to restart nodes > IGNITE-10013 Unassigned Node restart may lead to NPE in > GridDhtPartitionsExchangeFuture > IGNITE-9928 Igor Seliverstov MVCC TX: Late affinity assignment support. > IGNITE-9985 Igor Seliverstov MVCC TX: fix backup mappings > IGNITE-10007 Sergey Kozlov Deactivation hangs if an open transaction exists > IGNITE-10004 Andrew Mashenkov Parse error leads to leave the transaction > IGNITE-10024 Ivan Pavlukhin MVCC TX: Stackoverflow during DhtEnlistFuture > mapping > IGNITE-9996 Alexey Goncharuk Investigate possible performance drop in FSYNC > mode for ignite-2.7 compared to ignite-2.6 > IGNITE-9982 Ivan Pavlukhin SQLLine: can't run with option > --autoCommit=false or true > IGNITE-9828 Roman Kondakov MVCC: Continuous query failover. > > > пт, 26 окт. 2018 г. в 9:59, Vladimir Ozerov : > > > Hi Nikolay, > > > > I do not know. We need to investigate them first. These are all > > regressions, so decision about impact and urgency should be made > separately > > for every ticket. > > > > On Fri, Oct 26, 2018 at 9:57 AM Nikolay Izhikov > > wrote: > > > > > Hello, Igniters. > > > > > > We have *9* tickets mapped to 2.7 today > > > > > > Vladimir, do you think 1 week delay will be enough to resolve all this > > > tickets? > > > > > > IGNITE-9828 Roman Kondakov MVCC: Continuous query > failover. > > > IGNITE-9928 Igor SeliverstovMVCC TX: Late affinity > assignment > > > support. > > > IGNITE-9985 Igor SeliverstovMVCC TX: fix backup mappings > > > IGNITE-9982 Ivan Pavlukhin SQLLine: can't run with option > > > --autoCommit=false or true > > > IGNITE-10010Unassigned Node halted if table was > dropped > > > IGNITE-10013Unassigned Node restart may lead to NPE in > > > GridDhtPartitionsExchangeFuture > > > IGNITE-9996 Unassigned Investigate possible > performance > > > drop in FSYNC mode for ignite-2.7 compared to ignite-2.6 > > > IGNITE-10007Unassigned Deactivation hangs if an open > > > transaction exists > > > IGNITE-10004Unassigned Parse error leads to leave the > > > transaction > > > > > > В Ср, 24/10/2018 в 12:30 +0300, Nikolay Izhikov пишет: > > > > Hello, Igniters. > > > > > > > > We have 3 ticket mapped to 2.7 today: > > > > > > > > Igor Seliverstov - IGNITE-9892 - MVCC: Exchange hangs on mvcc > > > coordinator fail > > > > Roman Kondakov - IGNITE-9828 - MVCC: Continuous query failover. > > > > Roman Kondakov - IGNITE-9928 - MVCC TX: Bug in SQL query mapping. > > > > > > > > В Вт, 23/10/2018 в 15:01 +0300, Nikolay Izhikov пишет: > > > > > Hello, Dmitriy. > > > > > > > > > > I'm OK with including this patch to 2.7. > > > > > > > > > > Can you ensure it completely fix the issue? > > > > > I left comment in ticket. > > > > > > > > > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-9854?focusedCommentId=16660516&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16660516 > > > > > > > > > > > > > > > В Вт, 23/10/2018 в 13:10 +0300, Dmitriy Govorukhin пишет: > > > > > > Nikolay, > > > > > > > > > > > > I have an issue which I want to include in 2.7 release, > > > > > > https://issues.apache.org/jira/browse/IGNITE-9854 > > > > > > It is a very small fix but very important, it protects us from > NPE > > > in some > > > > > > race scenario. > > > > > > Changes already in master, but the issue still not resolve, need > > your > > > > > > approval for cherry-picking changes to ignite-2.7. > > > > > > > > > > > > On Tue, Oct 23, 2018 at 10:51 AM Vladimir Ozerov < > > > voze...@gridgain.com> > > > > > > wrote: > > > > > > > > > > > > > Igniters, > > > > > > > > > > > > > > There are still tickets in the scope as we continue finding new > > > issues > > > > > > > during QA. I propose the following plan: if there are still > > opened > > > issues > > > > > > > by Friday, then shift vote date for 1 week, to 2nd November. > This > > > is needed > > > > > > > to ensure that product quality is sufficient. But if the > backlog > > > is empty > > > > > > > by Friday, we can go ahead with vote. > > > > > > > > >
Re: Hello
Hi Rodion, Welcome to the Apache Software Foundation and to the Apache Ignite Community. I've added your account to the list of contributors. Now you should be able to assign an issue to yourself. Sincerely, Dmitriy Pavlov P.S. Additional references that should boost your onboarding. Please subscribe to both dev and user lists: https://ignite.apache.org/community/resources.html#mail-lists Get familiar with Apache Ignite development process described here: https://cwiki.apache.org/confluence/display/IGNITE/Development+Process Instructions on how to contribute can be found here: https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute Project setup in Intellij IDEA: https://cwiki.apache.org/confluence/display/IGNITE/Project+Setup вт, 30 окт. 2018 г. в 16:16, Родион Власов : > > Hello, Ignite Community! > >My name is Rodion. I want to contribute to > Apache Ignite and want to start with this issue > https://issues.apache.org/jira/browse/IGNITE-8896 . >JIRA username is RodionVl. > > > > -- > С уважением, Родион Власов. > Best regards, > Rodion Vlasov
Hello
Hello, Ignite Community! My name is Rodion. I want to contribute to Apache Ignite and want to start with this issue https://issues.apache.org/jira/browse/IGNITE-8896 . JIRA username is RodionVl. -- С уважением, Родион Власов. Best regards, Rodion Vlasov
[GitHub] ignite pull request #5211: IGNITE-10062: improve logging on binary recovery
GitHub user Mmuzaf opened a pull request: https://github.com/apache/ignite/pull/5211 IGNITE-10062: improve logging on binary recovery You can merge this pull request into a Git repository by running: $ git pull https://github.com/Mmuzaf/ignite ignite-10062 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5211 commit b6f5e5acec13013ab8b3e35b55980f695f7f9a65 Author: Maxim Muzafarov Date: 2018-10-30T12:27:17Z IGNITE-10062: improve message logging on binary memory recovery commit 9ee45f1ecf16107185681de5aed26522c5e080a3 Author: Maxim Muzafarov Date: 2018-10-30T12:30:05Z Merge branch 'master' into ignite-10062 # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java commit 9e144c7b46d910b8b68a24602bb0e5f8f2772784 Author: Maxim Muzafarov Date: 2018-10-30T12:31:20Z IGNITE-10062: minor logging changes commit 470fed8b031c49589d415d74bf25ea36b73783bb Author: Maxim Muzafarov Date: 2018-10-30T12:33:05Z IGNITE-10062: fix message style ---
[GitHub] asfgit closed pull request #54: IGNITE-9848 Chain run report using pre-fetched builds instead of REST-cache
asfgit closed pull request #54: IGNITE-9848 Chain run report using pre-fetched builds instead of REST-cache URL: https://github.com/apache/ignite-teamcity-bot/pull/54 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (IGNITE-10062) Ambiguous warn message on binary memory restore and reading Metastore
Maxim Muzafarov created IGNITE-10062: Summary: Ambiguous warn message on binary memory restore and reading Metastore Key: IGNITE-10062 URL: https://issues.apache.org/jira/browse/IGNITE-10062 Project: Ignite Issue Type: Bug Reporter: Maxim Muzafarov Fix For: 2.8 Currently, there is no difference between logging message on restore binary memory and reading Metastore for read-only mode. We have to fix it to avoid ambiguous logging. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: How to begin to contribute
Hi Michael, I can see that https://issues.apache.org/jira/browse/IGNITE-7153 is already assigned to Roman Shtykh and is In Progress status. I hope Roman can step in and comment if he is interested in continuing of developing this issue/or he could apply you PR as well. Sincerely, Dmitriy Pavlov пн, 22 окт. 2018 г. в 11:33, Michael Fong : > Ah, never mind. I found out that I chose the wrong test suite to begin with > on Team City. :-) > > On Sun, Oct 21, 2018 at 10:20 PM Michael Fong > wrote: > > > Hi, all, > > > > I happened to have a fix for IGNITE-7153 and created pull request for > it. ( > > https://github.com/apache/ignite/pull/5044) > > > > I tried to follow the How to Contribute Workflow > > < > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Workflow> > but > > kind of got stuck on TeamCity CI, where all the test suite build failed > at > > unrelated library (ignite-tool). Is there any other easier or more > > intuitive CI or documentation to guide through the testing process? > > > > Furthermore, I wonder what would the code review process be, still via > > github comment review? > > > > Regards, > > > > Michael > > >
[GitHub] ignite pull request #4932: IGNITE-9221 Uncomment Cache Query tests, delete a...
Github user alamar closed the pull request at: https://github.com/apache/ignite/pull/4932 ---
Re: Abbreviation code-style requirement.
Hi Eduard, feel free to share your wiki ID, I could set up an edit permissions. ср, 24 окт. 2018 г. в 14:18, Eduard Shangareev : > Igniters, > thank you for your feedback. > > I haven't seen any arguments against making abbreviation optional and not > mandatory. > So, could we update our wiki with code style to reflect our new vision on > abbreviations? > > On Tue, Oct 23, 2018 at 2:01 PM Dmitriy Pavlov > wrote: > > > Hi Ivan > > > > if by conflict we mean arguing and fighting it is definitely should be > > avoided, it never helps the community. > > > > But if we mean different opinions on details (variable namings, method > > structure, etc), such different views are unavoidable and I find it is > > perfectly ok that people with different background have different views. > > The paramount thing here if we can solve such conflicts with a positive > > outcome for all community and for the codebase. > > > > The good friend of mine reminded me some time ago that we all have a > common > > goal here: make the community bigger and this project better. If we > always > > remember that we are connected by a common interest but we admit each > > contributor may have different preferences in coding and probably > different > > opinion. We may build up consensus sharing our arguments if it is really > > needed, or these different opinions/priorities/preferences may co-exist. > > > > In a particular case, if reviewer's concerns are not major, another > > reviewer can agree with your proposal. So it should be always considered > > case-by-case, there is no silver bullet here. > > > > Sincerely, > > Dmitriy Pavlov > > > > вт, 23 окт. 2018 г., 11:32 Maxim Muzafarov : > > > > > Igniters, > > > > > > I think it's easy to disable the code style abbreviation plugin option > by > > > switching off > > > the checkbox on - File | Settings | Inspections | Apache Ignite | > > Incorrect > > > Java abbreviation usage. > > > > > > +1 to make abbreviation not mandatory, but I'd like to keep it for > common > > > variable names like `context = ctx`. > > > > > > On Mon, 22 Oct 2018 at 14:05 Павлухин Иван > wrote: > > > > > > > Hi all, > > > > > > > > I also think that abbreviations should not be mandatory (point 3). > > > > But what I am worrying about is a conflict resolution between a patch > > > > submitter and a reviewer. > > > > How to come to an agreement when one side is strictly for and another > > > side > > > > is strictly against > > > > using abbreviations in some concrete case? > > > > > > > > вс, 21 окт. 2018 г. в 11:34, Dmitriy Pavlov : > > > > > > > > > +1 for proposal 3. > > > > > > > > > > 1. I'm not sure we need to revisit all abbreviations as a lot of > > people > > > > get > > > > > used to it. > > > > > 2. I'm not sure multiword is always need to be fully named, > sometimes > > > it > > > > > may be ok to abbreviate. > > > > > 3. But I agree with abbreviations should not be mandatory. > > > > > > > > > > Abbreviated and short names like i,j,cp and etc. are good for > simple > > > > > methods and code blocks; for a fast demonstration of some idea, but > > for > > > > > complex enterprise level software it can hide meaning instead of > > > clearly > > > > > showing it. > > > > > > > > > > As a next step, I would like to propose to contribute an option to > > > > disable > > > > > abbreviation requirements for some cases in ignite-abbrev-plugin. > > > > > > > > > > сб, 20 окт. 2018 г. в 10:47, Zhenya : > > > > > > > > > > > +1 for all proposals. > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Best regards, > > > > Ivan Pavlukhin > > > > > > > -- > > > -- > > > Maxim Muzafarov > > > > > >
Re: Legal advise on including Visual C++ Redistributable package into ODBC installer
Hi Igor, Denis, Feel free to CC me in every request to a mailing list(s) or mention LEGAL ticket you'll create.. I would be happy to help, but it is not likely I would have spare cycles to drive this topic. Sincerely, Dmitriy Pavlov чт, 25 окт. 2018 г. в 22:15, Denis Magda : > Dmitry, > > Thanks for the pointers! > > Would you be interested in sorting this out for the community by talking to > our ASF-mates who should know? > > -- > Denis > > On Thu, Oct 25, 2018 at 3:21 AM Dmitriy Pavlov > wrote: > > > Hi Igor, > > > > I'm not sure if someone in the community can know an answer to this > > question. > > > > I can share a page with resolved legal questions here: > > https://www.apache.org/legal/resolved.html#category-b > > > > But I think it may require confirmation from Apache Legal > > http://www.apache.org/legal/ > > https://issues.apache.org/jira/projects/LEGAL/summary > > http://www.apache.org/foundation/mailinglists.html#foundation-legal > > > > Sincerely, > > Dmitriy Pavlov > > > > ср, 24 окт. 2018 г. в 18:40, Igor Sapego : > > > > > Hi guys, > > > > > > I need your advice here. As some of you probably know we have > > > Windows installers for ODBC in our binary releases, so users won't need > > > to build Ignite C++ if all they want is to install and use our ODBC > > driver. > > > However, as we build driver with MSVC 10 when we are preparing our > > > binary release, user should have Visual C++ 2010 Redistributable > package > > > for it to work properly. If they do not, it just do not work, not > giving > > > any > > > human-readable errors, which is very confusing to a user. > > > > > > So my idea was to check for required package during installation and > > > give user a download link to a proper package. However, on the WiX > > > website there are articles on how to include the package into installer > > > [1]. > > > So I've thought that maybe this is even the better way to solve a > > problem. > > > > > > So thus is my question, is it OK from the legal standpoint, if we will > > > distribute > > > installer, that includes Visual C++ 2010 Redistributable package? We > are > > > not > > > going to put any binaries under the source control, of course. > > > > > > Can anyone help? > > > > > > [1] - > > > > > > > > > http://wixtoolset.org/documentation/manual/v3/howtos/redistributables_and_install_checks/install_vcredist.html > > > > > > Best Regards, > > > Igor > > > > > >
[GitHub] ignite pull request #5210: IGNITE-9842 Avoid stopping rebalance on Indexing ...
GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/5210 IGNITE-9842 Avoid stopping rebalance on Indexing SPI errors. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9842 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5210.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5210 commit 7f7663fc1738a563796d710ecf22a87c06d08d30 Author: Ilya Kasnacheev Date: 2018-10-30T11:40:28Z IGNITE-9842 Avoid stopping rebalance on Indexing SPI errors. ---
[GitHub] ignite pull request #5209: IGNITE-9221 Rename classes to avoid changing suit...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5209 ---
[GitHub] ignite pull request #5206: IGNITE-9221 Uncomment Cache Query tests, delete d...
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5206 ---
[GitHub] ignite pull request #5209: IGNITE-9221 Rename classes to avoid changing suit...
GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/5209 IGNITE-9221 Rename classes to avoid changing suites on TC. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9221b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5209 commit b5d3cec3bcdcf1153d53aa2c562928afff6cf024 Author: Ilya Kasnacheev Date: 2018-10-26T15:08:56Z IGNITE-9221 Rename classes to avoid changing suites on TC. ---
[GitHub] ignite pull request #5208: IGNITE-10011 Fixed pages leak
GitHub user agoncharuk opened a pull request: https://github.com/apache/ignite/pull/5208 IGNITE-10011 Fixed pages leak You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10011 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5208.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5208 commit c4d52c527050e006767850e04bdde653463ae9fe Author: Alexey Goncharuk Date: 2018-10-30T10:42:01Z IGNITE-10011 Fixed pages leak ---
Re: Problem with reading incomplete payload - IGNITE-7153
Michael, can you please share a reproducer? Is it possible to snapshot a packet that causes the error and just emulate packet send with manually opened socket bypassing Redis client lib? --Yakov
[GitHub] ignite pull request #5207: IGNITE-10037: Cache 2 tests optimization
GitHub user avplatonov opened a pull request: https://github.com/apache/ignite/pull/5207 IGNITE-10037: Cache 2 tests optimization You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10037 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5207.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5207 commit 4e85c11c3a5781b88cf2e3ae2a70b033f66e6e5d Author: Alexey Platonov Date: 2018-10-29T13:59:05Z init commit commit 45076feec0dc4a26172eb79acb9dabcd1a8bab73 Author: Alexey Platonov Date: 2018-10-30T09:37:14Z add scale factor ---
[GitHub] ignite pull request #5206: IGNITE-9221 Uncomment Cache Query tests, delete d...
GitHub user alamar opened a pull request: https://github.com/apache/ignite/pull/5206 IGNITE-9221 Uncomment Cache Query tests, delete duplicating suites to simplify layout. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9221a Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5206 commit 6c28d2c4a5075ab7b261c7bd0b8cce3d5ce6de41 Author: Ilya Kasnacheev Date: 2018-10-29T13:33:45Z IGNITE-9221 Uncomment Cache Query tests, delete and rename suites to simplify layout. ---
[jira] [Created] (IGNITE-10061) Improvement: warning or debug message is required in case if some data in SQL join requests isn't collocated.
Andrey Aleksandrov created IGNITE-10061: --- Summary: Improvement: warning or debug message is required in case if some data in SQL join requests isn't collocated. Key: IGNITE-10061 URL: https://issues.apache.org/jira/browse/IGNITE-10061 Project: Ignite Issue Type: Improvement Components: sql Affects Versions: 2.6 Reporter: Andrey Aleksandrov Fix For: 2.8 When data isn't collocated then during executing of the join request will be great to get for some warning like "your data isn't collocated" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5193: IGNITE-10042: Fix wrong TxLog root page type.
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5193 ---
[GitHub] ignite pull request #5202: IGNITE-10055
Github user devozerov closed the pull request at: https://github.com/apache/ignite/pull/5202 ---
[jira] [Created] (IGNITE-10060) Optimize IncSnapshotNearbyFullSnapshotTest#test use seconds instead of minutes
Alexand Polyakov created IGNITE-10060: - Summary: Optimize IncSnapshotNearbyFullSnapshotTest#test use seconds instead of minutes Key: IGNITE-10060 URL: https://issues.apache.org/jira/browse/IGNITE-10060 Project: Ignite Issue Type: Test Reporter: Alexand Polyakov -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10059) Local scan query against LOST partition fails
Stanislav Lukyanov created IGNITE-10059:
---
Summary: Local scan query against LOST partition fails
Key: IGNITE-10059
URL: https://issues.apache.org/jira/browse/IGNITE-10059
Project: Ignite
Issue Type: Bug
Reporter: Stanislav Lukyanov
Local scan queries executed against a LOST partition always fail.
Stack trace:
{code}
javax.cache.CacheException: No queryable nodes for partition 0 [forced local
query=GridCacheQueryAdapter [type=SCAN, clsName=null, clause=null, filter=null,
transform=null, part=0, incMeta=false, metrics=GridCacheQueryMetricsAdapter
[minTime=9223372036854775807, maxTime=0, sumTime=0, avgTime=0.0, execs=0,
completed=0, fails=0], pageSize=1024, timeout=0, incBackups=false,
forceLocal=true, dedup=false,
prj=org.apache.ignite.internal.cluster.ClusterGroupAdapter@3a806080,
keepBinary=false, subjId=null, taskHash=0, mvccSnapshot=null]]
at
org.apache.ignite.internal.processors.cache.IgniteCacheProxyImpl.query(IgniteCacheProxyImpl.java:697)
at
org.apache.ignite.internal.processors.cache.GatewayProtectedCacheProxy.query(GatewayProtectedCacheProxy.java:376)
at
org.apache.ignite.internal.processors.cache.distributed.IgniteCachePartitionLossPolicySelfTest.checkQueryPasses(IgniteCachePartitionLossPolicySelfTest.java:767)
at
org.apache.ignite.internal.processors.cache.distributed.IgniteCachePartitionLossPolicySelfTest.validateQuery0(IgniteCachePartitionLossPolicySelfTest.java:720)
at
org.apache.ignite.internal.processors.cache.distributed.IgniteCachePartitionLossPolicySelfTest.validateQuery(IgniteCachePartitionLossPolicySelfTest.java:691)
at
org.apache.ignite.internal.processors.cache.distributed.IgniteCachePartitionLossPolicySelfTest.checkLostPartition(IgniteCachePartitionLossPolicySelfTest.java:497)
at
org.apache.ignite.internal.processors.cache.distributed.IgniteCachePartitionLossPolicySelfTest.testReadOnlyAll(IgniteCachePartitionLossPolicySelfTest.java:185)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at junit.framework.TestCase.runTest(TestCase.java:176)
at
org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2209)
at
org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:144)
at
org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:2124)
at java.lang.Thread.run(Thread.java:748)
Caused by: class org.apache.ignite.IgniteCheckedException: No queryable nodes
for partition 0 [forced local query=GridCacheQueryAdapter [type=SCAN,
clsName=null, clause=null, filter=null, transform=null, part=0, incMeta=false,
metrics=GridCacheQueryMetricsAdapter [minTime=9223372036854775807, maxTime=0,
sumTime=0, avgTime=0.0, execs=0, completed=0, fails=0], pageSize=1024,
timeout=0, incBackups=false, forceLocal=true, dedup=false,
prj=org.apache.ignite.internal.cluster.ClusterGroupAdapter@3a806080,
keepBinary=false, subjId=null, taskHash=0, mvccSnapshot=null]]
at
org.apache.ignite.internal.processors.cache.query.GridCacheQueryAdapter.executeScanQuery(GridCacheQueryAdapter.java:541)
at
org.apache.ignite.internal.processors.cache.IgniteCacheProxyImpl$1.applyx(IgniteCacheProxyImpl.java:410)
at
org.apache.ignite.internal.processors.cache.IgniteCacheProxyImpl$1.applyx(IgniteCacheProxyImpl.java:408)
at
org.apache.ignite.internal.util.lang.IgniteOutClosureX.apply(IgniteOutClosureX.java:36)
at
org.apache.ignite.internal.processors.query.GridQueryProcessor.executeQuery(GridQueryProcessor.java:2713)
at
org.apache.ignite.internal.processors.cache.IgniteCacheProxyImpl.query(IgniteCacheProxyImpl.java:407)
at
org.apache.ignite.internal.processors.cache.IgniteCacheProxyImpl.query(IgniteCacheProxyImpl.java:689)
... 15 more
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-10058) resetLostPartitions() leaves an additional copy of a partition in the cluster
Stanislav Lukyanov created IGNITE-10058: --- Summary: resetLostPartitions() leaves an additional copy of a partition in the cluster Key: IGNITE-10058 URL: https://issues.apache.org/jira/browse/IGNITE-10058 Project: Ignite Issue Type: Bug Reporter: Stanislav Lukyanov If there are several copies of a LOST partition, resetLostPartitions() will leave all of them in the cluster as OWNING. Scenario: 1) Start 4 nodes, a cache with backups=0 and READ_WRITE_SAFE, fill the cache 2) Stop one node - some partitions are recreated on the remaining nodes as LOST 3) Start one node - the LOST partitions are being rebalanced to the new node from the existing ones 4) Wait for rebalance to complete 5) Call resetLostPartitions() After that the partitions that were LOST become OWNING on all nodes that had them. Eviction of these partitions doesn't start. Need to correctly evict additional copies of LOST partitions either after rebalance on step 4 or after resetLostPartitions() call on step 5. Current resetLostPartitions() implementation does call checkEvictions(), but the ready affinity assignment contains several nodes per partition for some reason. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10057) SQL queries hang during rebalance if there are LOST partitions
Stanislav Lukyanov created IGNITE-10057:
---
Summary: SQL queries hang during rebalance if there are LOST
partitions
Key: IGNITE-10057
URL: https://issues.apache.org/jira/browse/IGNITE-10057
Project: Ignite
Issue Type: Bug
Components: sql
Reporter: Stanislav Lukyanov
When there are both LOST and MOVING partitions in the cluster, SQL queries will
hang until rebalance has completed and there aren't any MOVING partitions.
During that time the reducer node keeps printing
{code}
[2018-10-30 10:26:06,787][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=13, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:06,798][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=14, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:06,818][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=15, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:06,849][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=16, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:06,889][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=17, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:06,940][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=18, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:07,001][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=19, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:07,072][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=20, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:07,152][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=21, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:07,243][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=22, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:07,343][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=23, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:07,454][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
corresponding cache group has data nodes) [qryId=24, cacheIds=[1254100233],
cacheName=partitioned, cacheId=1254100233, part=0, cacheGroupId=1254100233]
[2018-10-30 10:26:07,575][INFO
][test-runner-#1%cache.IndexingCachePartitionLossPolicySelfTest%][GridReduceQueryExecutor]
Failed to calculate nodes for SQL query (partition has no owners, but
correspondi
