Re: Apache Ignite 2.7. Last Mile
+1 for revert. On Sun, Nov 18, 2018 at 11:31 PM Dmitriy Pavlov wrote: > I personally don't mind. > > But I would like Dmitry Ryabov and Alexey Goncharuck share their opinions. > > вс, 18 нояб. 2018 г., 20:43 Nikolay Izhikov : > > > Yes, I think so. > > > > вс, 18 нояб. 2018 г., 20:34 Denis Magda dma...@apache.org: > > > > > Sounds good to me. Are we starting the vote then? > > > > > > Denis > > > > > > > > > > > > On Sun, Nov 18, 2018 at 8:25 AM Nikolay Izhikov > > > wrote: > > > > > > > Hello, Igniters. > > > > > > > > This issue is the only ticket that blocks 2.7 release. > > > > > > > > I looked at IGNITE-602 PR and GridToStringBuilder. > > > > The code looks complicated for me. > > > > And it's not obvious for me how to fix this issue in a short period > of > > > > time. > > > > Especially, code deals with recursion and other things that can lead > to > > > > very dangerous errors. > > > > > > > > Let's revert this patch and fix it in calmly. > > > > Also, we need additional tests for it. > > > > > > > > В Пт, 16/11/2018 в 17:57 +0300, Dmitrii Ryabov пишет: > > > > > Ok, I'll check the issue. > > > > > пт, 16 нояб. 2018 г. в 17:52, Alexey Goncharuk < > > > > alexey.goncha...@gmail.com>: > > > > > > > > > > > > Igniters, > > > > > > > > > > > > I've just found that S.toString() implementation is broken in > > > > ignite-2.7 and master [1]. It leads to a message > > > > > > Wrapper [p=Parent [a=0]Child [b=0, super=]] > > > > > > being formed instead of > > > > > > Wrapper [p=Child [b=0, super=Parent [a=0]]] > > > > > > for classes with inheritance that use S.toString(SomeClass.class, > > > > this, super.toString()) embedded to some other object. > > > > > > > > > > > > Dmitrii Ryabov, I've reverted two commits related to IGNITE-602 > and > > > > IGNITE-9209 tickets locally and it fixes the issue. Can you take a > look > > > at > > > > the issue? > > > > > > > > > > > > I think this regression essentially makes our logs unreadable in > > some > > > > cases and I would like to get it fixed in ignite-2.7 or revert both > > > commits > > > > from the release. > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10301 > > > > > > > > > > > > пт, 9 нояб. 2018 г. в 09:22, Nikolay Izhikov < > nizhi...@apache.org > > >: > > > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > > > We still have 5 tickets for 2.7: > > > > > > > > > > > > > > IGNITE-10052Andrew Mashenkov Restart node during TX causes > > > > vacuum error. > > > > > > > IGNITE-10170Unassigned .NET: > Services.ServicesTestAsync > > > > fails > > > > > > > IGNITE-10196Maxim Pudov Remove kafka-clients-*-test > > > > dependency > > > > > > > IGNITE-10154Andrey Gura Critical worker liveness check > > > > configuration is non-trivial and inconsistent > > > > > > > IGNITE-9996 Nikolay Izhikov Investigate possible > performance > > > > drop in FSYNC mode for ignite-2.7 compared to ignite-2.6 > > > > > > > > > > > > > > > > > > > > > В Чт, 08/11/2018 в 14:25 +0300, Nikolay Izhikov пишет: > > > > > > > > I'm OK with this. > > > > > > > > > > > > > > > > чт, 8 нояб. 2018 г., 13:44 Andrey Gura ag...@apache.org: > > > > > > > > > Long, long way to release :) > > > > > > > > > > > > > > > > > > Guys, we have a breaking change in Ignite 2.7 so we must > add > > > > > > > > > IGNITE-10154 [1] fix to the release. > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10154 > > > > > > > > > On Tue, Nov 6, 2018 at 6:30 PM Igor Sapego < > > isap...@apache.org > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > Guys, > > > > > > > > > > > > > > > > > > > > I've found the following issue: [1]. It is quite local > > (only > > > > affects > > > > > > > > > > Ignite C++ Linux build system) but quite critical too. I > > > think > > > > it > > > > > > > > > > should be included in 2.7. > > > > > > > > > > > > > > > > > > > > What do you think? > > > > > > > > > > > > > > > > > > > > [1] - https://issues.apache.org/jira/browse/IGNITE-10147 > > > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Oct 30, 2018 at 4:35 PM Вячеслав Коптилин < > > > > slava.kopti...@gmail.com> > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hello Nikolay, Igniters, > > > > > > > > > > > > > > > > > > > > > > It seems that we lost the following commit that should > be > > > > included in > > > > > > > > > > > 'ignite-2.7' branch > > > > > > > > > > > (It looks like the change was not accidentally > > > cherry-picked > > > > from 'master' > > > > > > > > > > > to 'ignite-2.7') > > > > > > > > > > > - > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/ignite/commit/6e0ff06f8e309657a16c94da605348d9c3b804ad > > > > > > > > > > > > > > > > > > > > > > The most important part is the change introduced into > > > > GridDhtAtomicCache, > > > > > >
Re: Brainstorm: Make TC Run All faster
Concerning current TeamCity compute capacity — I think we should invest into it’s stability at first: there are lots of problems associated with — tests hangs (which now can render agent useless up to 3 days) — checkout issues (speedup proxy is installed but sometimes even it is not enough for checkout on 100 agents simultaneously, server side checkout research is required) — tests architecture (current one relies heavily on large file movement over network which also can be a bottleneck in case of 100 agents simultaneous download start) And so on. After it additional donation can be discussed. > On 16 Nov 2018, at 17:05, Vyacheslav Daradur wrote: > > At one of the meetups, Vladimir Ozerov has said that we may specify > and move less risky to be broken tests in separate build plan which > will be executed daily or weekly > > For example tests of compatibility with different JDK versions or > compatibility between Ignite's releases. > > Also, I agree with Denis we should find and remove tests with the same checks. > > By the way, if someone of the community donates TC agents, can this > help to reduce the time? > > On Thu, Nov 15, 2018 at 5:38 PM Yakov Zhdanov wrote: >> >> Denis, you can go even further. E.g. you can start topology once for the >> full set of single threaded full api cache tests. Each test should start >> cache dynamically and run it logic. >> >> As for me, I would think of splitting RunAll to 2 steps - one containing >> basic tests and another with more complex tests. 2nd step should not start >> (except manually) if 1st step results in any build failure. >> >> --Yakov > > > > -- > Best Regards, Vyacheslav D.
[jira] [Created] (IGNITE-10316) control.sh --baseline remove outputs wrong error message when trying to remove node from baseline when cluster is inactive.
Pavel Voronkin created IGNITE-10316:
---
Summary: control.sh --baseline remove outputs wrong error message
when trying to remove node from baseline when cluster is inactive.
Key: IGNITE-10316
URL: https://issues.apache.org/jira/browse/IGNITE-10316
Project: Ignite
Issue Type: Bug
Reporter: Pavel Voronkin
1. start 2 nodes from clean lfs
2. grep node consistent ids
{noformat}
$ grep "Consistent ID" work/log/*.log
work/log/ignite-15958745.0.log:[16:59:13,190][INFO][main][PdsFoldersResolver]
Consistent ID used for local node is [7ee8018b-3f5f-4c58-b6dd-f53ed7af2679]
according to persistence data storage folders
work/log/ignite-300c7412.0.log:[16:59:15,678][INFO][main][PdsFoldersResolver]
Consistent ID used for local node is [5adcf3a1-7ad9-40fa-88ac-40b488dc6b34]
according to persistence data storage folders
{noformat}
3. try to remove node from baseline
expected: error message about cluster inactive state
actual: error message about node id not found, BUG
{noformat}
Caused by: java.lang.IllegalStateException: Node not found for consistent ID:
7ee8018b-3f5f-4c58-b6dd-f53ed7af2679
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.remove(VisorBaselineTask.java:178)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:208)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:52)
at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
at
org.apache.ignite.internal.processors.job.GridJobWorker$2.call(GridJobWorker.java:568)
at
org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6726)
at
org.apache.ignite.internal.processors.job.GridJobWorker.execute0(GridJobWorker.java:562)
... 19 more
{noformat}
however, when trying to add node to baseline, error message is correct:
{noformat}
Caused by: class org.apache.ignite.IgniteException: Changing BaselineTopology
on inactive cluster is not allowed.
at
org.apache.ignite.internal.cluster.IgniteClusterImpl.validateBeforeBaselineChange(IgniteClusterImpl.java:406)
at
org.apache.ignite.internal.cluster.IgniteClusterImpl.setBaselineTopology(IgniteClusterImpl.java:356)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.set0(VisorBaselineTask.java:87)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.add(VisorBaselineTask.java:162)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:205)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:52)
at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
at
org.apache.ignite.internal.processors.job.GridJobWorker$2.call(GridJobWorker.java:568)
at
org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6726)
at
org.apache.ignite.internal.processors.job.GridJobWorker.execute0(GridJobWorker.java:562)
at
org.apache.ignite.internal.processors.job.GridJobWorker.body(GridJobWorker.java:491)
at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
at
org.apache.ignite.internal.processors.job.GridJobProcessor.processJobExecuteRequest(GridJobProcessor.java:1123)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.sendRequest(GridTaskWorker.java:1407)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.processMappedJobs(GridTaskWorker.java:660)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.body(GridTaskWorker.java:532)
... 13 more
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-10315) control.sh --baseline remove outputs wrong error message when trying to remove node from baseline when cluster is inactive.
Pavel Voronkin created IGNITE-10315:
---
Summary: control.sh --baseline remove outputs wrong error message
when trying to remove node from baseline when cluster is inactive.
Key: IGNITE-10315
URL: https://issues.apache.org/jira/browse/IGNITE-10315
Project: Ignite
Issue Type: Bug
Reporter: Pavel Voronkin
1. start 2 nodes from clean lfs
2. grep node consistent ids
{noformat}
$ grep "Consistent ID" work/log/*.log
work/log/ignite-15958745.0.log:[16:59:13,190][INFO][main][PdsFoldersResolver]
Consistent ID used for local node is [7ee8018b-3f5f-4c58-b6dd-f53ed7af2679]
according to persistence data storage folders
work/log/ignite-300c7412.0.log:[16:59:15,678][INFO][main][PdsFoldersResolver]
Consistent ID used for local node is [5adcf3a1-7ad9-40fa-88ac-40b488dc6b34]
according to persistence data storage folders
{noformat}
3. try to remove node from baseline
expected: error message about cluster inactive state
actual: error message about node id not found, BUG
{noformat}
Caused by: java.lang.IllegalStateException: Node not found for consistent ID:
7ee8018b-3f5f-4c58-b6dd-f53ed7af2679
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.remove(VisorBaselineTask.java:178)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:208)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:52)
at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
at
org.apache.ignite.internal.processors.job.GridJobWorker$2.call(GridJobWorker.java:568)
at
org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6726)
at
org.apache.ignite.internal.processors.job.GridJobWorker.execute0(GridJobWorker.java:562)
... 19 more
{noformat}
however, when trying to add node to baseline, error message is correct:
{noformat}
Caused by: class org.apache.ignite.IgniteException: Changing BaselineTopology
on inactive cluster is not allowed.
at
org.apache.ignite.internal.cluster.IgniteClusterImpl.validateBeforeBaselineChange(IgniteClusterImpl.java:406)
at
org.apache.ignite.internal.cluster.IgniteClusterImpl.setBaselineTopology(IgniteClusterImpl.java:356)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.set0(VisorBaselineTask.java:87)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.add(VisorBaselineTask.java:162)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:205)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:52)
at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
at
org.apache.ignite.internal.processors.job.GridJobWorker$2.call(GridJobWorker.java:568)
at
org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6726)
at
org.apache.ignite.internal.processors.job.GridJobWorker.execute0(GridJobWorker.java:562)
at
org.apache.ignite.internal.processors.job.GridJobWorker.body(GridJobWorker.java:491)
at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
at
org.apache.ignite.internal.processors.job.GridJobProcessor.processJobExecuteRequest(GridJobProcessor.java:1123)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.sendRequest(GridTaskWorker.java:1407)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.processMappedJobs(GridTaskWorker.java:660)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.body(GridTaskWorker.java:532)
... 13 more
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] ignite pull request #5423: IGNITE-9811 Web console: show validation messages...
GitHub user Klaster1 opened a pull request: https://github.com/apache/ignite/pull/5423 IGNITE-9811 Web console: show validation messages on form submit [The issue.](https://issues.apache.org/jira/browse/IGNITE-9811) You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9811 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5423 commit 93350c53cc5b16bf54e2b441d2b4fc64bd383ec7 Author: Ilya Borisov Date: 2018-11-19T05:06:16Z IGNITE-9811 Show validation error message when errors are triggered too. commit a5bb7a0dccb0bc56f29d7d432e87f538361b3cbf Author: Ilya Borisov Date: 2018-11-19T05:06:57Z IGNITE-9811 Do not disable user profile save button, trigger validation instead. ---
[GitHub] ignite pull request #5422: IGNITE-10314 QueryEntity is not updated when colu...
GitHub user ldzhjn opened a pull request: https://github.com/apache/ignite/pull/5422 IGNITE-10314 QueryEntity is not updated when column and index added or dropped You can merge this pull request into a Git repository by running: $ git pull https://github.com/ldzhjn/ignite IGNITE-10314 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5422.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5422 commit 50081ba19ec1f0c841adf69408e7db256e22334b Author: rayliu Date: 2018-11-19T03:43:11Z Fix bug ---
[jira] [Created] (IGNITE-10314) QueryEntity is not updated when column and index added or dropped
Ray created IGNITE-10314: Summary: QueryEntity is not updated when column and index added or dropped Key: IGNITE-10314 URL: https://issues.apache.org/jira/browse/IGNITE-10314 Project: Ignite Issue Type: Bug Affects Versions: 2.6, 2.7 Reporter: Ray Assignee: Ray Fix For: 2.8 When user performs column and index modification operation in SQL(ex create index, drop index, add column, drop column), QueryEntity in CacheConfiguration for the modified cache is not updated. Analyse QueryEntity in QuerySchema is a local copy of the original QueryEntity, so the original QueryEntity is not updated when modification happens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] ignite pull request #5421: IGNITE-8765: Fixed event's query type
GitHub user pavel-kuznetsov opened a pull request: https://github.com/apache/ignite/pull/5421 IGNITE-8765: Fixed event's query type You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8765 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5421.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5421 commit d4ecd8454a5511c8b85fb3c3ede0072d71b2757f Author: palmuhal Date: 2018-11-18T23:49:42Z ignite-8765: Enabled test for the bug. Bug itself have been fixed during IGNITE-10253. commit 6cad0bb22b2b7a0f3a58486c66d145a39eacb312 Author: palmuhal Date: 2018-11-19T00:17:39Z ignite-8765: Fixed event type. Earlier no matter query of what type (SQL or SQL_FIELDS) got executed, "SQL" used to be the query type of the event. Now we make a difference. Also event message is updated. ---
[GitHub] ignite pull request #5058: IGNITE-8867: Bagging
Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5058 ---
Re: Apache Ignite 2.7. Last Mile
I personally don't mind. But I would like Dmitry Ryabov and Alexey Goncharuck share their opinions. вс, 18 нояб. 2018 г., 20:43 Nikolay Izhikov : > Yes, I think so. > > вс, 18 нояб. 2018 г., 20:34 Denis Magda dma...@apache.org: > > > Sounds good to me. Are we starting the vote then? > > > > Denis > > > > > > > > On Sun, Nov 18, 2018 at 8:25 AM Nikolay Izhikov > > wrote: > > > > > Hello, Igniters. > > > > > > This issue is the only ticket that blocks 2.7 release. > > > > > > I looked at IGNITE-602 PR and GridToStringBuilder. > > > The code looks complicated for me. > > > And it's not obvious for me how to fix this issue in a short period of > > > time. > > > Especially, code deals with recursion and other things that can lead to > > > very dangerous errors. > > > > > > Let's revert this patch and fix it in calmly. > > > Also, we need additional tests for it. > > > > > > В Пт, 16/11/2018 в 17:57 +0300, Dmitrii Ryabov пишет: > > > > Ok, I'll check the issue. > > > > пт, 16 нояб. 2018 г. в 17:52, Alexey Goncharuk < > > > alexey.goncha...@gmail.com>: > > > > > > > > > > Igniters, > > > > > > > > > > I've just found that S.toString() implementation is broken in > > > ignite-2.7 and master [1]. It leads to a message > > > > > Wrapper [p=Parent [a=0]Child [b=0, super=]] > > > > > being formed instead of > > > > > Wrapper [p=Child [b=0, super=Parent [a=0]]] > > > > > for classes with inheritance that use S.toString(SomeClass.class, > > > this, super.toString()) embedded to some other object. > > > > > > > > > > Dmitrii Ryabov, I've reverted two commits related to IGNITE-602 and > > > IGNITE-9209 tickets locally and it fixes the issue. Can you take a look > > at > > > the issue? > > > > > > > > > > I think this regression essentially makes our logs unreadable in > some > > > cases and I would like to get it fixed in ignite-2.7 or revert both > > commits > > > from the release. > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10301 > > > > > > > > > > пт, 9 нояб. 2018 г. в 09:22, Nikolay Izhikov >: > > > > > > > > > > > > Hello, Igniters. > > > > > > > > > > > > We still have 5 tickets for 2.7: > > > > > > > > > > > > IGNITE-10052Andrew Mashenkov Restart node during TX causes > > > vacuum error. > > > > > > IGNITE-10170Unassigned .NET: Services.ServicesTestAsync > > > fails > > > > > > IGNITE-10196Maxim Pudov Remove kafka-clients-*-test > > > dependency > > > > > > IGNITE-10154Andrey Gura Critical worker liveness check > > > configuration is non-trivial and inconsistent > > > > > > IGNITE-9996 Nikolay Izhikov Investigate possible performance > > > drop in FSYNC mode for ignite-2.7 compared to ignite-2.6 > > > > > > > > > > > > > > > > > > В Чт, 08/11/2018 в 14:25 +0300, Nikolay Izhikov пишет: > > > > > > > I'm OK with this. > > > > > > > > > > > > > > чт, 8 нояб. 2018 г., 13:44 Andrey Gura ag...@apache.org: > > > > > > > > Long, long way to release :) > > > > > > > > > > > > > > > > Guys, we have a breaking change in Ignite 2.7 so we must add > > > > > > > > IGNITE-10154 [1] fix to the release. > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10154 > > > > > > > > On Tue, Nov 6, 2018 at 6:30 PM Igor Sapego < > isap...@apache.org > > > > > > wrote: > > > > > > > > > > > > > > > > > > Guys, > > > > > > > > > > > > > > > > > > I've found the following issue: [1]. It is quite local > (only > > > affects > > > > > > > > > Ignite C++ Linux build system) but quite critical too. I > > think > > > it > > > > > > > > > should be included in 2.7. > > > > > > > > > > > > > > > > > > What do you think? > > > > > > > > > > > > > > > > > > [1] - https://issues.apache.org/jira/browse/IGNITE-10147 > > > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Oct 30, 2018 at 4:35 PM Вячеслав Коптилин < > > > slava.kopti...@gmail.com> > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Hello Nikolay, Igniters, > > > > > > > > > > > > > > > > > > > > It seems that we lost the following commit that should be > > > included in > > > > > > > > > > 'ignite-2.7' branch > > > > > > > > > > (It looks like the change was not accidentally > > cherry-picked > > > from 'master' > > > > > > > > > > to 'ignite-2.7') > > > > > > > > > > - > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/ignite/commit/6e0ff06f8e309657a16c94da605348d9c3b804ad > > > > > > > > > > > > > > > > > > > > The most important part is the change introduced into > > > GridDhtAtomicCache, > > > > > > > > > > the fix prevents NullPointerException during cache > updates > > > under some > > > > > > > > > > circumstances. > > > > > > > > > > So, I propose including the fix into ignite-2.7, at least > > > the change of > > > > > > > > > > GridDhtAtomicCache. > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > Slava. > > > > > > > > > > > > > > > > > > > > пн, 29 ок
Re: Apache Ignite 2.7. Last Mile
Yes, I think so. вс, 18 нояб. 2018 г., 20:34 Denis Magda dma...@apache.org: > Sounds good to me. Are we starting the vote then? > > Denis > > > > On Sun, Nov 18, 2018 at 8:25 AM Nikolay Izhikov > wrote: > > > Hello, Igniters. > > > > This issue is the only ticket that blocks 2.7 release. > > > > I looked at IGNITE-602 PR and GridToStringBuilder. > > The code looks complicated for me. > > And it's not obvious for me how to fix this issue in a short period of > > time. > > Especially, code deals with recursion and other things that can lead to > > very dangerous errors. > > > > Let's revert this patch and fix it in calmly. > > Also, we need additional tests for it. > > > > В Пт, 16/11/2018 в 17:57 +0300, Dmitrii Ryabov пишет: > > > Ok, I'll check the issue. > > > пт, 16 нояб. 2018 г. в 17:52, Alexey Goncharuk < > > alexey.goncha...@gmail.com>: > > > > > > > > Igniters, > > > > > > > > I've just found that S.toString() implementation is broken in > > ignite-2.7 and master [1]. It leads to a message > > > > Wrapper [p=Parent [a=0]Child [b=0, super=]] > > > > being formed instead of > > > > Wrapper [p=Child [b=0, super=Parent [a=0]]] > > > > for classes with inheritance that use S.toString(SomeClass.class, > > this, super.toString()) embedded to some other object. > > > > > > > > Dmitrii Ryabov, I've reverted two commits related to IGNITE-602 and > > IGNITE-9209 tickets locally and it fixes the issue. Can you take a look > at > > the issue? > > > > > > > > I think this regression essentially makes our logs unreadable in some > > cases and I would like to get it fixed in ignite-2.7 or revert both > commits > > from the release. > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10301 > > > > > > > > пт, 9 нояб. 2018 г. в 09:22, Nikolay Izhikov : > > > > > > > > > > Hello, Igniters. > > > > > > > > > > We still have 5 tickets for 2.7: > > > > > > > > > > IGNITE-10052Andrew Mashenkov Restart node during TX causes > > vacuum error. > > > > > IGNITE-10170Unassigned .NET: Services.ServicesTestAsync > > fails > > > > > IGNITE-10196Maxim Pudov Remove kafka-clients-*-test > > dependency > > > > > IGNITE-10154Andrey Gura Critical worker liveness check > > configuration is non-trivial and inconsistent > > > > > IGNITE-9996 Nikolay Izhikov Investigate possible performance > > drop in FSYNC mode for ignite-2.7 compared to ignite-2.6 > > > > > > > > > > > > > > > В Чт, 08/11/2018 в 14:25 +0300, Nikolay Izhikov пишет: > > > > > > I'm OK with this. > > > > > > > > > > > > чт, 8 нояб. 2018 г., 13:44 Andrey Gura ag...@apache.org: > > > > > > > Long, long way to release :) > > > > > > > > > > > > > > Guys, we have a breaking change in Ignite 2.7 so we must add > > > > > > > IGNITE-10154 [1] fix to the release. > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10154 > > > > > > > On Tue, Nov 6, 2018 at 6:30 PM Igor Sapego > > > wrote: > > > > > > > > > > > > > > > > Guys, > > > > > > > > > > > > > > > > I've found the following issue: [1]. It is quite local (only > > affects > > > > > > > > Ignite C++ Linux build system) but quite critical too. I > think > > it > > > > > > > > should be included in 2.7. > > > > > > > > > > > > > > > > What do you think? > > > > > > > > > > > > > > > > [1] - https://issues.apache.org/jira/browse/IGNITE-10147 > > > > > > > > > > > > > > > > Best Regards, > > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Oct 30, 2018 at 4:35 PM Вячеслав Коптилин < > > slava.kopti...@gmail.com> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hello Nikolay, Igniters, > > > > > > > > > > > > > > > > > > It seems that we lost the following commit that should be > > included in > > > > > > > > > 'ignite-2.7' branch > > > > > > > > > (It looks like the change was not accidentally > cherry-picked > > from 'master' > > > > > > > > > to 'ignite-2.7') > > > > > > > > > - > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/ignite/commit/6e0ff06f8e309657a16c94da605348d9c3b804ad > > > > > > > > > > > > > > > > > > The most important part is the change introduced into > > GridDhtAtomicCache, > > > > > > > > > the fix prevents NullPointerException during cache updates > > under some > > > > > > > > > circumstances. > > > > > > > > > So, I propose including the fix into ignite-2.7, at least > > the change of > > > > > > > > > GridDhtAtomicCache. > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > Slava. > > > > > > > > > > > > > > > > > > пн, 29 окт. 2018 г. в 11:20, Nikolay Izhikov < > > nizhi...@apache.org>: > > > > > > > > > > > > > > > > > > > Hello, guys. > > > > > > > > > > > > > > > > > > > > For today we have 11 tickets mapped to 2.7 > > > > > > > > > > > > > > > > > > > > IGNITE-10010 Alexey Goncharuk Node halted if second node > > was stopped, > > > > > > > > > > > > > > > > > > then > > > > > > > > > > cache destroyed, then second node returned > > > > > > > > > > IGNITE-10015 Al
Re: Apache Ignite 2.7. Last Mile
Sounds good to me. Are we starting the vote then? Denis On Sun, Nov 18, 2018 at 8:25 AM Nikolay Izhikov wrote: > Hello, Igniters. > > This issue is the only ticket that blocks 2.7 release. > > I looked at IGNITE-602 PR and GridToStringBuilder. > The code looks complicated for me. > And it's not obvious for me how to fix this issue in a short period of > time. > Especially, code deals with recursion and other things that can lead to > very dangerous errors. > > Let's revert this patch and fix it in calmly. > Also, we need additional tests for it. > > В Пт, 16/11/2018 в 17:57 +0300, Dmitrii Ryabov пишет: > > Ok, I'll check the issue. > > пт, 16 нояб. 2018 г. в 17:52, Alexey Goncharuk < > alexey.goncha...@gmail.com>: > > > > > > Igniters, > > > > > > I've just found that S.toString() implementation is broken in > ignite-2.7 and master [1]. It leads to a message > > > Wrapper [p=Parent [a=0]Child [b=0, super=]] > > > being formed instead of > > > Wrapper [p=Child [b=0, super=Parent [a=0]]] > > > for classes with inheritance that use S.toString(SomeClass.class, > this, super.toString()) embedded to some other object. > > > > > > Dmitrii Ryabov, I've reverted two commits related to IGNITE-602 and > IGNITE-9209 tickets locally and it fixes the issue. Can you take a look at > the issue? > > > > > > I think this regression essentially makes our logs unreadable in some > cases and I would like to get it fixed in ignite-2.7 or revert both commits > from the release. > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10301 > > > > > > пт, 9 нояб. 2018 г. в 09:22, Nikolay Izhikov : > > > > > > > > Hello, Igniters. > > > > > > > > We still have 5 tickets for 2.7: > > > > > > > > IGNITE-10052Andrew Mashenkov Restart node during TX causes > vacuum error. > > > > IGNITE-10170Unassigned .NET: Services.ServicesTestAsync > fails > > > > IGNITE-10196Maxim Pudov Remove kafka-clients-*-test > dependency > > > > IGNITE-10154Andrey Gura Critical worker liveness check > configuration is non-trivial and inconsistent > > > > IGNITE-9996 Nikolay Izhikov Investigate possible performance > drop in FSYNC mode for ignite-2.7 compared to ignite-2.6 > > > > > > > > > > > > В Чт, 08/11/2018 в 14:25 +0300, Nikolay Izhikov пишет: > > > > > I'm OK with this. > > > > > > > > > > чт, 8 нояб. 2018 г., 13:44 Andrey Gura ag...@apache.org: > > > > > > Long, long way to release :) > > > > > > > > > > > > Guys, we have a breaking change in Ignite 2.7 so we must add > > > > > > IGNITE-10154 [1] fix to the release. > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10154 > > > > > > On Tue, Nov 6, 2018 at 6:30 PM Igor Sapego > wrote: > > > > > > > > > > > > > > Guys, > > > > > > > > > > > > > > I've found the following issue: [1]. It is quite local (only > affects > > > > > > > Ignite C++ Linux build system) but quite critical too. I think > it > > > > > > > should be included in 2.7. > > > > > > > > > > > > > > What do you think? > > > > > > > > > > > > > > [1] - https://issues.apache.org/jira/browse/IGNITE-10147 > > > > > > > > > > > > > > Best Regards, > > > > > > > Igor > > > > > > > > > > > > > > > > > > > > > On Tue, Oct 30, 2018 at 4:35 PM Вячеслав Коптилин < > slava.kopti...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > Hello Nikolay, Igniters, > > > > > > > > > > > > > > > > It seems that we lost the following commit that should be > included in > > > > > > > > 'ignite-2.7' branch > > > > > > > > (It looks like the change was not accidentally cherry-picked > from 'master' > > > > > > > > to 'ignite-2.7') > > > > > > > > - > > > > > > > > > > > > > > > > > https://github.com/apache/ignite/commit/6e0ff06f8e309657a16c94da605348d9c3b804ad > > > > > > > > > > > > > > > > The most important part is the change introduced into > GridDhtAtomicCache, > > > > > > > > the fix prevents NullPointerException during cache updates > under some > > > > > > > > circumstances. > > > > > > > > So, I propose including the fix into ignite-2.7, at least > the change of > > > > > > > > GridDhtAtomicCache. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Slava. > > > > > > > > > > > > > > > > пн, 29 окт. 2018 г. в 11:20, Nikolay Izhikov < > nizhi...@apache.org>: > > > > > > > > > > > > > > > > > Hello, guys. > > > > > > > > > > > > > > > > > > For today we have 11 tickets mapped to 2.7 > > > > > > > > > > > > > > > > > > IGNITE-10010 Alexey Goncharuk Node halted if second node > was stopped, > > > > > > > > > > > > > > > > then > > > > > > > > > cache destroyed, then second node returned > > > > > > > > > IGNITE-10015 Alexey Goncharuk Sporadic JVM crash due to > restart nodes > > > > > > > > > IGNITE-10013 Unassigned Node restart may lead to NPE in > > > > > > > > > GridDhtPartitionsExchangeFuture > > > > > > > > > IGNITE-9928 Igor Seliverstov MVCC TX: Late affinity > assignment support. > > > > > > > > > IGNITE-9985 Igor Seliverstov MVCC TX: fix backup mappings > > > > >
Re: Apache Ignite 2.7. Last Mile
Hello, Igniters. This issue is the only ticket that blocks 2.7 release. I looked at IGNITE-602 PR and GridToStringBuilder. The code looks complicated for me. And it's not obvious for me how to fix this issue in a short period of time. Especially, code deals with recursion and other things that can lead to very dangerous errors. Let's revert this patch and fix it in calmly. Also, we need additional tests for it. В Пт, 16/11/2018 в 17:57 +0300, Dmitrii Ryabov пишет: > Ok, I'll check the issue. > пт, 16 нояб. 2018 г. в 17:52, Alexey Goncharuk : > > > > Igniters, > > > > I've just found that S.toString() implementation is broken in ignite-2.7 > > and master [1]. It leads to a message > > Wrapper [p=Parent [a=0]Child [b=0, super=]] > > being formed instead of > > Wrapper [p=Child [b=0, super=Parent [a=0]]] > > for classes with inheritance that use S.toString(SomeClass.class, this, > > super.toString()) embedded to some other object. > > > > Dmitrii Ryabov, I've reverted two commits related to IGNITE-602 and > > IGNITE-9209 tickets locally and it fixes the issue. Can you take a look at > > the issue? > > > > I think this regression essentially makes our logs unreadable in some cases > > and I would like to get it fixed in ignite-2.7 or revert both commits from > > the release. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10301 > > > > пт, 9 нояб. 2018 г. в 09:22, Nikolay Izhikov : > > > > > > Hello, Igniters. > > > > > > We still have 5 tickets for 2.7: > > > > > > IGNITE-10052Andrew Mashenkov Restart node during TX causes vacuum > > > error. > > > IGNITE-10170Unassigned .NET: Services.ServicesTestAsync fails > > > IGNITE-10196Maxim Pudov Remove kafka-clients-*-test dependency > > > IGNITE-10154Andrey Gura Critical worker liveness check > > > configuration is non-trivial and inconsistent > > > IGNITE-9996 Nikolay Izhikov Investigate possible performance drop in > > > FSYNC mode for ignite-2.7 compared to ignite-2.6 > > > > > > > > > В Чт, 08/11/2018 в 14:25 +0300, Nikolay Izhikov пишет: > > > > I'm OK with this. > > > > > > > > чт, 8 нояб. 2018 г., 13:44 Andrey Gura ag...@apache.org: > > > > > Long, long way to release :) > > > > > > > > > > Guys, we have a breaking change in Ignite 2.7 so we must add > > > > > IGNITE-10154 [1] fix to the release. > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-10154 > > > > > On Tue, Nov 6, 2018 at 6:30 PM Igor Sapego wrote: > > > > > > > > > > > > Guys, > > > > > > > > > > > > I've found the following issue: [1]. It is quite local (only affects > > > > > > Ignite C++ Linux build system) but quite critical too. I think it > > > > > > should be included in 2.7. > > > > > > > > > > > > What do you think? > > > > > > > > > > > > [1] - https://issues.apache.org/jira/browse/IGNITE-10147 > > > > > > > > > > > > Best Regards, > > > > > > Igor > > > > > > > > > > > > > > > > > > On Tue, Oct 30, 2018 at 4:35 PM Вячеслав Коптилин > > > > > > > > > > > > wrote: > > > > > > > > > > > > > Hello Nikolay, Igniters, > > > > > > > > > > > > > > It seems that we lost the following commit that should be > > > > > > > included in > > > > > > > 'ignite-2.7' branch > > > > > > > (It looks like the change was not accidentally cherry-picked from > > > > > > > 'master' > > > > > > > to 'ignite-2.7') > > > > > > > - > > > > > > > > > > > > > > https://github.com/apache/ignite/commit/6e0ff06f8e309657a16c94da605348d9c3b804ad > > > > > > > > > > > > > > The most important part is the change introduced into > > > > > > > GridDhtAtomicCache, > > > > > > > the fix prevents NullPointerException during cache updates under > > > > > > > some > > > > > > > circumstances. > > > > > > > So, I propose including the fix into ignite-2.7, at least the > > > > > > > change of > > > > > > > GridDhtAtomicCache. > > > > > > > > > > > > > > Thanks, > > > > > > > Slava. > > > > > > > > > > > > > > пн, 29 окт. 2018 г. в 11:20, Nikolay Izhikov > > > > > > > : > > > > > > > > > > > > > > > Hello, guys. > > > > > > > > > > > > > > > > For today we have 11 tickets mapped to 2.7 > > > > > > > > > > > > > > > > IGNITE-10010 Alexey Goncharuk Node halted if second node was > > > > > > > > stopped, > > > > > > > > > > > > > > then > > > > > > > > cache destroyed, then second node returned > > > > > > > > IGNITE-10015 Alexey Goncharuk Sporadic JVM crash due to restart > > > > > > > > nodes > > > > > > > > IGNITE-10013 Unassigned Node restart may lead to NPE in > > > > > > > > GridDhtPartitionsExchangeFuture > > > > > > > > IGNITE-9928 Igor Seliverstov MVCC TX: Late affinity assignment > > > > > > > > support. > > > > > > > > IGNITE-9985 Igor Seliverstov MVCC TX: fix backup mappings > > > > > > > > IGNITE-10007 Sergey Kozlov Deactivation hangs if an open > > > > > > > > transaction > > > > > > > > > > > > > > exists > > > > > > > > IGNITE-10004 Andrew Mashenkov Parse error leads to leave the > > > > > > > >
[jira] [Created] (IGNITE-10313) Long exchange on deactivation process
ARomantsov created IGNITE-10313: --- Summary: Long exchange on deactivation process Key: IGNITE-10313 URL: https://issues.apache.org/jira/browse/IGNITE-10313 Project: Ignite Issue Type: Bug Affects Versions: 2.7 Environment: 16 host, 1 server node per host Reporter: ARomantsov Fix For: 2.8 Long exhange after start deactivation process - near to three minutes. Probably in doesn't end, but control.sh return to control to console and I stop cluster -- This message was sent by Atlassian JIRA (v7.6.3#76005)
