Release process wiki update
Hi Igniters, I've started the process of updating https://cwiki.apache.org/confluence/display/IGNITE/Release+Process and merging other pages and sources into one single page. The document is not final, I will add changes as soon as I do steps. Feedback is, as always, welcomed! Sincerely Dmitriy Pavlov
Re: SQL query crashes Ignite.
Hello!
Consider adding ;lazy=true to connection string. You're causing overly huge
result set to be held on heap otherwise.
Regards,
--
Ilya Kasnacheev
пт, 7 июн. 2019 г. в 19:07, Shane Duan :
> Thanks Denis.
>
> Oops, copied wrong section of log file. The previous log which complains
> schema will happen for any further operations once Ignite crashed.
>
> Here is how I prepared the JDBC connection:
>
> String connectionStr = "jdbc:ignite:thin://" + hostName + ":" + portNumber
> +";"
> + "schema=" + schema + ";"
> + "user=" + userName + ";"
> + "password=" + password;
>
> // Register JDBC driver.
> Class.forName("org.apache.ignite.IgniteJdbcThinDriver");
>
> // Open the JDBC connection with predefined connection endpoints.
> Connection conn = DriverManager.getConnection(connectionStr);
>
>
> The example works if just fetch a couple of rows.
>
> Here is the right log.
>
>
> 2019-06-06 10:42:34,402 DEBUG Client request received [reqId=0, addr=/
> 10.212.22.67:54469, req=JdbcQueryExecuteRequest
> [schemaName=FEATURE_TILE_CACHE, pageSize=1024, maxRows=0, sqlQry=SELECT id,
> val FROM CITY WHERE id > 500, args=[], stmtType=SELECT_STATEMENT_TYPE,
> autoCommit=true]]
> 2019-06-06 10:42:34,407 DEBUG Set schema: FEATURE_TILE_CACHE
> 2019-06-06 10:42:34,448 DEBUG Parsed query: `SELECT id, val FROM CITY WHERE
> id > 500` into two step query: GridCacheTwoStepQuery
> [mapQrys=[GridCacheSqlQuery [qry=SELECT
> __Z0.ID __C0_0,
> __Z0.VAL __C0_1
> FROM FEATURE_TILE_CACHE.CITY __Z0
> WHERE __Z0.ID > 500, paramIdxs=[], cols={__C0_0=GridSqlType [type=5,
> scale=0, precision=19, displaySize=20, sql=BIGINT], __C0_1=GridSqlType
> [type=12, scale=0, precision=2147483647, displaySize=2147483647,
> sql=VARBINARY]}, alias=null, sort=[], partitioned=true, node=null,
> derivedPartitions=null, hasSubQries=false]], rdc=GridCacheSqlQuery
> [qry=SELECT
> __C0_0 ID,
> __C0_1 VAL
> FROM PUBLIC.__T0, paramIdxs=[], cols=null, alias=null, sort=null,
> partitioned=false, node=null, derivedPartitions=null, hasSubQries=false],
> pageSize=1024, explain=false, originalSql=SELECT
> ID,
> VAL
> FROM FEATURE_TILE_CACHE.CITY
> WHERE ID > 500, distributedJoins=false, skipMergeTbl=true, local=false,
> mvccEnabled=false, forUpdate=false]
> 2019-06-06 10:42:34,448 DEBUG Parsed query: `SELECT id, val FROM CITY WHERE
> id > 500` into two step query: GridCacheTwoStepQuery
> [mapQrys=[GridCacheSqlQuery [qry=SELECT
> __Z0.ID __C0_0,
> __Z0.VAL __C0_1
> FROM FEATURE_TILE_CACHE.CITY __Z0
> WHERE __Z0.ID > 500, paramIdxs=[], cols={__C0_0=GridSqlType [type=5,
> scale=0, precision=19, displaySize=20, sql=BIGINT], __C0_1=GridSqlType
> [type=12, scale=0, precision=2147483647, displaySize=2147483647,
> sql=VARBINARY]}, alias=null, sort=[], partitioned=true, node=null,
> derivedPartitions=null, hasSubQries=false]], rdc=GridCacheSqlQuery
> [qry=SELECT
> __C0_0 ID,
> __C0_1 VAL
> FROM PUBLIC.__T0, paramIdxs=[], cols=null, alias=null, sort=null,
> partitioned=false, node=null, derivedPartitions=null, hasSubQries=false],
> pageSize=1024, explain=false, originalSql=SELECT
> ID,
> VAL
> FROM FEATURE_TILE_CACHE.CITY
> WHERE ID > 500, distributedJoins=false, skipMergeTbl=true, local=false,
> mvccEnabled=false, forUpdate=false]
> 2019-06-06 10:42:34,457 DEBUG Sending: [msg=GridH2QueryRequest [reqId=1,
> caches=[-2013421729], topVer=AffinityTopologyVersion [topVer=1,
> minorTopVer=2], parts=null, qryParts=null, pageSize=1024,
> qrys=[GridCacheSqlQuery [qry=SELECT
> __Z0.ID __C0_0,
> __Z0.VAL __C0_1
> FROM FEATURE_TILE_CACHE.CITY __Z0
> WHERE __Z0.ID > 500, paramIdxs=[], cols={__C0_0=GridSqlType [type=5,
> scale=0, precision=19, displaySize=20, sql=BIGINT], __C0_1=GridSqlType
> [type=12, scale=0, precision=2147483647, displaySize=2147483647,
> sql=VARBINARY]}, alias=null, sort=[], partitioned=true, node=null,
> derivedPartitions=null, hasSubQries=false]], flags=2, tbls=null, timeout=0,
> params=[], schemaName=FEATURE_TILE_CACHE, mvccSnapshot=null, txReq=null],
> nodes=[TcpDiscoveryNode [id=9f8714ae-d9ba-4135-836c-ca8c2a1cc4c1,
> addrs=[0:0:0:0:0:0:0:1%lo, 10.29.77.101, 127.0.0.1, 172.17.0.1],
> sockAddrs=[/172.17.0.1:9820, greentea.esri.com/10.29.77.101:9820,
> /0:0:0:0:0:0:0:1%lo:9820, /127.0.0.1:9820], discPort=9820, order=1,
> intOrder=1, lastExchangeTime=1559842863817, loc=true,
> ver=2.7.0#20181130-sha1:256ae401, isClient=false]], specialize=null]
> 2019-06-06 10:42:34,463 DEBUG Getting internal cache adapter:
> SQL_FEATURE_TILE_CACHE_CITY
> 2019-06-06 10:42:34,644 DEBUG Balancing data [min0=0, minIdx=0, max0=-1,
> maxIdx=-1]
> 2019-06-06 10:42:35,195 DEBUG Balancing data [min0=0, minIdx=0, max0=-1,
> maxIdx=-1]
> 2019-06-06 10:42:35,642 DEBUG Timeout has occurred [obj=CancelableTask
> [id=a3531ed2b61-03a278bc-9575-4d0a-932a-cd5848a66225,
> endTime=1559842955633, period=2000, cancel=false,
>
> task=org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing$13@3ee9d374
> ],
> process=true]
> 2019-06-06 10:42:35,669 DEBUG Balancing data [min0=0, minIdx=0,
Re: SQL query crashes Ignite.
Thanks Denis.
Oops, copied wrong section of log file. The previous log which complains
schema will happen for any further operations once Ignite crashed.
Here is how I prepared the JDBC connection:
String connectionStr = "jdbc:ignite:thin://" + hostName + ":" + portNumber +";"
+ "schema=" + schema + ";"
+ "user=" + userName + ";"
+ "password=" + password;
// Register JDBC driver.
Class.forName("org.apache.ignite.IgniteJdbcThinDriver");
// Open the JDBC connection with predefined connection endpoints.
Connection conn = DriverManager.getConnection(connectionStr);
The example works if just fetch a couple of rows.
Here is the right log.
2019-06-06 10:42:34,402 DEBUG Client request received [reqId=0, addr=/
10.212.22.67:54469, req=JdbcQueryExecuteRequest
[schemaName=FEATURE_TILE_CACHE, pageSize=1024, maxRows=0, sqlQry=SELECT id,
val FROM CITY WHERE id > 500, args=[], stmtType=SELECT_STATEMENT_TYPE,
autoCommit=true]]
2019-06-06 10:42:34,407 DEBUG Set schema: FEATURE_TILE_CACHE
2019-06-06 10:42:34,448 DEBUG Parsed query: `SELECT id, val FROM CITY WHERE
id > 500` into two step query: GridCacheTwoStepQuery
[mapQrys=[GridCacheSqlQuery [qry=SELECT
__Z0.ID __C0_0,
__Z0.VAL __C0_1
FROM FEATURE_TILE_CACHE.CITY __Z0
WHERE __Z0.ID > 500, paramIdxs=[], cols={__C0_0=GridSqlType [type=5,
scale=0, precision=19, displaySize=20, sql=BIGINT], __C0_1=GridSqlType
[type=12, scale=0, precision=2147483647, displaySize=2147483647,
sql=VARBINARY]}, alias=null, sort=[], partitioned=true, node=null,
derivedPartitions=null, hasSubQries=false]], rdc=GridCacheSqlQuery
[qry=SELECT
__C0_0 ID,
__C0_1 VAL
FROM PUBLIC.__T0, paramIdxs=[], cols=null, alias=null, sort=null,
partitioned=false, node=null, derivedPartitions=null, hasSubQries=false],
pageSize=1024, explain=false, originalSql=SELECT
ID,
VAL
FROM FEATURE_TILE_CACHE.CITY
WHERE ID > 500, distributedJoins=false, skipMergeTbl=true, local=false,
mvccEnabled=false, forUpdate=false]
2019-06-06 10:42:34,448 DEBUG Parsed query: `SELECT id, val FROM CITY WHERE
id > 500` into two step query: GridCacheTwoStepQuery
[mapQrys=[GridCacheSqlQuery [qry=SELECT
__Z0.ID __C0_0,
__Z0.VAL __C0_1
FROM FEATURE_TILE_CACHE.CITY __Z0
WHERE __Z0.ID > 500, paramIdxs=[], cols={__C0_0=GridSqlType [type=5,
scale=0, precision=19, displaySize=20, sql=BIGINT], __C0_1=GridSqlType
[type=12, scale=0, precision=2147483647, displaySize=2147483647,
sql=VARBINARY]}, alias=null, sort=[], partitioned=true, node=null,
derivedPartitions=null, hasSubQries=false]], rdc=GridCacheSqlQuery
[qry=SELECT
__C0_0 ID,
__C0_1 VAL
FROM PUBLIC.__T0, paramIdxs=[], cols=null, alias=null, sort=null,
partitioned=false, node=null, derivedPartitions=null, hasSubQries=false],
pageSize=1024, explain=false, originalSql=SELECT
ID,
VAL
FROM FEATURE_TILE_CACHE.CITY
WHERE ID > 500, distributedJoins=false, skipMergeTbl=true, local=false,
mvccEnabled=false, forUpdate=false]
2019-06-06 10:42:34,457 DEBUG Sending: [msg=GridH2QueryRequest [reqId=1,
caches=[-2013421729], topVer=AffinityTopologyVersion [topVer=1,
minorTopVer=2], parts=null, qryParts=null, pageSize=1024,
qrys=[GridCacheSqlQuery [qry=SELECT
__Z0.ID __C0_0,
__Z0.VAL __C0_1
FROM FEATURE_TILE_CACHE.CITY __Z0
WHERE __Z0.ID > 500, paramIdxs=[], cols={__C0_0=GridSqlType [type=5,
scale=0, precision=19, displaySize=20, sql=BIGINT], __C0_1=GridSqlType
[type=12, scale=0, precision=2147483647, displaySize=2147483647,
sql=VARBINARY]}, alias=null, sort=[], partitioned=true, node=null,
derivedPartitions=null, hasSubQries=false]], flags=2, tbls=null, timeout=0,
params=[], schemaName=FEATURE_TILE_CACHE, mvccSnapshot=null, txReq=null],
nodes=[TcpDiscoveryNode [id=9f8714ae-d9ba-4135-836c-ca8c2a1cc4c1,
addrs=[0:0:0:0:0:0:0:1%lo, 10.29.77.101, 127.0.0.1, 172.17.0.1],
sockAddrs=[/172.17.0.1:9820, greentea.esri.com/10.29.77.101:9820,
/0:0:0:0:0:0:0:1%lo:9820, /127.0.0.1:9820], discPort=9820, order=1,
intOrder=1, lastExchangeTime=1559842863817, loc=true,
ver=2.7.0#20181130-sha1:256ae401, isClient=false]], specialize=null]
2019-06-06 10:42:34,463 DEBUG Getting internal cache adapter:
SQL_FEATURE_TILE_CACHE_CITY
2019-06-06 10:42:34,644 DEBUG Balancing data [min0=0, minIdx=0, max0=-1,
maxIdx=-1]
2019-06-06 10:42:35,195 DEBUG Balancing data [min0=0, minIdx=0, max0=-1,
maxIdx=-1]
2019-06-06 10:42:35,642 DEBUG Timeout has occurred [obj=CancelableTask
[id=a3531ed2b61-03a278bc-9575-4d0a-932a-cd5848a66225,
endTime=1559842955633, period=2000, cancel=false,
task=org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing$13@3ee9d374],
process=true]
2019-06-06 10:42:35,669 DEBUG Balancing data [min0=0, minIdx=0, max0=-1,
maxIdx=-1]
2019-06-06 10:42:36,634 DEBUG Timeout has occurred [obj=CancelableTask
[id=b3531ed2b61-03a278bc-9575-4d0a-932a-cd5848a66225,
endTime=1559842956623, period=3000, cancel=false,
task=org.apache.ignite.internal.processors.query.GridQueryProcessor$2@1cd33664],
process=true]
2019-06-06 10:42:36,916 DEBUG Timeout has occurred [obj=CancelableTask
Re: Code styles issues in IGNITE-11750
Nikolay, +1. I'd add my 50 cents. There should no TODOs without any ticket link, otherwise such TODOs will never be fixed. On Fri, Jun 7, 2019 at 4:23 PM Andrey Gura wrote: > Big +1 from me. > Make code base clean and clear. > > On Fri, Jun 7, 2019 at 3:26 PM Nikolay Izhikov > wrote: > > > > Hello, Igniters. > > > > Please, pay attention to commits quality. > > > > 1. Please, writer Javadocs. > > 2. Please, make the new lines according to code style. > > > > Issues like [1] has to be fixed *BEFORE* commit. > > > > > > [1] > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java#L45 > > > -- Best regards, Andrey V. Mashenkov
[jira] [Created] (IGNITE-11903) Checkstyle must support to JavadocStyle rule
Maxim Muzafarov created IGNITE-11903:
Summary: Checkstyle must support to JavadocStyle rule
Key: IGNITE-11903
URL: https://issues.apache.org/jira/browse/IGNITE-11903
Project: Ignite
Issue Type: Bug
Reporter: Maxim Muzafarov
Add support to to checkstyle plugin. Analyze and
set the best-fit configuration properties for the Apache Ignite needs.
[http://checkstyle.sourceforge.net/config_javadoc.html#JavadocStyle]
{noformat}
Validates Javadoc comments to help ensure they are well formed. The following
checks are performed:
Ensures the first sentence ends with proper punctuation (That is a period,
question mark, or exclamation mark, by default). Javadoc automatically places
the first sentence in the method summary table and index. Without proper
punctuation the Javadoc may be malformed. All items eligible for the
{@inheritDoc} tag are exempt from this requirement.
Check text for Javadoc statements that do not have any description. This
includes both completely empty Javadoc, and Javadoc with only tags such as
@param and @return.
Check text for incomplete HTML tags. Verifies that HTML tags have corresponding
end tags and issues an "Unclosed HTML tag found:" error if not. An "Extra HTML
tag found:" error is issued if an end tag is found without a previous open tag.
Check that a package Javadoc comment is well-formed (as described above) and
NOT missing from any package-info.java files.
Check for allowed HTML tags. The list of allowed HTML tags is "a", "abbr",
"acronym", "address", "area", "b", "bdo", "big", "blockquote", "br", "caption",
"cite", "code", "colgroup", "dd", "del", "div", "dfn", "dl", "dt", "em",
"fieldset", "font", "h1" to "h6", "hr", "i", "img", "ins", "kbd", "li", "ol",
"p", "pre", "q", "samp", "small", "span", "strong", "sub", "sup", "table",
"tbody", "td", "tfoot", "th", "thread", "tr", "tt", "u", "ul".
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-11902) Checkstyle must support MagicNumbers rule
Maxim Muzafarov created IGNITE-11902:
Summary: Checkstyle must support MagicNumbers rule
Key: IGNITE-11902
URL: https://issues.apache.org/jira/browse/IGNITE-11902
Project: Ignite
Issue Type: Bug
Reporter: Maxim Muzafarov
Add support to checkstyle plugin.
Checks that there are no "magic numbers" where a magic number is a numeric
literal that is not defined as a constant. By default, -1, 0, 1, and 2 are not
considered to be magic numbers.
Constant definition is any variable/field that has 'final' modifier. It is fine
to have one constant defining multiple numeric literals within one expression:
{code}
static final int SECONDS_PER_DAY = 24 * 60 * 60;
static final double SPECIAL_RATIO = 4.0 / 3.0;
static final double SPECIAL_SUM = 1 + Math.E;
static final double SPECIAL_DIFFERENCE = 4 - Math.PI;
static final Border STANDARD_BORDER = BorderFactory.createEmptyBorder(3, 3, 3,
3);
static final Integer ANSWER_TO_THE_ULTIMATE_QUESTION_OF_LIFE = new Integer(42);
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-11901) CacheMvccTransactionsTest.testMvccCoordinatorChangeSimple is flaky
Ivan Pavlukhin created IGNITE-11901: --- Summary: CacheMvccTransactionsTest.testMvccCoordinatorChangeSimple is flaky Key: IGNITE-11901 URL: https://issues.apache.org/jira/browse/IGNITE-11901 Project: Ignite Issue Type: Bug Components: mvcc Reporter: Ivan Pavlukhin Assignee: Ivan Pavlukhin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Code styles issues in IGNITE-11750
Big +1 from me. Make code base clean and clear. On Fri, Jun 7, 2019 at 3:26 PM Nikolay Izhikov wrote: > > Hello, Igniters. > > Please, pay attention to commits quality. > > 1. Please, writer Javadocs. > 2. Please, make the new lines according to code style. > > Issues like [1] has to be fixed *BEFORE* commit. > > > [1] > https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java#L45 >
[jira] [Created] (IGNITE-11900) Fix ClassPathContentLoggingTest test
Denis Chudov created IGNITE-11900: - Summary: Fix ClassPathContentLoggingTest test Key: IGNITE-11900 URL: https://issues.apache.org/jira/browse/IGNITE-11900 Project: Ignite Issue Type: Bug Reporter: Denis Chudov Assignee: Denis Chudov This test failed in TC because of incorrect path separator in beforeTestsStarted. Should be File.pathSeparator instead of ';'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [Code Style Check] TC issues in master
Hello, Petr. > at least Scala does not compile How cat I reproduce it? Do we have ticket? В Пт, 07/06/2019 в 15:28 +0300, Petr Ivanov пишет: > Suite fails because Apache Ignite compilation is not supported under JDK 9+ > (at least Scala does not compile). > Your build from [3] was triggered with JDK 11. > > > On 7 Jun 2019, at 14:57, Maxim Muzafarov wrote: > > > > Igniters, > > > > I've noticed a few problems with Code Style Check Suite on TC in the > > master branch. > > > > 1. Some of the rules have been violated by previous commits to the > > master branch. I've created ticket [1] and have prepared PR [2] which > > is fixing it. > > Dmitry, or maybe someone else, can you take a look, please? > > > > 2. The Code Style Check Stuite still fails (time to time) on TC with > > compile error on [ignite-scalar] module > > (java.lang.NoClassDefFoundError: javax/tools/ToolProvider). For > > instance, this build [3] fails and this is fully ok [4]. However, the > > ~Build Apache Ignite~ Suite with almost the same configuration passes > > normally. > > > > I'd like to create a new suite with checkstyle for debug purposes, can > > anyone grant permission to copy\clone\edit suites on TC? My login: > > maxmu...@gmail.com > > > > [1] https://issues.apache.org/jira/browse/IGNITE-11899 > > [2] https://github.com/apache/ignite/pull/6597 > > [3] > > https://ci.ignite.apache.org/viewLog.html?buildId=4020653=IgniteTests24Java8_CheckCodeStyle=buildLog_IgniteTests24Java8=%3Cdefault%3E > > [4] > > https://ci.ignite.apache.org/viewLog.html?buildId=4021372=IgniteTests24Java8_CheckCodeStyle > > signature.asc Description: This is a digitally signed message part
Re: [Code Style Check] TC issues in master
Petr, Yes, I see thanks. How can we force the suite to use the only JDK8? I see the configuration parameter: JDK home path: %env.JDK_ORA_18%, but probably it works not well enough. On Fri, 7 Jun 2019 at 15:28, Petr Ivanov wrote: > > Suite fails because Apache Ignite compilation is not supported under JDK 9+ > (at least Scala does not compile). > Your build from [3] was triggered with JDK 11. > > > On 7 Jun 2019, at 14:57, Maxim Muzafarov wrote: > > > > Igniters, > > > > I've noticed a few problems with Code Style Check Suite on TC in the > > master branch. > > > > 1. Some of the rules have been violated by previous commits to the > > master branch. I've created ticket [1] and have prepared PR [2] which > > is fixing it. > > Dmitry, or maybe someone else, can you take a look, please? > > > > 2. The Code Style Check Stuite still fails (time to time) on TC with > > compile error on [ignite-scalar] module > > (java.lang.NoClassDefFoundError: javax/tools/ToolProvider). For > > instance, this build [3] fails and this is fully ok [4]. However, the > > ~Build Apache Ignite~ Suite with almost the same configuration passes > > normally. > > > > I'd like to create a new suite with checkstyle for debug purposes, can > > anyone grant permission to copy\clone\edit suites on TC? My login: > > maxmu...@gmail.com > > > > [1] https://issues.apache.org/jira/browse/IGNITE-11899 > > [2] https://github.com/apache/ignite/pull/6597 > > [3] > > https://ci.ignite.apache.org/viewLog.html?buildId=4020653=IgniteTests24Java8_CheckCodeStyle=buildLog_IgniteTests24Java8=%3Cdefault%3E > > [4] > > https://ci.ignite.apache.org/viewLog.html?buildId=4021372=IgniteTests24Java8_CheckCodeStyle >
Re: [Code Style Check] TC issues in master
Suite fails because Apache Ignite compilation is not supported under JDK 9+ (at least Scala does not compile). Your build from [3] was triggered with JDK 11. > On 7 Jun 2019, at 14:57, Maxim Muzafarov wrote: > > Igniters, > > I've noticed a few problems with Code Style Check Suite on TC in the > master branch. > > 1. Some of the rules have been violated by previous commits to the > master branch. I've created ticket [1] and have prepared PR [2] which > is fixing it. > Dmitry, or maybe someone else, can you take a look, please? > > 2. The Code Style Check Stuite still fails (time to time) on TC with > compile error on [ignite-scalar] module > (java.lang.NoClassDefFoundError: javax/tools/ToolProvider). For > instance, this build [3] fails and this is fully ok [4]. However, the > ~Build Apache Ignite~ Suite with almost the same configuration passes > normally. > > I'd like to create a new suite with checkstyle for debug purposes, can > anyone grant permission to copy\clone\edit suites on TC? My login: > maxmu...@gmail.com > > [1] https://issues.apache.org/jira/browse/IGNITE-11899 > [2] https://github.com/apache/ignite/pull/6597 > [3] > https://ci.ignite.apache.org/viewLog.html?buildId=4020653=IgniteTests24Java8_CheckCodeStyle=buildLog_IgniteTests24Java8=%3Cdefault%3E > [4] > https://ci.ignite.apache.org/viewLog.html?buildId=4021372=IgniteTests24Java8_CheckCodeStyle
Code styles issues in IGNITE-11750
Hello, Igniters. Please, pay attention to commits quality. 1. Please, writer Javadocs. 2. Please, make the new lines according to code style. Issues like [1] has to be fixed *BEFORE* commit. [1] https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java#L45 signature.asc Description: This is a digitally signed message part
[Code Style Check] TC issues in master
Igniters, I've noticed a few problems with Code Style Check Suite on TC in the master branch. 1. Some of the rules have been violated by previous commits to the master branch. I've created ticket [1] and have prepared PR [2] which is fixing it. Dmitry, or maybe someone else, can you take a look, please? 2. The Code Style Check Stuite still fails (time to time) on TC with compile error on [ignite-scalar] module (java.lang.NoClassDefFoundError: javax/tools/ToolProvider). For instance, this build [3] fails and this is fully ok [4]. However, the ~Build Apache Ignite~ Suite with almost the same configuration passes normally. I'd like to create a new suite with checkstyle for debug purposes, can anyone grant permission to copy\clone\edit suites on TC? My login: maxmu...@gmail.com [1] https://issues.apache.org/jira/browse/IGNITE-11899 [2] https://github.com/apache/ignite/pull/6597 [3] https://ci.ignite.apache.org/viewLog.html?buildId=4020653=IgniteTests24Java8_CheckCodeStyle=buildLog_IgniteTests24Java8=%3Cdefault%3E [4] https://ci.ignite.apache.org/viewLog.html?buildId=4021372=IgniteTests24Java8_CheckCodeStyle
[jira] [Created] (IGNITE-11899) Fix code style violation
Maxim Muzafarov created IGNITE-11899:
Summary: Fix code style violation
Key: IGNITE-11899
URL: https://issues.apache.org/jira/browse/IGNITE-11899
Project: Ignite
Issue Type: Bug
Reporter: Maxim Muzafarov
Assignee: Maxim Muzafarov
All the code style issues must be fixed, see the sample below.
{code}
[09:38:03] [Step 2/2] [ERROR]
/opt/buildagent/work/69588afcb2ab3382/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java:50:
'VARIABLE_DEF' should be separated from previous statement.
[EmptyLineSeparator]
[09:38:03] [Step 2/2] [ERROR]
/opt/buildagent/work/69588afcb2ab3382/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java:183:
'VARIABLE_DEF' should be separated from previous statement.
[EmptyLineSeparator]
[09:38:03] [Step 2/2] [ERROR]
/opt/buildagent/work/69588afcb2ab3382/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java:187:
'VARIABLE_DEF' should be separated from previous statement.
[EmptyLineSeparator]
[09:38:03] [Step 2/2] [ERROR]
/opt/buildagent/work/69588afcb2ab3382/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java:191:
'VARIABLE_DEF' should be separated from previous statement.
[EmptyLineSeparator]
{code}
TC log:
https://ci.ignite.apache.org/viewLog.html?buildId=4062737=IgniteTests24Java8_CheckCodeStyle=buildLog_IgniteTests24Java8=%3Cdefault%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [DISCUSSION] Release Apache Ignite 2.7.5-rc4
Vyacheslav, > Ivan, according to described issues with versions it looks like some > previously built artefacts have been cashed in Maven local repository. Versions I saw actually are consistent with a way how they had been built. But they look a little bit surprising. But actually I do not know our expectations for them.. пт, 7 июн. 2019 г. в 11:49, Vyacheslav Daradur : > > Dmitry, thank you for pointing this out, I just mixed threads. > > >> 3. Some mix of versions reported by nodes launched in different ways. > Ivan, according to described issues with versions it looks like some > previously built artefacts have been cashed in Maven local repository. > > On Fri, Jun 7, 2019 at 9:45 AM Павлухин Иван wrote: > > > > Vyacheslav, > > > > > Ivan, try to clean local repo (~/m2) and rebuild the project once again > > > according to DEVNOTES.txt > > > > Thank you for suggestion! But what problem it will solve? > > > > пт, 7 июн. 2019 г. в 00:52, Dmitriy Pavlov : > > > > > > Hi Vyacheslav, > > > > > > I'm sorry for being too formal here, although could you please cast your > > > vote in > > > https://lists.apache.org/thread.html/35cbc2d4c5b769155dc8aec15edd808a25c5cf48a5e12637528e931d@%3Cdev.ignite.apache.org%3E > > > > > > And thank you for advice on how to check examples. > > > > > > Sincerely > > > Dmitriy Pavlov > > > > > > чт, 6 июн. 2019 г. в 22:37, Vyacheslav Daradur : > > > > > > > +1 from me. Built from sources and run several examples. > > > > > > > > Ivan, try to clean local repo (~/m2) and rebuild the project once > > > > again according to DEVNOTES.txt > > > > > > > > On Thu, Jun 6, 2019 at 7:37 PM Павлухин Иван > > > > wrote: > > > > > > > > > > I spent a while running examples for RC from bin package. I did the > > > > following: > > > > > 1. "mvn clean install" for src package in order to have all > > > > > dependencies needed for examples in local maven repo on my machine. > > > > > 2. Tried to compile and launch examples from bin package. > > > > > 2.1 Failed claiming that classes from org.jetbrains.annotations are > > > > > not present on classpath. > > > > > 2.2. Fixed by adding a corresponding dependency to examples pom > > > > > manually. Run SQL examples successfully. > > > > > > > > > > So, I observed following glitches: > > > > > 1. Missing dependency containing org.jetbrains.annotations in examples > > > > > in bin package. > > > > > 2. "2018 Copyright(C) Apache Software Foundation" with year 2018 in > > > > > console output when starting ignite (using examples main classes and > > > > > ignite.sh). > > > > > 3. Some mix of versions reported by nodes launched in different ways. > > > > > 3.1 ignite.sh from bin package -- ver. 2.7.5#20190603-sha1:be4f2a15 > > > > > 3.2. examples main classes from bin package -- ver. > > > > 2.7.5#19700101-sha1:DEV > > > > > 3.3. examples main classes from src package -- ver. > > > > > 2.7.5-SNAPSHOT#19700101-sha1:DEV > > > > > > > > > > ср, 5 июн. 2019 г. в 18:59, Dmitriy Pavlov : > > > > > > > > > > > > I managed to get some build using build number from 1. Release build > > > > step > > > > > > (for that case - 20) > > > > > > > > > > > > The result can be found here > > > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=4049646=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages=artifacts#%2Fsrc > > > > > > > > > > > > Pavel T., Peter I., > > > > > > > > > > > > Please confirm that it is sufficient. I'll update the release > > > > > > manager > > > > notes > > > > > > with steps required to run this configuration. > > > > > > > > > > > > Sincerely > > > > > > Dmitriy Pavlov > > > > > > > > > > > > ср, 5 июн. 2019 г. в 18:07, Dmitriy Pavlov : > > > > > > > > > > > > > I've found only this step > > > > > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages=buildTypeStatusDiv_Releases_ApacheIgniteMain=__all_branches__ > > > > > > > > > > > > > > > > > > > > > It requires some build counter. > > > > > > > > > > > > > > Peter I, could you please chime in? > > > > > > > > > > > > > > ср, 5 июн. 2019 г. в 18:02, Dmitriy Pavlov : > > > > > > > > > > > > > >> Hi Igniters, Pavel T., > > > > > > >> > > > > > > >> I'm struggling to find clear steps for building/uploading NuGet > > > > packages. > > > > > > >> How can I double check if it was built or not? What should I do? > > > > > > >> > > > > > > >> In some internal notes, I've found that NuGet upload can't be > > > > undone, and > > > > > > >> in > > > > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process it > > > > > > >> is a post-release step. > > > > > > >> > > > > > > >> Please advise, both here or in private. I will update the > > > > instructions > > > > > > >> accordingly. > > > > > > >> > > > > > > >> Sincerely > > > > > > >> Dmitriy Pavlov > > > > > > >> > > > > > > >> ср, 5 июн. 2019 г. в 15:27, Dmitriy Pavlov : > > > > > > >> > > > > > > >>> Hi Ivan, > > > > > > >>> > > > >
Re: [DISCUSSION] Release Apache Ignite 2.7.5-rc4
Dmitry, thank you for pointing this out, I just mixed threads. >> 3. Some mix of versions reported by nodes launched in different ways. Ivan, according to described issues with versions it looks like some previously built artefacts have been cashed in Maven local repository. On Fri, Jun 7, 2019 at 9:45 AM Павлухин Иван wrote: > > Vyacheslav, > > > Ivan, try to clean local repo (~/m2) and rebuild the project once again > > according to DEVNOTES.txt > > Thank you for suggestion! But what problem it will solve? > > пт, 7 июн. 2019 г. в 00:52, Dmitriy Pavlov : > > > > Hi Vyacheslav, > > > > I'm sorry for being too formal here, although could you please cast your > > vote in > > https://lists.apache.org/thread.html/35cbc2d4c5b769155dc8aec15edd808a25c5cf48a5e12637528e931d@%3Cdev.ignite.apache.org%3E > > > > And thank you for advice on how to check examples. > > > > Sincerely > > Dmitriy Pavlov > > > > чт, 6 июн. 2019 г. в 22:37, Vyacheslav Daradur : > > > > > +1 from me. Built from sources and run several examples. > > > > > > Ivan, try to clean local repo (~/m2) and rebuild the project once > > > again according to DEVNOTES.txt > > > > > > On Thu, Jun 6, 2019 at 7:37 PM Павлухин Иван wrote: > > > > > > > > I spent a while running examples for RC from bin package. I did the > > > following: > > > > 1. "mvn clean install" for src package in order to have all > > > > dependencies needed for examples in local maven repo on my machine. > > > > 2. Tried to compile and launch examples from bin package. > > > > 2.1 Failed claiming that classes from org.jetbrains.annotations are > > > > not present on classpath. > > > > 2.2. Fixed by adding a corresponding dependency to examples pom > > > > manually. Run SQL examples successfully. > > > > > > > > So, I observed following glitches: > > > > 1. Missing dependency containing org.jetbrains.annotations in examples > > > > in bin package. > > > > 2. "2018 Copyright(C) Apache Software Foundation" with year 2018 in > > > > console output when starting ignite (using examples main classes and > > > > ignite.sh). > > > > 3. Some mix of versions reported by nodes launched in different ways. > > > > 3.1 ignite.sh from bin package -- ver. 2.7.5#20190603-sha1:be4f2a15 > > > > 3.2. examples main classes from bin package -- ver. > > > 2.7.5#19700101-sha1:DEV > > > > 3.3. examples main classes from src package -- ver. > > > > 2.7.5-SNAPSHOT#19700101-sha1:DEV > > > > > > > > ср, 5 июн. 2019 г. в 18:59, Dmitriy Pavlov : > > > > > > > > > > I managed to get some build using build number from 1. Release build > > > step > > > > > (for that case - 20) > > > > > > > > > > The result can be found here > > > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=4049646=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages=artifacts#%2Fsrc > > > > > > > > > > Pavel T., Peter I., > > > > > > > > > > Please confirm that it is sufficient. I'll update the release manager > > > notes > > > > > with steps required to run this configuration. > > > > > > > > > > Sincerely > > > > > Dmitriy Pavlov > > > > > > > > > > ср, 5 июн. 2019 г. в 18:07, Dmitriy Pavlov : > > > > > > > > > > > I've found only this step > > > > > > > > > > > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages=buildTypeStatusDiv_Releases_ApacheIgniteMain=__all_branches__ > > > > > > > > > > > > > > > > > > It requires some build counter. > > > > > > > > > > > > Peter I, could you please chime in? > > > > > > > > > > > > ср, 5 июн. 2019 г. в 18:02, Dmitriy Pavlov : > > > > > > > > > > > >> Hi Igniters, Pavel T., > > > > > >> > > > > > >> I'm struggling to find clear steps for building/uploading NuGet > > > packages. > > > > > >> How can I double check if it was built or not? What should I do? > > > > > >> > > > > > >> In some internal notes, I've found that NuGet upload can't be > > > undone, and > > > > > >> in > > > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process it > > > > > >> is a post-release step. > > > > > >> > > > > > >> Please advise, both here or in private. I will update the > > > instructions > > > > > >> accordingly. > > > > > >> > > > > > >> Sincerely > > > > > >> Dmitriy Pavlov > > > > > >> > > > > > >> ср, 5 июн. 2019 г. в 15:27, Dmitriy Pavlov : > > > > > >> > > > > > >>> Hi Ivan, > > > > > >>> > > > > > >>> In code there are 2 differences: > > > > > >>> - TLSv1.2 is used as a default protocol for Communication in case > > > SSL is > > > > > >>> used. > > > > > >>> - version changed for all pom files, so apache-ignite-src.zip now > > > > > >>> contains correct version instead of -SNAPSHOT. > > > > > >>> > > > > > >>> Sincerely, > > > > > >>> Dmitriy Pavlov > > > > > >>> > > > > > >>> > > > > > >>> ср, 5 июн. 2019 г. в 10:49, Павлухин Иван : > > > > > >>> > > > > > Dmitriy, > > > > > > > > > > Are there any differences between 2.7.5-rc4 and a previous RC? > > > > > > > > > > вт, 4 июн. 2019 г. в
Re: [DISCUSSION] Release Apache Ignite 2.7.5-rc4
Vyacheslav, > Ivan, try to clean local repo (~/m2) and rebuild the project once again > according to DEVNOTES.txt Thank you for suggestion! But what problem it will solve? пт, 7 июн. 2019 г. в 00:52, Dmitriy Pavlov : > > Hi Vyacheslav, > > I'm sorry for being too formal here, although could you please cast your > vote in > https://lists.apache.org/thread.html/35cbc2d4c5b769155dc8aec15edd808a25c5cf48a5e12637528e931d@%3Cdev.ignite.apache.org%3E > > And thank you for advice on how to check examples. > > Sincerely > Dmitriy Pavlov > > чт, 6 июн. 2019 г. в 22:37, Vyacheslav Daradur : > > > +1 from me. Built from sources and run several examples. > > > > Ivan, try to clean local repo (~/m2) and rebuild the project once > > again according to DEVNOTES.txt > > > > On Thu, Jun 6, 2019 at 7:37 PM Павлухин Иван wrote: > > > > > > I spent a while running examples for RC from bin package. I did the > > following: > > > 1. "mvn clean install" for src package in order to have all > > > dependencies needed for examples in local maven repo on my machine. > > > 2. Tried to compile and launch examples from bin package. > > > 2.1 Failed claiming that classes from org.jetbrains.annotations are > > > not present on classpath. > > > 2.2. Fixed by adding a corresponding dependency to examples pom > > > manually. Run SQL examples successfully. > > > > > > So, I observed following glitches: > > > 1. Missing dependency containing org.jetbrains.annotations in examples > > > in bin package. > > > 2. "2018 Copyright(C) Apache Software Foundation" with year 2018 in > > > console output when starting ignite (using examples main classes and > > > ignite.sh). > > > 3. Some mix of versions reported by nodes launched in different ways. > > > 3.1 ignite.sh from bin package -- ver. 2.7.5#20190603-sha1:be4f2a15 > > > 3.2. examples main classes from bin package -- ver. > > 2.7.5#19700101-sha1:DEV > > > 3.3. examples main classes from src package -- ver. > > > 2.7.5-SNAPSHOT#19700101-sha1:DEV > > > > > > ср, 5 июн. 2019 г. в 18:59, Dmitriy Pavlov : > > > > > > > > I managed to get some build using build number from 1. Release build > > step > > > > (for that case - 20) > > > > > > > > The result can be found here > > > > > > https://ci.ignite.apache.org/viewLog.html?buildId=4049646=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages=artifacts#%2Fsrc > > > > > > > > Pavel T., Peter I., > > > > > > > > Please confirm that it is sufficient. I'll update the release manager > > notes > > > > with steps required to run this configuration. > > > > > > > > Sincerely > > > > Dmitriy Pavlov > > > > > > > > ср, 5 июн. 2019 г. в 18:07, Dmitriy Pavlov : > > > > > > > > > I've found only this step > > > > > > > > > > > > https://ci.ignite.apache.org/viewType.html?buildTypeId=ApacheIgniteReleaseJava8_PrepareVote3BuildNuGetPackages=buildTypeStatusDiv_Releases_ApacheIgniteMain=__all_branches__ > > > > > > > > > > > > > > > It requires some build counter. > > > > > > > > > > Peter I, could you please chime in? > > > > > > > > > > ср, 5 июн. 2019 г. в 18:02, Dmitriy Pavlov : > > > > > > > > > >> Hi Igniters, Pavel T., > > > > >> > > > > >> I'm struggling to find clear steps for building/uploading NuGet > > packages. > > > > >> How can I double check if it was built or not? What should I do? > > > > >> > > > > >> In some internal notes, I've found that NuGet upload can't be > > undone, and > > > > >> in > > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process it > > > > >> is a post-release step. > > > > >> > > > > >> Please advise, both here or in private. I will update the > > instructions > > > > >> accordingly. > > > > >> > > > > >> Sincerely > > > > >> Dmitriy Pavlov > > > > >> > > > > >> ср, 5 июн. 2019 г. в 15:27, Dmitriy Pavlov : > > > > >> > > > > >>> Hi Ivan, > > > > >>> > > > > >>> In code there are 2 differences: > > > > >>> - TLSv1.2 is used as a default protocol for Communication in case > > SSL is > > > > >>> used. > > > > >>> - version changed for all pom files, so apache-ignite-src.zip now > > > > >>> contains correct version instead of -SNAPSHOT. > > > > >>> > > > > >>> Sincerely, > > > > >>> Dmitriy Pavlov > > > > >>> > > > > >>> > > > > >>> ср, 5 июн. 2019 г. в 10:49, Павлухин Иван : > > > > >>> > > > > Dmitriy, > > > > > > > > Are there any differences between 2.7.5-rc4 and a previous RC? > > > > > > > > вт, 4 июн. 2019 г. в 20:35, Dmitriy Pavlov : > > > > > > > > > > Dear Community, > > > > > > > > > > > > > > > > > > > > Please use this thread for all non-voting, discussion, questions > > > > related to > > > > > this release. > > > > > > > > > > > > > > > > > > > > Cast your vote here > > > > > > > > > > > https://lists.apache.org/thread.html/35cbc2d4c5b769155dc8aec15edd808a25c5cf48a5e12637528e931d@%3Cdev.ignite.apache.org%3E > > > > > > > > > > > > > > > Since NuGet is a post-release step, I will proceed with
