[jira] [Created] (IGNITE-14225) Add Helper Method to Check For Expected Exceptions in JUnitAssertAware

2021-02-23 Thread Atri Sharma (Jira)
Atri Sharma created IGNITE-14225:


 Summary: Add Helper Method to Check For Expected Exceptions in 
JUnitAssertAware
 Key: IGNITE-14225
 URL: https://issues.apache.org/jira/browse/IGNITE-14225
 Project: Ignite
  Issue Type: Improvement
 Environment: We should have a helper method which allows checking if 
an expected exception is raised from a specific code block in tests
Reporter: Atri Sharma






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


TeamCity agent aitc-lin07_04 fails to run Build

2021-02-23 Thread Max Timonin
Hi!

My "Build" runs on TC fail with on 1 (Step: Cleanup local maven repository
(Command Line))

Error is related to AI 3.0.0:

+ rm -rfv /opt/buildagent/.m2/repository/org/apache/ignite

rm: cannot remove
'/opt/buildagent/.m2/repository/org/apache/ignite/ignite-configuration/
*3.0.0-SNAPSHOT*/_remote.repositories': *Permission denied*

As I can see this error is only on aitc-lin07_04 agent. The first time it
appeared 16th of February [1]

[1]
https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_BuildApacheIgnite/5876992

How can we fix this?


[jira] [Created] (IGNITE-14224) Extend logging of client failure handling.

2021-02-23 Thread Stanilovsky Evgeny (Jira)
Stanilovsky Evgeny created IGNITE-14224:
---

 Summary: Extend logging of client failure handling.
 Key: IGNITE-14224
 URL: https://issues.apache.org/jira/browse/IGNITE-14224
 Project: Ignite
  Issue Type: Improvement
  Components: clients
Affects Versions: 2.9.1
Reporter: Stanilovsky Evgeny
Assignee: Stanilovsky Evgeny


# "Finished serving remote node connection " but this message doesn't contain 
node id, it should be added (check 
org.apache.ignite.spi.discovery.tcp.ServerImpl.SocketReader#body).
 # When client worker is removed from clientMsgWorkers, 
org.apache.ignite.internal.util.IgniteUtils#closeQuiet(java.lang.AutoCloseable) 
is used to close the socket, we don't see any exception if it has happened, 
closeQuiet should be replaced with 
org.apache.ignite.internal.util.IgniteUtils#close(java.lang.AutoCloseable, 
org.apache.ignite.IgniteLogger) which works in the same way but prints 
exception.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IGNITE-14223) Remove FilePageStoreFactory internal interface

2021-02-23 Thread Maxim Muzafarov (Jira)
Maxim Muzafarov created IGNITE-14223:


 Summary: Remove FilePageStoreFactory internal interface
 Key: IGNITE-14223
 URL: https://issues.apache.org/jira/browse/IGNITE-14223
 Project: Ignite
  Issue Type: Task
Reporter: Maxim Muzafarov
Assignee: Maxim Muzafarov
 Fix For: 2.11


The FilePageStoreFactory can be simplified since this factory has a single 
implementation that produces FilePageStore's.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Re[2]: [DISCUSSION] Apache Ignite Release 2.10 (time, scope, manager)

2021-02-23 Thread Maxim Muzafarov
Folks,


I'd like to cherry-pick to the release branch the following fixes:

Fix security context for JDBC bulk-load operations
https://issues.apache.org/jira/browse/IGNITE-13472

Fixed an issue that caused a deadlock when user cache was created in
parallel with TTL worker was in progress.
https://issues.apache.org/jira/browse/IGNITE-14078

On Thu, 18 Feb 2021 at 20:26, Maxim Muzafarov  wrote:
>
> Maxim, Igor,
>
> Thanks for sharing details.
> Let's wait for these fixes.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-14206
> [2] https://issues.apache.org/jira/browse/IGNITE-14204
>
> On Thu, 18 Feb 2021 at 18:35, Igor Sapego  wrote:
> >
> > Maxim,
> >
> > I believe I could fix the ticket [1] by the end of the next week.
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-14204
> >
> > Best Regards,
> > Igor
> >
> >
> > On Thu, Feb 18, 2021 at 6:30 PM Max Timonin  wrote:
> >
> > > Hi! I've today found an issue [1], there is wrong handling of inlined 
> > > POJO.
> > > This bug appeared in 2.9.0 and makes it impossible to work with
> > > multi-column indexes created on old AI versions that contain inlined POJO
> > > keys in the middle.
> > >
> > > I'm working on the fix and asked Konstantin Orlov to review it. I think
> > > that it will take only a couple of days to fix this issue. From my side, 
> > > it
> > > looks like a release blocker, but we've been living with that since 2.9.0.
> > > WDYT if the release can wait for the fix?
> > >
> > > [1] https://issues.apache.org/jira/browse/IGNITE-14206
> > >
> > > On Thu, Feb 18, 2021 at 5:38 PM Maxim Muzafarov  wrote:
> > >
> > > > Folks,
> > > >
> > > >
> > > > Do we have any estimations of how long does it take to fix the issue
> > > > [1] in C++ thin client? The bug must be fixed for sure, however, I
> > > > tend to continue with the release (if fixing the bug require a few
> > > > weeks) and prepare a batch of fixes for the 2.10.1.
> > > >
> > > >
> > > > [1] https://issues.apache.org/jira/browse/IGNITE-14204
> > > >
> > > > On Thu, 18 Feb 2021 at 13:22, Ilya Kasnacheev  > > >
> > > > wrote:
> > > > >
> > > > > Hello!
> > > > >
> > > > > There was a ticket filed about the new feature, transactions in C++
> > > thin
> > > > > client, making this feature unusable if there's more than one
> > > connection
> > > > > endpoint:
> > > > > https://issues.apache.org/jira/browse/IGNITE-14204
> > > > >
> > > > > I don't think this is a genuine blocker for 2.10, since there is a
> > > > > workaround (use just one endpoint), nevertheless it is a critical
> > > crasher
> > > > > bug, so I wonder if Igor could take a look at it promptly, include the
> > > > fix
> > > > > in 2.10.
> > > > >
> > > > > Regards,
> > > > > --
> > > > > Ilya Kasnacheev
> > > > >
> > > > >
> > > > > чт, 18 февр. 2021 г. в 09:03, Zhenya Stanilovsky
> > > >  > > > > >:
> > > > >
> > > > > >
> > > > > >
> > > > > > I fill the ticket with drop problem, plz take a look [1]
> > > > > >
> > > > > > [1]  https://issues.apache.org/jira/browse/IGNITE-14205
> > > > > >
> > > > > > >Ilya,
> > > > > > >
> > > > > > >Thanks!
> > > > > > >I've added this step to the Release Process wiki page also [1].
> > > > > > >
> > > > > > >[1]
> > > > > >
> > > >
> > > https://cwiki.apache.org/confluence/display/IGNITE/Release+Process#ReleaseProcess-P1.2ImplementationandScopeFinalization
> > > > > > >
> > > > > > >On Wed, 17 Feb 2021 at 18:05, Ilya Kasnacheev <
> > > > ilya.kasnach...@gmail.com
> > > > > > > wrote:
> > > > > > >>
> > > > > > >> Hello!
> > > > > > >>
> > > > > > >> I have added ignite-2.10 to Nightly build triggering. I hope we
> > > will
> > > > > > have a
> > > > > > >> 2.10 nightly tomorrow. Shame that I didn't do it earlier.
> > > > > > >>
> > > > > >
> > > >
> > > https://ci.ignite.apache.org/buildConfiguration/Releases_NightlyRelease_RunApacheIgniteNightlyRelease?branch=ignite-2.10&buildTypeTab=overview&mode=builds
> > > > > > >>
> > > > > > >> Regards,
> > > > > > >> --
> > > > > > >> Ilya Kasnacheev
> > > > > > >>
> > > > > > >>
> > > > > > >> ср, 17 февр. 2021 г. в 17:37, Maxim Muzafarov < mmu...@apache.org
> > > > >:
> > > > > > >>
> > > > > > >> > Folks,
> > > > > > >> >
> > > > > > >> > There is a possible issue with the performance for 2.9.1 vs
> > > 2.10.
> > > > I'm
> > > > > > >> > trying to reproduce on a stress-testing environment.
> > > > > > >> > [1]
> > > > > > >> >
> > > > > >
> > > >
> > > https://cwiki.apache.org/confluence/download/attachments/165224767/atomicPutRandomValueFullSync.jpg?api=v2
> > > > > > >> >
> > > > > > >> > On Fri, 12 Feb 2021 at 20:46, Maxim Muzafarov <
> > > mmu...@apache.org
> > > > >
> > > > > > wrote:
> > > > > > >> > >
> > > > > > >> > > Folks,
> > > > > > >> > >
> > > > > > >> > > I'm going to cherry-pick these issues to the release branch,
> > > any
> > > > > > >> > objections?
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >> > > Checkpointer thread holds write lock too long
> > > > > > >> > >  https://issues.apache.org/jira/browse/IGNITE-141

[jira] [Created] (IGNITE-14222) CacheGroupReencryptionTest.testPartitionFileDestroyAndRecreate is flaky

2021-02-23 Thread Pavel Pereslegin (Jira)
Pavel Pereslegin created IGNITE-14222:
-

 Summary: 
CacheGroupReencryptionTest.testPartitionFileDestroyAndRecreate is flaky
 Key: IGNITE-14222
 URL: https://issues.apache.org/jira/browse/IGNITE-14222
 Project: Ignite
  Issue Type: Bug
Reporter: Pavel Pereslegin
Assignee: Pavel Pereslegin


Test CacheGroupReencryptionTest.testPartitionFileDestroyAndRecreate is flaky on 
TeamCity: 
[https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&buildTypeId=IgniteTests24Java8_PdsIndexing&tab=testDetails&testNameId=-8434643757933460841&order=TEST_STATUS_DESC&branch_IgniteTests24Java8=%3Cdefault%3E&itemsCount=50]
{noformat}
class org.apache.ignite.IgniteCheckedException: Failed to apply page delta
at 
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.lambda$performBinaryMemoryRestore$23(GridCacheDatabaseSharedManager.java:2199)
at 
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.lambda$stripedApplyPage$24(GridCacheDatabaseSharedManager.java:2306)
at 
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.lambda$stripedApply$25(GridCacheDatabaseSharedManager.java:2344)
at 
org.apache.ignite.internal.util.StripedExecutor$Stripe.body(StripedExecutor.java:569)
at 
org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.AssertionError: FullPageId [pageId=0001000e0001, 
effectivePageId=000e0001, grpId=1613773252]
at 
org.apache.ignite.internal.processors.cache.persistence.pagemem.PageMemoryImpl.acquirePage(PageMemoryImpl.java:827)
at 
org.apache.ignite.internal.processors.cache.persistence.pagemem.PageMemoryImpl.acquirePage(PageMemoryImpl.java:707)
at 
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.applyPageDelta(GridCacheDatabaseSharedManager.java:2400)
at 
org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.lambda$performBinaryMemoryRestore$23(GridCacheDatabaseSharedManager.java:2192)
... 5 more{noformat}
This test seems to fail because a page scan during re-encryption may scan some 
pages after a checkpoint is complete, but before the partition has been 
destroyed. Thus, it can create WAL records targeting the previous (destroyed) 
version of the partition, which should not be applied to the re-created 
partition.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: IGNITE-2399: Implement acquireAndExecute Utility Method

2021-02-23 Thread Atri Sharma
Thank you, very kind of you! Let me fix the PR and ping you back there.

On Tue, 23 Feb 2021 at 2:05 PM, Данилов Семён  wrote:

> Hello Atri,
>
> I've read through your changes, have a look at the review.
>
> Kind regards,
> Sam.
>
> 23.02.2021, 08:07, "Atri Sharma" :
> > Hi All,
> >
> > Please help in reviewing the following PR:
> >
> > https://github.com/apache/ignite/pull/8820
> >
> > Regards,
> >
> > Atri
> >
> > --
> > Regards,
> >
> > Atri
> > Apache Concerted
>
-- 
Regards,

Atri
Apache Concerted


[jira] [Created] (IGNITE-14221) SQL Constants not hidden in IGNITE_TO_STRING_INCLUDE_SENSITIVE=false

2021-02-23 Thread Nikolay Izhikov (Jira)
Nikolay Izhikov created IGNITE-14221:


 Summary: SQL Constants not hidden in 
IGNITE_TO_STRING_INCLUDE_SENSITIVE=false
 Key: IGNITE-14221
 URL: https://issues.apache.org/jira/browse/IGNITE-14221
 Project: Ignite
  Issue Type: Improvement
Reporter: Nikolay Izhikov
Assignee: Nikolay Izhikov


Currently, SQL constants not hidden if 
{{IGNITE_TO_STRING_INCLUDE_SENSITIVE=false}}.
This can lead to security incidents when some applications don't use SQL 
parameters and send constant in query body.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: IGNITE-2399: Implement acquireAndExecute Utility Method

2021-02-23 Thread Данилов Семён
Hello Atri,

I've read through your changes, have a look at the review.

Kind regards,
Sam.

23.02.2021, 08:07, "Atri Sharma" :
> Hi All,
>
> Please help in reviewing the following PR:
>
> https://github.com/apache/ignite/pull/8820
>
> Regards,
>
> Atri
>
> --
> Regards,
>
> Atri
> Apache Concerted