Re: [VOTE][EXTENSION] Release Apache Ignite spring-data-all-ext extensions 1.0.0 RC5
Hello! +1 (binding) The source zip now has the correct layout and builds OK. Regards, -- Ilya Kasnacheev пт, 2 июл. 2021 г. в 14:19, Maxim Muzafarov : > +1 (binding) > > On Fri, 2 Jul 2021 at 14:00, Nikolay Izhikov wrote: > > > > +1 (binding) > > > > > 1 июля 2021 г., в 08:35, Petrov Mikhail > написал(а): > > > > > > +1 > > > > > > Checked on Ubuntu 20.04. Created separate Spring Applications for each > version of Spring Data Integrations using the Maven RC repository and > following the documentation. Tested common use cases. Checked archive > signs. Built from the sources. > > > > > > On 01.07.2021 00:31, Sergei Ryzhov wrote: > > >> +1 > > >> Building modules from source and running tests successfully on Java 8 > > >> > > >> ср, 30 июн. 2021 г. в 16:02, Alex Plehanov : > > >> > > >>> +1 > > >>> > > >>> Check sha512, sign of archives and versions of released artifacts. > > >>> Check licenses with "mvn validate -DskipTests -P check-licenses" > > >>> Build modules from the source with Java 8 > > >>> Run examples: > > >>> from modules/spring-data-2.0-ext/examples with artifacts: Ignite > > >>> v2.10.0/ignite-spring-data-2.0-ext v1.0.0/spring-data v2.0 > > >>> from modules/spring-data-2.2-ext/examples with artifacts: Ignite > > >>> v2.10.0/ignite-spring-data-2.2-ext v1.0.0/spring-data v2.2 > > >>> > > >>> > > >>> ср, 30 июн. 2021 г. в 15:13, Nikita Amelchev : > > >>> > > Dear Ignite Community, > > > > I have uploaded a release candidate of the following extension > modules: > > > > spring-data-commons > > spring-data-ext > > spring-data-2.0-ext > > spring-data-2.2-ext > > > > The release candidate of the extensions: > > > > > > >>> > https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-data-all-ext/1.0.0-rc5/ > > The instruction for building from the source package is placed in > the > > DEVNOTES file. > > > > The following staging can be used for testing: > > > https://repository.apache.org/content/repositories/orgapacheignite-1524 > > > > Tags were created: > > > > ignite-spring-data-commons-1.0.0-rc5 > > ignite-spring-data-ext-1.0.0-rc5 > > ignite-spring-data-2.2-ext-1.0.0-rc5 > > ignite-spring-data-2.0-ext-1.0.0-rc5 > > ignite-spring-data-all-ext-1.0.0-rc5 > > > > > > >>> > https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=4a3ba7b542c46501d425dfa378ac8670e253f49a > > RELEASE NOTES: > > > > > > >>> > https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=22f8d665c194ba2dfa6167354d97ad53d5ef206f;hb=c8de80ee14d1fb76d6cbb0b18513bb70b499c3cb > > DOCUMENTATION: > > Documentation of listed extensions was updated in the following > issues: > > > > > > >>> > https://issues.apache.org/jira/issues/?filter=-1&jql=key%20in%20(IGNITE-14662%2CIGNITE-14398%2CIGNITE-14493) > > The vote is formal, see voting guidelines > > https://www.apache.org/foundation/voting.html > > > > +1 - to accept all the Apache Ignite spring-data-all-ext extensions > > 1.0.0-rc5 listed in the thread > > 0 - don't care either way > > -1 - DO NOT accept either of the Apache Ignite spring-data-all-ext > > extensions 1.0.0-rc5 (explain why) > > > > The vote will hold for 3 days and will end on July 3 2021 13:00 UTC > > > > > > >>> > https://www.timeanddate.com/countdown/generic?iso=20210703T13&p0=0&font=cursive > > -- > > Best wishes, > > Amelchev Nikita > > > > >> > > >
Re: Re[2]: Setting IGNITE_TO_STRING_INCLUDE_SENSITIVE=false prevents VM Arguments output
Ok, and what's about other VM arguments, not included to IgniteSystemProperties? пт, 2 июл. 2021 г. в 09:27, Zhenya Stanilovsky : > > -1 for extra arg, +1 for Ivan`s upper proposal : @IgniteSystemProperty > annotation. > Look, someone will set some of IGNITE_* option and after possibly cluster > problems will give this logs into analysis and engineer can`t reproduce > such a case, cause no param is applied. > > >An extra argument for IgniteSystemProperty sounds reasonable. > > > >-Val > > > >On Thu, Jul 1, 2021 at 10:04 AM Ivan Daschinsky < ivanda...@gmail.com > > wrote: > > > >> Ok, this can be excluded using blocklist-jvm-params.properties or just > by > >> providing and extra arg to annotation, as I have just suggested > >> > >> чт, 1 июл. 2021 г., 19:51 Valentin Kulichenko < > >> valentin.kuliche...@gmail.com > >> >: > >> > >> > Ivan, > >> > > >> > IP addresses (e.g. IGNITE_TCP_DISCOVERY_ADDRESSES) and file paths > >> > (e.g. IGNITE_CONFIG_URL) are often considered sensitive information. > Data > >> > related to authentication (e.g. IGNITE_SSH_USER_NAME) is very likely > to > >> be > >> > sensitive. > >> > > >> > Once again - I would exclude any property that can contain > user-specific > >> > information. Only our internal settings (stuff > >> > like IGNITE_SQL_MERGE_TABLE_MAX_SIZE) are OK to appear in the logs. > >> > > >> > -Val > >> > > >> > On Thu, Jul 1, 2021 at 9:47 AM Ivan Daschinsky < ivanda...@gmail.com > > > >> > wrote: > >> > > >> > > We can add add an extra param in annotation, that blocks param to be > >> > > printed, just set it to false by default and block it wheb set to > true > >> > > > >> > > чт, 1 июл. 2021 г., 19:45 Atri Sharma < a...@apache.org >: > >> > > > >> > > > What if we allowed a blocklist of parameters that are never > printed? > >> > > > > >> > > > On Thu, 1 Jul 2021, 22:06 Valentin Kulichenko, < > >> > > > valentin.kuliche...@gmail.com > wrote: > >> > > > > >> > > > > Not all of them are OK to be printed out. At the very least, we > >> > should > >> > > > have > >> > > > > a mechanism to exclude some of them. I would still go with > opt-in > >> > > rather > >> > > > > than opt-out though, but I guess that is up to a discussion. > >> > > > > > >> > > > > -Val > >> > > > > > >> > > > > On Thu, Jul 1, 2021 at 9:29 AM Ivan Daschinsky < > >> ivanda...@gmail.com > > >> > > > > wrote: > >> > > > > > >> > > > > > This is security through obscurity, an obvious and a > well-known > >> > anti > >> > > > > > pattern. I suppose that printing jvm options, that is > registered > >> by > >> > > > > > @IgniteSystemProperty annotation is an ideal variant > >> > > > > > > >> > > > > > чт, 1 июл. 2021 г., 19:25 Valentin Kulichenko < > >> > > > > > valentin.kuliche...@gmail.com > >> > > > > > >: > >> > > > > > > >> > > > > > > Folks, > >> > > > > > > > >> > > > > > > *Anything* that a user provides to the system can > potentially > >> be > >> > > > > > considered > >> > > > > > > sensitive information. This includes the VM arguments. We > can't > >> > > > predict > >> > > > > > > what exactly one can put there, so let's not make > assumptions. > >> > > > > > > > >> > > > > > > When dealing with security, we should be as conservative as > >> > > possible. > >> > > > > > That > >> > > > > > > said, I do not even agree with the pattern approach - there > >> might > >> > > be > >> > > > a > >> > > > > > > user's system property named IGNITE_xxx. It is also possible > >> for > >> > > our > >> > > > > > > internal properties to contain sensitive information (not > all > >> of > >> > > them > >> > > > > are > >> > > > > > > boolean flags). > >> > > > > > > > >> > > > > > > The only option I see is to print out specific properties > for > >> > which > >> > > > we > >> > > > > > > agree that they are safe. For example, we can introduce an > >> > > annotation > >> > > > > > that > >> > > > > > > would mark "safe" properties in IgniteSystemProperties; we > will > >> > > then > >> > > > > > print > >> > > > > > > out only those that are marked with the annotation. > >> > > > > > > > >> > > > > > > -Val > >> > > > > > > > >> > > > > > > > >> > > > > > > On Thu, Jul 1, 2021 at 7:07 AM Вячеслав Коптилин < > >> > > > > > slava.kopti...@gmail.com > >> > > > > > > > > >> > > > > > > wrote: > >> > > > > > > > >> > > > > > > > Hello Ivan, > >> > > > > > > > > >> > > > > > > > > At least, we could just hide params that match a > specific > >> > > pattern > >> > > > > > > > Yes, we can filter out all vm options that do not relate > to > >> > > Ignite, > >> > > > > for > >> > > > > > > > instance. > >> > > > > > > > > >> > > > > > > > > Ilya, go ahead, file ticket and prepare a PR. > >> > > > > > > > Please do not rush. Let's listen to other community > members. > >> > This > >> > > > > > > question > >> > > > > > > > is about security and it should not be discussed in a > hurry > >> > (even > >> > > > > > though > >> > > > > > > it > >> > > > > > > > looks like an obvious thing). > >> > > > > > > > > >>
Re: [VOTE][EXTENSION] Release Apache Ignite spring-data-all-ext extensions 1.0.0 RC5
+1 (binding) On Fri, 2 Jul 2021 at 14:00, Nikolay Izhikov wrote: > > +1 (binding) > > > 1 июля 2021 г., в 08:35, Petrov Mikhail написал(а): > > > > +1 > > > > Checked on Ubuntu 20.04. Created separate Spring Applications for each > > version of Spring Data Integrations using the Maven RC repository and > > following the documentation. Tested common use cases. Checked archive > > signs. Built from the sources. > > > > On 01.07.2021 00:31, Sergei Ryzhov wrote: > >> +1 > >> Building modules from source and running tests successfully on Java 8 > >> > >> ср, 30 июн. 2021 г. в 16:02, Alex Plehanov : > >> > >>> +1 > >>> > >>> Check sha512, sign of archives and versions of released artifacts. > >>> Check licenses with "mvn validate -DskipTests -P check-licenses" > >>> Build modules from the source with Java 8 > >>> Run examples: > >>> from modules/spring-data-2.0-ext/examples with artifacts: Ignite > >>> v2.10.0/ignite-spring-data-2.0-ext v1.0.0/spring-data v2.0 > >>> from modules/spring-data-2.2-ext/examples with artifacts: Ignite > >>> v2.10.0/ignite-spring-data-2.2-ext v1.0.0/spring-data v2.2 > >>> > >>> > >>> ср, 30 июн. 2021 г. в 15:13, Nikita Amelchev : > >>> > Dear Ignite Community, > > I have uploaded a release candidate of the following extension modules: > > spring-data-commons > spring-data-ext > spring-data-2.0-ext > spring-data-2.2-ext > > The release candidate of the extensions: > > > >>> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-data-all-ext/1.0.0-rc5/ > The instruction for building from the source package is placed in the > DEVNOTES file. > > The following staging can be used for testing: > https://repository.apache.org/content/repositories/orgapacheignite-1524 > > Tags were created: > > ignite-spring-data-commons-1.0.0-rc5 > ignite-spring-data-ext-1.0.0-rc5 > ignite-spring-data-2.2-ext-1.0.0-rc5 > ignite-spring-data-2.0-ext-1.0.0-rc5 > ignite-spring-data-all-ext-1.0.0-rc5 > > > >>> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=4a3ba7b542c46501d425dfa378ac8670e253f49a > RELEASE NOTES: > > > >>> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=22f8d665c194ba2dfa6167354d97ad53d5ef206f;hb=c8de80ee14d1fb76d6cbb0b18513bb70b499c3cb > DOCUMENTATION: > Documentation of listed extensions was updated in the following issues: > > > >>> https://issues.apache.org/jira/issues/?filter=-1&jql=key%20in%20(IGNITE-14662%2CIGNITE-14398%2CIGNITE-14493) > The vote is formal, see voting guidelines > https://www.apache.org/foundation/voting.html > > +1 - to accept all the Apache Ignite spring-data-all-ext extensions > 1.0.0-rc5 listed in the thread > 0 - don't care either way > -1 - DO NOT accept either of the Apache Ignite spring-data-all-ext > extensions 1.0.0-rc5 (explain why) > > The vote will hold for 3 days and will end on July 3 2021 13:00 UTC > > > >>> https://www.timeanddate.com/countdown/generic?iso=20210703T13&p0=0&font=cursive > -- > Best wishes, > Amelchev Nikita > > >> >
Re: [VOTE][EXTENSION] Release Apache Ignite spring-data-all-ext extensions 1.0.0 RC5
+1 (binding) > 1 июля 2021 г., в 08:35, Petrov Mikhail написал(а): > > +1 > > Checked on Ubuntu 20.04. Created separate Spring Applications for each > version of Spring Data Integrations using the Maven RC repository and > following the documentation. Tested common use cases. Checked archive signs. > Built from the sources. > > On 01.07.2021 00:31, Sergei Ryzhov wrote: >> +1 >> Building modules from source and running tests successfully on Java 8 >> >> ср, 30 июн. 2021 г. в 16:02, Alex Plehanov : >> >>> +1 >>> >>> Check sha512, sign of archives and versions of released artifacts. >>> Check licenses with "mvn validate -DskipTests -P check-licenses" >>> Build modules from the source with Java 8 >>> Run examples: >>> from modules/spring-data-2.0-ext/examples with artifacts: Ignite >>> v2.10.0/ignite-spring-data-2.0-ext v1.0.0/spring-data v2.0 >>> from modules/spring-data-2.2-ext/examples with artifacts: Ignite >>> v2.10.0/ignite-spring-data-2.2-ext v1.0.0/spring-data v2.2 >>> >>> >>> ср, 30 июн. 2021 г. в 15:13, Nikita Amelchev : >>> Dear Ignite Community, I have uploaded a release candidate of the following extension modules: spring-data-commons spring-data-ext spring-data-2.0-ext spring-data-2.2-ext The release candidate of the extensions: >>> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-data-all-ext/1.0.0-rc5/ The instruction for building from the source package is placed in the DEVNOTES file. The following staging can be used for testing: https://repository.apache.org/content/repositories/orgapacheignite-1524 Tags were created: ignite-spring-data-commons-1.0.0-rc5 ignite-spring-data-ext-1.0.0-rc5 ignite-spring-data-2.2-ext-1.0.0-rc5 ignite-spring-data-2.0-ext-1.0.0-rc5 ignite-spring-data-all-ext-1.0.0-rc5 >>> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=4a3ba7b542c46501d425dfa378ac8670e253f49a RELEASE NOTES: >>> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=22f8d665c194ba2dfa6167354d97ad53d5ef206f;hb=c8de80ee14d1fb76d6cbb0b18513bb70b499c3cb DOCUMENTATION: Documentation of listed extensions was updated in the following issues: >>> https://issues.apache.org/jira/issues/?filter=-1&jql=key%20in%20(IGNITE-14662%2CIGNITE-14398%2CIGNITE-14493) The vote is formal, see voting guidelines https://www.apache.org/foundation/voting.html +1 - to accept all the Apache Ignite spring-data-all-ext extensions 1.0.0-rc5 listed in the thread 0 - don't care either way -1 - DO NOT accept either of the Apache Ignite spring-data-all-ext extensions 1.0.0-rc5 (explain why) The vote will hold for 3 days and will end on July 3 2021 13:00 UTC >>> https://www.timeanddate.com/countdown/generic?iso=20210703T13&p0=0&font=cursive -- Best wishes, Amelchev Nikita >>
Re: [VOTE][EXTENSION] Release Apache Ignite performance-statistics-ext extension 1.0.0 RC5
+1 Check sha512, sign of archives and versions of released artifacts. Check licenses with "mvn validate -P check-licenses" Build from the source with Java 8, run unit tests пт, 2 июл. 2021 г. в 12:01, Maxim Muzafarov : > +1 (binding) > > On Thu, 1 Jul 2021 at 13:23, Nikolay Izhikov wrote: > > > > +1 (binding) > > > > > 1 июля 2021 г., в 09:29, Petrov Mikhail > написал(а): > > > > > > +1 > > > > > > Checked on Ubuntu 20.04. Checked built-report and print-statistics > scripts for the custom Ignite application. Checked archive signs. Built > from the sources. > > > > > > On 01.07.2021 00:24, Sergei Ryzhov wrote: > > >> +1 > > >> Checked a report with an ignite-performance-statistics-example. > > >> > > >
Re: [VOTE][EXTENSION] Release Apache Ignite performance-statistics-ext extension 1.0.0 RC5
+1 (binding) On Thu, 1 Jul 2021 at 13:23, Nikolay Izhikov wrote: > > +1 (binding) > > > 1 июля 2021 г., в 09:29, Petrov Mikhail написал(а): > > > > +1 > > > > Checked on Ubuntu 20.04. Checked built-report and print-statistics scripts > > for the custom Ignite application. Checked archive signs. Built from the > > sources. > > > > On 01.07.2021 00:24, Sergei Ryzhov wrote: > >> +1 > >> Checked a report with an ignite-performance-statistics-example. > >> >
