Re: IGNITE-14812: Statistics
Hello Igniters, The PR with latest documentation on SQL statistics is here: https://github.com/apache/ignite/pull/9550 Regards, Nikita пн, 5 июл. 2021 г. в 12:53, Nikita Safonov : > Hello Igniters, > > I'd be glad to help with documenting this functionality. > I do believe that it won't take long. Hope to finish it before the end of > next week to have enough time for docs discussion. > > Regards, > Nikita > > ср, 23 июн. 2021 г. в 18:11, Ivan Daschinsky : > >> AFAIK, it is enough to include mention of this library in NOTICE, please >> see here [1][2][3] >> >> [1] -- https://www.apache.org/legal/src-headers.html#3party >> [2] -- https://www.apache.org/legal/src-headers.html#notice >> [3] -- https://www.apache.org/legal/resolved.html >> >> ср, 23 июн. 2021 г. в 17:36, Valentin Kulichenko < >> valentin.kuliche...@gmail.com>: >> >> > Taras, >> > >> > It is true that we try to minimize dependencies, but there are some >> anyway. >> > I think it's perfectly fine to add this library as a dependency. >> > >> > Will you be able to do this asap? It is surely better than reverting the >> > commit :) >> > >> > -Val >> > >> > On Wed, Jun 23, 2021 at 12:32 AM Taras Ledkov >> > wrote: >> > >> > > Hi, >> > > >> > > > Taras, can you, please, describe the features that was implemented >> in >> > > this merge? >> > > > How users supposed to use them? >> > > > Do we have plans to document? >> > > >> > > Sure. Alexander Belyak will describe and file ticket to documentation. >> > > >> > > On 23.06.2021 9:27, Nikolay Izhikov wrote: >> > > > Hello, Taras. >> > > > >> > > > Thanks for feedback. >> > > > >> > > >> AFAIK and as long as I can remember Ignite project try to minimize >> > > external dependencies usage and adds new external dependency only when >> > > there is no other way out. >> > > > Does it mean we have to incapsulate every external library we want >> to >> > > use? >> > > > >> > > > Taras, can you, please, describe the features that was implemented >> in >> > > this merge? >> > > > How users supposed to use them? >> > > > Do we have plans to document? >> > > > >> > > > >> > > >> 23 июня 2021 г., в 09:21, Taras Ledkov >> > > написал(а): >> > > >> >> > > >> Hi, >> > > >> >> > > >> We have discussed BCrypt include/add dependency here [1]. >> > > >> AFAIK and as long as I can remember Ignite project try to minimize >> > > external dependencies usage >> > > >> and adds new external dependency only when there is no other way >> out. >> > > >> >> > > >> [1]. >> > > >> > >> http://apache-ignite-developers.2346864.n4.nabble.com/Username-password-authentication-for-thin-clients-tp26058p26954.html >> > > >> >> > > >> On 23.06.2021 3:08, Valentin Kulichenko wrote: >> > > >>> Dmitry, >> > > >>> >> > > >>> As the PMC chair, would you mind contacting legal regarding the >> > matter? >> > > >>> This is not the only example of such code (e.g. [1]), so we should >> > look >> > > >>> into this asap. >> > > >>> >> > > >>> [1] >> > > >>> >> > > >> > >> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java >> > > >>> >> > > >>> As for this particular commit, can HLL be added as a dependency >> > > instead? Is >> > > >>> there any particular reason to include the source code? @Sasha >> Belyak >> > > >>> , can you please chime in? >> > > >>> >> > > >>> -Val >> > > >>> >> > > >>> On Tue, Jun 22, 2021 at 8:10 AM Dmitry Pavlov > > >> > > wrote: >> > > >>> >> > > Hi Nikolai, >> > > >> > > thank you for noticing. I guess it's not about license, but about >> > > Intellectual Property (IP) ownership. >> > > >> > > AFAIK, Apache License 2.0 is here and AL 2.0 is definetely >> allowed >> > to >> > > be >> > > used in the codebase for an Apache project ( >> > > https://www.apache.org/legal/resolved.html) >> > > >> > > But licenese and IP owner are 2 sligthly different things. E.g at >> > the >> > > end >> > > of any website you can find: >> > > Copyright © 2021 The Apache Software Foundation, Licensed under >> the >> > > Apache >> > > License, Version 2.0. >> > > >> > > Incubated projects are mandated to transfer IP to the ASF. And >> I'm >> > not >> > > aware of any exceptions. >> > > >> > > In this PR there are 5 classes which licenses with AL 2.0, but IP >> > > owner is >> > > 3rd party company. >> > > >> > > I'm a bit concerned about having such code in the project. I'd >> > rather >> > > reverted it until we have approval from experts at mailing list: >> > > legal-disc...@apache.org >> > > >> > > Sincerely, >> > > Dmitriy Pavlov >> > > >> > > On 2021/06/22 14:56:49, Nikolay Izhikov >> > wrote: >> > > > Hello, Igniters. >> > > > >> > > > Recently huge commit was merged [1]. >> > > > >> > > > Taras, Alexander, can you, please, explain what is purpose of >> the >> > > commit? >> > > > What feature it implemented? >> > > > >> > >
Re: [DISCUSSION] Add SystemRegionMetricsEnabled property on DataStorageConfiguration.
Hi, Andrey! Thank you for your reply. I had the same thought about special system-region-configuration-class, but then I discovered that we have 3 special regions: sysMemPlc, volatileDsMemPlc, metastoreMemPlc. *If we decide to provide a special type* for configuration, then should it be *one* type for all special regions but *different* instances, or should the user provide *one* instance of system-region-configuration-class, or maybe even *different* type for each special region? My heart aligns with the first option. Or maybe it is better to stick to the initial plan: only make new holes in *DataStorageConfiguration?* On Tue, 2 Nov 2021 at 17:40, Andrey Gura wrote: > Hi, > > Your proposal is consistent with the current interface of > DataStorageConfiguration class, so I', okay with the proposed change. > > Alternatively, DataStorageConfiguration#systemDataRegionConfiguration > field could be introduced which could be DataRegionConfiguration type > or special SystemDataRegionConfiguration type in case if we want to > limit access to the system data region parameters. > > On Tue, Nov 2, 2021 at 2:42 PM Eduard Rakhmankulov > wrote: > > > > Hello, Igniters! > > > > At the moment metrics on system region are disabled on node start. > > User-defined regions can be tuned to have enabled metrics via region > > configuration > > > (org.apache.ignite.configuration.DataRegionConfiguration#setMetricsEnabled) > > To enable metrics on system region users should use non-public API or use > > deprecated JMX bean > > (org.apache.ignite.mxbean.DataRegionMetricsMXBean#enableMetrics) for it, > > which doesn't solve problem because it needs human attention when node > > restarts. > > > > I want to add a new property to > > *org.apache.ignite.configuration.DataStorageConfiguration* which enables > or > > disables collection of metrics on system region (aka sysMemPlc) on node > > start. > > > > API change > > add new public methods: > > > >1. > > > *org.apache.ignite.configuration.DataStorageConfiguration#isSystemRegionMetricsEnabled()* > >2. > > > *org.apache.ignite.configuration.DataStorageConfiguration#setSystemRegionMetricsEnabled(boolean)* > > > > > > WDYT? > > -- > > Best regards, Eduard. >
Re: ASF Board report, Nov 2021
Denis and Pavel, probably we also need to mention 3 virtual meetups in July [1], [2], and September [3]. Also, we gathered at one offline meetup in September in Moscow [4] [1] https://www.meetup.com/Apache-Ignite-Virtual-Meetup/events/279417063/ [2] https://www.meetup.com/Moscow-Apache-Ignite-Meetup/events/279466477/ [3] https://www.meetup.com/Apache-Ignite-Virtual-Meetup/events/280030600/ [4] https://www.meetup.com/Moscow-Apache-Ignite-Meetup/events/280030657/ вт, 2 нояб. 2021 г. в 18:47, Denis Magda : > Hi Dmitry, thanks for sharing the draft, > > I would also add that the community is hosting the next Ignite Summit in > November: https://ignite-summit.org > > @Kseniya Romanova , anything else? > > - > Denis > > > On Tue, Nov 2, 2021 at 11:01 AM Dmitriy Pavlov wrote: > >> Hi Folks, >> >> It's time to submit next quarter's report to the board. >> >> I've prepared a draft at >> >> https://cwiki.apache.org/confluence/display/IGNITE/ASF+Board+Report+Drafts#ASFBoardReportDrafts-Nov2021 >> >> Feel free to suggest any changes, significant activities, and/or released >> features to be added to Community and Project sections. >> >> I would finalize the report on 08 Nov. Before that time I'll have >> limited access to the Internet. >> >> Sincerely, >> Dmitriy Pavlov >> >
Re: ASF Board report, Nov 2021
Hi Dmitry, thanks for sharing the draft, I would also add that the community is hosting the next Ignite Summit in November: https://ignite-summit.org @Kseniya Romanova , anything else? - Denis On Tue, Nov 2, 2021 at 11:01 AM Dmitriy Pavlov wrote: > Hi Folks, > > It's time to submit next quarter's report to the board. > > I've prepared a draft at > > https://cwiki.apache.org/confluence/display/IGNITE/ASF+Board+Report+Drafts#ASFBoardReportDrafts-Nov2021 > > Feel free to suggest any changes, significant activities, and/or released > features to be added to Community and Project sections. > > I would finalize the report on 08 Nov. Before that time I'll have > limited access to the Internet. > > Sincerely, > Dmitriy Pavlov >
ASF Board report, Nov 2021
Hi Folks, It's time to submit next quarter's report to the board. I've prepared a draft at https://cwiki.apache.org/confluence/display/IGNITE/ASF+Board+Report+Drafts#ASFBoardReportDrafts-Nov2021 Feel free to suggest any changes, significant activities, and/or released features to be added to Community and Project sections. I would finalize the report on 08 Nov. Before that time I'll have limited access to the Internet. Sincerely, Dmitriy Pavlov
Re: [DISCUSSION] Add SystemRegionMetricsEnabled property on DataStorageConfiguration.
Hi, Your proposal is consistent with the current interface of DataStorageConfiguration class, so I', okay with the proposed change. Alternatively, DataStorageConfiguration#systemDataRegionConfiguration field could be introduced which could be DataRegionConfiguration type or special SystemDataRegionConfiguration type in case if we want to limit access to the system data region parameters. On Tue, Nov 2, 2021 at 2:42 PM Eduard Rakhmankulov wrote: > > Hello, Igniters! > > At the moment metrics on system region are disabled on node start. > User-defined regions can be tuned to have enabled metrics via region > configuration > (org.apache.ignite.configuration.DataRegionConfiguration#setMetricsEnabled) > To enable metrics on system region users should use non-public API or use > deprecated JMX bean > (org.apache.ignite.mxbean.DataRegionMetricsMXBean#enableMetrics) for it, > which doesn't solve problem because it needs human attention when node > restarts. > > I want to add a new property to > *org.apache.ignite.configuration.DataStorageConfiguration* which enables or > disables collection of metrics on system region (aka sysMemPlc) on node > start. > > API change > add new public methods: > >1. > > *org.apache.ignite.configuration.DataStorageConfiguration#isSystemRegionMetricsEnabled()* >2. > > *org.apache.ignite.configuration.DataStorageConfiguration#setSystemRegionMetricsEnabled(boolean)* > > > WDYT? > -- > Best regards, Eduard.
Re: [DISCUSSION] Array to BinaryObject serialization
Hello, Igniters.
I've prepared implementation of support of BinaryArray.
Please, join the review.
Ticket - https://issues.apache.org/jira/browse/IGNITE-14742
PR - https://github.com/apache/ignite/pull/9490
ср, 19 мая 2021 г. в 14:44, Ilya Kasnacheev :
> Hello!
>
> We don't have to do it in toBinary() - we may preserve its behavior if you
> like, and only do that transition for Cache API, where additional support
> may be added to
> e.g.
> org.apache.ignite.internal.processors.cache.binary.CacheObjectBinaryProcessorImpl
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> ср, 19 мая 2021 г. в 14:23, Nikolay Izhikov :
>
> > Ilya.
> >
> > Actually, current behaviour described even in documentation [1]
> >
> >
> > > Note that not all objects are converted to the binary object format.
> The
> > following classes are never converted (e.g., the toBinary(Object) method
> > returns the original object, and instances of these classes are stored
> > without changes):
> > ...
> > > ... arrays of objects (but the objects inside them are reconverted if
> > they are binary)
> >
> > [1]
> >
> https://ignite.apache.org/docs/latest/key-value-api/binary-objects#enabling-binary-mode-for-caches
> >
> > > 19 мая 2021 г., в 14:12, Ilya Kasnacheev
> > написал(а):
> > >
> > > Hello!
> > >
> > > Why do you need to take compatibility into account here at all?
> > > You can start writing entries to cache in new format while reading both
> > old
> > > and new format.
> > >
> > > I consider returning Object[] instead of ConcreteType[] a bug so it's
> > > totally OK to start returning the "better" ConcreteType[] instead.
> > >
> > > I think you can just fix the bug while preserving accessibility of old
> > > (pre-bugfix) data as it was pre-2.11.
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > ср, 19 мая 2021 г. в 14:08, Nikolay Izhikov :
> > >
> > >> Ilya,
> > >>
> > >>> Maybe we should just automate that, e.g., whenever user stores
> Type[],
> > >> always store one-field ArrayWrapper object, and automatically unwrap
> it
> > on
> > >> get()
> > >>
> > >> Yes, I’m talking about this opportunity from the beginning of the
> > thread.
> > >>
> > >>> 1. Implement binary serialization that correctly Ser and Deser array
> > >> using some kind of the wrapper (BinaryArrayWrapper).
> > >>
> > >>
> > >>> 19 мая 2021 г., в 14:05, Ilya Kasnacheev
> > >> написал(а):
> > >>>
> > >>> Hello!
> > >>>
> > >>> Yes, it does not look pretty, I agree. But I'm saying that I've not
> > >>> encountered this issue on the user list before, and it can probably
> be
> > >>> easily countered by storing some one-field ArrayWrapper object in the
> > >> cache
> > >>> as value.
> > >>>
> > >>> Maybe we should just automate that, e.g., whenever user stores
> Type[],
> > >>> always store one-field ArrayWrapper object, and automatically unwrap
> it
> > >> on
> > >>> get()
> > >>> This way we may not even need any changes to storage format, if
> binary
> > >>> marshaller does not mind.
> > >>>
> > >>> Regards,
> > >>>
> > >>> Regards,
> > >>> --
> > >>> Ilya Kasnacheev
> > >>>
> > >>>
> > >>> ср, 19 мая 2021 г. в 13:33, Nikolay Izhikov :
> > >>>
> > Igniters.
> >
> > Just to clarify the issue:
> >
> > ```
> > public class BinaryObjectTest extends GridCommonAbstractTest {
> > /** */
> > @Test
> > public void testArray() throws Exception {
> > Ignite ign = startGrid();
> >
> > IgniteCache cache =
> > ign.createCache("my-cache");
> >
> > cache.put(1, new TestClass1[] {new TestClass1(), new
> > TestClass1()});
> > TestClass1[] obj = cache.get(1); //This will fail with
> > ClassCastException.
> >
> > assertEquals(TestClass1[].class, obj.getClass());
> > }
> > }
> > ```
> >
> > > 19 мая 2021 г., в 13:04, Nikolay Izhikov
> > написал(а):
> > >
> > > Thanks, Ilya.
> > >
> > > Can you put more context on this?
> > > I don’t familiar with these issues.
> > >
> > >> 19 мая 2021 г., в 13:02, Ilya Kasnacheev <
> ilya.kasnach...@gmail.com
> > >
> > написал(а):
> > >>
> > >> Hello!
> > >>
> > >> Obvious issues are Lazy SQL, Event Driven Services, Sort Binary
> > Object
> > >> Fields.
> > >>
> > >> Regards,
> > >> --
> > >> Ilya Kasnacheev
> > >>
> > >>
> > >> ср, 19 мая 2021 г. в 12:56, Nikolay Izhikov >:
> > >>
> > >>> Hello,
> > >>>
> > However, for internal platform and services implementations we
> > >> should
> > >>> fix the root cause:
> > avoid extra deserialization->serialization pass completely.
> > This will also improve performance.
> > >>>
> > >>> Pavel, thanks for the feedback.
> > >>> If I understand correctly, your suggestion is to know data size
> at
> > >> the
> > >>> start of reading service parameters.
> > >>> Is it correct?
> > >>>
> >
Re: Apache Ignite 2.12 RELEASE [Time, Scope, Manager]
Thanks, cherry-picked to master. вт, 2 нояб. 2021 г. в 16:00, Nikita Amelchev : > Ivan, > > Yes, the patch can be cherry-picked. > > вт, 2 нояб. 2021 г. в 15:55, Ivan Daschinsky : > > > > Since code freeze is postponed, may be I can cherry-pick my patch already > > merged to master? > > https://issues.apache.org/jira/browse/IGNITE-15806 > > > > пт, 29 окт. 2021 г. в 20:24, Nikita Amelchev : > > > > > Maksim T., Maxim M., Ok. > > > > > > I think we can move code freeze to +1 week to await these issues. > > > > > > пт, 29 окт. 2021 г. в 15:53, Maxim Muzafarov : > > > > > > > > Folks, > > > > > > > > I've previously mentioned that I'd like to include the [1] issue in > > > > the release. Currently, the status is "Patch Available" and it's > > > > actively reviewing now. I'd be happy if we wait a couple of days and > > > > add this improvement to the release. > > > > > > > > I've also created an issue [2] to remove the ambiguity output message > > > > for the snapshot check and idle verify procedures. This is a minor > > > > output message change, however, it was directly requested by users. > > > > Would you don't mind if we include this issue in the release also? > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14744 > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15849 > > > > > > > > On Fri, 29 Oct 2021 at 14:19, Maksim Timonin < > timonin.ma...@gmail.com> > > > wrote: > > > > > > > > > > Status update on my issue: > > > > > > > > > > IGNITE-15530 [1] is in "Patch Available" state, Anton Vinogradov > > > agreed to > > > > > review this ticket. > > > > > > > > > > Also, I'm preparing IndexQuery docs in ticket IGNITE-15745 [2]. I'm > > > going > > > > > to submit a patch with docs today/tomorrow, and want to include > them in > > > > > 2.12 too. > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15530 > > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15745 > > > > > > > > > > On Thu, Oct 28, 2021 at 11:06 AM Ilya Kasnacheev < > > > ilya.kasnach...@gmail.com> > > > > > wrote: > > > > > > > > > > > Hello! > > > > > > > > > > > > I have prepared a fix for sqlline.sh -e: > > > > > > https://github.com/apache/ignite/pull/9536 > > > > > > > > > > > > If smbd reviews it, we can put it on 2.12. > > > > > > > > > > > > Regards, > > > > > > -- > > > > > > Ilya Kasnacheev > > > > > > > > > > > > > > > > > > чт, 28 окт. 2021 г. в 10:39, Nikita Amelchev < > namelc...@apache.org>: > > > > > > > > > > > > > Maksim, ok. > > > > > > > > > > > > > > Ivan, > > > > > > > The minor issues can be considered if they will be merged > before > > > the > > > > > > > code freeze. > > > > > > > > > > > > > > ср, 27 окт. 2021 г. в 14:55, Pavel Tupitsyn < > ptupit...@apache.org > > > >: > > > > > > > > > > > > > > > > Ivan, every additional ticket potentially moves the release > date > > > > > > further. > > > > > > > > Also, AFAIK, Igor is on vacation and can't do a review this > week. > > > > > > > > > > > > > > > > On Wed, Oct 27, 2021 at 2:32 PM Ivan Daschinsky < > > > ivanda...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > Pavel, but what is the problem to include a minor > refactoring? > > > > > > > Especially > > > > > > > > > before code freeze? > > > > > > > > > > > > > > > > > > ср, 27 окт. 2021 г. в 14:25, Pavel Tupitsyn < > > > ptupit...@apache.org>: > > > > > > > > > > > > > > > > > > > Ivan, IGNITE-15806 seems to be a minor refactoring, not > sure > > > we > > > > > > > should > > > > > > > > > > inflate the scope with this. > > > > > > > > > > > > > > > > > > > > On Wed, Oct 27, 2021 at 2:13 PM Ivan Daschinsky < > > > > > > ivanda...@gmail.com > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Nikita, can we add > > > > > > > https://issues.apache.org/jira/browse/IGNITE-15806 > > > > > > > > > > this > > > > > > > > > > > ticket for release? > > > > > > > > > > > > > > > > > > > > > > ср, 27 окт. 2021 г. в 13:40, Maksim Timonin < > > > > > > > timonin.ma...@gmail.com>: > > > > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > > > I'd like to include the ticket in 2.12. There was a > > > performance > > > > > > > > > issue, > > > > > > > > > > I > > > > > > > > > > > > spent some time trying to figure it out. I prepared > some > > > fixes > > > > > > > and I > > > > > > > > > am > > > > > > > > > > > > going to submit a patch this week. > > > > > > > > > > > > > > > > > > > > > > > > I think this issue is critical to include to 2.12 > > > together with > > > > > > > basic > > > > > > > > > > > > IndexQuery functionality, because this ticket > provides > > > expected > > > > > > > > > > behavior > > > > > > > > > > > of > > > > > > > > > > > > querying indexes - sorted over all nodes results. > > > > > > > > > > > > > > > > > > > > > > > > - IGNITE-15530: IndexQuery has to use MergeSort > reducer > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > [1] > https://issues.apache.or
Re: Apache Ignite 2.12 RELEASE [Time, Scope, Manager]
Ivan, Yes, the patch can be cherry-picked. вт, 2 нояб. 2021 г. в 15:55, Ivan Daschinsky : > > Since code freeze is postponed, may be I can cherry-pick my patch already > merged to master? > https://issues.apache.org/jira/browse/IGNITE-15806 > > пт, 29 окт. 2021 г. в 20:24, Nikita Amelchev : > > > Maksim T., Maxim M., Ok. > > > > I think we can move code freeze to +1 week to await these issues. > > > > пт, 29 окт. 2021 г. в 15:53, Maxim Muzafarov : > > > > > > Folks, > > > > > > I've previously mentioned that I'd like to include the [1] issue in > > > the release. Currently, the status is "Patch Available" and it's > > > actively reviewing now. I'd be happy if we wait a couple of days and > > > add this improvement to the release. > > > > > > I've also created an issue [2] to remove the ambiguity output message > > > for the snapshot check and idle verify procedures. This is a minor > > > output message change, however, it was directly requested by users. > > > Would you don't mind if we include this issue in the release also? > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14744 > > > [2] https://issues.apache.org/jira/browse/IGNITE-15849 > > > > > > On Fri, 29 Oct 2021 at 14:19, Maksim Timonin > > wrote: > > > > > > > > Status update on my issue: > > > > > > > > IGNITE-15530 [1] is in "Patch Available" state, Anton Vinogradov > > agreed to > > > > review this ticket. > > > > > > > > Also, I'm preparing IndexQuery docs in ticket IGNITE-15745 [2]. I'm > > going > > > > to submit a patch with docs today/tomorrow, and want to include them in > > > > 2.12 too. > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15530 > > > > [2] https://issues.apache.org/jira/browse/IGNITE-15745 > > > > > > > > On Thu, Oct 28, 2021 at 11:06 AM Ilya Kasnacheev < > > ilya.kasnach...@gmail.com> > > > > wrote: > > > > > > > > > Hello! > > > > > > > > > > I have prepared a fix for sqlline.sh -e: > > > > > https://github.com/apache/ignite/pull/9536 > > > > > > > > > > If smbd reviews it, we can put it on 2.12. > > > > > > > > > > Regards, > > > > > -- > > > > > Ilya Kasnacheev > > > > > > > > > > > > > > > чт, 28 окт. 2021 г. в 10:39, Nikita Amelchev : > > > > > > > > > > > Maksim, ok. > > > > > > > > > > > > Ivan, > > > > > > The minor issues can be considered if they will be merged before > > the > > > > > > code freeze. > > > > > > > > > > > > ср, 27 окт. 2021 г. в 14:55, Pavel Tupitsyn > >: > > > > > > > > > > > > > > Ivan, every additional ticket potentially moves the release date > > > > > further. > > > > > > > Also, AFAIK, Igor is on vacation and can't do a review this week. > > > > > > > > > > > > > > On Wed, Oct 27, 2021 at 2:32 PM Ivan Daschinsky < > > ivanda...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > > Pavel, but what is the problem to include a minor refactoring? > > > > > > Especially > > > > > > > > before code freeze? > > > > > > > > > > > > > > > > ср, 27 окт. 2021 г. в 14:25, Pavel Tupitsyn < > > ptupit...@apache.org>: > > > > > > > > > > > > > > > > > Ivan, IGNITE-15806 seems to be a minor refactoring, not sure > > we > > > > > > should > > > > > > > > > inflate the scope with this. > > > > > > > > > > > > > > > > > > On Wed, Oct 27, 2021 at 2:13 PM Ivan Daschinsky < > > > > > ivanda...@gmail.com > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Nikita, can we add > > > > > > https://issues.apache.org/jira/browse/IGNITE-15806 > > > > > > > > > this > > > > > > > > > > ticket for release? > > > > > > > > > > > > > > > > > > > > ср, 27 окт. 2021 г. в 13:40, Maksim Timonin < > > > > > > timonin.ma...@gmail.com>: > > > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > I'd like to include the ticket in 2.12. There was a > > performance > > > > > > > > issue, > > > > > > > > > I > > > > > > > > > > > spent some time trying to figure it out. I prepared some > > fixes > > > > > > and I > > > > > > > > am > > > > > > > > > > > going to submit a patch this week. > > > > > > > > > > > > > > > > > > > > > > I think this issue is critical to include to 2.12 > > together with > > > > > > basic > > > > > > > > > > > IndexQuery functionality, because this ticket provides > > expected > > > > > > > > > behavior > > > > > > > > > > of > > > > > > > > > > > querying indexes - sorted over all nodes results. > > > > > > > > > > > > > > > > > > > > > > - IGNITE-15530: IndexQuery has to use MergeSort reducer > > [1] > > > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15530 > > > > > > > > > > > > > > > > > > > > > > On Wed, Oct 27, 2021 at 1:23 PM Nikita Amelchev < > > > > > > > > namelc...@apache.org> > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Hello. > > > > > > > > > > > > > > > > > > > > > > > > Code freeze is planned for Friday, October 29. > > > > > > > > > > > > > > > > > > > > > > > > There are 40 unresolved issues [1] in the release > > scope. I > >
Re: Apache Ignite 2.12 RELEASE [Time, Scope, Manager]
Since code freeze is postponed, may be I can cherry-pick my patch already merged to master? https://issues.apache.org/jira/browse/IGNITE-15806 пт, 29 окт. 2021 г. в 20:24, Nikita Amelchev : > Maksim T., Maxim M., Ok. > > I think we can move code freeze to +1 week to await these issues. > > пт, 29 окт. 2021 г. в 15:53, Maxim Muzafarov : > > > > Folks, > > > > I've previously mentioned that I'd like to include the [1] issue in > > the release. Currently, the status is "Patch Available" and it's > > actively reviewing now. I'd be happy if we wait a couple of days and > > add this improvement to the release. > > > > I've also created an issue [2] to remove the ambiguity output message > > for the snapshot check and idle verify procedures. This is a minor > > output message change, however, it was directly requested by users. > > Would you don't mind if we include this issue in the release also? > > > > [1] https://issues.apache.org/jira/browse/IGNITE-14744 > > [2] https://issues.apache.org/jira/browse/IGNITE-15849 > > > > On Fri, 29 Oct 2021 at 14:19, Maksim Timonin > wrote: > > > > > > Status update on my issue: > > > > > > IGNITE-15530 [1] is in "Patch Available" state, Anton Vinogradov > agreed to > > > review this ticket. > > > > > > Also, I'm preparing IndexQuery docs in ticket IGNITE-15745 [2]. I'm > going > > > to submit a patch with docs today/tomorrow, and want to include them in > > > 2.12 too. > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15530 > > > [2] https://issues.apache.org/jira/browse/IGNITE-15745 > > > > > > On Thu, Oct 28, 2021 at 11:06 AM Ilya Kasnacheev < > ilya.kasnach...@gmail.com> > > > wrote: > > > > > > > Hello! > > > > > > > > I have prepared a fix for sqlline.sh -e: > > > > https://github.com/apache/ignite/pull/9536 > > > > > > > > If smbd reviews it, we can put it on 2.12. > > > > > > > > Regards, > > > > -- > > > > Ilya Kasnacheev > > > > > > > > > > > > чт, 28 окт. 2021 г. в 10:39, Nikita Amelchev : > > > > > > > > > Maksim, ok. > > > > > > > > > > Ivan, > > > > > The minor issues can be considered if they will be merged before > the > > > > > code freeze. > > > > > > > > > > ср, 27 окт. 2021 г. в 14:55, Pavel Tupitsyn >: > > > > > > > > > > > > Ivan, every additional ticket potentially moves the release date > > > > further. > > > > > > Also, AFAIK, Igor is on vacation and can't do a review this week. > > > > > > > > > > > > On Wed, Oct 27, 2021 at 2:32 PM Ivan Daschinsky < > ivanda...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > Pavel, but what is the problem to include a minor refactoring? > > > > > Especially > > > > > > > before code freeze? > > > > > > > > > > > > > > ср, 27 окт. 2021 г. в 14:25, Pavel Tupitsyn < > ptupit...@apache.org>: > > > > > > > > > > > > > > > Ivan, IGNITE-15806 seems to be a minor refactoring, not sure > we > > > > > should > > > > > > > > inflate the scope with this. > > > > > > > > > > > > > > > > On Wed, Oct 27, 2021 at 2:13 PM Ivan Daschinsky < > > > > ivanda...@gmail.com > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Nikita, can we add > > > > > https://issues.apache.org/jira/browse/IGNITE-15806 > > > > > > > > this > > > > > > > > > ticket for release? > > > > > > > > > > > > > > > > > > ср, 27 окт. 2021 г. в 13:40, Maksim Timonin < > > > > > timonin.ma...@gmail.com>: > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > I'd like to include the ticket in 2.12. There was a > performance > > > > > > > issue, > > > > > > > > I > > > > > > > > > > spent some time trying to figure it out. I prepared some > fixes > > > > > and I > > > > > > > am > > > > > > > > > > going to submit a patch this week. > > > > > > > > > > > > > > > > > > > > I think this issue is critical to include to 2.12 > together with > > > > > basic > > > > > > > > > > IndexQuery functionality, because this ticket provides > expected > > > > > > > > behavior > > > > > > > > > of > > > > > > > > > > querying indexes - sorted over all nodes results. > > > > > > > > > > > > > > > > > > > > - IGNITE-15530: IndexQuery has to use MergeSort reducer > [1] > > > > > > > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15530 > > > > > > > > > > > > > > > > > > > > On Wed, Oct 27, 2021 at 1:23 PM Nikita Amelchev < > > > > > > > namelc...@apache.org> > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Hello. > > > > > > > > > > > > > > > > > > > > > > Code freeze is planned for Friday, October 29. > > > > > > > > > > > > > > > > > > > > > > There are 40 unresolved issues [1] in the release > scope. I > > > > > suggest > > > > > > > > > > > bumping up the fix version if they will not be > resolved till > > > > > the > > > > > > > code > > > > > > > > > > > freeze. > > > > > > > > > > > > > > > > > > > > > > Please, feel free to write if some of them are > critical to be > > > > > in > > > > > > > the > > > > > > > > > > 2.12. > > > > > > > > > > > > > > > > > > > > > > Als
[RESULT] [VOTE] Release Apache Ignite spring-tx-ext, spring-cache-ext extensions 1.0.0 RC1
Dear community, Release of Apache Ignite spring-tx-ext, spring-cache-ext extensions 1.0.0 RC1 has been accepted. 3 - "+1" votes received (3 binding). 2 - "+0,5" vote received (1 binding). 1 - "-0" vote received (1 binding). Here are the votes received: Anton Vinogradov (binding) Ivan Daschinsky Maxim Muzafarov (binding) Ilya Kasnacheev (binding) Denis Magda (binding) Nikolay Izhikov (binding) New release will be announced soon. -- Best wishes, Amelchev Nikita
[DISCUSSION] Add SystemRegionMetricsEnabled property on DataStorageConfiguration.
Hello, Igniters! At the moment metrics on system region are disabled on node start. User-defined regions can be tuned to have enabled metrics via region configuration (org.apache.ignite.configuration.DataRegionConfiguration#setMetricsEnabled) To enable metrics on system region users should use non-public API or use deprecated JMX bean (org.apache.ignite.mxbean.DataRegionMetricsMXBean#enableMetrics) for it, which doesn't solve problem because it needs human attention when node restarts. I want to add a new property to *org.apache.ignite.configuration.DataStorageConfiguration* which enables or disables collection of metrics on system region (aka sysMemPlc) on node start. API change add new public methods: 1. *org.apache.ignite.configuration.DataStorageConfiguration#isSystemRegionMetricsEnabled()* 2. *org.apache.ignite.configuration.DataStorageConfiguration#setSystemRegionMetricsEnabled(boolean)* WDYT? -- Best regards, Eduard.
Re: [VOTE][EXTENSION] Release Apache Ignite spring-tx-ext, spring-cache-ext extensions 1.0.0 RC1
The vote received enough votes for a resolution. I will prepare a result shortly. I have created issues to improve the release process: IGNITE-15860 [Extensions] Automated RC preparation and testing at Apache TeamCity [1] IGNITE-15861 [Extensions] Move examples to separate maven projects [2] Thanks for voting! [1] https://issues.apache.org/jira/browse/IGNITE-15860 [2] https://issues.apache.org/jira/browse/IGNITE-15861 вт, 2 нояб. 2021 г. в 12:04, Nikolay Izhikov : > > +1 (binding) > > > 1 нояб. 2021 г., в 17:41, Denis Magda написал(а): > > > > +1 (binding) > > > > Support to release the integration and then bring in essential automation > > for testing. > > > > - > > Denis > > > > > > On Wed, Oct 27, 2021 at 4:48 AM Nikita Amelchev > > wrote: > > > >> Dear Ignite Community, > >> > >> I have uploaded a release candidate of extensions modules: > >> - spring-tx-ext 1.0.0 > >> - spring-cache-ext 1.0.0 > >> - spring-data-commons 1.1.0 > >> > >> The following staging can be used for testing: > >> https://repository.apache.org/content/repositories/orgapacheignite-1533 > >> > >> The release candidate of the spring-tx-ext 1.0.0 extension: > >> > >> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-tx-ext/1.0.0-rc1/ > >> > >> The release candidate of the spring-cache-ext 1.0.0 extension: > >> > >> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-cache-ext/1.0.0-rc1/ > >> > >> The release candidate of the spring-data-common 1.1.0 dependent module > >> is in the packages mentioned above. > >> > >> Tags were created: > >> ignite-spring-tx-ext-1.0.0-rc1 > >> ignite-spring-cache-ext-1.0.0-rc1 > >> ignite-spring-data-commons-1.1.0-rc1 > >> > >> > >> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=refs/tags/ignite-spring-tx-ext-1.0.0-rc1 > >> > >> RELEASE NOTES: > >> > >> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=c6b2a393e042ce956bfefd5d7d92d5ab4ff04cda;hb=HEAD > >> > >> DOCUMENTATION: > >> Documentation of the spring-tx-ext extension: > >> > >> https://github.com/apache/ignite/blob/master/docs/_docs/extensions-and-integrations/spring/spring-tx.adoc > >> > >> Documentation of the spring-cache-ext extension: > >> > >> https://github.com/apache/ignite/blob/master/docs/_docs/extensions-and-integrations/spring/spring-caching.adoc > >> > >> The vote is formal, see voting guidelines > >> https://www.apache.org/foundation/voting.html > >> > >> +1 - to accept the extensions modules listed in the thread > >> 0 - don't care either way > >> -1 - DO NOT accept either of the extensions modules listed in the > >> thread (explain why) > >> > >> The vote will hold for 5 days and will end on November 1, 2021, 10:00 UTC > >> https://www.timeanddate.com/countdown/generic?iso=20211101T10&p0=0 > >> > >> -- > >> Best wishes, > >> Amelchev Nikita > >> > -- Best wishes, Amelchev Nikita
Re: [VOTE][EXTENSION] Release Apache Ignite spring-tx-ext, spring-cache-ext extensions 1.0.0 RC1
+1 (binding) > 1 нояб. 2021 г., в 17:41, Denis Magda написал(а): > > +1 (binding) > > Support to release the integration and then bring in essential automation > for testing. > > - > Denis > > > On Wed, Oct 27, 2021 at 4:48 AM Nikita Amelchev > wrote: > >> Dear Ignite Community, >> >> I have uploaded a release candidate of extensions modules: >> - spring-tx-ext 1.0.0 >> - spring-cache-ext 1.0.0 >> - spring-data-commons 1.1.0 >> >> The following staging can be used for testing: >> https://repository.apache.org/content/repositories/orgapacheignite-1533 >> >> The release candidate of the spring-tx-ext 1.0.0 extension: >> >> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-tx-ext/1.0.0-rc1/ >> >> The release candidate of the spring-cache-ext 1.0.0 extension: >> >> https://dist.apache.org/repos/dist/dev/ignite/ignite-extensions/ignite-spring-cache-ext/1.0.0-rc1/ >> >> The release candidate of the spring-data-common 1.1.0 dependent module >> is in the packages mentioned above. >> >> Tags were created: >> ignite-spring-tx-ext-1.0.0-rc1 >> ignite-spring-cache-ext-1.0.0-rc1 >> ignite-spring-data-commons-1.1.0-rc1 >> >> >> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=commit;h=refs/tags/ignite-spring-tx-ext-1.0.0-rc1 >> >> RELEASE NOTES: >> >> https://gitbox.apache.org/repos/asf?p=ignite-extensions.git;a=blob;f=RELEASE_NOTES.txt;h=c6b2a393e042ce956bfefd5d7d92d5ab4ff04cda;hb=HEAD >> >> DOCUMENTATION: >> Documentation of the spring-tx-ext extension: >> >> https://github.com/apache/ignite/blob/master/docs/_docs/extensions-and-integrations/spring/spring-tx.adoc >> >> Documentation of the spring-cache-ext extension: >> >> https://github.com/apache/ignite/blob/master/docs/_docs/extensions-and-integrations/spring/spring-caching.adoc >> >> The vote is formal, see voting guidelines >> https://www.apache.org/foundation/voting.html >> >> +1 - to accept the extensions modules listed in the thread >> 0 - don't care either way >> -1 - DO NOT accept either of the extensions modules listed in the >> thread (explain why) >> >> The vote will hold for 5 days and will end on November 1, 2021, 10:00 UTC >> https://www.timeanddate.com/countdown/generic?iso=20211101T10&p0=0 >> >> -- >> Best wishes, >> Amelchev Nikita >>
