Re: [DISCUSSION] Add SystemRegionMetricsEnabled property on DataStorageConfiguration.
Folks, I have created a new ticket [1] for moving system-region-related-properties to its own class. I will be pleased with your feedback on this topic. 1. https://issues.apache.org/jira/browse/IGNITE-15998 On Tue, 2 Nov 2021 at 19:58, Eduard Rakhmankulov wrote: > Hi, Andrey! > > Thank you for your reply. > > I had the same thought about special system-region-configuration-class, > but then I discovered that we have 3 special regions: > sysMemPlc, volatileDsMemPlc, metastoreMemPlc. > *If we decide to provide a special type* for configuration, then should > it be *one* type for all special regions but *different* instances, or > should the user provide *one* instance of > system-region-configuration-class, or maybe even *different* type for > each special region? > > My heart aligns with the first option. > > Or maybe it is better to stick to the initial plan: only make new holes in > *DataStorageConfiguration?* > > On Tue, 2 Nov 2021 at 17:40, Andrey Gura wrote: > >> Hi, >> >> Your proposal is consistent with the current interface of >> DataStorageConfiguration class, so I', okay with the proposed change. >> >> Alternatively, DataStorageConfiguration#systemDataRegionConfiguration >> field could be introduced which could be DataRegionConfiguration type >> or special SystemDataRegionConfiguration type in case if we want to >> limit access to the system data region parameters. >> >> On Tue, Nov 2, 2021 at 2:42 PM Eduard Rakhmankulov >> wrote: >> > >> > Hello, Igniters! >> > >> > At the moment metrics on system region are disabled on node start. >> > User-defined regions can be tuned to have enabled metrics via region >> > configuration >> > >> (org.apache.ignite.configuration.DataRegionConfiguration#setMetricsEnabled) >> > To enable metrics on system region users should use non-public API or >> use >> > deprecated JMX bean >> > (org.apache.ignite.mxbean.DataRegionMetricsMXBean#enableMetrics) for it, >> > which doesn't solve problem because it needs human attention when node >> > restarts. >> > >> > I want to add a new property to >> > *org.apache.ignite.configuration.DataStorageConfiguration* which >> enables or >> > disables collection of metrics on system region (aka sysMemPlc) on node >> > start. >> > >> > API change >> > add new public methods: >> > >> >1. >> > >> *org.apache.ignite.configuration.DataStorageConfiguration#isSystemRegionMetricsEnabled()* >> >2. >> > >> *org.apache.ignite.configuration.DataStorageConfiguration#setSystemRegionMetricsEnabled(boolean)* >> > >> > >> > WDYT? >> > -- >> > Best regards, Eduard. >> >
Re: Moving snapshot tests to their own test suites
My concern was only that 1.0 is too high for TC overall. If it is OK for Nightly builds — no problems. However — ordinary Run All uses 0.1 scale and to use 0.2 in that suite we should hardcode it inside the suite (or to be more precise — compute based on input). > On 25 Nov 2021, at 16:06, Maxim Muzafarov wrote: > > Petr, > > For the RunAll - 0.2 > For the RunAll(Nightly) - 1.0 (the 1.0 is better that 0.2 for sure) > > On Thu, 25 Nov 2021 at 15:54, Petr Ivanov wrote: >> >> 0.2 or 1.0? >> >>> On 25 Nov 2021, at 14:34, Maxim Muzafarov wrote: >>> >>> Pert, >>> >>> I think for nightly builds this is the only right option for the >>> suites mentioned above. >>> >>> On Thu, 25 Nov 2021 at 14:33, Petr Ivanov wrote: Hi, Maksim. Run All (Nightly) build will run suites with test scale factor 1.0 — will it be a problem? > On 25 Nov 2021, at 14:22, Maxim Muzafarov wrote: > > Folks, > > I've merged the PR [1] to the master branch and applied scale factor > 0.2 to the tests that were moved to dedicated suites. > I've created two suites and added them to the Run.All test suite. > - Snapshots [2] > - SnapshotsWithIndexes [3] > > [1] https://github.com/apache/ignite/pull/9584/files > [2] > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Snapshots&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > [3] > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SnapsohtWithIndexes&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > > On Wed, 24 Nov 2021 at 15:30, Maxim Muzafarov wrote: >> >> Igniters, >> >> Currently, there are a lot of snapshot tests running under the >> `Basic3` test suite. Since the amount of tests is actually growing it >> is not good to run them at the basic Ignite test suite. >> >> I propose moving all the tests to a dedicated test suite and running >> them independently taking into account that most of them require >> TEST_SCALE_FACTOR_PROPERTY to be configured. The default number of >> affinity partitions is 1024 and this is too big for TeamCity agents >> with slow HDD. >> >> I've prepared the PR [2] within the issue [1]. >> Are there any objections to do such changes? >> >> >> [1] https://issues.apache.org/jira/browse/IGNITE-15233 >> [2] https://github.com/apache/ignite/pull/9584/files >> [3] >> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_DiskPageCompressions1&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv >>
Re: Apache Ignite 2.12 RELEASE [Time, Scope, Manager]
Hello Ivan, +1, the issue can be cherry-picked to the 2.12. чт, 25 нояб. 2021 г. в 17:07, Ivan Bessonov : > > Hello everyone, > > is there a chance to add this issue to the release scope? [1] > Currently, defragmentation of certain types of indexes can corrupt them. > Fix is straightforward and should not cause any problems. > Thank you! > > [1] https://issues.apache.org/jira/browse/IGNITE-15968 > > вт, 23 нояб. 2021 г. в 20:44, Nikita Amelchev : > > > Ivan, > > > > I have cherry-picked the issue: > > https://issues.apache.org/jira/browse/IGNITE-15767 > > > > вт, 23 нояб. 2021 г. в 20:31, Nikolay Izhikov : > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15951 > > > > > > Cherry-picked to 2.12 > > > > > > > 23 нояб. 2021 г., в 16:38, Nikita Amelchev > > написал(а): > > > > > > > > Hi, +1 to cherry-pick. > > > > > > > > вт, 23 нояб. 2021 г. в 15:25, Ivan Daschinsky : > > > >> > > > >> Hi! Lets add one simple bug fix, but very useful > > > >> > > > >> https://issues.apache.org/jira/browse/IGNITE-15767 > > > >> > > > >> пн, 22 нояб. 2021 г. в 15:22, Pavel Tupitsyn : > > > >> > > > >>> Yes, let's fix those auth issues, there are so many complaints on > > the user > > > >>> list. > > > >>> > > > >>> On Mon, Nov 22, 2021 at 1:03 PM Mikhail Petrov < > > pmgheap@gmail.com> > > > >>> wrote: > > > >>> > > > Igniters, > > > it seems that issues [1] and [2] that were discovered recently are > > > blockers for the 2.12 release. > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15951 > > > [2] https://issues.apache.org/jira/browse/IGNITE-15966 > > > > > > On 22.11.2021 11:04, Nikolay Izhikov wrote: > > > > Hello. > > > > > > > > One more tiny fix that will improve java thin client performance in > > > certain cases [1] > > > > I think it worth to cherry-pick it to 2.12 release. > > > > > > > > Any objections? > > > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15924 > > > > > > > >> 19 нояб. 2021 г., в 14:56, Nikita Amelchev > > > написал(а): > > > >> > > > >> Vladimir, +1. > > > >> > > > >> I have cherry-picked the issue. > > > >> > > > >> пт, 19 нояб. 2021 г. в 14:53, Steshin Vladimir < > > vlads...@gmail.com>: > > > >>> Hi all. > > > >>> > > > >>> > > > >>> Let's add simple and useful thin-client-pool monitoring in > > 2.12: > > > >>> > > > >>> https://issues.apache.org/jira/browse/IGNITE-15183 > > > >>> > > > >>> https://github.com/apache/ignite/pull/9525 > > > >>> > > > >>> > > > >>> 19.11.2021 09:50, Maksim Timonin пишет: > > > Hi, I want to add to 2.12 a fix [1] of a bug [2]. It affects > > users > > > >>> of > > > metrics in case there are too many partitions (> 2), we > > observed > > > extensive heap usage. > > > > > > [1] https://github.com/apache/ignite/pull/9518/files > > > [2] https://issues.apache.org/jira/browse/IGNITE-15781 > > > > > > On Thu, Nov 18, 2021 at 12:59 PM Maksim Timonin < > > > timonin.ma...@gmail.com> > > > wrote: > > > > > > > Hi, guys, we have a blocker [1]. NPE for some SQL queries. I > > will > > > fix it > > > > in 1-2 days. > > > > > > > > https://issues.apache.org/jira/browse/IGNITE-15943 > > > > > > > > On Mon, Nov 15, 2021 at 2:57 PM Maxim Muzafarov < > > mmu...@apache.org > > > > > > wrote: > > > > > > > >> Folks, > > > >> > > > >> I've fixed almost all the review comments [1]. Hopefully, the > > > changes > > > >> will be merged by the end of the week. > > > >> > > > >> [1] https://issues.apache.org/jira/browse/IGNITE-14744 > > > >> > > > >> On Mon, 8 Nov 2021 at 15:42, Nikita Amelchev < > > > >>> namelc...@apache.org> > > > >> wrote: > > > >>> Hello, Pavel. > > > >>> > > > >>> The code freeze is blocked by two issues discussed above [1] > > [2]. > > > The > > > >>> issues are in the final review state and should be merged > > soon. > > > >>> > > > >>> The bugfix is useful and can be cherry-picked, thank you. > > > >>> > > > >>> [1] https://issues.apache.org/jira/browse/IGNITE-15530 > > > >>> [2] https://issues.apache.org/jira/browse/IGNITE-14744 > > > >>> > > > >>> > > > >>> пн, 8 нояб. 2021 г. в 14:46, Pavel Tupitsyn < > > > >>> ptupit...@apache.org > > > > : > > > >>> > > > Igniters, > > > > > > What's the code freeze status? > > > Can I cherry-pick a bugfix [1] ? > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15807 > > > > > > On Tue, Nov 2, 2021 at 4:39 PM Ivan Daschinsky < > > > ivanda...@gm
Re: Apache Ignite 2.12 RELEASE [Time, Scope, Manager]
Hello everyone, is there a chance to add this issue to the release scope? [1] Currently, defragmentation of certain types of indexes can corrupt them. Fix is straightforward and should not cause any problems. Thank you! [1] https://issues.apache.org/jira/browse/IGNITE-15968 вт, 23 нояб. 2021 г. в 20:44, Nikita Amelchev : > Ivan, > > I have cherry-picked the issue: > https://issues.apache.org/jira/browse/IGNITE-15767 > > вт, 23 нояб. 2021 г. в 20:31, Nikolay Izhikov : > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15951 > > > > Cherry-picked to 2.12 > > > > > 23 нояб. 2021 г., в 16:38, Nikita Amelchev > написал(а): > > > > > > Hi, +1 to cherry-pick. > > > > > > вт, 23 нояб. 2021 г. в 15:25, Ivan Daschinsky : > > >> > > >> Hi! Lets add one simple bug fix, but very useful > > >> > > >> https://issues.apache.org/jira/browse/IGNITE-15767 > > >> > > >> пн, 22 нояб. 2021 г. в 15:22, Pavel Tupitsyn : > > >> > > >>> Yes, let's fix those auth issues, there are so many complaints on > the user > > >>> list. > > >>> > > >>> On Mon, Nov 22, 2021 at 1:03 PM Mikhail Petrov < > pmgheap@gmail.com> > > >>> wrote: > > >>> > > Igniters, > > it seems that issues [1] and [2] that were discovered recently are > > blockers for the 2.12 release. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15951 > > [2] https://issues.apache.org/jira/browse/IGNITE-15966 > > > > On 22.11.2021 11:04, Nikolay Izhikov wrote: > > > Hello. > > > > > > One more tiny fix that will improve java thin client performance in > > certain cases [1] > > > I think it worth to cherry-pick it to 2.12 release. > > > > > > Any objections? > > > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15924 > > > > > >> 19 нояб. 2021 г., в 14:56, Nikita Amelchev > > написал(а): > > >> > > >> Vladimir, +1. > > >> > > >> I have cherry-picked the issue. > > >> > > >> пт, 19 нояб. 2021 г. в 14:53, Steshin Vladimir < > vlads...@gmail.com>: > > >>> Hi all. > > >>> > > >>> > > >>> Let's add simple and useful thin-client-pool monitoring in > 2.12: > > >>> > > >>> https://issues.apache.org/jira/browse/IGNITE-15183 > > >>> > > >>> https://github.com/apache/ignite/pull/9525 > > >>> > > >>> > > >>> 19.11.2021 09:50, Maksim Timonin пишет: > > Hi, I want to add to 2.12 a fix [1] of a bug [2]. It affects > users > > >>> of > > metrics in case there are too many partitions (> 2), we > observed > > extensive heap usage. > > > > [1] https://github.com/apache/ignite/pull/9518/files > > [2] https://issues.apache.org/jira/browse/IGNITE-15781 > > > > On Thu, Nov 18, 2021 at 12:59 PM Maksim Timonin < > > timonin.ma...@gmail.com> > > wrote: > > > > > Hi, guys, we have a blocker [1]. NPE for some SQL queries. I > will > > fix it > > > in 1-2 days. > > > > > > https://issues.apache.org/jira/browse/IGNITE-15943 > > > > > > On Mon, Nov 15, 2021 at 2:57 PM Maxim Muzafarov < > mmu...@apache.org > > > > wrote: > > > > > >> Folks, > > >> > > >> I've fixed almost all the review comments [1]. Hopefully, the > > changes > > >> will be merged by the end of the week. > > >> > > >> [1] https://issues.apache.org/jira/browse/IGNITE-14744 > > >> > > >> On Mon, 8 Nov 2021 at 15:42, Nikita Amelchev < > > >>> namelc...@apache.org> > > >> wrote: > > >>> Hello, Pavel. > > >>> > > >>> The code freeze is blocked by two issues discussed above [1] > [2]. > > The > > >>> issues are in the final review state and should be merged > soon. > > >>> > > >>> The bugfix is useful and can be cherry-picked, thank you. > > >>> > > >>> [1] https://issues.apache.org/jira/browse/IGNITE-15530 > > >>> [2] https://issues.apache.org/jira/browse/IGNITE-14744 > > >>> > > >>> > > >>> пн, 8 нояб. 2021 г. в 14:46, Pavel Tupitsyn < > > >>> ptupit...@apache.org > > > : > > >>> > > Igniters, > > > > What's the code freeze status? > > Can I cherry-pick a bugfix [1] ? > > > > [1] https://issues.apache.org/jira/browse/IGNITE-15807 > > > > On Tue, Nov 2, 2021 at 4:39 PM Ivan Daschinsky < > > ivanda...@gmail.com> > > >> wrote: > > > Thanks, cherry-picked to master. > > > > > > вт, 2 нояб. 2021 г. в 16:00, Nikita Amelchev < > > namelc...@apache.org > > >>> : > > >> Ivan, > > >> > > >> Yes, the patch can be cherry-picked. > > >> > > >> вт, 2 нояб. 2021 г. в 15:55, Ivan Daschinsky <
Re: Moving snapshot tests to their own test suites
Petr, For the RunAll - 0.2 For the RunAll(Nightly) - 1.0 (the 1.0 is better that 0.2 for sure) On Thu, 25 Nov 2021 at 15:54, Petr Ivanov wrote: > > 0.2 or 1.0? > > > On 25 Nov 2021, at 14:34, Maxim Muzafarov wrote: > > > > Pert, > > > > I think for nightly builds this is the only right option for the > > suites mentioned above. > > > > On Thu, 25 Nov 2021 at 14:33, Petr Ivanov wrote: > >> > >> Hi, Maksim. > >> > >> > >> Run All (Nightly) build will run suites with test scale factor 1.0 — will > >> it be a problem? > >> > >>> On 25 Nov 2021, at 14:22, Maxim Muzafarov wrote: > >>> > >>> Folks, > >>> > >>> I've merged the PR [1] to the master branch and applied scale factor > >>> 0.2 to the tests that were moved to dedicated suites. > >>> I've created two suites and added them to the Run.All test suite. > >>> - Snapshots [2] > >>> - SnapshotsWithIndexes [3] > >>> > >>> [1] https://github.com/apache/ignite/pull/9584/files > >>> [2] > >>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Snapshots&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > >>> [3] > >>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SnapsohtWithIndexes&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > >>> > >>> On Wed, 24 Nov 2021 at 15:30, Maxim Muzafarov wrote: > > Igniters, > > Currently, there are a lot of snapshot tests running under the > `Basic3` test suite. Since the amount of tests is actually growing it > is not good to run them at the basic Ignite test suite. > > I propose moving all the tests to a dedicated test suite and running > them independently taking into account that most of them require > TEST_SCALE_FACTOR_PROPERTY to be configured. The default number of > affinity partitions is 1024 and this is too big for TeamCity agents > with slow HDD. > > I've prepared the PR [2] within the issue [1]. > Are there any objections to do such changes? > > > [1] https://issues.apache.org/jira/browse/IGNITE-15233 > [2] https://github.com/apache/ignite/pull/9584/files > [3] > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_DiskPageCompressions1&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > >> >
Re: Moving snapshot tests to their own test suites
0.2 or 1.0? > On 25 Nov 2021, at 14:34, Maxim Muzafarov wrote: > > Pert, > > I think for nightly builds this is the only right option for the > suites mentioned above. > > On Thu, 25 Nov 2021 at 14:33, Petr Ivanov wrote: >> >> Hi, Maksim. >> >> >> Run All (Nightly) build will run suites with test scale factor 1.0 — will it >> be a problem? >> >>> On 25 Nov 2021, at 14:22, Maxim Muzafarov wrote: >>> >>> Folks, >>> >>> I've merged the PR [1] to the master branch and applied scale factor >>> 0.2 to the tests that were moved to dedicated suites. >>> I've created two suites and added them to the Run.All test suite. >>> - Snapshots [2] >>> - SnapshotsWithIndexes [3] >>> >>> [1] https://github.com/apache/ignite/pull/9584/files >>> [2] >>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Snapshots&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv >>> [3] >>> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SnapsohtWithIndexes&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv >>> >>> On Wed, 24 Nov 2021 at 15:30, Maxim Muzafarov wrote: Igniters, Currently, there are a lot of snapshot tests running under the `Basic3` test suite. Since the amount of tests is actually growing it is not good to run them at the basic Ignite test suite. I propose moving all the tests to a dedicated test suite and running them independently taking into account that most of them require TEST_SCALE_FACTOR_PROPERTY to be configured. The default number of affinity partitions is 1024 and this is too big for TeamCity agents with slow HDD. I've prepared the PR [2] within the issue [1]. Are there any objections to do such changes? [1] https://issues.apache.org/jira/browse/IGNITE-15233 [2] https://github.com/apache/ignite/pull/9584/files [3] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_DiskPageCompressions1&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv >>
RE: Issue - IGNITE-15348
Thanks!
Re: Issue - IGNITE-15348
Nikolay, Andrei, I've already merged the patch. чт, 25 нояб. 2021 г. в 14:36, Nikolay Izhikov : > Hello, Andrei. > > I will review your changes shortly. > > > 25 нояб. 2021 г., в 14:31, Andrei Demidov > написал(а): > > > > Hi! > > > > Could somebody please explain me. > > Should I do something for my changes to be merged? > > In contributing guide it's said that changes will be merged by any > committer after review. > > > > Thanks! > >
Re: Issue - IGNITE-15348
Ok, thanks!
Re: Issue - IGNITE-15348
Hello, Andrei. I will review your changes shortly. > 25 нояб. 2021 г., в 14:31, Andrei Demidov > написал(а): > > Hi! > > Could somebody please explain me. > Should I do something for my changes to be merged? > In contributing guide it's said that changes will be merged by any committer > after review. > > Thanks!
Re: Moving snapshot tests to their own test suites
Pert, I think for nightly builds this is the only right option for the suites mentioned above. On Thu, 25 Nov 2021 at 14:33, Petr Ivanov wrote: > > Hi, Maksim. > > > Run All (Nightly) build will run suites with test scale factor 1.0 — will it > be a problem? > > > On 25 Nov 2021, at 14:22, Maxim Muzafarov wrote: > > > > Folks, > > > > I've merged the PR [1] to the master branch and applied scale factor > > 0.2 to the tests that were moved to dedicated suites. > > I've created two suites and added them to the Run.All test suite. > > - Snapshots [2] > > - SnapshotsWithIndexes [3] > > > > [1] https://github.com/apache/ignite/pull/9584/files > > [2] > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Snapshots&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > > [3] > > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SnapsohtWithIndexes&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > > > > On Wed, 24 Nov 2021 at 15:30, Maxim Muzafarov wrote: > >> > >> Igniters, > >> > >> Currently, there are a lot of snapshot tests running under the > >> `Basic3` test suite. Since the amount of tests is actually growing it > >> is not good to run them at the basic Ignite test suite. > >> > >> I propose moving all the tests to a dedicated test suite and running > >> them independently taking into account that most of them require > >> TEST_SCALE_FACTOR_PROPERTY to be configured. The default number of > >> affinity partitions is 1024 and this is too big for TeamCity agents > >> with slow HDD. > >> > >> I've prepared the PR [2] within the issue [1]. > >> Are there any objections to do such changes? > >> > >> > >> [1] https://issues.apache.org/jira/browse/IGNITE-15233 > >> [2] https://github.com/apache/ignite/pull/9584/files > >> [3] > >> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_DiskPageCompressions1&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv >
Re: Moving snapshot tests to their own test suites
Hi, Maksim. Run All (Nightly) build will run suites with test scale factor 1.0 — will it be a problem? > On 25 Nov 2021, at 14:22, Maxim Muzafarov wrote: > > Folks, > > I've merged the PR [1] to the master branch and applied scale factor > 0.2 to the tests that were moved to dedicated suites. > I've created two suites and added them to the Run.All test suite. > - Snapshots [2] > - SnapshotsWithIndexes [3] > > [1] https://github.com/apache/ignite/pull/9584/files > [2] > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Snapshots&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > [3] > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SnapsohtWithIndexes&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv > > On Wed, 24 Nov 2021 at 15:30, Maxim Muzafarov wrote: >> >> Igniters, >> >> Currently, there are a lot of snapshot tests running under the >> `Basic3` test suite. Since the amount of tests is actually growing it >> is not good to run them at the basic Ignite test suite. >> >> I propose moving all the tests to a dedicated test suite and running >> them independently taking into account that most of them require >> TEST_SCALE_FACTOR_PROPERTY to be configured. The default number of >> affinity partitions is 1024 and this is too big for TeamCity agents >> with slow HDD. >> >> I've prepared the PR [2] within the issue [1]. >> Are there any objections to do such changes? >> >> >> [1] https://issues.apache.org/jira/browse/IGNITE-15233 >> [2] https://github.com/apache/ignite/pull/9584/files >> [3] >> https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_DiskPageCompressions1&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
Re: Issue - IGNITE-15348
Hi! Could somebody please explain me. Should I do something for my changes to be merged? In contributing guide it's said that changes will be merged by any committer after review. Thanks!
Re: Moving snapshot tests to their own test suites
Folks, I've merged the PR [1] to the master branch and applied scale factor 0.2 to the tests that were moved to dedicated suites. I've created two suites and added them to the Run.All test suite. - Snapshots [2] - SnapshotsWithIndexes [3] [1] https://github.com/apache/ignite/pull/9584/files [2] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Snapshots&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv [3] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_SnapsohtWithIndexes&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv On Wed, 24 Nov 2021 at 15:30, Maxim Muzafarov wrote: > > Igniters, > > Currently, there are a lot of snapshot tests running under the > `Basic3` test suite. Since the amount of tests is actually growing it > is not good to run them at the basic Ignite test suite. > > I propose moving all the tests to a dedicated test suite and running > them independently taking into account that most of them require > TEST_SCALE_FACTOR_PROPERTY to be configured. The default number of > affinity partitions is 1024 and this is too big for TeamCity agents > with slow HDD. > > I've prepared the PR [2] within the issue [1]. > Are there any objections to do such changes? > > > [1] https://issues.apache.org/jira/browse/IGNITE-15233 > [2] https://github.com/apache/ignite/pull/9584/files > [3] > https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_DiskPageCompressions1&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
Re: IEP-82 Thin Client Retry Policy
Igor, I think it should list all operations, mostly the same as ClientOperation enum, but without internal things like RESOURCE_CLOSE. Users should be able to implement policies like "retry k/v operations, but not SQL". On Thu, Nov 25, 2021 at 12:27 PM Igor Sapego wrote: > Pavel, > > What is ClientOperationType? Will it list basically all operations or only > types like Idempotent, NonIdempotent? > > Best Regards, > Igor > > > On Wed, Nov 24, 2021 at 5:21 PM Pavel Tupitsyn > wrote: > > > Igniters, > > > > I've prepared a proposal about thin client retry behavior. > > Please review and let me know your thoughts. > > > > > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-82+Thin+Client+Retry+Policy > > >
Re: IEP-82 Thin Client Retry Policy
Pavel, What is ClientOperationType? Will it list basically all operations or only types like Idempotent, NonIdempotent? Best Regards, Igor On Wed, Nov 24, 2021 at 5:21 PM Pavel Tupitsyn wrote: > Igniters, > > I've prepared a proposal about thin client retry behavior. > Please review and let me know your thoughts. > > > https://cwiki.apache.org/confluence/display/IGNITE/IEP-82+Thin+Client+Retry+Policy >
