Re: TeamCity #1: Problem with 'ZooKeeper (Discovery) 1'
Thanks a lot, Ivan! I have prepared a ticket [1] and will check suggested changes soon. 1. https://issues.apache.org/jira/browse/IGNITE-16793 пн, 4 апр. 2022 г. в 18:04, Ivan Daschinsky : > Seems that after update of zookeeper and curator, behaviour of testing > cluster have been slightly changed. I've tried to > increase zookeeper.electionPortBindRetry for testing zk ensemble > nodes and seems all issues are resolved now. > > пн, 4 апр. 2022 г. в 17:37, Ilya Shishkov : > > > Hi all, > > > > As I see TC#1 (ci.ignite.apache.org) experiences problems with > 'ZooKeeper > > (Discovery) 1' test suite execution (master branch). > > There are such errors in logs as below [1, 2]: > > [2022-04-04 03:37:09,971][ERROR][QuorumPeerListener][ServiceUtils] > > Exiting JVM with code 14 > > Process exited with code 14 > > > > I checked TC#2 (ci2.ignite.apache.org) and found out that the amount of > > test runs on TC2 [3, 4] is more than those on TC1 [5, 6]. And, BTW, > > there are no problems with exit code on TC#2. > > > > It seems to be an infrastructure problem, because as I understand, > > Zookeeper can't bind to a port. This line is from Zookeeper ExitCode > class > > [7]: > > /** Unable to bind to the quorum (election) port after multiple retry > > */ > > UNABLE_TO_BIND_QUORUM_PORT(14); > > > > Please, can anyone take a look at possible misconfiguration on TC#1? > > > > Links: > > 1. > > > > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6500597?showLog=6500597_230432_890.962.230567.230604=debug > > 2. > > > > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6501316?showLog=6501316_228931_890.962.228942=debug > > 4. > > > > > https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6376069?buildTab=tests=classes > > 5 . > > > > > https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6377319?buildTab=tests=classes > > > > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6500597?buildTab=tests=passed=classes > > 6. > > > > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6501316?buildTab=tests=classes=all > > 7. > > > > > https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/ExitCode.java#L51 > > > > > -- > Sincerely yours, Ivan Daschinskiy >
Re: TeamCity #1: Problem with 'ZooKeeper (Discovery) 1'
Seems that after update of zookeeper and curator, behaviour of testing cluster have been slightly changed. I've tried to increase zookeeper.electionPortBindRetry for testing zk ensemble nodes and seems all issues are resolved now. пн, 4 апр. 2022 г. в 17:37, Ilya Shishkov : > Hi all, > > As I see TC#1 (ci.ignite.apache.org) experiences problems with 'ZooKeeper > (Discovery) 1' test suite execution (master branch). > There are such errors in logs as below [1, 2]: > [2022-04-04 03:37:09,971][ERROR][QuorumPeerListener][ServiceUtils] > Exiting JVM with code 14 > Process exited with code 14 > > I checked TC#2 (ci2.ignite.apache.org) and found out that the amount of > test runs on TC2 [3, 4] is more than those on TC1 [5, 6]. And, BTW, > there are no problems with exit code on TC#2. > > It seems to be an infrastructure problem, because as I understand, > Zookeeper can't bind to a port. This line is from Zookeeper ExitCode class > [7]: > /** Unable to bind to the quorum (election) port after multiple retry > */ > UNABLE_TO_BIND_QUORUM_PORT(14); > > Please, can anyone take a look at possible misconfiguration on TC#1? > > Links: > 1. > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6500597?showLog=6500597_230432_890.962.230567.230604=debug > 2. > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6501316?showLog=6501316_228931_890.962.228942=debug > 4. > > https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6376069?buildTab=tests=classes > 5 . > > https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6377319?buildTab=tests=classes > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6500597?buildTab=tests=passed=classes > 6. > > https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6501316?buildTab=tests=classes=all > 7. > > https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/ExitCode.java#L51 > -- Sincerely yours, Ivan Daschinskiy
TeamCity #1: Problem with 'ZooKeeper (Discovery) 1'
Hi all, As I see TC#1 (ci.ignite.apache.org) experiences problems with 'ZooKeeper (Discovery) 1' test suite execution (master branch). There are such errors in logs as below [1, 2]: [2022-04-04 03:37:09,971][ERROR][QuorumPeerListener][ServiceUtils] Exiting JVM with code 14 Process exited with code 14 I checked TC#2 (ci2.ignite.apache.org) and found out that the amount of test runs on TC2 [3, 4] is more than those on TC1 [5, 6]. And, BTW, there are no problems with exit code on TC#2. It seems to be an infrastructure problem, because as I understand, Zookeeper can't bind to a port. This line is from Zookeeper ExitCode class [7]: /** Unable to bind to the quorum (election) port after multiple retry */ UNABLE_TO_BIND_QUORUM_PORT(14); Please, can anyone take a look at possible misconfiguration on TC#1? Links: 1. https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6500597?showLog=6500597_230432_890.962.230567.230604=debug 2. https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6501316?showLog=6501316_228931_890.962.228942=debug 4. https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6376069?buildTab=tests=classes 5 . https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6377319?buildTab=tests=classes https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6500597?buildTab=tests=passed=classes 6. https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_ZooKeeperDiscovery1/6501316?buildTab=tests=classes=all 7. https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/ExitCode.java#L51
IFRA ticket regarding GitHub notifications on dev list
Hi, I observed some GitHub PR notifications on dev list and today and created a ticket https://issues.apache.org/jira/browse/INFRA-23075 Best regards, Ivan Pavlukhin
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #739: IGNITE-16697 MV storage methods and reference implementation
korlov42 commented on code in PR #739:
URL: https://github.com/apache/ignite-3/pull/739#discussion_r841462683
##
modules/core/src/main/java/org/apache/ignite/internal/util/Cursor.java:
##
@@ -25,5 +26,40 @@
* @param Type of elements.
*/
public interface Cursor extends Iterator, Iterable, AutoCloseable {
+/** {@inheritDoc} */
+@Override
+default Iterator iterator() {
+return this;
+}
+/**
+ * Creates an iterator based cursor.
+ *
+ * @param it Iterator.
+ * @param Type of elements in iterator.
+ * @return Cursor.
+ */
+static Cursor fromIterator(Iterator it) {
+return new Cursor() {
+/** {@inheritDoc} */
+@Override
+public void close() throws Exception {
+if (it instanceof Closeable) {
Review Comment:
I believe `AutoCloseable` fits better here. The logic is simple: since
`Cursor` extends `AutoCloseable`, I would expect that wrapped iterator which
extends `AutoCloseable` as well will be closed by invocation of 'close()' on
the cursor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #754: IGNITE-16691 Storage Configuration refactoring and improvements
ibessonov commented on code in PR #754:
URL: https://github.com/apache/ignite-3/pull/754#discussion_r841445460
##
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorageEngineFactory.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.storage.rocksdb;
+
+import java.nio.file.Path;
+import org.apache.ignite.internal.configuration.ConfigurationRegistry;
+import org.apache.ignite.internal.storage.StorageException;
+import org.apache.ignite.internal.storage.engine.StorageEngine;
+import org.apache.ignite.internal.storage.engine.StorageEngineFactory;
+import
org.apache.ignite.internal.storage.rocksdb.configuration.schema.RocksDbStorageEngineConfiguration;
+
+/**
+ * Implementation for creating {@link RocksDbStorageEngine}'s.
+ */
+public class RocksDbStorageEngineFactory implements StorageEngineFactory {
+/** {@inheritDoc} */
+@Override
+public StorageEngine createEngine(ConfigurationRegistry configRegistry,
Path storagePath) throws StorageException {
+RocksDbStorageEngineConfiguration engineConfig =
configRegistry.getConfiguration(RocksDbStorageEngineConfiguration.KEY);
+
+if (engineConfig == null) {
Review Comment:
I should refactor our approach to validators, too many weird annotations =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #739: IGNITE-16697 MV storage methods and reference implementation
ibessonov commented on code in PR #739:
URL: https://github.com/apache/ignite-3/pull/739#discussion_r841437090
##
modules/core/src/main/java/org/apache/ignite/internal/util/Cursor.java:
##
@@ -25,5 +25,38 @@
* @param Type of elements.
*/
public interface Cursor extends Iterator, Iterable, AutoCloseable {
+/** {@inheritDoc} */
+@Override
+default Iterator iterator() {
+return this;
+}
+/**
+ * Creates an iterator based cursor.
+ *
+ * @param it Iterator.
+ * @param Type of elements in iterator.
+ * @return Cursor.
+ */
+static Cursor fromIterator(Iterator it) {
+return new Cursor() {
+/** {@inheritDoc} */
+@Override
+public void close() throws Exception {
+// No-op.
Review Comment:
Nice, I'll do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #754: IGNITE-16691 Storage Configuration refactoring and improvements
tkalkirill commented on code in PR #754:
URL: https://github.com/apache/ignite-3/pull/754#discussion_r841435461
##
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorageEngineFactory.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.storage.rocksdb;
+
+import java.nio.file.Path;
+import org.apache.ignite.internal.configuration.ConfigurationRegistry;
+import org.apache.ignite.internal.storage.StorageException;
+import org.apache.ignite.internal.storage.engine.StorageEngine;
+import org.apache.ignite.internal.storage.engine.StorageEngineFactory;
+import
org.apache.ignite.internal.storage.rocksdb.configuration.schema.RocksDbStorageEngineConfiguration;
+
+/**
+ * Implementation for creating {@link RocksDbStorageEngine}'s.
+ */
+public class RocksDbStorageEngineFactory implements StorageEngineFactory {
+/** {@inheritDoc} */
+@Override
+public StorageEngine createEngine(ConfigurationRegistry configRegistry,
Path storagePath) throws StorageException {
+RocksDbStorageEngineConfiguration engineConfig =
configRegistry.getConfiguration(RocksDbStorageEngineConfiguration.KEY);
+
+if (engineConfig == null) {
Review Comment:
Replaced with: **@PageMemoryDataRegionValidator** and
**@RocksDbDataRegionValidator**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #739: IGNITE-16697 MV storage methods and reference implementation
korlov42 commented on code in PR #739:
URL: https://github.com/apache/ignite-3/pull/739#discussion_r841434095
##
modules/core/src/main/java/org/apache/ignite/internal/util/Cursor.java:
##
@@ -25,5 +25,38 @@
* @param Type of elements.
*/
public interface Cursor extends Iterator, Iterable, AutoCloseable {
+/** {@inheritDoc} */
+@Override
+default Iterator iterator() {
+return this;
+}
+/**
+ * Creates an iterator based cursor.
+ *
+ * @param it Iterator.
+ * @param Type of elements in iterator.
+ * @return Cursor.
+ */
+static Cursor fromIterator(Iterator it) {
+return new Cursor() {
+/** {@inheritDoc} */
+@Override
+public void close() throws Exception {
+// No-op.
Review Comment:
Perhaps, it would be better to propagate `close()` to the iterator in case
the latter implements an interface `AutoCloseable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
