IGNITE-10698 Task
Hello everyone, I've fixed codestyle issues in my branch and got "No possible blockers" in TC bot, so PR is currently ready for review. PR github link: https://github.com/apache/ignite/pull/7394 Jira task link: https://issues.apache.org/jira/browse/IGNITE-10698 TeamcityBot link: https://mtcga.gridgain.com/pr.html?serverId=apache=IgniteTests24Java8_RunAll=pull/7394/head=Latest
[ML] Tickets for beginners
Hello everyone I'd like to take following task: https://issues.apache.org/jira/browse/IGNITE-12384?jql=project%20%3D%20IGNITE%20AND%20status%20in%20(Open%2C%20Reopened)%20AND%20component%20%3D%20ML%20AND%20labels%20%3D%20newbie But I do not fully understand what exactly needs to be done. As far as I understand encoders are needed to convert categorical variables to numerical. So, to demonstrate how they works I need some dataset with several categorical features. Should I search for it or generate by myself? Then, do I need to solve some regression/classification problem in order to demonstrate "power" of using categorical variables to fit prediction or classification models?
IGNITE-10698 Task
Hello everyone, I've finished task [IGNITE-10698] and made PR Jira issue link: https://issues.apache.org/jira/browse/IGNITE-10698?jql=project%20%3D%20IGNITE%20AND%20labels%20in%20(newbie)%20and%20status%20%3D%20OPEN PR github link: https://github.com/apache/ignite/pull/7394 It will be cool if someone checks it, especially Andrey Gura, with whom we discussed implementation details. Thanks!
Re: Contribution
Andrey,
> > Andrey, then I suggest firstly check if old annotations are present,
and if
> > not - are there any new annotations. Do you agree?
> I'm afraid I don't understand. Old annotations are present and new
> annotations don't exist yet :)
I talked about implementation of methods *getDescription* /
*getParameterName* in *IgniteStandardMXBean *class. To support backward
compatibility I need to check if there are old annotations above method, or
new one before parameters. So, my question was the order of searching
annotations (first - old, after - new).
вт, 4 февр. 2020 г. в 21:10, Andrey Gura :
> > Andrey, then I suggest firstly check if old annotations are present, and
> if
> > not - are there any new annotations. Do you agree?
>
> I'm afraid I don't understand. Old annotations are present and new
> annotations don't exist yet :)
>
> > And should I also replace usage of old annotations or leave it as it is?
>
> It would be great to replace old annotations by new ones.
>
> On Tue, Feb 4, 2020 at 6:09 PM Лев Киселев
> wrote:
> >
> > Andrey, then I suggest firstly check if old annotations are present, and
> if
> > not - are there any new annotations. Do you agree?
> > And should I also replace usage of old annotations or leave it as it is?
> >
> > вт, 4 февр. 2020 г. в 16:57, Andrey Gura :
> >
> > > Lev,
> > >
> > > > I'm confused about your first comment. Does it mean, that the only
> thing
> > > I
> > > can do is to create new annotation?
> > >
> > > Yes, it does. But in this case you can mark old annotations as
> > > deprecated because new annotations are real alternative.
> > >
> > > > So, I can't change implementation of *getDescription /
> getParameterName
> > > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods
> from*
> > > > IgniteStandardMXBean* class,
> > > > and replace current annotations with new one.
> > >
> > > You have to support both old and new annotations due to a backward
> > > compatibility.
> > >
> > > On Tue, Feb 4, 2020 at 3:14 PM Лев Киселев >
> > > wrote:
> > > >
> > > > Thanks for answer, Andrey.
> > > > I'm confused about your first comment. Does it mean, that the only
> thing
> > > I
> > > > can do is to create new annotation?
> > > > Because, as you said, I must leave unchanged all related to old
> > > annotations
> > > > functionality.
> > > > So, I can't change implementation of *getDescription /
> getParameterName
> > > > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods
> from*
> > > > IgniteStandardMXBean* class,
> > > > and replace current annotations with new one.
> > > >
> > > > вт, 4 февр. 2020 г. в 14:28, Andrey Gura :
> > > >
> > > > > Hi, Lev!
> > > > >
> > > > > I think you understand task correctly.
> > > > >
> > > > > A couple of comments:
> > > > >
> > > > > - Existing annotations and related functionality must not be
> deleted
> > > > > because it is part of public API and we committed to have stable
> API
> > > > > between major releases.
> > > > > - I would suggest introduce @MXBeanParameter annotation instead of
> > > > > @MXBeanParameterInformation. Just shorten name.
> > > > >
> > > > > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda
> wrote:
> > > > > >
> > > > > > Nikolay, Andrey,
> > > > > >
> > > > > > Would you be the best committers to help out here? You are
> already
> > > > > deeply involved in metrics development and can quickly suggest Lev
> how
> > > to
> > > > > proceed with this task.
> > > > > >
> > > > > > -
> > > > > > Denis
> > > > > >
> > > > > >
> > > > > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <
> > > lev.kiselev.1...@gmail.com>
> > > > > wrote:
> > > > > >>
> > > > > >> Hello everyone, I have question about following task:
> > > > > >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> > > > > >> Solution proposed in task description is seem to be logical.
> > > > > >> So, I need to every replace @MXBeanParametersNames and
> > > > > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> > > > > something
> > > > > >> like:
> > > > > >> void methodName(@MXBeanParameterInformation(name = "name",
> > > description =
> > > > > >> "description") firstParameter, ...) {}.
> > > > > >> And, of course, need to change processing logic at
> > > > > >> getParameterName/getDescription methods from
> IgniteStandardMXBean.
> > > > > >> Do I understand correctly what needs to be done?
> > > > >
> > >
>
Re: Contribution
Andrey, then I suggest firstly check if old annotations are present, and if
not - are there any new annotations. Do you agree?
And should I also replace usage of old annotations or leave it as it is?
вт, 4 февр. 2020 г. в 16:57, Andrey Gura :
> Lev,
>
> > I'm confused about your first comment. Does it mean, that the only thing
> I
> can do is to create new annotation?
>
> Yes, it does. But in this case you can mark old annotations as
> deprecated because new annotations are real alternative.
>
> > So, I can't change implementation of *getDescription / getParameterName
> > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > IgniteStandardMXBean* class,
> > and replace current annotations with new one.
>
> You have to support both old and new annotations due to a backward
> compatibility.
>
> On Tue, Feb 4, 2020 at 3:14 PM Лев Киселев
> wrote:
> >
> > Thanks for answer, Andrey.
> > I'm confused about your first comment. Does it mean, that the only thing
> I
> > can do is to create new annotation?
> > Because, as you said, I must leave unchanged all related to old
> annotations
> > functionality.
> > So, I can't change implementation of *getDescription / getParameterName
> > (MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
> > IgniteStandardMXBean* class,
> > and replace current annotations with new one.
> >
> > вт, 4 февр. 2020 г. в 14:28, Andrey Gura :
> >
> > > Hi, Lev!
> > >
> > > I think you understand task correctly.
> > >
> > > A couple of comments:
> > >
> > > - Existing annotations and related functionality must not be deleted
> > > because it is part of public API and we committed to have stable API
> > > between major releases.
> > > - I would suggest introduce @MXBeanParameter annotation instead of
> > > @MXBeanParameterInformation. Just shorten name.
> > >
> > > On Thu, Jan 30, 2020 at 8:53 PM Denis Magda wrote:
> > > >
> > > > Nikolay, Andrey,
> > > >
> > > > Would you be the best committers to help out here? You are already
> > > deeply involved in metrics development and can quickly suggest Lev how
> to
> > > proceed with this task.
> > > >
> > > > -
> > > > Denis
> > > >
> > > >
> > > > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев <
> lev.kiselev.1...@gmail.com>
> > > wrote:
> > > >>
> > > >> Hello everyone, I have question about following task:
> > > >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> > > >> Solution proposed in task description is seem to be logical.
> > > >> So, I need to every replace @MXBeanParametersNames and
> > > >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> > > something
> > > >> like:
> > > >> void methodName(@MXBeanParameterInformation(name = "name",
> description =
> > > >> "description") firstParameter, ...) {}.
> > > >> And, of course, need to change processing logic at
> > > >> getParameterName/getDescription methods from IgniteStandardMXBean.
> > > >> Do I understand correctly what needs to be done?
> > >
>
Re: Contribution
Thanks for answer, Andrey.
I'm confused about your first comment. Does it mean, that the only thing I
can do is to create new annotation?
Because, as you said, I must leave unchanged all related to old annotations
functionality.
So, I can't change implementation of *getDescription / getParameterName
(MBeanOperationInfo op, MBeanParameterInfo param, int seq)* methods from*
IgniteStandardMXBean* class,
and replace current annotations with new one.
вт, 4 февр. 2020 г. в 14:28, Andrey Gura :
> Hi, Lev!
>
> I think you understand task correctly.
>
> A couple of comments:
>
> - Existing annotations and related functionality must not be deleted
> because it is part of public API and we committed to have stable API
> between major releases.
> - I would suggest introduce @MXBeanParameter annotation instead of
> @MXBeanParameterInformation. Just shorten name.
>
> On Thu, Jan 30, 2020 at 8:53 PM Denis Magda wrote:
> >
> > Nikolay, Andrey,
> >
> > Would you be the best committers to help out here? You are already
> deeply involved in metrics development and can quickly suggest Lev how to
> proceed with this task.
> >
> > -
> > Denis
> >
> >
> > On Thu, Jan 30, 2020 at 2:46 AM Лев Киселев
> wrote:
> >>
> >> Hello everyone, I have question about following task:
> >> [https://issues.apache.org/jira/browse/IGNITE-10698]
> >> Solution proposed in task description is seem to be logical.
> >> So, I need to every replace @MXBeanParametersNames and
> >> @MXBeanParametersDescriptions (everywhere, for uniformity) with
> something
> >> like:
> >> void methodName(@MXBeanParameterInformation(name = "name", description =
> >> "description") firstParameter, ...) {}.
> >> And, of course, need to change processing logic at
> >> getParameterName/getDescription methods from IgniteStandardMXBean.
> >> Do I understand correctly what needs to be done?
>
Contribution
Hello everyone, I have question about following task:
[https://issues.apache.org/jira/browse/IGNITE-10698]
Solution proposed in task description is seem to be logical.
So, I need to every replace @MXBeanParametersNames and
@MXBeanParametersDescriptions (everywhere, for uniformity) with something
like:
void methodName(@MXBeanParameterInformation(name = "name", description =
"description") firstParameter, ...) {}.
And, of course, need to change processing logic at
getParameterName/getDescription methods from IgniteStandardMXBean.
Do I understand correctly what needs to be done?
Apache Ignite contribution
Hello, I want to take part in the development of Apache Ignite. Primary skills: Java SE, Java 8, Spring framework, SQL. Also: Multithreading (incl. FJP), Design Patterns, Algorithms and Data Structures. My JIRA ID: l4ndsc4pe Thanks.
