Re: [DISCUSSION] Shmem removal.
Patch has been reviewed by Andrey Mashenkov and Max Muzafarov and approved. If nobody disagrees, I will merge it in a few hours. пн, 7 февр. 2022 г. в 12:21, Ivan Daschinsky : > Patch is ready for review > > пт, 4 февр. 2022 г. в 14:45, Ivan Daschinsky : > >> https://issues.apache.org/jira/browse/IGNITE-16480 -- I've filed ticked. >> >> пт, 7 янв. 2022 г. в 23:44, Valentin Kulichenko < >> valentin.kuliche...@gmail.com>: >> >>> Doesn't look like there are any objections - it's been a month since you >>> started this thread. Let's create a ticket. >>> >>> -Val >>> >>> >>> On Thu, Jan 6, 2022 at 1:22 AM Ivan Daschinsky >>> wrote: >>> >>> > Hi, Val. My plan was to file a specific ticket after discussion. If the >>> > community agrees that this module should be removed, I will file a >>> specific >>> > ticket for it. >>> > >>> > ср, 5 янв. 2022 г., 22:26 Valentin Kulichenko < >>> > valentin.kuliche...@gmail.com >>> > >: >>> > >>> > > Hi Ivan, >>> > > >>> > > Do we have a ticket for this? >>> > > >>> > > -Val >>> > > >>> > > On Fri, Dec 3, 2021 at 10:58 AM Valentin Kulichenko < >>> > > valentin.kuliche...@gmail.com> wrote: >>> > > >>> > > > I think we can safely remove it. >>> > > > >>> > > > -Val >>> > > > >>> > > > On Thu, Dec 2, 2021 at 11:52 PM Ivan Daschinsky < >>> ivanda...@gmail.com> >>> > > > wrote: >>> > > > >>> > > >> Hi, igniters. >>> > > >> >>> > > >> Recently I've discovered one fact >>> > > >> 1. GridShmemCommunicationClient and all shmem functionality are >>> broken >>> > > >> since 2.10. In master it is broken since August 2020. And nobody >>> have >>> > > >> noticed it, only one thread in user list. >>> > > >> 2. We have source code for native JNI library (that is shipped in >>> > > >> ignite-shmem.jar), but we never built it since 2015. >>> > > >> 3. This code is of questionable quality, contains outdated >>> internal >>> > gcc >>> > > >> api >>> > > >> (__sync builtins, now deprecated in favour of __atomic builtins >>> in gcc >>> > > and >>> > > >> is not advisable to use since C++ 11). It contains a lot of >>> autotool >>> > > mess, >>> > > >> while just one CMakeFile.txt is enough to build the same >>> > > >> 4. This code doesn't even compile on modern gcc (gcc 9.3.0 namely) >>> > > >> >>> > > >> We have 2 options >>> > > >> 1. If this concept is useful, we (for example I can do it) should >>> > > rewrite >>> > > >> native part, >>> > > >> a. Use C++ 11 and header-only boost.interprocess [1] >>> > > >> b. Build it regularly with CMake and incorporate build in regular >>> TC >>> > > runs >>> > > >> (via maven-cmake-plugin, >>> > > >> see for example my numa-allocator [2]). >>> > > >> 2. If this concept and functionality is not useful, we should >>> remove >>> > it, >>> > > >> may be even in 2.12 >>> > > >> >>> > > >> >>> > > >> [1] -- >>> > https://www.boost.org/doc/libs/1_77_0/doc/html/interprocess.html >>> > > >> [2] -- >>> > > >> >>> > > >> >>> > > >>> > >>> https://github.com/apache/ignite/pull/9569/files#diff-77baf2378aa83911a8c3091814db3ff60b7bf328c4ab4850f707717ed96f3d92 >>> > > >> -- >>> > > >> Sincerely yours, Ivan Daschinskiy >>> > > >> >>> > > > >>> > > >>> > >>> >> >> >> -- >> Sincerely yours, Ivan Daschinskiy >> > > > -- > Sincerely yours, Ivan Daschinskiy > -- Sincerely yours, Ivan Daschinskiy
Re: [DISCUSSION] Shmem removal.
Patch is ready for review пт, 4 февр. 2022 г. в 14:45, Ivan Daschinsky : > https://issues.apache.org/jira/browse/IGNITE-16480 -- I've filed ticked. > > пт, 7 янв. 2022 г. в 23:44, Valentin Kulichenko < > valentin.kuliche...@gmail.com>: > >> Doesn't look like there are any objections - it's been a month since you >> started this thread. Let's create a ticket. >> >> -Val >> >> >> On Thu, Jan 6, 2022 at 1:22 AM Ivan Daschinsky >> wrote: >> >> > Hi, Val. My plan was to file a specific ticket after discussion. If the >> > community agrees that this module should be removed, I will file a >> specific >> > ticket for it. >> > >> > ср, 5 янв. 2022 г., 22:26 Valentin Kulichenko < >> > valentin.kuliche...@gmail.com >> > >: >> > >> > > Hi Ivan, >> > > >> > > Do we have a ticket for this? >> > > >> > > -Val >> > > >> > > On Fri, Dec 3, 2021 at 10:58 AM Valentin Kulichenko < >> > > valentin.kuliche...@gmail.com> wrote: >> > > >> > > > I think we can safely remove it. >> > > > >> > > > -Val >> > > > >> > > > On Thu, Dec 2, 2021 at 11:52 PM Ivan Daschinsky < >> ivanda...@gmail.com> >> > > > wrote: >> > > > >> > > >> Hi, igniters. >> > > >> >> > > >> Recently I've discovered one fact >> > > >> 1. GridShmemCommunicationClient and all shmem functionality are >> broken >> > > >> since 2.10. In master it is broken since August 2020. And nobody >> have >> > > >> noticed it, only one thread in user list. >> > > >> 2. We have source code for native JNI library (that is shipped in >> > > >> ignite-shmem.jar), but we never built it since 2015. >> > > >> 3. This code is of questionable quality, contains outdated internal >> > gcc >> > > >> api >> > > >> (__sync builtins, now deprecated in favour of __atomic builtins in >> gcc >> > > and >> > > >> is not advisable to use since C++ 11). It contains a lot of >> autotool >> > > mess, >> > > >> while just one CMakeFile.txt is enough to build the same >> > > >> 4. This code doesn't even compile on modern gcc (gcc 9.3.0 namely) >> > > >> >> > > >> We have 2 options >> > > >> 1. If this concept is useful, we (for example I can do it) should >> > > rewrite >> > > >> native part, >> > > >> a. Use C++ 11 and header-only boost.interprocess [1] >> > > >> b. Build it regularly with CMake and incorporate build in regular >> TC >> > > runs >> > > >> (via maven-cmake-plugin, >> > > >> see for example my numa-allocator [2]). >> > > >> 2. If this concept and functionality is not useful, we should >> remove >> > it, >> > > >> may be even in 2.12 >> > > >> >> > > >> >> > > >> [1] -- >> > https://www.boost.org/doc/libs/1_77_0/doc/html/interprocess.html >> > > >> [2] -- >> > > >> >> > > >> >> > > >> > >> https://github.com/apache/ignite/pull/9569/files#diff-77baf2378aa83911a8c3091814db3ff60b7bf328c4ab4850f707717ed96f3d92 >> > > >> -- >> > > >> Sincerely yours, Ivan Daschinskiy >> > > >> >> > > > >> > > >> > >> > > > -- > Sincerely yours, Ivan Daschinskiy > -- Sincerely yours, Ivan Daschinskiy
Re: [DISCUSSION] Shmem removal.
https://issues.apache.org/jira/browse/IGNITE-16480 -- I've filed ticked. пт, 7 янв. 2022 г. в 23:44, Valentin Kulichenko < valentin.kuliche...@gmail.com>: > Doesn't look like there are any objections - it's been a month since you > started this thread. Let's create a ticket. > > -Val > > > On Thu, Jan 6, 2022 at 1:22 AM Ivan Daschinsky > wrote: > > > Hi, Val. My plan was to file a specific ticket after discussion. If the > > community agrees that this module should be removed, I will file a > specific > > ticket for it. > > > > ср, 5 янв. 2022 г., 22:26 Valentin Kulichenko < > > valentin.kuliche...@gmail.com > > >: > > > > > Hi Ivan, > > > > > > Do we have a ticket for this? > > > > > > -Val > > > > > > On Fri, Dec 3, 2021 at 10:58 AM Valentin Kulichenko < > > > valentin.kuliche...@gmail.com> wrote: > > > > > > > I think we can safely remove it. > > > > > > > > -Val > > > > > > > > On Thu, Dec 2, 2021 at 11:52 PM Ivan Daschinsky > > > > > wrote: > > > > > > > >> Hi, igniters. > > > >> > > > >> Recently I've discovered one fact > > > >> 1. GridShmemCommunicationClient and all shmem functionality are > broken > > > >> since 2.10. In master it is broken since August 2020. And nobody > have > > > >> noticed it, only one thread in user list. > > > >> 2. We have source code for native JNI library (that is shipped in > > > >> ignite-shmem.jar), but we never built it since 2015. > > > >> 3. This code is of questionable quality, contains outdated internal > > gcc > > > >> api > > > >> (__sync builtins, now deprecated in favour of __atomic builtins in > gcc > > > and > > > >> is not advisable to use since C++ 11). It contains a lot of autotool > > > mess, > > > >> while just one CMakeFile.txt is enough to build the same > > > >> 4. This code doesn't even compile on modern gcc (gcc 9.3.0 namely) > > > >> > > > >> We have 2 options > > > >> 1. If this concept is useful, we (for example I can do it) should > > > rewrite > > > >> native part, > > > >> a. Use C++ 11 and header-only boost.interprocess [1] > > > >> b. Build it regularly with CMake and incorporate build in regular TC > > > runs > > > >> (via maven-cmake-plugin, > > > >> see for example my numa-allocator [2]). > > > >> 2. If this concept and functionality is not useful, we should remove > > it, > > > >> may be even in 2.12 > > > >> > > > >> > > > >> [1] -- > > https://www.boost.org/doc/libs/1_77_0/doc/html/interprocess.html > > > >> [2] -- > > > >> > > > >> > > > > > > https://github.com/apache/ignite/pull/9569/files#diff-77baf2378aa83911a8c3091814db3ff60b7bf328c4ab4850f707717ed96f3d92 > > > >> -- > > > >> Sincerely yours, Ivan Daschinskiy > > > >> > > > > > > > > > > -- Sincerely yours, Ivan Daschinskiy
Re: [DISCUSSION] Shmem removal.
Doesn't look like there are any objections - it's been a month since you started this thread. Let's create a ticket. -Val On Thu, Jan 6, 2022 at 1:22 AM Ivan Daschinsky wrote: > Hi, Val. My plan was to file a specific ticket after discussion. If the > community agrees that this module should be removed, I will file a specific > ticket for it. > > ср, 5 янв. 2022 г., 22:26 Valentin Kulichenko < > valentin.kuliche...@gmail.com > >: > > > Hi Ivan, > > > > Do we have a ticket for this? > > > > -Val > > > > On Fri, Dec 3, 2021 at 10:58 AM Valentin Kulichenko < > > valentin.kuliche...@gmail.com> wrote: > > > > > I think we can safely remove it. > > > > > > -Val > > > > > > On Thu, Dec 2, 2021 at 11:52 PM Ivan Daschinsky > > > wrote: > > > > > >> Hi, igniters. > > >> > > >> Recently I've discovered one fact > > >> 1. GridShmemCommunicationClient and all shmem functionality are broken > > >> since 2.10. In master it is broken since August 2020. And nobody have > > >> noticed it, only one thread in user list. > > >> 2. We have source code for native JNI library (that is shipped in > > >> ignite-shmem.jar), but we never built it since 2015. > > >> 3. This code is of questionable quality, contains outdated internal > gcc > > >> api > > >> (__sync builtins, now deprecated in favour of __atomic builtins in gcc > > and > > >> is not advisable to use since C++ 11). It contains a lot of autotool > > mess, > > >> while just one CMakeFile.txt is enough to build the same > > >> 4. This code doesn't even compile on modern gcc (gcc 9.3.0 namely) > > >> > > >> We have 2 options > > >> 1. If this concept is useful, we (for example I can do it) should > > rewrite > > >> native part, > > >> a. Use C++ 11 and header-only boost.interprocess [1] > > >> b. Build it regularly with CMake and incorporate build in regular TC > > runs > > >> (via maven-cmake-plugin, > > >> see for example my numa-allocator [2]). > > >> 2. If this concept and functionality is not useful, we should remove > it, > > >> may be even in 2.12 > > >> > > >> > > >> [1] -- > https://www.boost.org/doc/libs/1_77_0/doc/html/interprocess.html > > >> [2] -- > > >> > > >> > > > https://github.com/apache/ignite/pull/9569/files#diff-77baf2378aa83911a8c3091814db3ff60b7bf328c4ab4850f707717ed96f3d92 > > >> -- > > >> Sincerely yours, Ivan Daschinskiy > > >> > > > > > >
Re: [DISCUSSION] Shmem removal.
Hi, Val. My plan was to file a specific ticket after discussion. If the community agrees that this module should be removed, I will file a specific ticket for it. ср, 5 янв. 2022 г., 22:26 Valentin Kulichenko : > Hi Ivan, > > Do we have a ticket for this? > > -Val > > On Fri, Dec 3, 2021 at 10:58 AM Valentin Kulichenko < > valentin.kuliche...@gmail.com> wrote: > > > I think we can safely remove it. > > > > -Val > > > > On Thu, Dec 2, 2021 at 11:52 PM Ivan Daschinsky > > wrote: > > > >> Hi, igniters. > >> > >> Recently I've discovered one fact > >> 1. GridShmemCommunicationClient and all shmem functionality are broken > >> since 2.10. In master it is broken since August 2020. And nobody have > >> noticed it, only one thread in user list. > >> 2. We have source code for native JNI library (that is shipped in > >> ignite-shmem.jar), but we never built it since 2015. > >> 3. This code is of questionable quality, contains outdated internal gcc > >> api > >> (__sync builtins, now deprecated in favour of __atomic builtins in gcc > and > >> is not advisable to use since C++ 11). It contains a lot of autotool > mess, > >> while just one CMakeFile.txt is enough to build the same > >> 4. This code doesn't even compile on modern gcc (gcc 9.3.0 namely) > >> > >> We have 2 options > >> 1. If this concept is useful, we (for example I can do it) should > rewrite > >> native part, > >> a. Use C++ 11 and header-only boost.interprocess [1] > >> b. Build it regularly with CMake and incorporate build in regular TC > runs > >> (via maven-cmake-plugin, > >> see for example my numa-allocator [2]). > >> 2. If this concept and functionality is not useful, we should remove it, > >> may be even in 2.12 > >> > >> > >> [1] -- https://www.boost.org/doc/libs/1_77_0/doc/html/interprocess.html > >> [2] -- > >> > >> > https://github.com/apache/ignite/pull/9569/files#diff-77baf2378aa83911a8c3091814db3ff60b7bf328c4ab4850f707717ed96f3d92 > >> -- > >> Sincerely yours, Ivan Daschinskiy > >> > > >
Re: [DISCUSSION] Shmem removal.
Hi Ivan, Do we have a ticket for this? -Val On Fri, Dec 3, 2021 at 10:58 AM Valentin Kulichenko < valentin.kuliche...@gmail.com> wrote: > I think we can safely remove it. > > -Val > > On Thu, Dec 2, 2021 at 11:52 PM Ivan Daschinsky > wrote: > >> Hi, igniters. >> >> Recently I've discovered one fact >> 1. GridShmemCommunicationClient and all shmem functionality are broken >> since 2.10. In master it is broken since August 2020. And nobody have >> noticed it, only one thread in user list. >> 2. We have source code for native JNI library (that is shipped in >> ignite-shmem.jar), but we never built it since 2015. >> 3. This code is of questionable quality, contains outdated internal gcc >> api >> (__sync builtins, now deprecated in favour of __atomic builtins in gcc and >> is not advisable to use since C++ 11). It contains a lot of autotool mess, >> while just one CMakeFile.txt is enough to build the same >> 4. This code doesn't even compile on modern gcc (gcc 9.3.0 namely) >> >> We have 2 options >> 1. If this concept is useful, we (for example I can do it) should rewrite >> native part, >> a. Use C++ 11 and header-only boost.interprocess [1] >> b. Build it regularly with CMake and incorporate build in regular TC runs >> (via maven-cmake-plugin, >> see for example my numa-allocator [2]). >> 2. If this concept and functionality is not useful, we should remove it, >> may be even in 2.12 >> >> >> [1] -- https://www.boost.org/doc/libs/1_77_0/doc/html/interprocess.html >> [2] -- >> >> https://github.com/apache/ignite/pull/9569/files#diff-77baf2378aa83911a8c3091814db3ff60b7bf328c4ab4850f707717ed96f3d92 >> -- >> Sincerely yours, Ivan Daschinskiy >> >
Re: [DISCUSSION] Shmem removal.
I think we can safely remove it. -Val On Thu, Dec 2, 2021 at 11:52 PM Ivan Daschinsky wrote: > Hi, igniters. > > Recently I've discovered one fact > 1. GridShmemCommunicationClient and all shmem functionality are broken > since 2.10. In master it is broken since August 2020. And nobody have > noticed it, only one thread in user list. > 2. We have source code for native JNI library (that is shipped in > ignite-shmem.jar), but we never built it since 2015. > 3. This code is of questionable quality, contains outdated internal gcc api > (__sync builtins, now deprecated in favour of __atomic builtins in gcc and > is not advisable to use since C++ 11). It contains a lot of autotool mess, > while just one CMakeFile.txt is enough to build the same > 4. This code doesn't even compile on modern gcc (gcc 9.3.0 namely) > > We have 2 options > 1. If this concept is useful, we (for example I can do it) should rewrite > native part, > a. Use C++ 11 and header-only boost.interprocess [1] > b. Build it regularly with CMake and incorporate build in regular TC runs > (via maven-cmake-plugin, > see for example my numa-allocator [2]). > 2. If this concept and functionality is not useful, we should remove it, > may be even in 2.12 > > > [1] -- https://www.boost.org/doc/libs/1_77_0/doc/html/interprocess.html > [2] -- > > https://github.com/apache/ignite/pull/9569/files#diff-77baf2378aa83911a8c3091814db3ff60b7bf328c4ab4850f707717ed96f3d92 > -- > Sincerely yours, Ivan Daschinskiy >
[DISCUSSION] Shmem removal.
Hi, igniters. Recently I've discovered one fact 1. GridShmemCommunicationClient and all shmem functionality are broken since 2.10. In master it is broken since August 2020. And nobody have noticed it, only one thread in user list. 2. We have source code for native JNI library (that is shipped in ignite-shmem.jar), but we never built it since 2015. 3. This code is of questionable quality, contains outdated internal gcc api (__sync builtins, now deprecated in favour of __atomic builtins in gcc and is not advisable to use since C++ 11). It contains a lot of autotool mess, while just one CMakeFile.txt is enough to build the same 4. This code doesn't even compile on modern gcc (gcc 9.3.0 namely) We have 2 options 1. If this concept is useful, we (for example I can do it) should rewrite native part, a. Use C++ 11 and header-only boost.interprocess [1] b. Build it regularly with CMake and incorporate build in regular TC runs (via maven-cmake-plugin, see for example my numa-allocator [2]). 2. If this concept and functionality is not useful, we should remove it, may be even in 2.12 [1] -- https://www.boost.org/doc/libs/1_77_0/doc/html/interprocess.html [2] -- https://github.com/apache/ignite/pull/9569/files#diff-77baf2378aa83911a8c3091814db3ff60b7bf328c4ab4850f707717ed96f3d92 -- Sincerely yours, Ivan Daschinskiy
