Re: [IGNITE-9836] Invalid check of ea java versions

[Ilya Kasnacheev]

Hello!

Thank you, I have merged both.

Regards,
-- 
Ilya Kasnacheev


пт, 27 сент. 2019 г. в 14:36, Stephen Darlington <
stephen.darling...@gridgain.com>:

> Done: https://github.com/apache/ignite/pull/6920
>
> While we’re talking about the startup scripts…
> https://issues.apache.org/jira/browse/IGNITE-11856
>
> Regards,
> Stephen
>
> > On 26 Sep 2019, at 17:02, Ilya Kasnacheev 
> wrote:
> >
> > Hello!
> >
> > Please do!
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > вт, 17 сент. 2019 г. в 11:13, Stephen Darlington <
> > stephen.darling...@gridgain.com>:
> >
> >> I can’t take any credit for the patch but if the original author has
> lost
> >> interest I’m happy to help push it through.
> >>
> >> Regards,
> >> Stephen
> >>
> >>> On 16 Sep 2019, at 19:31, Denis Magda  wrote:
> >>>
> >>> Stephen,
> >>>
> >>> Thanks for sending the patch! Seems that Igniters are already actively
> >>> reviewing it in JIRA.
> >>>
> >>> -
> >>> Denis
> >>>
> >>>
> >>> On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
> >>> stephen.darling...@gridgain.com> wrote:
> >>>
>  Hi,
> 
>  Would someone mind taking a quick look at this ticket? Basically, a
> >> clean
>  download of Ignite won’t start if the version of Java you’re using
> has a
>  number like “java version "1.8.0_202-ea””. (This is the default if you
> >> get
>  your JDK using Homebrew on a Mac.)
> 
> > https://issues.apache.org/jira/browse/IGNITE-9836 <
>  https://issues.apache.org/jira/browse/IGNITE-9836>
> 
>  This has been bugging me for ages and now that I look at it I find
> that
>  there’s already a tiny, working patch available.
> 
>  Regards,
>  Stephen
> >>
> >>
> >>
>
>
>

Re: [IGNITE-9836] Invalid check of ea java versions

[Stephen Darlington]

Done: https://github.com/apache/ignite/pull/6920

While we’re talking about the startup scripts… 
https://issues.apache.org/jira/browse/IGNITE-11856

Regards,
Stephen

> On 26 Sep 2019, at 17:02, Ilya Kasnacheev  wrote:
> 
> Hello!
> 
> Please do!
> 
> Regards,
> -- 
> Ilya Kasnacheev
> 
> 
> вт, 17 сент. 2019 г. в 11:13, Stephen Darlington <
> stephen.darling...@gridgain.com>:
> 
>> I can’t take any credit for the patch but if the original author has lost
>> interest I’m happy to help push it through.
>> 
>> Regards,
>> Stephen
>> 
>>> On 16 Sep 2019, at 19:31, Denis Magda  wrote:
>>> 
>>> Stephen,
>>> 
>>> Thanks for sending the patch! Seems that Igniters are already actively
>>> reviewing it in JIRA.
>>> 
>>> -
>>> Denis
>>> 
>>> 
>>> On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
>>> stephen.darling...@gridgain.com> wrote:
>>> 
 Hi,
 
 Would someone mind taking a quick look at this ticket? Basically, a
>> clean
 download of Ignite won’t start if the version of Java you’re using has a
 number like “java version "1.8.0_202-ea””. (This is the default if you
>> get
 your JDK using Homebrew on a Mac.)
 
> https://issues.apache.org/jira/browse/IGNITE-9836 <
 https://issues.apache.org/jira/browse/IGNITE-9836>
 
 This has been bugging me for ages and now that I look at it I find that
 there’s already a tiny, working patch available.
 
 Regards,
 Stephen
>> 
>> 
>> 

Re: [IGNITE-9836] Invalid check of ea java versions

[Ilya Kasnacheev]

Hello!

Please do!

Regards,
-- 
Ilya Kasnacheev


вт, 17 сент. 2019 г. в 11:13, Stephen Darlington <
stephen.darling...@gridgain.com>:

> I can’t take any credit for the patch but if the original author has lost
> interest I’m happy to help push it through.
>
> Regards,
> Stephen
>
> > On 16 Sep 2019, at 19:31, Denis Magda  wrote:
> >
> > Stephen,
> >
> > Thanks for sending the patch! Seems that Igniters are already actively
> > reviewing it in JIRA.
> >
> > -
> > Denis
> >
> >
> > On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
> > stephen.darling...@gridgain.com> wrote:
> >
> >> Hi,
> >>
> >> Would someone mind taking a quick look at this ticket? Basically, a
> clean
> >> download of Ignite won’t start if the version of Java you’re using has a
> >> number like “java version "1.8.0_202-ea””. (This is the default if you
> get
> >> your JDK using Homebrew on a Mac.)
> >>
> >>> https://issues.apache.org/jira/browse/IGNITE-9836 <
> >> https://issues.apache.org/jira/browse/IGNITE-9836>
> >>
> >> This has been bugging me for ages and now that I look at it I find that
> >> there’s already a tiny, working patch available.
> >>
> >> Regards,
> >> Stephen
>
>
>

Re: [IGNITE-9836] Invalid check of ea java versions

[Stephen Darlington]

I can’t take any credit for the patch but if the original author has lost 
interest I’m happy to help push it through.

Regards,
Stephen

> On 16 Sep 2019, at 19:31, Denis Magda  wrote:
> 
> Stephen,
> 
> Thanks for sending the patch! Seems that Igniters are already actively
> reviewing it in JIRA.
> 
> -
> Denis
> 
> 
> On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
> stephen.darling...@gridgain.com> wrote:
> 
>> Hi,
>> 
>> Would someone mind taking a quick look at this ticket? Basically, a clean
>> download of Ignite won’t start if the version of Java you’re using has a
>> number like “java version "1.8.0_202-ea””. (This is the default if you get
>> your JDK using Homebrew on a Mac.)
>> 
>>> https://issues.apache.org/jira/browse/IGNITE-9836 <
>> https://issues.apache.org/jira/browse/IGNITE-9836>
>> 
>> This has been bugging me for ages and now that I look at it I find that
>> there’s already a tiny, working patch available.
>> 
>> Regards,
>> Stephen

Re: [IGNITE-9836] Invalid check of ea java versions

[Denis Magda]

Stephen,

Thanks for sending the patch! Seems that Igniters are already actively
reviewing it in JIRA.

-
Denis


On Mon, Sep 16, 2019 at 7:03 AM Stephen Darlington <
stephen.darling...@gridgain.com> wrote:

> Hi,
>
> Would someone mind taking a quick look at this ticket? Basically, a clean
> download of Ignite won’t start if the version of Java you’re using has a
> number like “java version "1.8.0_202-ea””. (This is the default if you get
> your JDK using Homebrew on a Mac.)
>
> > https://issues.apache.org/jira/browse/IGNITE-9836 <
> https://issues.apache.org/jira/browse/IGNITE-9836>
>
> This has been bugging me for ages and now that I look at it I find that
> there’s already a tiny, working patch available.
>
> Regards,
> Stephen

[IGNITE-9836] Invalid check of ea java versions

[Stephen Darlington]

Hi,

Would someone mind taking a quick look at this ticket? Basically, a clean 
download of Ignite won’t start if the version of Java you’re using has a number 
like “java version "1.8.0_202-ea””. (This is the default if you get your JDK 
using Homebrew on a Mac.)

> https://issues.apache.org/jira/browse/IGNITE-9836 
> 

This has been bugging me for ages and now that I look at it I find that there’s 
already a tiny, working patch available.

Regards,
Stephen

[jira] [Created] (IGNITE-9836) Invalid check of ea java versions

[Vasiliy Sisko (JIRA)]

Vasiliy Sisko created IGNITE-9836:
-

 Summary: Invalid check of ea java versions
 Key: IGNITE-9836
 URL: https://issues.apache.org/jira/browse/IGNITE-9836
 Project: Ignite
  Issue Type: Bug
Reporter: Vasiliy Sisko
Assignee: Vasiliy Sisko


On check of '1.8.0_192-ea' java version in ignite.sh the next messages in 
console are printed:
{code:java}
./include/functions.sh: line 81: [: -lt: unary operator expected
./ignite.sh: line 61: 
/home/vsisko/Downloads/distr/bin/include/build-classpath.sh: No such file or 
directory
./ignite.sh: line 152: [: -eq: unary operator expected
./ignite.sh: line 157: [: -gt: unary operator expected
./ignite.sh: line 170: [: -eq: unary operator expected{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)