Re: IGNITE-4052 ready for review
Hi Nikolay!
The comments was added.
Vadim
2017-04-17 15:32 GMT+03:00 Nikolai Tikhonov :
> Vadim,
>
> Thank you for your contribution. I'll look at changes. Can you please post
> the list improvements to jira ticket?
>
> On Mon, Apr 17, 2017 at 3:23 PM, Вадим Опольский
> wrote:
>
>> Hi, Nikolay!
>>
>> I've made the following improvements ( https://github.com/apache/igni
>> te/pull/1783 ):
>>
>> 1) Moved framework builder related code to separate method, so it make
>> code cleaner and framework testable.
>>
>> 2) Call framework builder method from test to test role and user.
>>
>> 3) Added validating mesos role according with mesos role documentation
>> http://mesos.apache.org/documentation/latest/roles/
>>
>> 4) Still using setEnv method because in IgniteFramework we cannot
>> override static method and make mock static methods (except powermock, but
>> it would require 3 extra dependencies in the module).
>>
>> P.S. setEnv method designed to worked both on Linux and Windows, and it
>> does not left variable in system environment after testing.
>>
>> Vadim Opolski
>>
>>
>> 2017-04-14 12:07 GMT+03:00 Nikolay Tikhonov (JIRA) :
>>
>>>
>>> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.a
>>> tlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&
>>> focusedCommentId=15968814#comment-15968814 ]
>>>
>>> Nikolay Tikhonov commented on IGNITE-4052:
>>> --
>>>
>>> [~javaller]
>>> It meens that lets remove #setEnv mathod and will create mock in test
>>> which will override {{getUser}} and {{getRole}} methods. Also how do you
>>> think might be need to add validation for role? Which valid set of values
>>> for this property?
>>>
>>> > Add ability to set up users for MESOS
>>> > -
>>> >
>>> > Key: IGNITE-4052
>>> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
>>> > Project: Ignite
>>> > Issue Type: Improvement
>>> > Components: general
>>> >Affects Versions: 1.7
>>> >Reporter: Nikolay Tikhonov
>>> >Assignee: Vadim Opolski
>>> >Priority: Trivial
>>> >
>>> > In current implementation Ignite Mesos Framework connects to MESOS
>>> cluster via current user. Need to add ability to configure this parameters
>>> via system env properties. Also need to add properties for mesos role.
>>> > See org/apache/ignite/mesos/IgniteFramework.java:537
>>>
>>>
>>>
>>> --
>>> This message was sent by Atlassian JIRA
>>> (v6.3.15#6346)
>>>
>>
>>
>
Re: IGNITE-4052 ready for review
Vadim,
Thank you for your contribution. I'll look at changes. Can you please post
the list improvements to jira ticket?
On Mon, Apr 17, 2017 at 3:23 PM, Вадим Опольский
wrote:
> Hi, Nikolay!
>
> I've made the following improvements ( https://github.com/apache/
> ignite/pull/1783 ):
>
> 1) Moved framework builder related code to separate method, so it make
> code cleaner and framework testable.
>
> 2) Call framework builder method from test to test role and user.
>
> 3) Added validating mesos role according with mesos role documentation
> http://mesos.apache.org/documentation/latest/roles/
>
> 4) Still using setEnv method because in IgniteFramework we cannot override
> static method and make mock static methods (except powermock, but it would
> require 3 extra dependencies in the module).
>
> P.S. setEnv method designed to worked both on Linux and Windows, and it
> does not left variable in system environment after testing.
>
> Vadim Opolski
>
>
> 2017-04-14 12:07 GMT+03:00 Nikolay Tikhonov (JIRA) :
>
>>
>> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=com.
>> atlassian.jira.plugin.system.issuetabpanels:comment-tabpane
>> l&focusedCommentId=15968814#comment-15968814 ]
>>
>> Nikolay Tikhonov commented on IGNITE-4052:
>> --
>>
>> [~javaller]
>> It meens that lets remove #setEnv mathod and will create mock in test
>> which will override {{getUser}} and {{getRole}} methods. Also how do you
>> think might be need to add validation for role? Which valid set of values
>> for this property?
>>
>> > Add ability to set up users for MESOS
>> > -
>> >
>> > Key: IGNITE-4052
>> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
>> > Project: Ignite
>> > Issue Type: Improvement
>> > Components: general
>> >Affects Versions: 1.7
>> >Reporter: Nikolay Tikhonov
>> >Assignee: Vadim Opolski
>> >Priority: Trivial
>> >
>> > In current implementation Ignite Mesos Framework connects to MESOS
>> cluster via current user. Need to add ability to configure this parameters
>> via system env properties. Also need to add properties for mesos role.
>> > See org/apache/ignite/mesos/IgniteFramework.java:537
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.15#6346)
>>
>
>
IGNITE-4052 ready for review
Hi, Nikolay!
I've made the following improvements (
https://github.com/apache/ignite/pull/1783 ):
1) Moved framework builder related code to separate method, so it make code
cleaner and framework testable.
2) Call framework builder method from test to test role and user.
3) Added validating mesos role according with mesos role documentation
http://mesos.apache.org/documentation/latest/roles/
4) Still using setEnv method because in IgniteFramework we cannot override
static method and make mock static methods (except powermock, but it would
require 3 extra dependencies in the module).
P.S. setEnv method designed to worked both on Linux and Windows, and it
does not left variable in system environment after testing.
Vadim Opolski
2017-04-14 12:07 GMT+03:00 Nikolay Tikhonov (JIRA) :
>
> [ https://issues.apache.org/jira/browse/IGNITE-4052?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=15968814#comment-15968814 ]
>
> Nikolay Tikhonov commented on IGNITE-4052:
> --
>
> [~javaller]
> It meens that lets remove #setEnv mathod and will create mock in test
> which will override {{getUser}} and {{getRole}} methods. Also how do you
> think might be need to add validation for role? Which valid set of values
> for this property?
>
> > Add ability to set up users for MESOS
> > -
> >
> > Key: IGNITE-4052
> > URL: https://issues.apache.org/jira/browse/IGNITE-4052
> > Project: Ignite
> > Issue Type: Improvement
> > Components: general
> >Affects Versions: 1.7
> >Reporter: Nikolay Tikhonov
> >Assignee: Vadim Opolski
> >Priority: Trivial
> >
> > In current implementation Ignite Mesos Framework connects to MESOS
> cluster via current user. Need to add ability to configure this parameters
> via system env properties. Also need to add properties for mesos role.
> > See org/apache/ignite/mesos/IgniteFramework.java:537
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
>
Re: IGNITE-4052 ready for review - what can I improve
Sure! On Fri, Mar 31, 2017 at 8:13 PM, Denis Magda wrote: > Nick, Vadim, > > Please don’t forget to update Mesos doc once this contribution gets merged: > https://apacheignite.readme.io/docs/mesos-deployment > > — > Denis > > On Mar 31, 2017, at 4:07 AM, Вадим Опольский wrote: > > Hello community! > > I want to add ability to connect to MESOS cluster via user name and role > from system env properties and to add JUnit test. > > Review please pull request, what can I improve ? How correctly to test > methods work? > > https://github.com/apache/ignite/pull/1662 > > Vadim Opolski > > > 2017-03-30 16:32 GMT+03:00 Вадим Опольский : > > Hello everyone! > > Nikolay, method Protos.FrameworkInfo.Builder#setRoleBytes and > Protos.FrameworkInfo.Builder#setUserBytes were added into > IgniteFrameworkInfoTest. > > Details please what do you want to me do with the methods. How > correctly to test methods work? > > The code was changed with official "Coding Guidelines" and the lib was > deleted. > > I didn't try to use new properties on real mesos cluster. > > https://github.com/apache/ignite/pull/1662 > > Vadim Opolski > > *You used only Protos.FrameworkInfo.Builder#setRole method, but also > exists Protos.FrameworkInfo.Builder#setRoleBytes. Please, pay attention on > it. You did some code styles changes which conflict with official "Coding > Guidelines" (see * > *https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute* > <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute>*). > Also you use lib for testing with licence different from Apache Licence > 2.0. Are you sure that for this test you need additional libs? I think this > can be implemented without them.* > > *Also did you try to use new properties on real mesos cluster? Did work > properly?* > > > 2017-03-24 15:54 GMT+03:00 Вадим Опольский : > > Nikolay, I will add properties for mesos role and unit test next week. > > -- Forwarded message -- > From: Вадим Опольский > Date: 2017-03-22 15:53 GMT+03:00 > Subject: Re: IGNITE-4052 ready for review > To: dev@ignite.apache.org > > > Nikolay, just changed status to "path available". > > 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov : > > Hi Вадим! > > Thank you for your contribution! > Please change status of the ticket to "path available". I'll review your > changes. > > Thanks, > Nikolay > > On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский > wrote: > > Hello everybody! > > Nikolay, > review please https://github.com/apache/ignite/pull/1662 . > > Added ability to configure current user parameters via system env > properties - "MESOS_USER". > > Vadim Opolski > > > -- Forwarded message -- > From: Вадим Опольский > Date: 2017-03-21 14:40 GMT+03:00 > Subject: Assignee IGNITE-4052 > To: dev@ignite.apache.org > > > Dear sirs ! > > I want to resolve issue IGNITE-4052. > > https://issues.apache.org/jira/browse/IGNITE-4052 > > Is it actual ? > > Vadim Opolski > > > > > > > > >
Re: IGNITE-4052 ready for review - what can I improve
Nick, Vadim, Please don’t forget to update Mesos doc once this contribution gets merged: https://apacheignite.readme.io/docs/mesos-deployment <https://apacheignite.readme.io/docs/mesos-deployment> — Denis > On Mar 31, 2017, at 4:07 AM, Вадим Опольский wrote: > > Hello community! > > I want to add ability to connect to MESOS cluster via user name and role > from system env properties and to add JUnit test. > > Review please pull request, what can I improve ? How correctly to test > methods work? > > https://github.com/apache/ignite/pull/1662 > > Vadim Opolski > > > 2017-03-30 16:32 GMT+03:00 Вадим Опольский : > >> Hello everyone! >> >> Nikolay, method Protos.FrameworkInfo.Builder#setRoleBytes and >> Protos.FrameworkInfo.Builder#setUserBytes were added into >> IgniteFrameworkInfoTest. >> >> Details please what do you want to me do with the methods. How >> correctly to test methods work? >> >> The code was changed with official "Coding Guidelines" and the lib was >> deleted. >> >> I didn't try to use new properties on real mesos cluster. >> >> https://github.com/apache/ignite/pull/1662 >> >> Vadim Opolski >> >> *You used only Protos.FrameworkInfo.Builder#setRole method, but also >> exists Protos.FrameworkInfo.Builder#setRoleBytes. Please, pay attention on >> it. You did some code styles changes which conflict with official "Coding >> Guidelines" (see * >> *https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute* >> <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute>*). >> Also you use lib for testing with licence different from Apache Licence >> 2.0. Are you sure that for this test you need additional libs? I think this >> can be implemented without them.* >> >> *Also did you try to use new properties on real mesos cluster? Did work >> properly?* >> >> 2017-03-24 15:54 GMT+03:00 Вадим Опольский : >> >>> Nikolay, I will add properties for mesos role and unit test next week. >>> >>> -- Forwarded message -- >>> From: Вадим Опольский >>> Date: 2017-03-22 15:53 GMT+03:00 >>> Subject: Re: IGNITE-4052 ready for review >>> To: dev@ignite.apache.org >>> >>> >>> Nikolay, just changed status to "path available". >>> >>> 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov : >>> >>>> Hi Вадим! >>>> >>>> Thank you for your contribution! >>>> Please change status of the ticket to "path available". I'll review your >>>> changes. >>>> >>>> Thanks, >>>> Nikolay >>>> >>>> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский >>>> wrote: >>>> >>>>> Hello everybody! >>>>> >>>>> Nikolay, >>>>> review please https://github.com/apache/ignite/pull/1662 . >>>>> >>>>> Added ability to configure current user parameters via system env >>>>> properties - "MESOS_USER". >>>>> >>>>> Vadim Opolski >>>>> >>>>> >>>>> -- Forwarded message -- >>>>> From: Вадим Опольский >>>>> Date: 2017-03-21 14:40 GMT+03:00 >>>>> Subject: Assignee IGNITE-4052 >>>>> To: dev@ignite.apache.org >>>>> >>>>> >>>>> Dear sirs ! >>>>> >>>>> I want to resolve issue IGNITE-4052. >>>>> >>>>> https://issues.apache.org/jira/browse/IGNITE-4052 >>>>> >>>>> Is it actual ? >>>>> >>>>> Vadim Opolski >>>>> >>>>> >>>> >>> >>> >>> >>
IGNITE-4052 ready for review - what can I improve
Hello community! I want to add ability to connect to MESOS cluster via user name and role from system env properties and to add JUnit test. Review please pull request, what can I improve ? How correctly to test methods work? https://github.com/apache/ignite/pull/1662 Vadim Opolski 2017-03-30 16:32 GMT+03:00 Вадим Опольский : > Hello everyone! > > Nikolay, method Protos.FrameworkInfo.Builder#setRoleBytes and > Protos.FrameworkInfo.Builder#setUserBytes were added into > IgniteFrameworkInfoTest. > > Details please what do you want to me do with the methods. How > correctly to test methods work? > > The code was changed with official "Coding Guidelines" and the lib was > deleted. > > I didn't try to use new properties on real mesos cluster. > > https://github.com/apache/ignite/pull/1662 > > Vadim Opolski > > *You used only Protos.FrameworkInfo.Builder#setRole method, but also > exists Protos.FrameworkInfo.Builder#setRoleBytes. Please, pay attention on > it. You did some code styles changes which conflict with official "Coding > Guidelines" (see * > *https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute* > <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute>*). > Also you use lib for testing with licence different from Apache Licence > 2.0. Are you sure that for this test you need additional libs? I think this > can be implemented without them.* > > *Also did you try to use new properties on real mesos cluster? Did work > properly?* > > 2017-03-24 15:54 GMT+03:00 Вадим Опольский : > >> Nikolay, I will add properties for mesos role and unit test next week. >> >> -- Forwarded message -- >> From: Вадим Опольский >> Date: 2017-03-22 15:53 GMT+03:00 >> Subject: Re: IGNITE-4052 ready for review >> To: dev@ignite.apache.org >> >> >> Nikolay, just changed status to "path available". >> >> 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov : >> >>> Hi Вадим! >>> >>> Thank you for your contribution! >>> Please change status of the ticket to "path available". I'll review your >>> changes. >>> >>> Thanks, >>> Nikolay >>> >>> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский >>> wrote: >>> >>> > Hello everybody! >>> > >>> > Nikolay, >>> > review please https://github.com/apache/ignite/pull/1662 . >>> > >>> > Added ability to configure current user parameters via system env >>> > properties - "MESOS_USER". >>> > >>> > Vadim Opolski >>> > >>> > >>> > -- Forwarded message -- >>> > From: Вадим Опольский >>> > Date: 2017-03-21 14:40 GMT+03:00 >>> > Subject: Assignee IGNITE-4052 >>> > To: dev@ignite.apache.org >>> > >>> > >>> > Dear sirs ! >>> > >>> > I want to resolve issue IGNITE-4052. >>> > >>> > https://issues.apache.org/jira/browse/IGNITE-4052 >>> > >>> > Is it actual ? >>> > >>> > Vadim Opolski >>> > >>> > >>> >> >> >> >
Re: IGNITE-4052 ready for review
Hello everyone! Nikolay, method Protos.FrameworkInfo.Builder#setRoleBytes and Protos.FrameworkInfo.Builder#setUserBytes were added into IgniteFrameworkInfoTest. Details please what do you want to me do with the methods. How correctly to test methods work? The code was changed with official "Coding Guidelines" and the lib was deleted. I didn't try to use new properties on real mesos cluster. https://github.com/apache/ignite/pull/1662 Vadim Opolski *You used only Protos.FrameworkInfo.Builder#setRole method, but also exists Protos.FrameworkInfo.Builder#setRoleBytes. Please, pay attention on it. You did some code styles changes which conflict with official "Coding Guidelines" (see * *https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute* <https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute>*). Also you use lib for testing with licence different from Apache Licence 2.0. Are you sure that for this test you need additional libs? I think this can be implemented without them.* *Also did you try to use new properties on real mesos cluster? Did work properly?* 2017-03-24 15:54 GMT+03:00 Вадим Опольский : > Nikolay, I will add properties for mesos role and unit test next week. > > -- Forwarded message -- > From: Вадим Опольский > Date: 2017-03-22 15:53 GMT+03:00 > Subject: Re: IGNITE-4052 ready for review > To: dev@ignite.apache.org > > > Nikolay, just changed status to "path available". > > 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov : > >> Hi Вадим! >> >> Thank you for your contribution! >> Please change status of the ticket to "path available". I'll review your >> changes. >> >> Thanks, >> Nikolay >> >> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский >> wrote: >> >> > Hello everybody! >> > >> > Nikolay, >> > review please https://github.com/apache/ignite/pull/1662 . >> > >> > Added ability to configure current user parameters via system env >> > properties - "MESOS_USER". >> > >> > Vadim Opolski >> > >> > >> > -- Forwarded message -- >> > From: Вадим Опольский >> > Date: 2017-03-21 14:40 GMT+03:00 >> > Subject: Assignee IGNITE-4052 >> > To: dev@ignite.apache.org >> > >> > >> > Dear sirs ! >> > >> > I want to resolve issue IGNITE-4052. >> > >> > https://issues.apache.org/jira/browse/IGNITE-4052 >> > >> > Is it actual ? >> > >> > Vadim Opolski >> > >> > >> > > >
Re: IGNITE-4052 ready for review
Thank you for your contribution! Please, don't forget to move ticket in "path available" state. On Wed, Mar 29, 2017 at 10:46 AM, Вадим Опольский wrote: > Hello everybody! > > Nikolay, the properties for mesos role and JUnit test were added. > > Review please the pull request - https://github.com/apache/igni > te/pull/1662 > > Vadim Opolski > > 2017-03-24 18:41 GMT+03:00 Nikolai Tikhonov : > >> Great! Looking forward to the contribution. >> >> On Fri, Mar 24, 2017 at 3:54 PM, Вадим Опольский >> wrote: >> >>> Nikolay, I will add properties for mesos role and unit test next week. >>> >>> -- Forwarded message ------ >>> From: Вадим Опольский >>> Date: 2017-03-22 15:53 GMT+03:00 >>> Subject: Re: IGNITE-4052 ready for review >>> To: dev@ignite.apache.org >>> >>> >>> Nikolay, just changed status to "path available". >>> >>> 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov : >>> >>>> Hi Вадим! >>>> >>>> Thank you for your contribution! >>>> Please change status of the ticket to "path available". I'll review your >>>> changes. >>>> >>>> Thanks, >>>> Nikolay >>>> >>>> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский >>>> wrote: >>>> >>>> > Hello everybody! >>>> > >>>> > Nikolay, >>>> > review please https://github.com/apache/ignite/pull/1662 . >>>> > >>>> > Added ability to configure current user parameters via system env >>>> > properties - "MESOS_USER". >>>> > >>>> > Vadim Opolski >>>> > >>>> > >>>> > -- Forwarded message -- >>>> > From: Вадим Опольский >>>> > Date: 2017-03-21 14:40 GMT+03:00 >>>> > Subject: Assignee IGNITE-4052 >>>> > To: dev@ignite.apache.org >>>> > >>>> > >>>> > Dear sirs ! >>>> > >>>> > I want to resolve issue IGNITE-4052. >>>> > >>>> > https://issues.apache.org/jira/browse/IGNITE-4052 >>>> > >>>> > Is it actual ? >>>> > >>>> > Vadim Opolski >>>> > >>>> > >>>> >>> >>> >>> >> >
IGNITE-4052 ready for review
Hello everybody! Nikolay, the properties for mesos role and JUnit test were added. Review please the pull request - https://github.com/apache/ignite/pull/1662 Vadim Opolski 2017-03-24 18:41 GMT+03:00 Nikolai Tikhonov : > Great! Looking forward to the contribution. > > On Fri, Mar 24, 2017 at 3:54 PM, Вадим Опольский > wrote: > >> Nikolay, I will add properties for mesos role and unit test next week. >> >> -- Forwarded message -- >> From: Вадим Опольский >> Date: 2017-03-22 15:53 GMT+03:00 >> Subject: Re: IGNITE-4052 ready for review >> To: dev@ignite.apache.org >> >> >> Nikolay, just changed status to "path available". >> >> 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov : >> >>> Hi Вадим! >>> >>> Thank you for your contribution! >>> Please change status of the ticket to "path available". I'll review your >>> changes. >>> >>> Thanks, >>> Nikolay >>> >>> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский >>> wrote: >>> >>> > Hello everybody! >>> > >>> > Nikolay, >>> > review please https://github.com/apache/ignite/pull/1662 . >>> > >>> > Added ability to configure current user parameters via system env >>> > properties - "MESOS_USER". >>> > >>> > Vadim Opolski >>> > >>> > >>> > -- Forwarded message -- >>> > From: Вадим Опольский >>> > Date: 2017-03-21 14:40 GMT+03:00 >>> > Subject: Assignee IGNITE-4052 >>> > To: dev@ignite.apache.org >>> > >>> > >>> > Dear sirs ! >>> > >>> > I want to resolve issue IGNITE-4052. >>> > >>> > https://issues.apache.org/jira/browse/IGNITE-4052 >>> > >>> > Is it actual ? >>> > >>> > Vadim Opolski >>> > >>> > >>> >> >> >> >
Re: IGNITE-4052 ready for review
Great! Looking forward to the contribution. On Fri, Mar 24, 2017 at 3:54 PM, Вадим Опольский wrote: > Nikolay, I will add properties for mesos role and unit test next week. > > -- Forwarded message -- > From: Вадим Опольский > Date: 2017-03-22 15:53 GMT+03:00 > Subject: Re: IGNITE-4052 ready for review > To: dev@ignite.apache.org > > > Nikolay, just changed status to "path available". > > 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov : > >> Hi Вадим! >> >> Thank you for your contribution! >> Please change status of the ticket to "path available". I'll review your >> changes. >> >> Thanks, >> Nikolay >> >> On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский >> wrote: >> >> > Hello everybody! >> > >> > Nikolay, >> > review please https://github.com/apache/ignite/pull/1662 . >> > >> > Added ability to configure current user parameters via system env >> > properties - "MESOS_USER". >> > >> > Vadim Opolski >> > >> > >> > -- Forwarded message -- >> > From: Вадим Опольский >> > Date: 2017-03-21 14:40 GMT+03:00 >> > Subject: Assignee IGNITE-4052 >> > To: dev@ignite.apache.org >> > >> > >> > Dear sirs ! >> > >> > I want to resolve issue IGNITE-4052. >> > >> > https://issues.apache.org/jira/browse/IGNITE-4052 >> > >> > Is it actual ? >> > >> > Vadim Opolski >> > >> > >> > > >
Fwd: IGNITE-4052 ready for review
Nikolay, I will add properties for mesos role and unit test next week. -- Forwarded message -- From: Вадим Опольский Date: 2017-03-22 15:53 GMT+03:00 Subject: Re: IGNITE-4052 ready for review To: dev@ignite.apache.org Nikolay, just changed status to "path available". 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov : > Hi Вадим! > > Thank you for your contribution! > Please change status of the ticket to "path available". I'll review your > changes. > > Thanks, > Nikolay > > On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский > wrote: > > > Hello everybody! > > > > Nikolay, > > review please https://github.com/apache/ignite/pull/1662 . > > > > Added ability to configure current user parameters via system env > > properties - "MESOS_USER". > > > > Vadim Opolski > > > > > > -- Forwarded message -- > > From: Вадим Опольский > > Date: 2017-03-21 14:40 GMT+03:00 > > Subject: Assignee IGNITE-4052 > > To: dev@ignite.apache.org > > > > > > Dear sirs ! > > > > I want to resolve issue IGNITE-4052. > > > > https://issues.apache.org/jira/browse/IGNITE-4052 > > > > Is it actual ? > > > > Vadim Opolski > > > > >
Re: IGNITE-4052 ready for review
Nikolay, just changed status to "path available". 2017-03-22 15:44 GMT+03:00 Nikolai Tikhonov : > Hi Вадим! > > Thank you for your contribution! > Please change status of the ticket to "path available". I'll review your > changes. > > Thanks, > Nikolay > > On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский > wrote: > > > Hello everybody! > > > > Nikolay, > > review please https://github.com/apache/ignite/pull/1662 . > > > > Added ability to configure current user parameters via system env > > properties - "MESOS_USER". > > > > Vadim Opolski > > > > > > -- Forwarded message -- > > From: Вадим Опольский > > Date: 2017-03-21 14:40 GMT+03:00 > > Subject: Assignee IGNITE-4052 > > To: dev@ignite.apache.org > > > > > > Dear sirs ! > > > > I want to resolve issue IGNITE-4052. > > > > https://issues.apache.org/jira/browse/IGNITE-4052 > > > > Is it actual ? > > > > Vadim Opolski > > > > >
Re: IGNITE-4052 ready for review
Hi Вадим! Thank you for your contribution! Please change status of the ticket to "path available". I'll review your changes. Thanks, Nikolay On Wed, Mar 22, 2017 at 3:36 PM, Вадим Опольский wrote: > Hello everybody! > > Nikolay, > review please https://github.com/apache/ignite/pull/1662 . > > Added ability to configure current user parameters via system env > properties - "MESOS_USER". > > Vadim Opolski > > > -- Forwarded message -- > From: Вадим Опольский > Date: 2017-03-21 14:40 GMT+03:00 > Subject: Assignee IGNITE-4052 > To: dev@ignite.apache.org > > > Dear sirs ! > > I want to resolve issue IGNITE-4052. > > https://issues.apache.org/jira/browse/IGNITE-4052 > > Is it actual ? > > Vadim Opolski > >
IGNITE-4052 ready for review
Hello everybody! Nikolay, review please https://github.com/apache/ignite/pull/1662 . Added ability to configure current user parameters via system env properties - "MESOS_USER". Vadim Opolski -- Forwarded message -- From: Вадим Опольский Date: 2017-03-21 14:40 GMT+03:00 Subject: Assignee IGNITE-4052 To: dev@ignite.apache.org Dear sirs ! I want to resolve issue IGNITE-4052. https://issues.apache.org/jira/browse/IGNITE-4052 Is it actual ? Vadim Opolski
