Re: Plugins in tests

[Maxim Muzafarov]

Igniters,

It seems that our pre-configured list of plugins a bit grow up.
The full list of them for now:

 TestReconnectPlugin 1.0
 StanByClusterTestProvider 1.0
 PageMemory tracker plugin 1.0
 TestDistibutedConfigurationPlugin 1.0
 NodeValidationPluginProvider 1.0

I think we should move them to separate modules, as mentioned Yakov in
the first message.
I've left a new comment in JIRA [1], so hopefully, we do not forget to do so.

[1] https://issues.apache.org/jira/browse/IGNITE-7679

On Fri, 7 Sep 2018 at 13:54, Maxim Muzafarov  wrote:
>
> Alex,
>
> Thank you.
>
> I've added an additional comment in IGNITE-7679 about PageMemory tracker 
> plugin, so we can move
> all plugins within a single ticket and do not miss anything.
>
> [1] https://issues.apache.org/jira/browse/IGNITE-7679
>
> On Fri, 7 Sep 2018 at 09:39 Alex Plehanov  wrote:
>>
>> Hello Maxim,
>>
>> I miss this conversation and ticket when implementing PageMemory tracker
>> plugin. By default, it's disabled (every method do nothing), but plugin
>> instance created anyway.
>>
>> If we want to get clear Ignite instances in the testing framework in the
>> core module, PageMemory tracker plugin also should be moved to another
>> module.
>>
>> чт, 6 сент. 2018 г. в 19:50, Maxim Muzafarov :
>>
>> > Folks,
>> >
>> > I've found another plugin - `PageMemory tracker plugin 1.0`. It contains
>> > `IGNITE_ENABLE_PAGE_MEMORY_TRACKER`
>> > which is `false` by default, so it doesn't participate in current tests.
>> >
>> > But I think we should also move it to `extdata` module too. Am I right?
>> > Should we update JIRA [1] description regarding newly available plugin?
>> >
>> > [1] https://issues.apache.org/jira/browse/IGNITE-7679
>> >
>> >
>> > On Mon, 12 Feb 2018 at 19:57 Dmitriy Govorukhin <
>> > dmitriy.govoruk...@gmail.com> wrote:
>> >
>> > >  Yakov,
>> > >
>> > > Agree, I created the issue for this. I will try to do it in the near
>> > > future.
>> > >
>> > > IGNITE-7679 
>> > >
>> > >
>> > > On Tue, Jan 30, 2018 at 8:40 AM, Yakov Zhdanov 
>> > > wrote:
>> > >
>> > > > Guys,
>> > > >
>> > > > When running tests from core module I see that Ignite has 2 plugins
>> > > > configured by default (because they are available in classpath):
>> > > >
>> > > > -TestReconnectPlugin 1.0
>> > > > -StanByClusterTestProvider 1.0
>> > > >
>> > > > It seems they were introduced by Dmitry Karachentsev and Dmitry
>> > > Govorukhin.
>> > > > Guys, can you please move the plugins to extdata project similar to
>> > > > PlatformTestPlugin and configure them only when needed. This is not
>> > > correct
>> > > > that each test we run for Ignite runs with plugins configured. By
>> > default
>> > > > Ignite does not have any plugin.
>> > > >
>> > > > --Yakov
>> > > >
>> > >
>> > --
>> > --
>> > Maxim Muzafarov
>> >
>
> --
> --
> Maxim Muzafarov

Re: Plugins in tests

[Maxim Muzafarov]

Alex,

Thank you.

I've added an additional comment in IGNITE-7679 about PageMemory tracker
plugin, so we can move
all plugins within a single ticket and do not miss anything.

[1] https://issues.apache.org/jira/browse/IGNITE-7679

On Fri, 7 Sep 2018 at 09:39 Alex Plehanov  wrote:

> Hello Maxim,
>
> I miss this conversation and ticket when implementing PageMemory tracker
> plugin. By default, it's disabled (every method do nothing), but plugin
> instance created anyway.
>
> If we want to get clear Ignite instances in the testing framework in the
> core module, PageMemory tracker plugin also should be moved to another
> module.
>
> чт, 6 сент. 2018 г. в 19:50, Maxim Muzafarov :
>
> > Folks,
> >
> > I've found another plugin - `PageMemory tracker plugin 1.0`. It contains
> > `IGNITE_ENABLE_PAGE_MEMORY_TRACKER`
> > which is `false` by default, so it doesn't participate in current tests.
> >
> > But I think we should also move it to `extdata` module too. Am I right?
> > Should we update JIRA [1] description regarding newly available plugin?
> >
> > [1] https://issues.apache.org/jira/browse/IGNITE-7679
> >
> >
> > On Mon, 12 Feb 2018 at 19:57 Dmitriy Govorukhin <
> > dmitriy.govoruk...@gmail.com> wrote:
> >
> > >  Yakov,
> > >
> > > Agree, I created the issue for this. I will try to do it in the near
> > > future.
> > >
> > > IGNITE-7679 
> > >
> > >
> > > On Tue, Jan 30, 2018 at 8:40 AM, Yakov Zhdanov 
> > > wrote:
> > >
> > > > Guys,
> > > >
> > > > When running tests from core module I see that Ignite has 2 plugins
> > > > configured by default (because they are available in classpath):
> > > >
> > > > -TestReconnectPlugin 1.0
> > > > -StanByClusterTestProvider 1.0
> > > >
> > > > It seems they were introduced by Dmitry Karachentsev and Dmitry
> > > Govorukhin.
> > > > Guys, can you please move the plugins to extdata project similar to
> > > > PlatformTestPlugin and configure them only when needed. This is not
> > > correct
> > > > that each test we run for Ignite runs with plugins configured. By
> > default
> > > > Ignite does not have any plugin.
> > > >
> > > > --Yakov
> > > >
> > >
> > --
> > --
> > Maxim Muzafarov
> >
>
-- 
--
Maxim Muzafarov

Re: Plugins in tests

[Alex Plehanov]

Hello Maxim,

I miss this conversation and ticket when implementing PageMemory tracker
plugin. By default, it's disabled (every method do nothing), but plugin
instance created anyway.

If we want to get clear Ignite instances in the testing framework in the
core module, PageMemory tracker plugin also should be moved to another
module.

чт, 6 сент. 2018 г. в 19:50, Maxim Muzafarov :

> Folks,
>
> I've found another plugin - `PageMemory tracker plugin 1.0`. It contains
> `IGNITE_ENABLE_PAGE_MEMORY_TRACKER`
> which is `false` by default, so it doesn't participate in current tests.
>
> But I think we should also move it to `extdata` module too. Am I right?
> Should we update JIRA [1] description regarding newly available plugin?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-7679
>
>
> On Mon, 12 Feb 2018 at 19:57 Dmitriy Govorukhin <
> dmitriy.govoruk...@gmail.com> wrote:
>
> >  Yakov,
> >
> > Agree, I created the issue for this. I will try to do it in the near
> > future.
> >
> > IGNITE-7679 
> >
> >
> > On Tue, Jan 30, 2018 at 8:40 AM, Yakov Zhdanov 
> > wrote:
> >
> > > Guys,
> > >
> > > When running tests from core module I see that Ignite has 2 plugins
> > > configured by default (because they are available in classpath):
> > >
> > > -TestReconnectPlugin 1.0
> > > -StanByClusterTestProvider 1.0
> > >
> > > It seems they were introduced by Dmitry Karachentsev and Dmitry
> > Govorukhin.
> > > Guys, can you please move the plugins to extdata project similar to
> > > PlatformTestPlugin and configure them only when needed. This is not
> > correct
> > > that each test we run for Ignite runs with plugins configured. By
> default
> > > Ignite does not have any plugin.
> > >
> > > --Yakov
> > >
> >
> --
> --
> Maxim Muzafarov
>

Re: Plugins in tests

[Maxim Muzafarov]

Folks,

I've found another plugin - `PageMemory tracker plugin 1.0`. It contains
`IGNITE_ENABLE_PAGE_MEMORY_TRACKER`
which is `false` by default, so it doesn't participate in current tests.

But I think we should also move it to `extdata` module too. Am I right?
Should we update JIRA [1] description regarding newly available plugin?

[1] https://issues.apache.org/jira/browse/IGNITE-7679


On Mon, 12 Feb 2018 at 19:57 Dmitriy Govorukhin <
dmitriy.govoruk...@gmail.com> wrote:

>  Yakov,
>
> Agree, I created the issue for this. I will try to do it in the near
> future.
>
> IGNITE-7679 
>
>
> On Tue, Jan 30, 2018 at 8:40 AM, Yakov Zhdanov 
> wrote:
>
> > Guys,
> >
> > When running tests from core module I see that Ignite has 2 plugins
> > configured by default (because they are available in classpath):
> >
> > -TestReconnectPlugin 1.0
> > -StanByClusterTestProvider 1.0
> >
> > It seems they were introduced by Dmitry Karachentsev and Dmitry
> Govorukhin.
> > Guys, can you please move the plugins to extdata project similar to
> > PlatformTestPlugin and configure them only when needed. This is not
> correct
> > that each test we run for Ignite runs with plugins configured. By default
> > Ignite does not have any plugin.
> >
> > --Yakov
> >
>
-- 
--
Maxim Muzafarov

Re: Plugins in tests

[Dmitriy Govorukhin]

 Yakov,

Agree, I created the issue for this. I will try to do it in the near future.

IGNITE-7679 


On Tue, Jan 30, 2018 at 8:40 AM, Yakov Zhdanov  wrote:

> Guys,
>
> When running tests from core module I see that Ignite has 2 plugins
> configured by default (because they are available in classpath):
>
> -TestReconnectPlugin 1.0
> -StanByClusterTestProvider 1.0
>
> It seems they were introduced by Dmitry Karachentsev and Dmitry Govorukhin.
> Guys, can you please move the plugins to extdata project similar to
> PlatformTestPlugin and configure them only when needed. This is not correct
> that each test we run for Ignite runs with plugins configured. By default
> Ignite does not have any plugin.
>
> --Yakov
>

Plugins in tests

[Yakov Zhdanov]

Guys,

When running tests from core module I see that Ignite has 2 plugins
configured by default (because they are available in classpath):

-TestReconnectPlugin 1.0
-StanByClusterTestProvider 1.0

It seems they were introduced by Dmitry Karachentsev and Dmitry Govorukhin.
Guys, can you please move the plugins to extdata project similar to
PlatformTestPlugin and configure them only when needed. This is not correct
that each test we run for Ignite runs with plugins configured. By default
Ignite does not have any plugin.

--Yakov

Re: Plugins in tests

[Pavel Tupitsyn]

I've replied in JIRA. Yakov, please have a look as well.

On Wed, Aug 23, 2017 at 6:44 PM, Vyacheslav Daradur 
wrote:

> Hi,
>
> >> ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879
> I've done it, could someone review it?
>
> 2017-07-31 11:13 GMT+03:00 Pavel Tupitsyn :
>
> > Got it, ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879
> >
> > On Fri, Jul 28, 2017 at 5:58 PM, Yakov Zhdanov 
> > wrote:
> >
> > > Pavel, I would create a new module just like "modules/extdata/p2p".
> > >
> > > --Yakov
> > >
> >
>
>
>
> --
> Best Regards, Vyacheslav D.
>

Re: Plugins in tests

[Vyacheslav Daradur]

Hi,

>> ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879
I've done it, could someone review it?

2017-07-31 11:13 GMT+03:00 Pavel Tupitsyn :

> Got it, ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879
>
> On Fri, Jul 28, 2017 at 5:58 PM, Yakov Zhdanov 
> wrote:
>
> > Pavel, I would create a new module just like "modules/extdata/p2p".
> >
> > --Yakov
> >
>



-- 
Best Regards, Vyacheslav D.

Re: Plugins in tests

[Pavel Tupitsyn]

Got it, ticket filed: https://issues.apache.org/jira/browse/IGNITE-5879

On Fri, Jul 28, 2017 at 5:58 PM, Yakov Zhdanov  wrote:

> Pavel, I would create a new module just like "modules/extdata/p2p".
>
> --Yakov
>

Re: Plugins in tests

[Yakov Zhdanov]

Pavel, I would create a new module just like "modules/extdata/p2p".

--Yakov

Re: Plugins in tests

[Pavel Tupitsyn]

TestPlatformPlugin is only needed for .NET tests.
I would gladly move it somewhere else, just not sure how to do this
properly, because .NET uses ignite-core only.
Any advice? Create a new module?

Pavel

On Fri, Jul 28, 2017 at 2:57 PM, Yakov Zhdanov  wrote:

> Hello!
>
> I see this output in each test I run:
>
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
> Configured plugins:
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- TestPlatformPlugin 1.0
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- -
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- TestReconnectPlugin 1.0
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^--
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- StanByClusterTestProvider 1.0
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>   ^-- null
> [2017-07-28 14:43:58,648][INFO
> ][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][
> IgnitePluginProcessor]
>
> I see that plugins were added by D. Karachentsev, P. Tupitsyn and D.
> Govorukhin. Guys, are these plugins required for each test we run? I doubt
> if it is true. Can we move them to another module similar to p2p classes
> and plug them in only when required? Otherwise they are always in class
> path and always activated which alters default Ignite configuration in
> which we have no any plugin configured.
>
> Thoughts?
>
> --Yakov
>

Plugins in tests

[Yakov Zhdanov]

Hello!

I see this output in each test I run:

[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
Configured plugins:
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- TestPlatformPlugin 1.0
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- -
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- TestReconnectPlugin 1.0
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^--
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- StanByClusterTestProvider 1.0
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]
  ^-- null
[2017-07-28 14:43:58,648][INFO
][test-runner-#139%datastreamer.DataStreamProcessorSelfTest%][IgnitePluginProcessor]

I see that plugins were added by D. Karachentsev, P. Tupitsyn and D.
Govorukhin. Guys, are these plugins required for each test we run? I doubt
if it is true. Can we move them to another module similar to p2p classes
and plug them in only when required? Otherwise they are always in class
path and always activated which alters default Ignite configuration in
which we have no any plugin configured.

Thoughts?

--Yakov