Re: Replace Cron4J with Quartz for ignite-schedule module.

[Ilya Kasnacheev]

Hello!

In any case I don't see why we would keep ignite-schedule module. We could
merge this change if you moved this functionality into ignite-spring (while
also fixing single thread problem).

The sole reason of existence of ignite-schedule module was the extra
dependency, if we don't have it anymore there's no reason to have this tiny
module.

Regards,
-- 
Ilya Kasnacheev


пт, 28 дек. 2018 г. в 17:18, Sergey :

> Ilya,
> before deciding about drop just don't forget that our scheduleLocal method
> extends functionality with optional prefix before standard Cron expression
> {n1,
> n2} where n1 is delay of scheduling and n2 is number of executions.
>
> Also we have own protection against task that has not finished before new
> execution:
> Look at
> org.apache.ignite.internal.processors.schedule.ScheduleFutureImpl#run
> In this case  a new task won't be executed (it just log warning message)
> disregarding Cron4J or Spring is used.
>
> Best regards,
> Sergey Kosarev.
>
>
> пт, 28 дек. 2018 г. в 13:51, Ilya Kasnacheev :
>
> > Hello!
> >
> > I've spent considerable amount of time working on your patch yesterday,
> but
> > eventually I have come to conclusion that we should Deprecate
> > IgniteScheduler and ignite-schedule module, and Remove it in 3.0.
> >
> > The reason for this: IgnoteScheduler interface has 5 methods, of those
> > callLocal() and runLocal() should probably be moved to IgniteCompute,
> > runLocal() with timeout should be moved somewhere elsewhere, and
> > scheduleLocal() which we are discussing should be removed since it does
> not
> > offer anything that you can't already do with Spring
> > ScheduledThreadPoolExecutor. It has no non-Local methods and it is hard
> to
> > understand why this functionality should belong to Ignite at all. WDYT?
> I'd
> > drop it in 3.0 and call it a day. Since then, avoid touching it.
> >
> > If we decide to NOT drop it, we should remove ignite-schedule module
> anyway
> > and move this code into ignite-spring module. As soon as we have Spring
> we
> > can have fully functioning IgniteScheduler so a dedicated module is NOT
> > needed. Are you ready to do that?
> >
> > I'm not really ready to merge your patch for two additional reasons:
> > - 1 thread limitation looks severe and will make scheduling more than 1-2
> > tasks a dangerous affair - one task may block your scheduler forever and
> > nothing else will be ran.
> > - What should happen if you scheduled a task every 5 minutes, task runs
> for
> > 6 minutes already and it's time to start it again: will it be started
> > concurrently, will it wait for the old one to finish and then start, will
> > it be discarded and ran only in 10 minutes after the original one is
> > started? What is the behavior of cron4j? What is the behavior of proposed
> > impl? Unfortunately we don't have tests on this and we don't want to,
> since
> > they'll take a lot of wall clock time, which we try to avoid to decrease
> TC
> > run time.
> >
> > Regards,
> > --
> > Ilya Kasnacheev
> >
> >
> > чт, 27 дек. 2018 г. в 18:53, Sergey :
> >
> > > Hi, Ilya!
> > > It looks like Spring *ThreadPoolTaskScheduler* is bounded to JDK's
> > > *ScheduledThreadPoolExecutor*, so to launch scheduled tasks on public
> > pool
> > > we need provide *ScheduledThreadPoolExecutor* for Public pool.
> Currently
> > I
> > > see we create Public pool executor as *IgniteThreadPoolExecutor* and it
> > > extends *ThreadPoolExecutor*.
> > > It seems we can easily introduce *IgniteScheduledThreadPoolExecutor*
> and
> > > extend it from *ScheduledThreadPoolExecutor* for public pool. How do
> you
> > > like it?
> > >
> > > Your idea about delegating tasks from Spring 1-threaded pool to Public
> > pool
> > > looks also workable.
> > >
> > > Best regards,
> > > Sergey Kosarev.
> > >
> > >
> > > вт, 25 дек. 2018 г. в 18:19, Ilya Kasnacheev <
> ilya.kasnach...@gmail.com
> > >:
> > >
> > > > Hello!
> > > >
> > > > I have started reviewing your pull request.
> > > > I will expect that scheduled tasks are executed on Public pool. Is it
> > > > possible that tasks are launched on Public pool? If Spring Scheduler
> > > > insists on its own thread pool, we can have single-thread pool which
> > will
> > > > execute put of tasks to public pool and immediately return. Is it
> > > possible
> > > > to do that?
> > > >
> > > > Regards,
> > > > --
> > > > Ilya Kasnacheev
> > > >
> > > >
> > > > вт, 25 дек. 2018 г. в 17:46, Alexey Kuznetsov  >:
> > > >
> > > > > Hi, Sergey!
> > > > >
> > > > > I think we should keep compatibility as much as possible for Ignite
> > > 2.x.
> > > > > And we can do breaking changes in Ignite 3.x
> > > > >
> > > > > What do you think?
> > > > >
> > > > >
> > > > > On Mon, Dec 24, 2018 at 11:58 PM Sergey 
> > wrote:
> > > > >
> > > > > > HI, Igniters!
> > > > > >
> > > > > > I've updated and rebased implementation to master branch and made
> > > some
> > > > > > fixes.
> > > > > > Also I have a question regarding current implementation.
> > > > > >
> > 

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Sergey]

Ilya,
before deciding about drop just don't forget that our scheduleLocal method
extends functionality with optional prefix before standard Cron expression {n1,
n2} where n1 is delay of scheduling and n2 is number of executions.

Also we have own protection against task that has not finished before new
execution:
Look at
org.apache.ignite.internal.processors.schedule.ScheduleFutureImpl#run
In this case  a new task won't be executed (it just log warning message)
disregarding Cron4J or Spring is used.

Best regards,
Sergey Kosarev.


пт, 28 дек. 2018 г. в 13:51, Ilya Kasnacheev :

> Hello!
>
> I've spent considerable amount of time working on your patch yesterday, but
> eventually I have come to conclusion that we should Deprecate
> IgniteScheduler and ignite-schedule module, and Remove it in 3.0.
>
> The reason for this: IgnoteScheduler interface has 5 methods, of those
> callLocal() and runLocal() should probably be moved to IgniteCompute,
> runLocal() with timeout should be moved somewhere elsewhere, and
> scheduleLocal() which we are discussing should be removed since it does not
> offer anything that you can't already do with Spring
> ScheduledThreadPoolExecutor. It has no non-Local methods and it is hard to
> understand why this functionality should belong to Ignite at all. WDYT? I'd
> drop it in 3.0 and call it a day. Since then, avoid touching it.
>
> If we decide to NOT drop it, we should remove ignite-schedule module anyway
> and move this code into ignite-spring module. As soon as we have Spring we
> can have fully functioning IgniteScheduler so a dedicated module is NOT
> needed. Are you ready to do that?
>
> I'm not really ready to merge your patch for two additional reasons:
> - 1 thread limitation looks severe and will make scheduling more than 1-2
> tasks a dangerous affair - one task may block your scheduler forever and
> nothing else will be ran.
> - What should happen if you scheduled a task every 5 minutes, task runs for
> 6 minutes already and it's time to start it again: will it be started
> concurrently, will it wait for the old one to finish and then start, will
> it be discarded and ran only in 10 minutes after the original one is
> started? What is the behavior of cron4j? What is the behavior of proposed
> impl? Unfortunately we don't have tests on this and we don't want to, since
> they'll take a lot of wall clock time, which we try to avoid to decrease TC
> run time.
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> чт, 27 дек. 2018 г. в 18:53, Sergey :
>
> > Hi, Ilya!
> > It looks like Spring *ThreadPoolTaskScheduler* is bounded to JDK's
> > *ScheduledThreadPoolExecutor*, so to launch scheduled tasks on public
> pool
> > we need provide *ScheduledThreadPoolExecutor* for Public pool. Currently
> I
> > see we create Public pool executor as *IgniteThreadPoolExecutor* and it
> > extends *ThreadPoolExecutor*.
> > It seems we can easily introduce *IgniteScheduledThreadPoolExecutor* and
> > extend it from *ScheduledThreadPoolExecutor* for public pool. How do you
> > like it?
> >
> > Your idea about delegating tasks from Spring 1-threaded pool to Public
> pool
> > looks also workable.
> >
> > Best regards,
> > Sergey Kosarev.
> >
> >
> > вт, 25 дек. 2018 г. в 18:19, Ilya Kasnacheev  >:
> >
> > > Hello!
> > >
> > > I have started reviewing your pull request.
> > > I will expect that scheduled tasks are executed on Public pool. Is it
> > > possible that tasks are launched on Public pool? If Spring Scheduler
> > > insists on its own thread pool, we can have single-thread pool which
> will
> > > execute put of tasks to public pool and immediately return. Is it
> > possible
> > > to do that?
> > >
> > > Regards,
> > > --
> > > Ilya Kasnacheev
> > >
> > >
> > > вт, 25 дек. 2018 г. в 17:46, Alexey Kuznetsov :
> > >
> > > > Hi, Sergey!
> > > >
> > > > I think we should keep compatibility as much as possible for Ignite
> > 2.x.
> > > > And we can do breaking changes in Ignite 3.x
> > > >
> > > > What do you think?
> > > >
> > > >
> > > > On Mon, Dec 24, 2018 at 11:58 PM Sergey 
> wrote:
> > > >
> > > > > HI, Igniters!
> > > > >
> > > > > I've updated and rebased implementation to master branch and made
> > some
> > > > > fixes.
> > > > > Also I have a question regarding current implementation.
> > > > >
> > > > > As I found Cron4J source code this implementation checks schedule
> > every
> > > > > minute (seconds not supported) but spawns a thread for every task
> > which
> > > > > scheduling pattern matches the current time. There no any limits to
> > the
> > > > > number of tasks launched silmultaneously.
> > > > >
> > > > >  New implementation is based on
> > > > > org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler
> > > > > with its default parameters currently, i.e thread pool size is 1.
> > > > >
> > > > > Could you advise me, do we need to add some system property or
> > > introduce
> > > > > some attribute to IgniteConfiguration to configure Scheduler thread
> > > pool
> > > > > 

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Sergey]

Hi, Ilya!
It looks like Spring *ThreadPoolTaskScheduler* is bounded to JDK's
*ScheduledThreadPoolExecutor*, so to launch scheduled tasks on public pool
we need provide *ScheduledThreadPoolExecutor* for Public pool. Currently I
see we create Public pool executor as *IgniteThreadPoolExecutor* and it
extends *ThreadPoolExecutor*.
It seems we can easily introduce *IgniteScheduledThreadPoolExecutor* and
extend it from *ScheduledThreadPoolExecutor* for public pool. How do you
like it?

Your idea about delegating tasks from Spring 1-threaded pool to Public pool
looks also workable.

Best regards,
Sergey Kosarev.


вт, 25 дек. 2018 г. в 18:19, Ilya Kasnacheev :

> Hello!
>
> I have started reviewing your pull request.
> I will expect that scheduled tasks are executed on Public pool. Is it
> possible that tasks are launched on Public pool? If Spring Scheduler
> insists on its own thread pool, we can have single-thread pool which will
> execute put of tasks to public pool and immediately return. Is it possible
> to do that?
>
> Regards,
> --
> Ilya Kasnacheev
>
>
> вт, 25 дек. 2018 г. в 17:46, Alexey Kuznetsov :
>
> > Hi, Sergey!
> >
> > I think we should keep compatibility as much as possible for Ignite 2.x.
> > And we can do breaking changes in Ignite 3.x
> >
> > What do you think?
> >
> >
> > On Mon, Dec 24, 2018 at 11:58 PM Sergey  wrote:
> >
> > > HI, Igniters!
> > >
> > > I've updated and rebased implementation to master branch and made some
> > > fixes.
> > > Also I have a question regarding current implementation.
> > >
> > > As I found Cron4J source code this implementation checks schedule every
> > > minute (seconds not supported) but spawns a thread for every task which
> > > scheduling pattern matches the current time. There no any limits to the
> > > number of tasks launched silmultaneously.
> > >
> > >  New implementation is based on
> > > org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler
> > > with its default parameters currently, i.e thread pool size is 1.
> > >
> > > Could you advise me, do we need to add some system property or
> introduce
> > > some attribute to IgniteConfiguration to configure Scheduler thread
> pool
> > > size? And what should be default value?
> > >
> > >
> > > Best regards,
> > > Sergey Kosarev.
> > >
> > >
> > > чт, 10 мая 2018 г. в 20:23, Dmitry Pavlov :
> > >
> > > > Hi Anton,
> > > >
> > > > Thank you for joining and review.
> > > > I hope all proposals will be applied.
> > > >
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > >
> > > > пт, 4 мая 2018 г. в 16:04, Anton Vinogradov :
> > > >
> > > > > Folks,
> > > > >
> > > > > How can it be at PATCH AVAILABLE since *none* of my latest comments
> > > (made
> > > > > Feb 8) are resolved at Upsource?
> > > > > Changed state to IP.
> > > > >
> > > > > пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov  >:
> > > > >
> > > > > > Hi Andrey,
> > > > > >
> > > > > > Could you please pick up review?
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan <
> > > dsetrak...@apache.org
> > > > >:
> > > > > >
> > > > > > > Dmitriy, who is a good candidate within the community to review
> > > this
> > > > > > > ticket?
> > > > > > >
> > > > > > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <
> > > > dpavlov@gmail.com>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hi Igniters,
> > > > > > > >
> > > > > > > > it seems ticket
> > > https://issues.apache.org/jira/browse/IGNITE-5565
> > > > is
> > > > > > > still
> > > > > > > > in PA state. What are our next steps?
> > > > > > > >
> > > > > > > > Who did review of this patch?
> > > > > > > >
> > > > > > > > Sincerely,
> > > > > > > > Dmitriy Pavlov
> > > > > > > >
> > > > > > > > ср, 28 июн. 2017 г. в 1:40, Denis Magda :
> > > > > > > >
> > > > > > > > > Yakov,
> > > > > > > > >
> > > > > > > > > No, the mentioned discussion didn’t turn into a JIRA
> ticket.
> > > > > > > > >
> > > > > > > > > Alex K., please follow to some thoughts from there and wrap
> > > them
> > > > up
> > > > > > in
> > > > > > > a
> > > > > > > > > form of the ticket.
> > > > > > > > >
> > > > > > > > > —
> > > > > > > > > Denis
> > > > > > > > >
> > > > > > > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <
> > > > yzhda...@apache.org>
> > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > Guys, I remember we discussed this some time ago.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > > > > > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > > > > > > >
> > > > > > > > > > Denis, do you have any ticket or SoW?
> > > > > > > > > >
> > > > > > > > > > --Yakov
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> > --
> > Alexey Kuznetsov
> >
>

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Ilya Kasnacheev]

Hello!

I have started reviewing your pull request.
I will expect that scheduled tasks are executed on Public pool. Is it
possible that tasks are launched on Public pool? If Spring Scheduler
insists on its own thread pool, we can have single-thread pool which will
execute put of tasks to public pool and immediately return. Is it possible
to do that?

Regards,
-- 
Ilya Kasnacheev


вт, 25 дек. 2018 г. в 17:46, Alexey Kuznetsov :

> Hi, Sergey!
>
> I think we should keep compatibility as much as possible for Ignite 2.x.
> And we can do breaking changes in Ignite 3.x
>
> What do you think?
>
>
> On Mon, Dec 24, 2018 at 11:58 PM Sergey  wrote:
>
> > HI, Igniters!
> >
> > I've updated and rebased implementation to master branch and made some
> > fixes.
> > Also I have a question regarding current implementation.
> >
> > As I found Cron4J source code this implementation checks schedule every
> > minute (seconds not supported) but spawns a thread for every task which
> > scheduling pattern matches the current time. There no any limits to the
> > number of tasks launched silmultaneously.
> >
> >  New implementation is based on
> > org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler
> > with its default parameters currently, i.e thread pool size is 1.
> >
> > Could you advise me, do we need to add some system property or introduce
> > some attribute to IgniteConfiguration to configure Scheduler thread pool
> > size? And what should be default value?
> >
> >
> > Best regards,
> > Sergey Kosarev.
> >
> >
> > чт, 10 мая 2018 г. в 20:23, Dmitry Pavlov :
> >
> > > Hi Anton,
> > >
> > > Thank you for joining and review.
> > > I hope all proposals will be applied.
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > пт, 4 мая 2018 г. в 16:04, Anton Vinogradov :
> > >
> > > > Folks,
> > > >
> > > > How can it be at PATCH AVAILABLE since *none* of my latest comments
> > (made
> > > > Feb 8) are resolved at Upsource?
> > > > Changed state to IP.
> > > >
> > > > пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov :
> > > >
> > > > > Hi Andrey,
> > > > >
> > > > > Could you please pick up review?
> > > > >
> > > > > Sincerely,
> > > > > Dmitriy Pavlov
> > > > >
> > > > > пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan <
> > dsetrak...@apache.org
> > > >:
> > > > >
> > > > > > Dmitriy, who is a good candidate within the community to review
> > this
> > > > > > ticket?
> > > > > >
> > > > > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <
> > > dpavlov@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Igniters,
> > > > > > >
> > > > > > > it seems ticket
> > https://issues.apache.org/jira/browse/IGNITE-5565
> > > is
> > > > > > still
> > > > > > > in PA state. What are our next steps?
> > > > > > >
> > > > > > > Who did review of this patch?
> > > > > > >
> > > > > > > Sincerely,
> > > > > > > Dmitriy Pavlov
> > > > > > >
> > > > > > > ср, 28 июн. 2017 г. в 1:40, Denis Magda :
> > > > > > >
> > > > > > > > Yakov,
> > > > > > > >
> > > > > > > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > > > > > > >
> > > > > > > > Alex K., please follow to some thoughts from there and wrap
> > them
> > > up
> > > > > in
> > > > > > a
> > > > > > > > form of the ticket.
> > > > > > > >
> > > > > > > > —
> > > > > > > > Denis
> > > > > > > >
> > > > > > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <
> > > yzhda...@apache.org>
> > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Guys, I remember we discussed this some time ago.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > > > > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > > > > > >
> > > > > > > > > Denis, do you have any ticket or SoW?
> > > > > > > > >
> > > > > > > > > --Yakov
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
> --
> Alexey Kuznetsov
>

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Alexey Kuznetsov]

Hi, Sergey!

I think we should keep compatibility as much as possible for Ignite 2.x.
And we can do breaking changes in Ignite 3.x

What do you think?


On Mon, Dec 24, 2018 at 11:58 PM Sergey  wrote:

> HI, Igniters!
>
> I've updated and rebased implementation to master branch and made some
> fixes.
> Also I have a question regarding current implementation.
>
> As I found Cron4J source code this implementation checks schedule every
> minute (seconds not supported) but spawns a thread for every task which
> scheduling pattern matches the current time. There no any limits to the
> number of tasks launched silmultaneously.
>
>  New implementation is based on
> org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler
> with its default parameters currently, i.e thread pool size is 1.
>
> Could you advise me, do we need to add some system property or introduce
> some attribute to IgniteConfiguration to configure Scheduler thread pool
> size? And what should be default value?
>
>
> Best regards,
> Sergey Kosarev.
>
>
> чт, 10 мая 2018 г. в 20:23, Dmitry Pavlov :
>
> > Hi Anton,
> >
> > Thank you for joining and review.
> > I hope all proposals will be applied.
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пт, 4 мая 2018 г. в 16:04, Anton Vinogradov :
> >
> > > Folks,
> > >
> > > How can it be at PATCH AVAILABLE since *none* of my latest comments
> (made
> > > Feb 8) are resolved at Upsource?
> > > Changed state to IP.
> > >
> > > пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov :
> > >
> > > > Hi Andrey,
> > > >
> > > > Could you please pick up review?
> > > >
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > >
> > > > пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan <
> dsetrak...@apache.org
> > >:
> > > >
> > > > > Dmitriy, who is a good candidate within the community to review
> this
> > > > > ticket?
> > > > >
> > > > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <
> > dpavlov@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Hi Igniters,
> > > > > >
> > > > > > it seems ticket
> https://issues.apache.org/jira/browse/IGNITE-5565
> > is
> > > > > still
> > > > > > in PA state. What are our next steps?
> > > > > >
> > > > > > Who did review of this patch?
> > > > > >
> > > > > > Sincerely,
> > > > > > Dmitriy Pavlov
> > > > > >
> > > > > > ср, 28 июн. 2017 г. в 1:40, Denis Magda :
> > > > > >
> > > > > > > Yakov,
> > > > > > >
> > > > > > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > > > > > >
> > > > > > > Alex K., please follow to some thoughts from there and wrap
> them
> > up
> > > > in
> > > > > a
> > > > > > > form of the ticket.
> > > > > > >
> > > > > > > —
> > > > > > > Denis
> > > > > > >
> > > > > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <
> > yzhda...@apache.org>
> > > > > > wrote:
> > > > > > > >
> > > > > > > > Guys, I remember we discussed this some time ago.
> > > > > > > >
> > > > > > > >
> > > > > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > > > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > > > > >
> > > > > > > > Denis, do you have any ticket or SoW?
> > > > > > > >
> > > > > > > > --Yakov
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>


-- 
Alexey Kuznetsov

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Sergey]

HI, Igniters!

I've updated and rebased implementation to master branch and made some
fixes.
Also I have a question regarding current implementation.

As I found Cron4J source code this implementation checks schedule every
minute (seconds not supported) but spawns a thread for every task which
scheduling pattern matches the current time. There no any limits to the
number of tasks launched silmultaneously.

 New implementation is based on
org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler
with its default parameters currently, i.e thread pool size is 1.

Could you advise me, do we need to add some system property or introduce
some attribute to IgniteConfiguration to configure Scheduler thread pool
size? And what should be default value?


Best regards,
Sergey Kosarev.


чт, 10 мая 2018 г. в 20:23, Dmitry Pavlov :

> Hi Anton,
>
> Thank you for joining and review.
> I hope all proposals will be applied.
>
> Sincerely,
> Dmitriy Pavlov
>
> пт, 4 мая 2018 г. в 16:04, Anton Vinogradov :
>
> > Folks,
> >
> > How can it be at PATCH AVAILABLE since *none* of my latest comments (made
> > Feb 8) are resolved at Upsource?
> > Changed state to IP.
> >
> > пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov :
> >
> > > Hi Andrey,
> > >
> > > Could you please pick up review?
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan  >:
> > >
> > > > Dmitriy, who is a good candidate within the community to review this
> > > > ticket?
> > > >
> > > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov <
> dpavlov@gmail.com>
> > > > wrote:
> > > >
> > > > > Hi Igniters,
> > > > >
> > > > > it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565
> is
> > > > still
> > > > > in PA state. What are our next steps?
> > > > >
> > > > > Who did review of this patch?
> > > > >
> > > > > Sincerely,
> > > > > Dmitriy Pavlov
> > > > >
> > > > > ср, 28 июн. 2017 г. в 1:40, Denis Magda :
> > > > >
> > > > > > Yakov,
> > > > > >
> > > > > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > > > > >
> > > > > > Alex K., please follow to some thoughts from there and wrap them
> up
> > > in
> > > > a
> > > > > > form of the ticket.
> > > > > >
> > > > > > —
> > > > > > Denis
> > > > > >
> > > > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov <
> yzhda...@apache.org>
> > > > > wrote:
> > > > > > >
> > > > > > > Guys, I remember we discussed this some time ago.
> > > > > > >
> > > > > > >
> > > > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > > > >
> > > > > > > Denis, do you have any ticket or SoW?
> > > > > > >
> > > > > > > --Yakov
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Dmitry Pavlov]

Hi Anton,

Thank you for joining and review.
I hope all proposals will be applied.

Sincerely,
Dmitriy Pavlov

пт, 4 мая 2018 г. в 16:04, Anton Vinogradov :

> Folks,
>
> How can it be at PATCH AVAILABLE since *none* of my latest comments (made
> Feb 8) are resolved at Upsource?
> Changed state to IP.
>
> пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov :
>
> > Hi Andrey,
> >
> > Could you please pick up review?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan :
> >
> > > Dmitriy, who is a good candidate within the community to review this
> > > ticket?
> > >
> > > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov 
> > > wrote:
> > >
> > > > Hi Igniters,
> > > >
> > > > it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is
> > > still
> > > > in PA state. What are our next steps?
> > > >
> > > > Who did review of this patch?
> > > >
> > > > Sincerely,
> > > > Dmitriy Pavlov
> > > >
> > > > ср, 28 июн. 2017 г. в 1:40, Denis Magda :
> > > >
> > > > > Yakov,
> > > > >
> > > > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > > > >
> > > > > Alex K., please follow to some thoughts from there and wrap them up
> > in
> > > a
> > > > > form of the ticket.
> > > > >
> > > > > —
> > > > > Denis
> > > > >
> > > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov 
> > > > wrote:
> > > > > >
> > > > > > Guys, I remember we discussed this some time ago.
> > > > > >
> > > > > >
> > > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > > >
> > > > > > Denis, do you have any ticket or SoW?
> > > > > >
> > > > > > --Yakov
> > > > >
> > > > >
> > > >
> > >
> >
>

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Anton Vinogradov]

Folks,

How can it be at PATCH AVAILABLE since *none* of my latest comments (made
Feb 8) are resolved at Upsource?
Changed state to IP.

пн, 23 апр. 2018 г. в 20:00, Dmitry Pavlov :

> Hi Andrey,
>
> Could you please pick up review?
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan :
>
> > Dmitriy, who is a good candidate within the community to review this
> > ticket?
> >
> > On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov 
> > wrote:
> >
> > > Hi Igniters,
> > >
> > > it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is
> > still
> > > in PA state. What are our next steps?
> > >
> > > Who did review of this patch?
> > >
> > > Sincerely,
> > > Dmitriy Pavlov
> > >
> > > ср, 28 июн. 2017 г. в 1:40, Denis Magda :
> > >
> > > > Yakov,
> > > >
> > > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > > >
> > > > Alex K., please follow to some thoughts from there and wrap them up
> in
> > a
> > > > form of the ticket.
> > > >
> > > > —
> > > > Denis
> > > >
> > > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov 
> > > wrote:
> > > > >
> > > > > Guys, I remember we discussed this some time ago.
> > > > >
> > > > >
> > > > http://apache-ignite-developers.2346864.n4.nabble.
> > > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > > >
> > > > > Denis, do you have any ticket or SoW?
> > > > >
> > > > > --Yakov
> > > >
> > > >
> > >
> >
>

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Dmitry Pavlov]

Hi Andrey,

Could you please pick up review?

Sincerely,
Dmitriy Pavlov

пн, 23 апр. 2018 г. в 17:39, Dmitriy Setrakyan :

> Dmitriy, who is a good candidate within the community to review this
> ticket?
>
> On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov 
> wrote:
>
> > Hi Igniters,
> >
> > it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is
> still
> > in PA state. What are our next steps?
> >
> > Who did review of this patch?
> >
> > Sincerely,
> > Dmitriy Pavlov
> >
> > ср, 28 июн. 2017 г. в 1:40, Denis Magda :
> >
> > > Yakov,
> > >
> > > No, the mentioned discussion didn’t turn into a JIRA ticket.
> > >
> > > Alex K., please follow to some thoughts from there and wrap them up in
> a
> > > form of the ticket.
> > >
> > > —
> > > Denis
> > >
> > > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov 
> > wrote:
> > > >
> > > > Guys, I remember we discussed this some time ago.
> > > >
> > > >
> > > http://apache-ignite-developers.2346864.n4.nabble.
> > com/Tasks-Scheduling-and-Chaining-td14293.html
> > > >
> > > > Denis, do you have any ticket or SoW?
> > > >
> > > > --Yakov
> > >
> > >
> >
>

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Dmitriy Setrakyan]

Dmitriy, who is a good candidate within the community to review this ticket?

On Mon, Apr 23, 2018 at 6:10 AM, Dmitry Pavlov 
wrote:

> Hi Igniters,
>
> it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is still
> in PA state. What are our next steps?
>
> Who did review of this patch?
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 28 июн. 2017 г. в 1:40, Denis Magda :
>
> > Yakov,
> >
> > No, the mentioned discussion didn’t turn into a JIRA ticket.
> >
> > Alex K., please follow to some thoughts from there and wrap them up in a
> > form of the ticket.
> >
> > —
> > Denis
> >
> > > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov 
> wrote:
> > >
> > > Guys, I remember we discussed this some time ago.
> > >
> > >
> > http://apache-ignite-developers.2346864.n4.nabble.
> com/Tasks-Scheduling-and-Chaining-td14293.html
> > >
> > > Denis, do you have any ticket or SoW?
> > >
> > > --Yakov
> >
> >
>

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Dmitry Pavlov]

Hi Igniters,

it seems ticket https://issues.apache.org/jira/browse/IGNITE-5565 is still
in PA state. What are our next steps?

Who did review of this patch?

Sincerely,
Dmitriy Pavlov

ср, 28 июн. 2017 г. в 1:40, Denis Magda :

> Yakov,
>
> No, the mentioned discussion didn’t turn into a JIRA ticket.
>
> Alex K., please follow to some thoughts from there and wrap them up in a
> form of the ticket.
>
> —
> Denis
>
> > On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov  wrote:
> >
> > Guys, I remember we discussed this some time ago.
> >
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/Tasks-Scheduling-and-Chaining-td14293.html
> >
> > Denis, do you have any ticket or SoW?
> >
> > --Yakov
>
>

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Denis Magda]

Yakov,

No, the mentioned discussion didn’t turn into a JIRA ticket.

Alex K., please follow to some thoughts from there and wrap them up in a form 
of the ticket.

—
Denis

> On Jun 26, 2017, at 2:58 AM, Yakov Zhdanov  wrote:
> 
> Guys, I remember we discussed this some time ago.
> 
> http://apache-ignite-developers.2346864.n4.nabble.com/Tasks-Scheduling-and-Chaining-td14293.html
> 
> Denis, do you have any ticket or SoW?
> 
> --Yakov

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Yakov Zhdanov]

Guys, I remember we discussed this some time ago.

http://apache-ignite-developers.2346864.n4.nabble.com/Tasks-Scheduling-and-Chaining-td14293.html

Denis, do you have any ticket or SoW?

--Yakov

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Alexey Kuznetsov]

Val and Michael ,

Very good point!

Any idea how it could be implemented?

Actually I need distributed scheduling.


On Thu, Jun 22, 2017 at 5:37 AM, Valentin Kulichenko <
valentin.kuliche...@gmail.com> wrote:

> I think Michael brought up a very good point. Current ignite-scheduler
> module schedules jobs only locally which is not very useful in distributed
> system. I don't think I've ever seen it used and I don't think it makes
> sense to spend time on it if we just replace one dependency with another.
> However, if we switch to Quartz in order to enhance functionality and
> introduce distributed scheduling - that can add value.
>
> -Val
>
> On Wed, Jun 21, 2017 at 3:21 PM, Michael André Pearce <
> michael.andre.pea...@me.com> wrote:
>
> > If taking the quartz route, it be great if ignite could expose a
> > distributed ignite job store, so you could setup and use quartz in a
> > distributed way, in a similar way to terracotta or hazelcasts quartz
> > jobstores.
> >
> >
> > Sent from my iPhone
> >
> > > On 21 Jun 2017, at 15:43, Alexey Kuznetsov 
> > wrote:
> > >
> > > Hi!
> > >
> > > Good point, I will take a look.
> > >
> > >> On Wed, Jun 21, 2017 at 5:42 PM, 李玉珏  wrote:
> > >>
> > >> Hi，
> > >>
> > >>
> > >> There is also an alternative that the community can consider using the
> > >> scheduling functionality in the spring-context module, for the
> following
> > >> reasons:
> > >> 1.quartz is a very heavy framework, and most functions we don't need;
> > >> 2., we already have spring dependencies in our project without
> > introducing
> > >> new dependencies;
> > >> 3.spring is also Apache 2.0 license;
> > >> 4.spring's scheduler supports standard CRON, and cron4j does not
> support
> > >> standard CRON;
> > >> 5.spring's code quality is very good, maintainability is good, and the
> > >> quality of quartz code is not very good.
> > >> On 06/21/2017 13:26，Alexey Kuznetsov wrote：
> > >> Hi!
> > >>
> > >> 1) Cron4J is very old:
> > >>  Latest Cron4j 2.2.5 released: *28-Dec-2011 *
> > >>  Latest Quarz 2.3.0 released: *20-Apr-2017*
> > >>
> > >> 2) Not very friendly license:
> > >>  CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
> > >>  Quartz is freely usable, licensed under the *Apache 2.0* license.
> > >>
> > >> So, if we replace Cron4J  with Quartz we can move *ignite-schedule*
> > module
> > >> from lgpl profile to main distribution.
> > >>
> > >> Any objections?
> > >>
> > >> If no, I will create JIRA issue and implement this change.
> > >>
> > >> --
> > >> Alexey Kuznetsov
> > >>
> > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > > GridGain Systems
> > > www.gridgain.com
> >
>



-- 
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Valentin Kulichenko]

I think Michael brought up a very good point. Current ignite-scheduler
module schedules jobs only locally which is not very useful in distributed
system. I don't think I've ever seen it used and I don't think it makes
sense to spend time on it if we just replace one dependency with another.
However, if we switch to Quartz in order to enhance functionality and
introduce distributed scheduling - that can add value.

-Val

On Wed, Jun 21, 2017 at 3:21 PM, Michael André Pearce <
michael.andre.pea...@me.com> wrote:

> If taking the quartz route, it be great if ignite could expose a
> distributed ignite job store, so you could setup and use quartz in a
> distributed way, in a similar way to terracotta or hazelcasts quartz
> jobstores.
>
>
> Sent from my iPhone
>
> > On 21 Jun 2017, at 15:43, Alexey Kuznetsov 
> wrote:
> >
> > Hi!
> >
> > Good point, I will take a look.
> >
> >> On Wed, Jun 21, 2017 at 5:42 PM, 李玉珏  wrote:
> >>
> >> Hi，
> >>
> >>
> >> There is also an alternative that the community can consider using the
> >> scheduling functionality in the spring-context module, for the following
> >> reasons:
> >> 1.quartz is a very heavy framework, and most functions we don't need;
> >> 2., we already have spring dependencies in our project without
> introducing
> >> new dependencies;
> >> 3.spring is also Apache 2.0 license;
> >> 4.spring's scheduler supports standard CRON, and cron4j does not support
> >> standard CRON;
> >> 5.spring's code quality is very good, maintainability is good, and the
> >> quality of quartz code is not very good.
> >> On 06/21/2017 13:26，Alexey Kuznetsov wrote：
> >> Hi!
> >>
> >> 1) Cron4J is very old:
> >>  Latest Cron4j 2.2.5 released: *28-Dec-2011 *
> >>  Latest Quarz 2.3.0 released: *20-Apr-2017*
> >>
> >> 2) Not very friendly license:
> >>  CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
> >>  Quartz is freely usable, licensed under the *Apache 2.0* license.
> >>
> >> So, if we replace Cron4J  with Quartz we can move *ignite-schedule*
> module
> >> from lgpl profile to main distribution.
> >>
> >> Any objections?
> >>
> >> If no, I will create JIRA issue and implement this change.
> >>
> >> --
> >> Alexey Kuznetsov
> >>
> >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
>

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Michael André Pearce]

If taking the quartz route, it be great if ignite could expose a distributed 
ignite job store, so you could setup and use quartz in a distributed way, in a 
similar way to terracotta or hazelcasts quartz jobstores.


Sent from my iPhone

> On 21 Jun 2017, at 15:43, Alexey Kuznetsov  wrote:
> 
> Hi!
> 
> Good point, I will take a look.
> 
>> On Wed, Jun 21, 2017 at 5:42 PM, 李玉珏  wrote:
>> 
>> Hi，
>> 
>> 
>> There is also an alternative that the community can consider using the
>> scheduling functionality in the spring-context module, for the following
>> reasons:
>> 1.quartz is a very heavy framework, and most functions we don't need;
>> 2., we already have spring dependencies in our project without introducing
>> new dependencies;
>> 3.spring is also Apache 2.0 license;
>> 4.spring's scheduler supports standard CRON, and cron4j does not support
>> standard CRON;
>> 5.spring's code quality is very good, maintainability is good, and the
>> quality of quartz code is not very good.
>> On 06/21/2017 13:26，Alexey Kuznetsov wrote：
>> Hi!
>> 
>> 1) Cron4J is very old:
>>  Latest Cron4j 2.2.5 released: *28-Dec-2011 *
>>  Latest Quarz 2.3.0 released: *20-Apr-2017*
>> 
>> 2) Not very friendly license:
>>  CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
>>  Quartz is freely usable, licensed under the *Apache 2.0* license.
>> 
>> So, if we replace Cron4J  with Quartz we can move *ignite-schedule* module
>> from lgpl profile to main distribution.
>> 
>> Any objections?
>> 
>> If no, I will create JIRA issue and implement this change.
>> 
>> --
>> Alexey Kuznetsov
>> 
> 
> 
> 
> -- 
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Alexey Kuznetsov]

Hi!

Good point, I will take a look.

On Wed, Jun 21, 2017 at 5:42 PM, 李玉珏  wrote:

> Hi，
>
>
> There is also an alternative that the community can consider using the
> scheduling functionality in the spring-context module, for the following
> reasons:
> 1.quartz is a very heavy framework, and most functions we don't need;
> 2., we already have spring dependencies in our project without introducing
> new dependencies;
> 3.spring is also Apache 2.0 license;
> 4.spring's scheduler supports standard CRON, and cron4j does not support
> standard CRON;
> 5.spring's code quality is very good, maintainability is good, and the
> quality of quartz code is not very good.
> On 06/21/2017 13:26，Alexey Kuznetsov wrote：
> Hi!
>
> 1) Cron4J is very old:
>   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
>   Latest Quarz 2.3.0 released: *20-Apr-2017*
>
> 2) Not very friendly license:
>   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
>   Quartz is freely usable, licensed under the *Apache 2.0* license.
>
> So, if we replace Cron4J  with Quartz we can move *ignite-schedule* module
>  from lgpl profile to main distribution.
>
> Any objections?
>
> If no, I will create JIRA issue and implement this change.
>
> --
> Alexey Kuznetsov
>



-- 
Alexey Kuznetsov
GridGain Systems
www.gridgain.com

Re: Replace Cron4J with Quartz for ignite-schedule module.

[李玉珏]

Hi，


There is also an alternative that the community can consider using the 
scheduling functionality in the spring-context module, for the following 
reasons:
1.quartz is a very heavy framework, and most functions we don't need;
2., we already have spring dependencies in our project without introducing new 
dependencies;
3.spring is also Apache 2.0 license;
4.spring's scheduler supports standard CRON, and cron4j does not support 
standard CRON;
5.spring's code quality is very good, maintainability is good, and the quality 
of quartz code is not very good.
On 06/21/2017 13:26，Alexey Kuznetsov wrote：
Hi!

1) Cron4J is very old:
  Latest Cron4j 2.2.5 released: *28-Dec-2011 *
  Latest Quarz 2.3.0 released: *20-Apr-2017*

2) Not very friendly license:
  CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
  Quartz is freely usable, licensed under the *Apache 2.0* license.

So, if we replace Cron4J  with Quartz we can move *ignite-schedule* module
 from lgpl profile to main distribution.

Any objections?

If no, I will create JIRA issue and implement this change.

-- 
Alexey Kuznetsov

Re: Replace Cron4J with Quartz for ignite-schedule module.

[dsetrakyan]

Probably a good task for a newbie.

⁣D.​

On Jun 21, 2017, 9:41 AM, at 9:41 AM, Alexey Kuznetsov  
wrote:
>Done,
>
>https://issues.apache.org/jira/browse/IGNITE-5565
>
>I think it could take a couple of days in background mode.
>
>On Wed, Jun 21, 2017 at 1:40 PM, Dmitriy Setrakyan
>
>wrote:
>
>> Thanks! Please file a ticket. Do you have an idea on the amount of
>work
>> this would require?
>>
>> On Wed, Jun 21, 2017 at 8:39 AM, Alexey Kuznetsov
>
>> wrote:
>>
>> > Dima,
>> >
>> > IgniteScheduler provides functionality for scheduling jobs locally
>using
>> > UNIX cron-based syntax. Instance of GridScheduler is obtained from
>grid
>> as
>> > follows:
>> >IgniteScheduler s = Ignition.ignite().scheduler();
>> >
>> > Scheduler supports standard UNIX cron format with optional prefix
>of {n1,
>> > n2}, where n1 is delay of scheduling in seconds and n2 is the
>number of
>> > execution.
>> > Both parameters are optional. Here's an example of scheduling a
>closure
>> > that broadcasts a message to all nodes five times, once every
>minute,
>> with
>> > initial delay of two seconds:
>> >Ignition.ignite().scheduler().scheduleLocal(
>> >SchedulerFuture = Ignition.ignite().scheduler().
>> > scheduleLocal(new
>> > Callable() {
>> >@Override public Object call() throws
>IgniteCheckedException {
>> >..
>> >}
>> >}, "{2, 5} * * * * *" // 2 seconds delay with 5 executions
>only.
>> >);
>> >
>> > On Wed, Jun 21, 2017 at 1:31 PM, Dmitriy Setrakyan <
>> dsetrak...@apache.org>
>> > wrote:
>> >
>> > > Alexey,
>> > >
>> > > Can you remind what we use the schedule module in Ignite for?
>> > >
>> > > D.
>> > >
>> > > On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov <
>> akuznet...@apache.org
>> > >
>> > > wrote:
>> > >
>> > > > Hi!
>> > > >
>> > > > 1) Cron4J is very old:
>> > > >   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
>> > > >   Latest Quarz 2.3.0 released: *20-Apr-2017*
>> > > >
>> > > > 2) Not very friendly license:
>> > > >   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
>> > > >   Quartz is freely usable, licensed under the *Apache 2.0*
>license.
>> > > >
>> > > > So, if we replace Cron4J  with Quartz we can move
>*ignite-schedule*
>> > > module
>> > > >  from lgpl profile to main distribution.
>> > > >
>> > > > Any objections?
>> > > >
>> > > > If no, I will create JIRA issue and implement this change.
>> > > >
>> > > > --
>> > > > Alexey Kuznetsov
>> > > >
>> > >
>> >
>> >
>> >
>> > --
>> > Alexey Kuznetsov
>> >
>>
>
>
>
>--
>Alexey Kuznetsov

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Alexey Kuznetsov]

Done,

https://issues.apache.org/jira/browse/IGNITE-5565

I think it could take a couple of days in background mode.

On Wed, Jun 21, 2017 at 1:40 PM, Dmitriy Setrakyan 
wrote:

> Thanks! Please file a ticket. Do you have an idea on the amount of work
> this would require?
>
> On Wed, Jun 21, 2017 at 8:39 AM, Alexey Kuznetsov 
> wrote:
>
> > Dima,
> >
> > IgniteScheduler provides functionality for scheduling jobs locally using
> > UNIX cron-based syntax. Instance of GridScheduler is obtained from grid
> as
> > follows:
> >IgniteScheduler s = Ignition.ignite().scheduler();
> >
> > Scheduler supports standard UNIX cron format with optional prefix of {n1,
> > n2}, where n1 is delay of scheduling in seconds and n2 is the number of
> > execution.
> > Both parameters are optional. Here's an example of scheduling a closure
> > that broadcasts a message to all nodes five times, once every minute,
> with
> > initial delay of two seconds:
> >Ignition.ignite().scheduler().scheduleLocal(
> >SchedulerFuture = Ignition.ignite().scheduler().
> > scheduleLocal(new
> > Callable() {
> >@Override public Object call() throws IgniteCheckedException {
> >..
> >}
> >}, "{2, 5} * * * * *" // 2 seconds delay with 5 executions only.
> >);
> >
> > On Wed, Jun 21, 2017 at 1:31 PM, Dmitriy Setrakyan <
> dsetrak...@apache.org>
> > wrote:
> >
> > > Alexey,
> > >
> > > Can you remind what we use the schedule module in Ignite for?
> > >
> > > D.
> > >
> > > On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov <
> akuznet...@apache.org
> > >
> > > wrote:
> > >
> > > > Hi!
> > > >
> > > > 1) Cron4J is very old:
> > > >   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
> > > >   Latest Quarz 2.3.0 released: *20-Apr-2017*
> > > >
> > > > 2) Not very friendly license:
> > > >   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
> > > >   Quartz is freely usable, licensed under the *Apache 2.0* license.
> > > >
> > > > So, if we replace Cron4J  with Quartz we can move *ignite-schedule*
> > > module
> > > >  from lgpl profile to main distribution.
> > > >
> > > > Any objections?
> > > >
> > > > If no, I will create JIRA issue and implement this change.
> > > >
> > > > --
> > > > Alexey Kuznetsov
> > > >
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> >
>



-- 
Alexey Kuznetsov

Re: Replace Cron4J with Quartz for ignite-schedule module.

[Dmitriy Setrakyan]

Alexey,

Can you remind what we use the schedule module in Ignite for?

D.

On Wed, Jun 21, 2017 at 7:26 AM, Alexey Kuznetsov 
wrote:

> Hi!
>
> 1) Cron4J is very old:
>   Latest Cron4j 2.2.5 released: *28-Dec-2011 *
>   Latest Quarz 2.3.0 released: *20-Apr-2017*
>
> 2) Not very friendly license:
>   CronJ4 licensed under GNU LESSER GENERAL PUBLIC LICENSE
>   Quartz is freely usable, licensed under the *Apache 2.0* license.
>
> So, if we replace Cron4J  with Quartz we can move *ignite-schedule* module
>  from lgpl profile to main distribution.
>
> Any objections?
>
> If no, I will create JIRA issue and implement this change.
>
> --
> Alexey Kuznetsov
>